]> git.lizzy.rs Git - rust.git/commit - src/tools/rust-analyzer
projects / rust.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(merge: ce197e2 e7ee823)
Rollup merge of #91404 - nnethercote:fix-bad-NodeId-limit-checking, r=dtolnay
authorMatthias Krüger <matthias.krueger@famsik.de>
Wed, 1 Dec 2021 09:50:23 +0000 (10:50 +0100)
committerGitHub <noreply@github.com>
Wed, 1 Dec 2021 09:50:23 +0000 (10:50 +0100)
commit4f252f1a91e8c46508443ea92c6f221e6de5beb1
tree78397810624b52cc485ce911abfbc6ab50561579tree | snapshot
parentce197e2bceca00372c172a02a966b96287476c55commit | diff
parente7ee8230ced7c14043ca51191063c13e7fbc7212commit | diff
Rollup merge of #91404 - nnethercote:fix-bad-NodeId-limit-checking, r=dtolnay

Fix bad `NodeId` limit checking.

`Resolver::next_node_id` converts a `u32` to a `usize` (which is
possibly bigger), does a checked add, and then converts the result back
to a `u32`. The `usize` conversion completely subverts the checked add!

This commit removes the conversion to/from `usize`.
Empowering everyone to build reliable and efficient software.