]> git.lizzy.rs Git - rust.git/commit - src/tools/miri
Rollup merge of #95831 - redzic:xor-uppercase, r=workingjubilee
authorDylan DPC <99973273+Dylan-DPC@users.noreply.github.com>
Sat, 9 Apr 2022 16:26:30 +0000 (18:26 +0200)
committerGitHub <noreply@github.com>
Sat, 9 Apr 2022 16:26:30 +0000 (18:26 +0200)
commit7726265ae0d3d2b37b4254980a72d5d5347fb92d
treeb7068e427d11a5cbc64f5da386e58e102f671235
parent2464ea251010f6de62ec875b32f3463dfa326cfb
parent1e6365d0751c0c7b88a30ad5eab0becb6cc87f7e
Rollup merge of #95831 - redzic:xor-uppercase, r=workingjubilee

Use bitwise XOR in to_ascii_uppercase

This saves an instruction compared to the previous approach, which
was to unset the fifth bit with bitwise OR.

Comparison of generated assembly on x86: https://godbolt.org/z/GdfvdGs39

This can also affect autovectorization, saving SIMD instructions as well: https://godbolt.org/z/cnPcz75T9

Not sure if `u8::to_ascii_lowercase` should also be changed, since using bitwise OR for that function does not require an extra bitwise negate since the code is setting a bit rather than unsetting a bit. `char::to_ascii_uppercase` already uses XOR, so no change seems to be required there.