]> git.lizzy.rs Git - rust.git/commit - src/tools/clippy
Auto merge of #69332 - nnethercote:revert-u8to64_le-changes, r=michaelwoerister
authorbors <bors@rust-lang.org>
Sat, 22 Feb 2020 07:26:58 +0000 (07:26 +0000)
committerbors <bors@rust-lang.org>
Sat, 22 Feb 2020 07:26:58 +0000 (07:26 +0000)
commit03d2f5cd6c634b1fdcd26b036009aa4dce37fdfc
tree276884fec5a6f84d9fdf190a5f4babafe8a28d35
parent87e494c4cdf3f4f39d25ca008173f80688b8eb3d
parent100ff5a25666a1903113ecff0dc63ad84e5bdff7
Auto merge of #69332 - nnethercote:revert-u8to64_le-changes, r=michaelwoerister

Revert `u8to64_le` changes from #68914.

`SipHasher128`'s `u8to64_le` function was simplified in #68914.
Unfortunately, the new version is slower, because it introduces `memcpy`
calls with non-statically-known lengths.

This commit reverts the change, and adds an explanatory comment (which
is also added to `libcore/hash/sip.rs`). This barely affects
`SipHasher128`'s speed because it doesn't use `u8to64_le` much, but it
does result in `SipHasher128` once again being consistent with
`libcore/hash/sip.rs`.

r? @michaelwoerister