X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=src%2Fmapblock.cpp;h=0996dd168874dea543cc2e7c5e0cd5654b8b0e86;hb=b994a35d978d3f1dd172ff9a77515d4fcba5e89c;hp=dd47c6ffc28aa4c01c8ad6c1b66ae91bd5e776c1;hpb=43a28f04fa3ddf4b612f58c25a896293a01567e3;p=dragonfireclient.git diff --git a/src/mapblock.cpp b/src/mapblock.cpp index dd47c6ffc..0996dd168 100644 --- a/src/mapblock.cpp +++ b/src/mapblock.cpp @@ -1,415 +1,136 @@ /* -Minetest-c55 -Copyright (C) 2010 celeron55, Perttu Ahola +Minetest +Copyright (C) 2013 celeron55, Perttu Ahola This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or +it under the terms of the GNU Lesser General Public License as published by +the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. +GNU Lesser General Public License for more details. -You should have received a copy of the GNU General Public License along +You should have received a copy of the GNU Lesser General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "mapblock.h" + +#include #include "map.h" -// For g_settings -#include "main.h" #include "light.h" -#include +#include "nodedef.h" +#include "nodemetadata.h" +#include "gamedef.h" +#include "log.h" +#include "nameidmapping.h" +#include "content_mapnode.h" // For legacy name-id mapping +#include "content_nodemeta.h" // For legacy deserialization +#include "serialization.h" +#ifndef SERVER +#include "client/mapblock_mesh.h" +#endif +#include "porting.h" +#include "util/string.h" +#include "util/serialize.h" +#include "util/basic_macros.h" + +static const char *modified_reason_strings[] = { + "initial", + "reallocate", + "setIsUnderground", + "setLightingExpired", + "setGenerated", + "setNode", + "setNodeNoCheck", + "setTimestamp", + "NodeMetaRef::reportMetadataChange", + "clearAllObjects", + "Timestamp expired (step)", + "addActiveObjectRaw", + "removeRemovedObjects/remove", + "removeRemovedObjects/deactivate", + "Stored list cleared in activateObjects due to overflow", + "deactivateFarObjects: Static data moved in", + "deactivateFarObjects: Static data moved out", + "deactivateFarObjects: Static data changed considerably", + "finishBlockMake: expireDayNightDiff", + "unknown", +}; + /* MapBlock */ -MapBlock::MapBlock(Map *parent, v3s16 pos, bool dummy): +MapBlock::MapBlock(Map *parent, v3s16 pos, IGameDef *gamedef, bool dummy): m_parent(parent), m_pos(pos), - m_modified(MOD_STATE_WRITE_NEEDED), - is_underground(false), - m_lighting_expired(true), - m_day_night_differs(false), - m_generated(false), - m_timestamp(BLOCK_TIMESTAMP_UNDEFINED), - m_usage_timer(0) + m_pos_relative(pos * MAP_BLOCKSIZE), + m_gamedef(gamedef) { - data = NULL; - if(dummy == false) + if (!dummy) reallocate(); - - //m_spawn_timer = -10000; - -#ifndef SERVER - m_mesh_expired = false; - mesh_mutex.Init(); - mesh = NULL; - m_temp_mods_mutex.Init(); -#endif } MapBlock::~MapBlock() { #ifndef SERVER { - JMutexAutoLock lock(mesh_mutex); - - if(mesh) - { - mesh->drop(); - mesh = NULL; - } + delete mesh; + mesh = nullptr; } #endif - if(data) - delete[] data; + delete[] data; } bool MapBlock::isValidPositionParent(v3s16 p) { - if(isValidPosition(p)) - { + if (isValidPosition(p)) { return true; } - else{ - return m_parent->isValidPosition(getPosRelative() + p); - } -} -MapNode MapBlock::getNodeParent(v3s16 p) -{ - if(isValidPosition(p) == false) - { - return m_parent->getNode(getPosRelative() + p); - } - else - { - if(data == NULL) - throw InvalidPositionException(); - return data[p.Z*MAP_BLOCKSIZE*MAP_BLOCKSIZE + p.Y*MAP_BLOCKSIZE + p.X]; - } + return m_parent->isValidPosition(getPosRelative() + p); } -void MapBlock::setNodeParent(v3s16 p, MapNode & n) +MapNode MapBlock::getNodeParent(v3s16 p, bool *is_valid_position) { - if(isValidPosition(p) == false) - { - m_parent->setNode(getPosRelative() + p, n); - } - else - { - if(data == NULL) - throw InvalidPositionException(); - data[p.Z*MAP_BLOCKSIZE*MAP_BLOCKSIZE + p.Y*MAP_BLOCKSIZE + p.X] = n; - } -} + if (!isValidPosition(p)) + return m_parent->getNodeNoEx(getPosRelative() + p, is_valid_position); -MapNode MapBlock::getNodeParentNoEx(v3s16 p) -{ - if(isValidPosition(p) == false) - { - try{ - return m_parent->getNode(getPosRelative() + p); - } - catch(InvalidPositionException &e) - { - return MapNode(CONTENT_IGNORE); - } - } - else - { - if(data == NULL) - { - return MapNode(CONTENT_IGNORE); - } - return data[p.Z*MAP_BLOCKSIZE*MAP_BLOCKSIZE + p.Y*MAP_BLOCKSIZE + p.X]; + if (!data) { + if (is_valid_position) + *is_valid_position = false; + return {CONTENT_IGNORE}; } + if (is_valid_position) + *is_valid_position = true; + return data[p.Z * zstride + p.Y * ystride + p.X]; } -#ifndef SERVER - -#if 1 -void MapBlock::updateMesh(u32 daynight_ratio) +std::string MapBlock::getModifiedReasonString() { -#if 0 - /* - DEBUG: If mesh has been generated, don't generate it again - */ - { - JMutexAutoLock meshlock(mesh_mutex); - if(mesh != NULL) - return; - } -#endif + std::string reason; - MeshMakeData data; - data.fill(daynight_ratio, this); - - scene::SMesh *mesh_new = makeMapBlockMesh(&data); - - /* - Replace the mesh - */ - - replaceMesh(mesh_new); - -} -#endif - -void MapBlock::replaceMesh(scene::SMesh *mesh_new) -{ - mesh_mutex.Lock(); - - //scene::SMesh *mesh_old = mesh[daynight_i]; - //mesh[daynight_i] = mesh_new; - - scene::SMesh *mesh_old = mesh; - mesh = mesh_new; - setMeshExpired(false); - - if(mesh_old != NULL) - { - // Remove hardware buffers of meshbuffers of mesh - // NOTE: No way, this runs in a different thread and everything - /*u32 c = mesh_old->getMeshBufferCount(); - for(u32 i=0; igetMeshBuffer(i); - }*/ - - /*dstream<<"mesh_old->getReferenceCount()=" - <getReferenceCount()<getMeshBufferCount(); - for(u32 i=0; igetMeshBuffer(i); - dstream<<"buf->getReferenceCount()=" - <getReferenceCount()<drop(); + for (u32 i = 0; i != ubound; i++) { + if ((m_modified_reason & (1 << i)) == 0) + continue; - //delete mesh_old; + reason += modified_reason_strings[i]; + reason += ", "; } - mesh_mutex.Unlock(); -} - -#endif // !SERVER - -/* - Propagates sunlight down through the block. - Doesn't modify nodes that are not affected by sunlight. - - Returns false if sunlight at bottom block is invalid. - Returns true if sunlight at bottom block is valid. - Returns true if bottom block doesn't exist. - - If there is a block above, continues from it. - If there is no block above, assumes there is sunlight, unless - is_underground is set or highest node is water. - - All sunlighted nodes are added to light_sources. + if (reason.length() > 2) + reason.resize(reason.length() - 2); - if remove_light==true, sets non-sunlighted nodes black. - - if black_air_left!=NULL, it is set to true if non-sunlighted - air is left in block. -*/ -bool MapBlock::propagateSunlight(core::map & light_sources, - bool remove_light, bool *black_air_left) -{ - // Whether the sunlight at the top of the bottom block is valid - bool block_below_is_valid = true; - - v3s16 pos_relative = getPosRelative(); - - for(s16 x=0; xndef(); + + // Running this function un-expires m_day_night_differs + m_day_night_differs_expired = false; + + if (!data) { m_day_night_differs = false; return; } @@ -446,33 +171,35 @@ void MapBlock::updateDayNightDiff() /* Check if any lighting value differs */ - for(u32 i=0; i=0; y--) { MapNode n = getNodeRef(p2d.X, y, p2d.Y); - if(content_features(n).walkable) - { + if (m_gamedef->ndef()->get(n).walkable) { if(y == MAP_BLOCKSIZE-1) return -2; - else - return y; + + return y; } } return -1; @@ -509,193 +246,359 @@ s16 MapBlock::getGroundLevel(v2s16 p2d) /* Serialization */ +// List relevant id-name pairs for ids in the block using nodedef +// Renumbers the content IDs (starting at 0 and incrementing +// use static memory requires about 65535 * sizeof(int) ram in order to be +// sure we can handle all content ids. But it's absolutely worth it as it's +// a speedup of 4 for one of the major time consuming functions on storing +// mapblocks. +static content_t getBlockNodeIdMapping_mapping[USHRT_MAX + 1]; +static void getBlockNodeIdMapping(NameIdMapping *nimap, MapNode *nodes, + const NodeDefManager *nodedef) +{ + memset(getBlockNodeIdMapping_mapping, 0xFF, (USHRT_MAX + 1) * sizeof(content_t)); + + std::set unknown_contents; + content_t id_counter = 0; + for (u32 i = 0; i < MapBlock::nodecount; i++) { + content_t global_id = nodes[i].getContent(); + content_t id = CONTENT_IGNORE; -void MapBlock::serialize(std::ostream &os, u8 version) + // Try to find an existing mapping + if (getBlockNodeIdMapping_mapping[global_id] != 0xFFFF) { + id = getBlockNodeIdMapping_mapping[global_id]; + } + else + { + // We have to assign a new mapping + id = id_counter++; + getBlockNodeIdMapping_mapping[global_id] = id; + + const ContentFeatures &f = nodedef->get(global_id); + const std::string &name = f.name; + if (name.empty()) + unknown_contents.insert(global_id); + else + nimap->set(id, name); + } + + // Update the MapNode + nodes[i].setContent(id); + } + for (u16 unknown_content : unknown_contents) { + errorstream << "getBlockNodeIdMapping(): IGNORING ERROR: " + << "Name for node id " << unknown_content << " not known" << std::endl; + } +} +// Correct ids in the block to match nodedef based on names. +// Unknown ones are added to nodedef. +// Will not update itself to match id-name pairs in nodedef. +static void correctBlockNodeIds(const NameIdMapping *nimap, MapNode *nodes, + IGameDef *gamedef) +{ + const NodeDefManager *nodedef = gamedef->ndef(); + // This means the block contains incorrect ids, and we contain + // the information to convert those to names. + // nodedef contains information to convert our names to globally + // correct ids. + std::unordered_set unnamed_contents; + std::unordered_set unallocatable_contents; + + bool previous_exists = false; + content_t previous_local_id = CONTENT_IGNORE; + content_t previous_global_id = CONTENT_IGNORE; + + for (u32 i = 0; i < MapBlock::nodecount; i++) { + content_t local_id = nodes[i].getContent(); + // If previous node local_id was found and same than before, don't lookup maps + // apply directly previous resolved id + // This permits to massively improve loading performance when nodes are similar + // example: default:air, default:stone are massively present + if (previous_exists && local_id == previous_local_id) { + nodes[i].setContent(previous_global_id); + continue; + } + + std::string name; + if (!nimap->getName(local_id, name)) { + unnamed_contents.insert(local_id); + previous_exists = false; + continue; + } + + content_t global_id; + if (!nodedef->getId(name, global_id)) { + global_id = gamedef->allocateUnknownNodeId(name); + if (global_id == CONTENT_IGNORE) { + unallocatable_contents.insert(name); + previous_exists = false; + continue; + } + } + nodes[i].setContent(global_id); + + // Save previous node local_id & global_id result + previous_local_id = local_id; + previous_global_id = global_id; + previous_exists = true; + } + + for (const content_t c: unnamed_contents) { + errorstream << "correctBlockNodeIds(): IGNORING ERROR: " + << "Block contains id " << c + << " with no name mapping" << std::endl; + } + for (const std::string &node_name: unallocatable_contents) { + errorstream << "correctBlockNodeIds(): IGNORING ERROR: " + << "Could not allocate global id for node name \"" + << node_name << "\"" << std::endl; + } +} + +void MapBlock::serialize(std::ostream &os, u8 version, bool disk) { if(!ser_ver_supported(version)) throw VersionMismatchException("ERROR: MapBlock format not supported"); - - if(data == NULL) - { + + if (!data) throw SerializationError("ERROR: Not writing dummy block."); + + FATAL_ERROR_IF(version < SER_FMT_VER_LOWEST_WRITE, "Serialisation version error"); + + // First byte + u8 flags = 0; + if(is_underground) + flags |= 0x01; + if(getDayNightDiff()) + flags |= 0x02; + if (!m_generated) + flags |= 0x08; + writeU8(os, flags); + if (version >= 27) { + writeU16(os, m_lighting_complete); } - - // These have no compression - if(version <= 3 || version == 5 || version == 6) - { - u32 nodecount = MAP_BLOCKSIZE*MAP_BLOCKSIZE*MAP_BLOCKSIZE; - - u32 buflen = 1 + nodecount * MapNode::serializedLength(version); - SharedBuffer dest(buflen); - dest[0] = is_underground; + /* + Bulk node data + */ + NameIdMapping nimap; + if(disk) + { + MapNode *tmp_nodes = new MapNode[nodecount]; for(u32 i=0; indef()); + + u8 content_width = 2; + u8 params_width = 2; + writeU8(os, content_width); + writeU8(os, params_width); + MapNode::serializeBulk(os, version, tmp_nodes, nodecount, + content_width, params_width, true); + delete[] tmp_nodes; } - else if(version <= 10) + else { - /* - With compression. - Compress the materials and the params separately. - */ - - // First byte - os.write((char*)&is_underground, 1); + u8 content_width = 2; + u8 params_width = 2; + writeU8(os, content_width); + writeU8(os, params_width); + MapNode::serializeBulk(os, version, data, nodecount, + content_width, params_width, true); + } - u32 nodecount = MAP_BLOCKSIZE*MAP_BLOCKSIZE*MAP_BLOCKSIZE; + /* + Node metadata + */ + std::ostringstream oss(std::ios_base::binary); + m_node_metadata.serialize(oss, version, disk); + compressZlib(oss.str(), os); - // Get and compress materials - SharedBuffer materialdata(nodecount); - for(u32 i=0; i lightdata(nodecount); - for(u32 i=0; i= 10) - { - // Get and compress param2 - SharedBuffer param2data(nodecount); - for(u32 i=0; i= 25){ + // Node timers + m_node_timers.serialize(os, version); } } - // All other versions (newest) - else +} + +void MapBlock::serializeNetworkSpecific(std::ostream &os) +{ + if (!data) { + throw SerializationError("ERROR: Not writing dummy block."); + } + + writeU8(os, 2); // version +} + +void MapBlock::deSerialize(std::istream &is, u8 version, bool disk) +{ + if(!ser_ver_supported(version)) + throw VersionMismatchException("ERROR: MapBlock format not supported"); + + TRACESTREAM(<<"MapBlock::deSerialize "<= 18) - { - if(m_generated == false) - flags |= 0x08; - } - os.write((char*)&flags, 1); + deSerialize_pre22(is, version, disk); + return; + } - u32 nodecount = MAP_BLOCKSIZE*MAP_BLOCKSIZE*MAP_BLOCKSIZE; + u8 flags = readU8(is); + is_underground = (flags & 0x01) != 0; + m_day_night_differs = (flags & 0x02) != 0; + if (version < 27) + m_lighting_complete = 0xFFFF; + else + m_lighting_complete = readU16(is); + m_generated = (flags & 0x08) == 0; - /* - Get data - */ + /* + Bulk node data + */ + TRACESTREAM(<<"MapBlock::deSerialize "< databuf_nodelist(nodecount*3); - for(u32 i=0; i= 23) + m_node_metadata.deSerialize(iss, m_gamedef->idef()); + else + content_nodemeta_deserialize_legacy(iss, + &m_node_metadata, &m_node_timers, + m_gamedef->idef()); + } catch(SerializationError &e) { + warningstream<<"MapBlock::deSerialize(): Ignoring an error" + <<" while deserializing node metadata at (" + < databuf(nodecount*3); - for(u32 i=0; i= 14) - { - if(version <= 15) - { - try{ - std::ostringstream oss(std::ios_base::binary); - m_node_metadata.serialize(oss); - os<= 25){ + TRACESTREAM(<<"MapBlock::deSerialize "<=25)"< databuf_nodelist(nodecount * ser_length); // These have no compression - if(version <= 3 || version == 5 || version == 6) - { - u32 nodecount = MAP_BLOCKSIZE*MAP_BLOCKSIZE*MAP_BLOCKSIZE; + if (version <= 3 || version == 5 || version == 6) { char tmp; is.read(&tmp, 1); - if(is.gcount() != 1) - throw SerializationError - ("MapBlock::deSerialize: no enough input data"); + if (is.gcount() != 1) + throw SerializationError(std::string(FUNCTION_NAME) + + ": not enough input data"); is_underground = tmp; - for(u32 i=0; i d(len); - is.read((char*)*d, len); - if(is.gcount() != len) - throw SerializationError - ("MapBlock::deSerialize: no enough input data"); - data[i].deSerialize(*d, version); - } - } - else if(version <= 10) - { - u32 nodecount = MAP_BLOCKSIZE*MAP_BLOCKSIZE*MAP_BLOCKSIZE; - + is.read((char *)*databuf_nodelist, nodecount * ser_length); + if ((u32)is.gcount() != nodecount * ser_length) + throw SerializationError(std::string(FUNCTION_NAME) + + ": not enough input data"); + } else if (version <= 10) { u8 t8; - is.read((char*)&t8, 1); + is.read((char *)&t8, 1); is_underground = t8; { @@ -703,12 +606,11 @@ void MapBlock::deSerialize(std::istream &is, u8 version) std::ostringstream os(std::ios_base::binary); decompress(is, os, version); std::string s = os.str(); - if(s.size() != nodecount) - throw SerializationError - ("MapBlock::deSerialize: invalid format"); - for(u32 i=0; i= 10) - { + + if (version >= 10) { // Uncompress and set param2 data std::ostringstream os(std::ios_base::binary); decompress(is, os, version); std::string s = os.str(); - if(s.size() != nodecount) - throw SerializationError - ("MapBlock::deSerialize: invalid format"); - for(u32 i=0; i= 18) - m_generated = (flags & 0x08) ? false : true; + m_generated = (flags & 0x08) == 0; // Uncompress data std::ostringstream os(std::ios_base::binary); decompress(is, os, version); std::string s = os.str(); - if(s.size() != nodecount*3) - throw SerializationError - ("MapBlock::deSerialize: decompress resulted in size" - " other than nodecount*3"); + if (s.size() != nodecount * 3) + throw SerializationError(std::string(FUNCTION_NAME) + + ": decompress resulted in size other than nodecount*3"); // deserialize nodes from buffer - for(u32 i=0; i= 14) - { + if (version >= 14) { // Ignore errors - try{ - if(version <= 15) - { + try { + if (version <= 15) { std::string data = deSerializeString(is); std::istringstream iss(data, std::ios_base::binary); - m_node_metadata.deSerialize(iss); - } - else - { + content_nodemeta_deserialize_legacy(iss, + &m_node_metadata, &m_node_timers, + m_gamedef->idef()); + } else { //std::string data = deSerializeLongString(is); std::ostringstream oss(std::ios_base::binary); decompressZlib(is, oss); std::istringstream iss(oss.str(), std::ios_base::binary); - m_node_metadata.deSerialize(iss); + content_nodemeta_deserialize_legacy(iss, + &m_node_metadata, &m_node_timers, + m_gamedef->idef()); } - } - catch(SerializationError &e) - { - dstream<<"WARNING: MapBlock::deSerialize(): Ignoring an error" + } catch(SerializationError &e) { + warningstream<<"MapBlock::deSerialize(): Ignoring an error" <<" while deserializing node metadata"<= 9) - { - // count=0 - writeU16(os, 0); - } - - // Versions up from 15 have static objects. - if(version >= 15) - { - m_static_objects.serialize(os); + // Deserialize node data + for (u32 i = 0; i < nodecount; i++) { + data[i].deSerialize(&databuf_nodelist[i * ser_length], version); } - // Timestamp - if(version >= 17) - { - writeU32(os, getTimestamp()); - } -} + if (disk) { + /* + Versions up from 9 have block objects. (DEPRECATED) + */ + if (version >= 9) { + u16 count = readU16(is); + // Not supported and length not known if count is not 0 + if(count != 0){ + warningstream<<"MapBlock::deSerialize_pre22(): " + <<"Ignoring stuff coming at and after MBOs"<= 9) - { - u16 count = readU16(is); - // Not supported and length not known if count is not 0 - if(count != 0){ - dstream<<"WARNING: MapBlock::deSerializeDiskExtra(): " - <<"Ignoring stuff coming at and after MBOs"<= 15) + m_static_objects.deSerialize(is); + + // Timestamp + if (version >= 17) { + setTimestamp(readU32(is)); + m_disk_timestamp = m_timestamp; + } else { + setTimestamp(BLOCK_TIMESTAMP_UNDEFINED); } - } - /* - Versions up from 15 have static objects. - */ - if(version >= 15) - { - m_static_objects.deSerialize(is); - } - - // Timestamp - if(version >= 17) - { - setTimestamp(readU32(is)); + // Dynamically re-set ids based on node names + NameIdMapping nimap; + // If supported, read node definition id mapping + if (version >= 21) { + nimap.deSerialize(is); + // Else set the legacy mapping + } else { + content_mapnode_get_name_id_mapping(&nimap); + } + correctBlockNodeIds(&nimap, data, m_gamedef); } - else + + + // Legacy data changes + // This code has to convert from pre-22 to post-22 format. + const NodeDefManager *nodedef = m_gamedef->ndef(); + for(u32 i=0; iget(data[i].getContent()); + // Mineral + if(nodedef->getId("default:stone") == data[i].getContent() + && data[i].getParam1() == 1) + { + data[i].setContent(nodedef->getId("default:stone_with_coal")); + data[i].setParam1(0); + } + else if(nodedef->getId("default:stone") == data[i].getContent() + && data[i].getParam1() == 2) + { + data[i].setContent(nodedef->getId("default:stone_with_iron")); + data[i].setParam1(0); + } + // facedir_simple + if(f.legacy_facedir_simple) + { + data[i].setParam2(data[i].getParam1()); + data[i].setParam1(0); + } + // wall_mounted + if(f.legacy_wallmounted) + { + u8 wallmounted_new_to_old[8] = {0x04, 0x08, 0x01, 0x02, 0x10, 0x20, 0, 0}; + u8 dir_old_format = data[i].getParam2(); + u8 dir_new_format = 0; + for(u8 j=0; j<8; j++) + { + if((dir_old_format & wallmounted_new_to_old[j]) != 0) + { + dir_new_format = j; + break; + } + } + data[i].setParam2(dir_new_format); + } } + } /* @@ -866,17 +786,15 @@ void MapBlock::deSerializeDiskExtra(std::istream &is, u8 version) std::string analyze_block(MapBlock *block) { if(block == NULL) - { return "NULL"; - } std::ostringstream desc; - + v3s16 p = block->getPos(); - char spos[20]; - snprintf(spos, 20, "(%2d,%2d,%2d), ", p.X, p.Y, p.Z); + char spos[25]; + porting::mt_snprintf(spos, sizeof(spos), "(%2d,%2d,%2d), ", p.X, p.Y, p.Z); desc<getModified()) { case MOD_STATE_CLEAN: @@ -902,17 +820,7 @@ std::string analyze_block(MapBlock *block) else desc<<"is_ug [ ], "; -#ifndef SERVER - if(block->getMeshExpired()) - desc<<"mesh_exp [X], "; - else - desc<<"mesh_exp [ ], "; -#endif - - if(block->getLightingExpired()) - desc<<"lighting_exp [X], "; - else - desc<<"lighting_exp [ ], "; + desc<<"lighting_complete: "<getLightingComplete()<<", "; if(block->isDummy()) { @@ -920,26 +828,16 @@ std::string analyze_block(MapBlock *block) } else { - // We'll just define the numbers here, don't want to include - // content_mapnode.h - const content_t content_water = 2; - const content_t content_watersource = 9; - const content_t content_tree = 0x801; - const content_t content_leaves = 0x802; - const content_t content_jungletree = 0x815; - bool full_ignore = true; bool some_ignore = false; bool full_air = true; bool some_air = false; - bool trees = false; - bool water = false; for(s16 z0=0; z0getNode(p); + MapNode n = block->getNodeNoEx(p); content_t c = n.getContent(); if(c == CONTENT_IGNORE) some_ignore = true; @@ -949,33 +847,22 @@ std::string analyze_block(MapBlock *block) some_air = true; else full_air = false; - if(c == content_tree || c == content_jungletree - || c == content_leaves) - trees = true; - if(c == content_water - || c == content_watersource) - water = true; } - + desc<<"content {"; - + std::ostringstream ss; - + if(full_ignore) ss<<"IGNORE (full), "; else if(some_ignore) ss<<"IGNORE, "; - + if(full_air) ss<<"AIR (full), "; else if(some_air) ss<<"AIR, "; - if(trees) - ss<<"trees, "; - if(water) - ss<<"water, "; - if(ss.str().size()>=2) desc<