X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=src%2Fcraftdef.cpp;h=8aa8099306bec44b268b833367851bdacdc91bc7;hb=1d4a2a6ea7608a9fbe8de07dde8a48476c9f5e0d;hp=80937ccb79ee0a671ba93d3491e585bd012f9e98;hpb=368496b612931323b589abc1cb07fdc4c8c02a6c;p=minetest.git diff --git a/src/craftdef.cpp b/src/craftdef.cpp index 80937ccb7..8aa809930 100644 --- a/src/craftdef.cpp +++ b/src/craftdef.cpp @@ -27,31 +27,71 @@ with this program; if not, write to the Free Software Foundation, Inc., #include "gamedef.h" #include "inventory.h" #include "util/serialize.h" -#include "strfnd.h" +#include "util/string.h" +#include "util/numeric.h" +#include "util/strfnd.h" #include "exceptions.h" +inline bool isGroupRecipeStr(const std::string &rec_name) +{ + return str_starts_with(rec_name, std::string("group:")); +} + +inline u64 getHashForString(const std::string &recipe_str) +{ + /*errorstream << "Hashing craft string \"" << recipe_str << '"';*/ + return murmur_hash_64_ua(recipe_str.data(), recipe_str.length(), 0xdeadbeef); +} + +static u64 getHashForGrid(CraftHashType type, const std::vector &grid_names) +{ + switch (type) { + case CRAFT_HASH_TYPE_ITEM_NAMES: { + std::ostringstream os; + bool is_first = true; + for (const std::string &grid_name : grid_names) { + if (!grid_name.empty()) { + os << (is_first ? "" : "\n") << grid_name; + is_first = false; + } + } + return getHashForString(os.str()); + } case CRAFT_HASH_TYPE_COUNT: { + u64 cnt = 0; + for (const std::string &grid_name : grid_names) + if (!grid_name.empty()) + cnt++; + return cnt; + } case CRAFT_HASH_TYPE_UNHASHED: + return 0; + } + // invalid CraftHashType + assert(false); + return 0; +} + // Check if input matches recipe // Takes recipe groups into account static bool inputItemMatchesRecipe(const std::string &inp_name, const std::string &rec_name, IItemDefManager *idef) { // Exact name - if(inp_name == rec_name) + if (inp_name == rec_name) return true; // Group - if(rec_name.substr(0,6) == "group:" && idef->isKnown(inp_name)){ + if (isGroupRecipeStr(rec_name) && idef->isKnown(inp_name)) { const struct ItemDefinition &def = idef->get(inp_name); Strfnd f(rec_name.substr(6)); bool all_groups_match = true; - do{ + do { std::string check_group = f.next(","); - if(itemgroup_get(def.groups, check_group) == 0){ + if (itemgroup_get(def.groups, check_group) == 0) { all_groups_match = false; break; } - }while(!f.atend()); - if(all_groups_match) + } while (!f.at_end()); + if (all_groups_match) return true; } @@ -72,11 +112,8 @@ static std::vector craftGetItemNames( const std::vector &itemstrings, IGameDef *gamedef) { std::vector result; - for(std::vector::const_iterator - i = itemstrings.begin(); - i != itemstrings.end(); i++) - { - result.push_back(craftGetItemName(*i, gamedef)); + for (const auto &itemstring : itemstrings) { + result.push_back(craftGetItemName(itemstring, gamedef)); } return result; } @@ -86,11 +123,8 @@ static std::vector craftGetItemNames( const std::vector &items, IGameDef *gamedef) { std::vector result; - for(std::vector::const_iterator - i = items.begin(); - i != items.end(); i++) - { - result.push_back(i->name); + for (const auto &item : items) { + result.push_back(item.name); } return result; } @@ -100,11 +134,9 @@ static std::vector craftGetItems( const std::vector &items, IGameDef *gamedef) { std::vector result; - for(std::vector::const_iterator - i = items.begin(); - i != items.end(); i++) - { - result.push_back(ItemStack(std::string(*i),(u16)1,(u16)0,"",gamedef->getItemDefManager())); + for (const auto &item : items) { + result.emplace_back(std::string(item), (u16)1, + (u16)0, gamedef->getItemDefManager()); } return result; } @@ -118,32 +150,25 @@ static bool craftGetBounds(const std::vector &items, unsigned int w bool success = false; unsigned int x = 0; unsigned int y = 0; - for(std::vector::const_iterator - i = items.begin(); - i != items.end(); i++) - { - if(*i != "") // Is this an actual item? - { - if(!success) - { + for (const std::string &item : items) { + // Is this an actual item? + if (!item.empty()) { + if (!success) { // This is the first nonempty item min_x = max_x = x; min_y = max_y = y; success = true; - } - else - { - if(x < min_x) min_x = x; - if(x > max_x) max_x = x; - if(y < min_y) min_y = y; - if(y > max_y) max_y = y; + } else { + if (x < min_x) min_x = x; + if (x > max_x) max_x = x; + if (y < min_y) min_y = y; + if (y > max_y) max_y = y; } } // Step coordinate x++; - if(x == width) - { + if (x == width) { x = 0; y++; } @@ -154,12 +179,9 @@ static bool craftGetBounds(const std::vector &items, unsigned int w // Removes 1 from each item stack static void craftDecrementInput(CraftInput &input, IGameDef *gamedef) { - for(std::vector::iterator - i = input.items.begin(); - i != input.items.end(); i++) - { - if(i->count != 0) - i->remove(1); + for (auto &item : input.items) { + if (item.count != 0) + item.remove(1); } } @@ -167,11 +189,11 @@ static void craftDecrementInput(CraftInput &input, IGameDef *gamedef) // Example: if replacements contains the pair ("bucket:bucket_water", "bucket:bucket_empty"), // a water bucket will not be removed but replaced by an empty bucket. static void craftDecrementOrReplaceInput(CraftInput &input, + std::vector &output_replacements, const CraftReplacements &replacements, IGameDef *gamedef) { - if(replacements.pairs.empty()) - { + if (replacements.pairs.empty()) { craftDecrementInput(input, gamedef); return; } @@ -179,37 +201,30 @@ static void craftDecrementOrReplaceInput(CraftInput &input, // Make a copy of the replacements pair list std::vector > pairs = replacements.pairs; - for(std::vector::iterator - i = input.items.begin(); - i != input.items.end(); i++) - { - if(i->count == 1) - { - // Find an appropriate replacement - bool found_replacement = false; - for(std::vector >::iterator - j = pairs.begin(); - j != pairs.end(); j++) - { - ItemStack from_item; - from_item.deSerialize(j->first, gamedef->idef()); - if(i->name == from_item.name) - { - i->deSerialize(j->second, gamedef->idef()); + for (auto &item : input.items) { + // Find an appropriate replacement + bool found_replacement = false; + for (auto j = pairs.begin(); j != pairs.end(); ++j) { + if (inputItemMatchesRecipe(item.name, j->first, gamedef->idef())) { + if (item.count == 1) { + item.deSerialize(j->second, gamedef->idef()); found_replacement = true; pairs.erase(j); break; } + + ItemStack rep; + rep.deSerialize(j->second, gamedef->idef()); + item.remove(1); + found_replacement = true; + output_replacements.push_back(rep); + break; + } - // No replacement was found, simply decrement count to zero - if(!found_replacement) - i->remove(1); - } - else if(i->count >= 2) - { - // Ignore replacements for items with count >= 2 - i->remove(1); } + // No replacement was found, simply decrement count by one + if (!found_replacement && item.count > 0) + item.remove(1); } } @@ -218,24 +233,19 @@ static std::string craftDumpMatrix(const std::vector &items, unsigned int width) { std::ostringstream os(std::ios::binary); - os<<"{ "; + os << "{ "; unsigned int x = 0; - for(std::vector::const_iterator - i = items.begin(); - i != items.end(); i++, x++) - { - if(x == width) - { - os<<"; "; + for(std::vector::size_type i = 0; + i < items.size(); i++, x++) { + if (x == width) { + os << "; "; x = 0; + } else if (x != 0) { + os << ","; } - else if(x != 0) - { - os<<","; - } - os<<"\""<<(*i)<<"\""; + os << '"' << items[i] << '"'; } - os<<" }"; + os << " }"; return os.str(); } @@ -244,24 +254,19 @@ std::string craftDumpMatrix(const std::vector &items, unsigned int width) { std::ostringstream os(std::ios::binary); - os<<"{ "; + os << "{ "; unsigned int x = 0; - for(std::vector::const_iterator - i = items.begin(); - i != items.end(); i++, x++) - { - if(x == width) - { - os<<"; "; + for (std::vector::size_type i = 0; + i < items.size(); i++, x++) { + if (x == width) { + os << "; "; x = 0; + } else if (x != 0) { + os << ","; } - else if(x != 0) - { - os<<","; - } - os<<"\""<<(i->getItemString())<<"\""; + os << '"' << (items[i].getItemString()) << '"'; } - os<<" }"; + os << " }"; return os.str(); } @@ -273,7 +278,8 @@ std::string craftDumpMatrix(const std::vector &items, std::string CraftInput::dump() const { std::ostringstream os(std::ios::binary); - os<<"(method="<<((int)method)<<", items="< >::const_iterator - i = pairs.begin(); - i != pairs.end(); i++) - { - os<first)<<"\"=>\""<<(i->second)<<"\""; + for (const auto &repl_p : pairs) { + os << sep + << '"' << (repl_p.first) + << "\"=>\"" << (repl_p.second) << '"'; sep = ","; } - os<<"}"; + os << "}"; return os.str(); } -void CraftReplacements::serialize(std::ostream &os) const -{ - writeU16(os, pairs.size()); - for(u32 i=0; ideSerializeBody(is, version); - return def; -} - /* CraftDefinitionShaped */ @@ -388,37 +324,44 @@ std::string CraftDefinitionShaped::getName() const bool CraftDefinitionShaped::check(const CraftInput &input, IGameDef *gamedef) const { - if(input.method != CRAFT_METHOD_NORMAL) + if (input.method != CRAFT_METHOD_NORMAL) return false; // Get input item matrix std::vector inp_names = craftGetItemNames(input.items, gamedef); unsigned int inp_width = input.width; - if(inp_width == 0) + if (inp_width == 0) return false; - while(inp_names.size() % inp_width != 0) - inp_names.push_back(""); + while (inp_names.size() % inp_width != 0) + inp_names.emplace_back(""); // Get input bounds - unsigned int inp_min_x=0, inp_max_x=0, inp_min_y=0, inp_max_y=0; - if(!craftGetBounds(inp_names, inp_width, inp_min_x, inp_max_x, inp_min_y, inp_max_y)) + unsigned int inp_min_x = 0, inp_max_x = 0, inp_min_y = 0, inp_max_y = 0; + if (!craftGetBounds(inp_names, inp_width, inp_min_x, inp_max_x, + inp_min_y, inp_max_y)) return false; // it was empty + std::vector rec_names; + if (hash_inited) + rec_names = recipe_names; + else + rec_names = craftGetItemNames(recipe, gamedef); + // Get recipe item matrix - std::vector rec_names = craftGetItemNames(recipe, gamedef); unsigned int rec_width = width; - if(rec_width == 0) + if (rec_width == 0) return false; - while(rec_names.size() % rec_width != 0) - rec_names.push_back(""); + while (rec_names.size() % rec_width != 0) + rec_names.emplace_back(""); // Get recipe bounds unsigned int rec_min_x=0, rec_max_x=0, rec_min_y=0, rec_max_y=0; - if(!craftGetBounds(rec_names, rec_width, rec_min_x, rec_max_x, rec_min_y, rec_max_y)) + if (!craftGetBounds(rec_names, rec_width, rec_min_x, rec_max_x, + rec_min_y, rec_max_y)) return false; // it was empty // Different sizes? - if(inp_max_x - inp_min_x != rec_max_x - rec_min_x || + if (inp_max_x - inp_min_x != rec_max_x - rec_min_x || inp_max_y - inp_min_y != rec_max_y - rec_min_y) return false; @@ -426,18 +369,17 @@ bool CraftDefinitionShaped::check(const CraftInput &input, IGameDef *gamedef) co unsigned int w = inp_max_x - inp_min_x + 1; unsigned int h = inp_max_y - inp_min_y + 1; - for(unsigned int y=0; y < h; y++) { + for (unsigned int y=0; y < h; y++) { unsigned int inp_y = (inp_min_y + y) * inp_width; unsigned int rec_y = (rec_min_y + y) * rec_width; - for(unsigned int x=0; x < w; x++) { + for (unsigned int x=0; x < w; x++) { unsigned int inp_x = inp_min_x + x; unsigned int rec_x = rec_min_x + x; - if(!inputItemMatchesRecipe( + if (!inputItemMatchesRecipe( inp_names[inp_y + inp_x], - rec_names[rec_y + rec_x], gamedef->idef()) - ) { + rec_names[rec_y + rec_x], gamedef->idef())) { return false; } } @@ -456,41 +398,54 @@ CraftInput CraftDefinitionShaped::getInput(const CraftOutput &output, IGameDef * return CraftInput(CRAFT_METHOD_NORMAL,width,craftGetItems(recipe,gamedef)); } -void CraftDefinitionShaped::decrementInput(CraftInput &input, IGameDef *gamedef) const +void CraftDefinitionShaped::decrementInput(CraftInput &input, std::vector &output_replacements, + IGameDef *gamedef) const { - craftDecrementOrReplaceInput(input, replacements, gamedef); + craftDecrementOrReplaceInput(input, output_replacements, replacements, gamedef); } -std::string CraftDefinitionShaped::dump() const +CraftHashType CraftDefinitionShaped::getHashType() const { - std::ostringstream os(std::ios::binary); - os<<"(shaped, output=\""< rec_names = recipe_names; + std::sort(rec_names.begin(), rec_names.end()); + return getHashForGrid(type, rec_names); } -void CraftDefinitionShaped::serializeBody(std::ostream &os) const +void CraftDefinitionShaped::initHash(IGameDef *gamedef) { - os< input_filtered; - for(std::vector::const_iterator - i = input.items.begin(); - i != input.items.end(); i++) - { - if(i->name != "") - input_filtered.push_back(i->name); + for (const auto &item : input.items) { + if (!item.name.empty()) + input_filtered.push_back(item.name); } // If there is a wrong number of items in input, no match - if(input_filtered.size() != recipe.size()){ + if (input_filtered.size() != recipe.size()) { /*dstream<<"Number of input items ("<idef())){ + if (!inputItemMatchesRecipe(input_filtered[i], recipe_copy[i], + gamedef->idef())) { all_match = false; break; } } //dstream<<" -> match="< &output_replacements, + IGameDef *gamedef) const { - craftDecrementOrReplaceInput(input, replacements, gamedef); + craftDecrementOrReplaceInput(input, output_replacements, replacements, gamedef); } -std::string CraftDefinitionShapeless::dump() const +CraftHashType CraftDefinitionShapeless::getHashType() const { - std::ostringstream os(std::ios::binary); - os<<"(shapeless, output=\""<idef(); - if(item1.count != 1 || item2.count != 1 || item1.name != item2.name + if (item1.count != 1 || item2.count != 1 || item1.name != item2.name || idef->get(item1.name).type != ITEM_TOOL - || idef->get(item2.name).type != ITEM_TOOL) - { + || idef->get(item2.name).type != ITEM_TOOL) { // Failure return ItemStack(); } @@ -618,9 +588,9 @@ static ItemStack craftToolRepair( s32 item2_uses = 65536 - (u32) item2.wear; s32 new_uses = item1_uses + item2_uses; s32 new_wear = 65536 - new_uses + floor(additional_wear * 65536 + 0.5); - if(new_wear >= 65536) + if (new_wear >= 65536) return ItemStack(); - if(new_wear < 0) + if (new_wear < 0) new_wear = 0; ItemStack repaired = item1; @@ -635,21 +605,17 @@ std::string CraftDefinitionToolRepair::getName() const bool CraftDefinitionToolRepair::check(const CraftInput &input, IGameDef *gamedef) const { - if(input.method != CRAFT_METHOD_NORMAL) + if (input.method != CRAFT_METHOD_NORMAL) return false; ItemStack item1; ItemStack item2; - for(std::vector::const_iterator - i = input.items.begin(); - i != input.items.end(); i++) - { - if(!i->empty()) - { - if(item1.empty()) - item1 = *i; - else if(item2.empty()) - item2 = *i; + for (const auto &item : input.items) { + if (!item.empty()) { + if (item1.empty()) + item1 = item; + else if (item2.empty()) + item2 = item; else return false; } @@ -662,16 +628,12 @@ CraftOutput CraftDefinitionToolRepair::getOutput(const CraftInput &input, IGameD { ItemStack item1; ItemStack item2; - for(std::vector::const_iterator - i = input.items.begin(); - i != input.items.end(); i++) - { - if(!i->empty()) - { - if(item1.empty()) - item1 = *i; - else if(item2.empty()) - item2 = *i; + for (const auto &item : input.items) { + if (!item.empty()) { + if (item1.empty()) + item1 = item; + else if (item2.empty()) + item2 = item; } } ItemStack repaired = craftToolRepair(item1, item2, additional_wear, gamedef); @@ -681,11 +643,12 @@ CraftOutput CraftDefinitionToolRepair::getOutput(const CraftInput &input, IGameD CraftInput CraftDefinitionToolRepair::getInput(const CraftOutput &output, IGameDef *gamedef) const { std::vector stack; - stack.push_back(ItemStack()); - return CraftInput(CRAFT_METHOD_COOKING,additional_wear,stack); + stack.emplace_back(); + return CraftInput(CRAFT_METHOD_COOKING, additional_wear, stack); } -void CraftDefinitionToolRepair::decrementInput(CraftInput &input, IGameDef *gamedef) const +void CraftDefinitionToolRepair::decrementInput(CraftInput &input, std::vector &output_replacements, + IGameDef *gamedef) const { craftDecrementInput(input, gamedef); } @@ -693,22 +656,10 @@ void CraftDefinitionToolRepair::decrementInput(CraftInput &input, IGameDef *game std::string CraftDefinitionToolRepair::dump() const { std::ostringstream os(std::ios::binary); - os<<"(toolrepair, additional_wear="< input_filtered; - for(std::vector::const_iterator - i = input.items.begin(); - i != input.items.end(); i++) - { - if(i->name != "") - input_filtered.push_back(i->name); + for (const auto &item : input.items) { + const std::string &name = item.name; + if (!name.empty()) + input_filtered.push_back(name); } // If there is a wrong number of items in input, no match - if(input_filtered.size() != 1){ + if (input_filtered.size() != 1) { /*dstream<<"Number of input items ("< input_filtered; - for(std::vector::const_iterator - i = input.items.begin(); - i != input.items.end(); i++) - { - if(i->name != "") - input_filtered.push_back(i->name); + for (const auto &item : input.items) { + const std::string &name = item.name; + if (!name.empty()) + input_filtered.push_back(name); } // If there is a wrong number of items in input, no match - if(input_filtered.size() != 1){ + if (input_filtered.size() != 1) { /*dstream<<"Number of input items ("< &output_replacement, bool decrementInput, + IGameDef *gamedef) const { output.item = ""; output.time = 0; // If all input items are empty, abort. bool all_empty = true; - for(std::vector::const_iterator - i = input.items.begin(); - i != input.items.end(); i++) - { - if(!i->empty()) - { + for (const auto &item : input.items) { + if (!item.empty()) { all_empty = false; break; } } - if(all_empty) + if (all_empty) return false; - // Walk crafting definitions from back to front, so that later - // definitions can override earlier ones. - for(std::vector::const_reverse_iterator - i = m_craft_definitions.rbegin(); - i != m_craft_definitions.rend(); i++) - { - CraftDefinition *def = *i; + std::vector input_names; + input_names = craftGetItemNames(input.items, gamedef); + std::sort(input_names.begin(), input_names.end()); + + // Try hash types with increasing collision rate, and return if found. + for (int type = 0; type <= craft_hash_type_max; type++) { + u64 hash = getHashForGrid((CraftHashType) type, input_names); + + /*errorstream << "Checking type " << type << " with hash " << hash << std::endl;*/ + + // We'd like to do "const [...] hash_collisions = m_craft_defs[type][hash];" + // but that doesn't compile for some reason. This does. + auto col_iter = (m_craft_defs[type]).find(hash); + + if (col_iter == (m_craft_defs[type]).end()) + continue; - /*infostream<<"Checking "<dump()< &hash_collisions = col_iter->second; + // Walk crafting definitions from back to front, so that later + // definitions can override earlier ones. + for (std::vector::size_type + i = hash_collisions.size(); i > 0; i--) { + CraftDefinition *def = hash_collisions[i - 1]; - try { - if(def->check(input, gamedef)) - { + /*errorstream << "Checking " << input.dump() << std::endl + << " against " << def->dump() << std::endl;*/ + + if (def->check(input, gamedef)) { // Get output, then decrement input (if requested) output = def->getOutput(input, gamedef); - if(decrementInput) - def->decrementInput(input, gamedef); + if (decrementInput) + def->decrementInput(input, output_replacement, gamedef); + /*errorstream << "Check RETURNS TRUE" << std::endl;*/ return true; } } - catch(SerializationError &e) - { - errorstream<<"getCraftResult: ERROR: " - <<"Serialization error in recipe " - <dump()< getCraftRecipes(CraftOutput &output, + IGameDef *gamedef, unsigned limit=0) const + { + std::vector recipes; + + auto vec_iter = m_output_craft_definitions.find(output.item); + + if (vec_iter == m_output_craft_definitions.end()) + return recipes; + + const std::vector &vec = vec_iter->second; + + recipes.reserve(limit ? MYMIN(limit, vec.size()) : vec.size()); + + for (std::vector::size_type i = vec.size(); + i > 0; i--) { + CraftDefinition *def = vec[i - 1]; + if (limit && recipes.size() >= limit) + break; + recipes.push_back(def); + } + + return recipes; + } + + virtual bool clearCraftRecipesByOutput(const CraftOutput &output, IGameDef *gamedef) { - CraftOutput tmpout; - tmpout.item = ""; - tmpout.time = 0; + auto vec_iter = m_output_craft_definitions.find(output.item); - // If output item is empty, abort. - if(output.item.empty()) + if (vec_iter == m_output_craft_definitions.end()) return false; - // Walk crafting definitions from back to front, so that later - // definitions can override earlier ones. - for(std::vector::const_reverse_iterator - i = m_craft_definitions.rbegin(); - i != m_craft_definitions.rend(); i++) - { - CraftDefinition *def = *i; - - /*infostream<<"Checking "<dump()<getOutput(input, gamedef); - if((tmpout.item.substr(0,output.item.length()) == output.item) && - ((tmpout.item[output.item.length()] == 0) || - (tmpout.item[output.item.length()] == ' '))) - { - // Get output, then decrement input (if requested) - input = def->getInput(output, gamedef); - return true; + std::vector &vec = vec_iter->second; + for (auto def : vec) { + // Recipes are not yet hashed at this point + std::vector &unhashed_inputs_vec = m_craft_defs[(int) CRAFT_HASH_TYPE_UNHASHED][0]; + std::vector new_vec_by_input; + /* We will preallocate necessary memory addresses, so we don't need to reallocate them later. + This would save us some performance. */ + new_vec_by_input.reserve(unhashed_inputs_vec.size()); + for (auto &i2 : unhashed_inputs_vec) { + if (def != i2) { + new_vec_by_input.push_back(i2); } } - catch(SerializationError &e) - { - errorstream<<"getCraftResult: ERROR: " - <<"Serialization error in recipe " - <dump()< getCraftRecipes(CraftOutput &output, - IGameDef *gamedef) const + + virtual bool clearCraftRecipesByInput(CraftMethod craft_method, unsigned int craft_grid_width, + const std::vector &recipe, IGameDef *gamedef) { - std::vector recipes_list; - CraftInput input; - CraftOutput tmpout; - tmpout.item = ""; - tmpout.time = 0; - - for(std::vector::const_reverse_iterator - i = m_craft_definitions.rbegin(); - i != m_craft_definitions.rend(); i++) - { - CraftDefinition *def = *i; - - /*infostream<<"Checking "<dump()<getOutput(input, gamedef); - if(tmpout.item.substr(0,output.item.length()) == output.item) - { - // Get output, then decrement input (if requested) - input = def->getInput(output, gamedef); - recipes_list.push_back(*i); - } + bool all_empty = true; + for (const auto &i : recipe) { + if (!i.empty()) { + all_empty = false; + break; } - catch(SerializationError &e) - { - errorstream<<"getCraftResult: ERROR: " - <<"Serialization error in recipe " - <dump()< &unhashed_inputs_vec = m_craft_defs[(int) CRAFT_HASH_TYPE_UNHASHED][0]; + std::vector new_vec_by_input; + bool got_hit = false; + for (std::vector::size_type + i = unhashed_inputs_vec.size(); i > 0; i--) { + CraftDefinition *def = unhashed_inputs_vec[i - 1]; + /* If the input doesn't match the recipe definition, this recipe definition later + will be added back in source map. */ + if (!def->check(input, gamedef)) { + new_vec_by_input.push_back(def); + continue; } + CraftOutput output = def->getOutput(input, gamedef); + got_hit = true; + auto vec_iter = m_output_craft_definitions.find(output.item); + if (vec_iter == m_output_craft_definitions.end()) + continue; + std::vector &vec = vec_iter->second; + std::vector new_vec_by_output; + /* We will preallocate necessary memory addresses, so we don't need + to reallocate them later. This would save us some performance. */ + new_vec_by_output.reserve(vec.size()); + for (auto &vec_i : vec) { + /* If pointers from map by input and output are not same, + we will add 'CraftDefinition*' to a new vector. */ + if (def != vec_i) { + /* Adding dereferenced iterator value (which are + 'CraftDefinition' reference) to a new vector. */ + new_vec_by_output.push_back(vec_i); + } + } + // Swaps assigned to current key value with new vector for output map. + m_output_craft_definitions[output.item].swap(new_vec_by_output); } - return recipes_list; + if (got_hit) + // Swaps value with new vector for input map. + m_craft_defs[(int) CRAFT_HASH_TYPE_UNHASHED][0].swap(new_vec_by_input); + + return got_hit; } + virtual std::string dump() const { std::ostringstream os(std::ios::binary); - os<<"Crafting definitions:\n"; - for(std::vector::const_iterator - i = m_craft_definitions.begin(); - i != m_craft_definitions.end(); i++) - { - os<<(*i)->dump()<<"\n"; + os << "Crafting definitions:\n"; + for (int type = 0; type <= craft_hash_type_max; ++type) { + for (auto it = m_craft_defs[type].begin(); + it != m_craft_defs[type].end(); ++it) { + for (std::vector::size_type i = 0; + i < it->second.size(); i++) { + os << "type " << type + << " hash " << it->first + << " def " << it->second[i]->dump() + << "\n"; + } + } } return os.str(); } - virtual void registerCraft(CraftDefinition *def) + virtual void registerCraft(CraftDefinition *def, IGameDef *gamedef) { - verbosestream<<"registerCraft: registering craft definition: " - <dump()<dump() << std::endl; + m_craft_defs[(int) CRAFT_HASH_TYPE_UNHASHED][0].push_back(def); + + CraftInput input; + std::string output_name = craftGetItemName( + def->getOutput(input, gamedef).item, gamedef); + m_output_craft_definitions[output_name].push_back(def); } virtual void clear() { - for(std::vector::iterator - i = m_craft_definitions.begin(); - i != m_craft_definitions.end(); i++){ - delete *i; - } - m_craft_definitions.clear(); - } - virtual void serialize(std::ostream &os) const - { - writeU8(os, 0); // version - u16 count = m_craft_definitions.size(); - writeU16(os, count); - for(std::vector::const_iterator - i = m_craft_definitions.begin(); - i != m_craft_definitions.end(); i++){ - CraftDefinition *def = *i; - // Serialize wrapped in a string - std::ostringstream tmp_os(std::ios::binary); - def->serialize(tmp_os); - os< &unhashed = + m_craft_defs[(int) CRAFT_HASH_TYPE_UNHASHED][0]; + for (auto def : unhashed) { + // Initialize and get the definition's hash + def->initHash(gamedef); + CraftHashType type = def->getHashType(); + u64 hash = def->getHash(type); + + // Enter the definition + m_craft_defs[type][hash].push_back(def); } + unhashed.clear(); } private: - std::vector m_craft_definitions; + //TODO: change both maps to unordered_map when c++11 can be used + std::vector > > m_craft_defs; + std::map > m_output_craft_definitions; }; IWritableCraftDefManager* createCraftDefManager() { return new CCraftDefManager(); } -