X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Fzero_div_zero.rs;h=ec380360e547e1f0297916427edb84fa8d40a71c;hb=6d1225981177587fbb68d9c4902c770c3dbaafb0;hp=aaba018484508df27b3bbdab84d555edcc50f679;hpb=424a33720d61e1cdc0f8886000d4549857a6ee55;p=rust.git diff --git a/clippy_lints/src/zero_div_zero.rs b/clippy_lints/src/zero_div_zero.rs index aaba0184845..ec380360e54 100644 --- a/clippy_lints/src/zero_div_zero.rs +++ b/clippy_lints/src/zero_div_zero.rs @@ -1,39 +1,36 @@ use crate::consts::{constant_simple, Constant}; -use rustc::lint::*; -use rustc::hir::*; use crate::utils::span_help_and_lint; +use if_chain::if_chain; +use rustc::declare_lint_pass; +use rustc::hir::*; +use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc_session::declare_tool_lint; -/// **What it does:** Checks for `0.0 / 0.0`. -/// -/// **Why is this bad?** It's less readable than `std::f32::NAN` or -/// `std::f64::NAN`. -/// -/// **Known problems:** None. -/// -/// **Example:** -/// ```rust -/// 0.0f32 / 0.0 -/// ``` declare_clippy_lint! { + /// **What it does:** Checks for `0.0 / 0.0`. + /// + /// **Why is this bad?** It's less readable than `std::f32::NAN` or + /// `std::f64::NAN`. + /// + /// **Known problems:** None. + /// + /// **Example:** + /// ```rust + /// 0.0f32 / 0.0; + /// ``` pub ZERO_DIVIDED_BY_ZERO, complexity, "usage of `0.0 / 0.0` to obtain NaN instead of std::f32::NaN or std::f64::NaN" } -pub struct Pass; - -impl LintPass for Pass { - fn get_lints(&self) -> LintArray { - lint_array!(ZERO_DIVIDED_BY_ZERO) - } -} +declare_lint_pass!(ZeroDiv => [ZERO_DIVIDED_BY_ZERO]); -impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass { +impl<'a, 'tcx> LateLintPass<'a, 'tcx> for ZeroDiv { fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) { // check for instances of 0.0/0.0 if_chain! { - if let ExprBinary(ref op, ref left, ref right) = expr.node; - if let BinOp_::BiDiv = op.node; + if let ExprKind::Binary(ref op, ref left, ref right) = expr.kind; + if let BinOpKind::Div = op.node; // TODO - constant_simple does not fold many operations involving floats. // That's probably fine for this lint - it's pretty unlikely that someone would // do something like 0.0/(2.0 - 2.0), but it would be nice to warn on that case too.