X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Fok_if_let.rs;h=e060220d56b31840cd56a8ad388af989a89d43cd;hb=4d60841205d10293d6759df1948acda4c607c7eb;hp=e6fe0631a63b95692d1a3146af514d43f1c7ced9;hpb=d094f98f0b644d6422e7d363fbfd275d4b073605;p=rust.git diff --git a/clippy_lints/src/ok_if_let.rs b/clippy_lints/src/ok_if_let.rs index e6fe0631a63..e060220d56b 100644 --- a/clippy_lints/src/ok_if_let.rs +++ b/clippy_lints/src/ok_if_let.rs @@ -1,6 +1,17 @@ -use rustc::lint::*; +// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +use crate::utils::{match_type, method_chain_args, paths, snippet, span_help_and_lint}; +use if_chain::if_chain; use rustc::hir::*; -use utils::{match_type, method_chain_args, paths, snippet, span_help_and_lint}; +use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; +use rustc::{declare_tool_lint, lint_array}; /// **What it does:*** Checks for unnecessary `ok()` in if let. /// @@ -26,9 +37,9 @@ /// } /// } /// ``` -declare_lint! { +declare_clippy_lint! { pub IF_LET_SOME_RESULT, - Warn, + style, "usage of `ok()` in `if let Some(pat)` statements is unnecessary, match on `Ok(pat)` instead" } @@ -44,12 +55,12 @@ fn get_lints(&self) -> LintArray { impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass { fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) { if_chain! { //begin checking variables - if let ExprMatch(ref op, ref body, ref source) = expr.node; //test if expr is a match + if let ExprKind::Match(ref op, ref body, ref source) = expr.node; //test if expr is a match if let MatchSource::IfLetDesugar { .. } = *source; //test if it is an If Let - if let ExprMethodCall(_, _, ref result_types) = op.node; //check is expr.ok() has type Result.ok() + if let ExprKind::MethodCall(_, _, ref result_types) = op.node; //check is expr.ok() has type Result.ok() if let PatKind::TupleStruct(QPath::Resolved(_, ref x), ref y, _) = body[0].pats[0].node; //get operation if method_chain_args(op, &["ok"]).is_some(); //test to see if using ok() methoduse std::marker::Sized; - + then { let is_result_type = match_type(cx, cx.tables.expr_ty(&result_types[0]), &paths::RESULT); let some_expr_string = snippet(cx, y[0].span, "");