X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Fno_effect.rs;h=b8bfa676a16088cd6b412626308b033b833ddb74;hb=2ff568d746e4641b992c0b74bea046e43a637997;hp=6383d3ca2454a7346d5a4cedfc4922571d2e525b;hpb=ce1c6b285dd41c5861bf3df9423c01b4a3232be4;p=rust.git diff --git a/clippy_lints/src/no_effect.rs b/clippy_lints/src/no_effect.rs index 6383d3ca245..b8bfa676a16 100644 --- a/clippy_lints/src/no_effect.rs +++ b/clippy_lints/src/no_effect.rs @@ -69,7 +69,7 @@ fn has_no_effect(cx: &LateContext<'_, '_>, expr: &Expr<'_>) -> bool { if let ExprKind::Path(ref qpath) = callee.kind { let res = qpath_res(cx, qpath, callee.hir_id); match res { - Res::Def(DefKind::Struct, ..) | Res::Def(DefKind::Variant, ..) | Res::Def(DefKind::Ctor(..), _) => { + Res::Def(DefKind::Struct | DefKind::Variant | DefKind::Ctor(..), ..) => { !has_drop(cx, cx.tables.expr_ty(expr)) && args.iter().all(|arg| has_no_effect(cx, arg)) }, _ => false,