X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Fneedless_borrow.rs;h=6e18501480b6043bc5d0ebaea57fd36446db195f;hb=6d1225981177587fbb68d9c4902c770c3dbaafb0;hp=3a0b6d0fbdf0a83ff3355630bb0e650b453475d3;hpb=cd3df6bee0ee07c7dbb562b29576a0b513a4331b;p=rust.git diff --git a/clippy_lints/src/needless_borrow.rs b/clippy_lints/src/needless_borrow.rs index 3a0b6d0fbdf..6e18501480b 100644 --- a/clippy_lints/src/needless_borrow.rs +++ b/clippy_lints/src/needless_borrow.rs @@ -4,12 +4,13 @@ use crate::utils::{snippet_opt, span_lint_and_then}; use if_chain::if_chain; -use rustc::hir::{BindingAnnotation, Expr, ExprKind, HirId, Item, MutImmutable, Pat, PatKind}; +use rustc::hir::{BindingAnnotation, BorrowKind, Expr, ExprKind, HirId, Item, Mutability, Pat, PatKind}; +use rustc::impl_lint_pass; use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; use rustc::ty; use rustc::ty::adjustment::{Adjust, Adjustment}; -use rustc::{declare_tool_lint, impl_lint_pass}; use rustc_errors::Applicability; +use rustc_session::declare_tool_lint; declare_clippy_lint! { /// **What it does:** Checks for address of operations (`&`) that are going to @@ -41,8 +42,8 @@ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) { if e.span.from_expansion() || self.derived_item.is_some() { return; } - if let ExprKind::AddrOf(MutImmutable, ref inner) = e.node { - if let ty::Ref(..) = cx.tables.expr_ty(inner).sty { + if let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Not, ref inner) = e.kind { + if let ty::Ref(..) = cx.tables.expr_ty(inner).kind { for adj3 in cx.tables.expr_adjustments(e).windows(3) { if let [Adjustment { kind: Adjust::Deref(_), .. @@ -80,12 +81,12 @@ fn check_pat(&mut self, cx: &LateContext<'a, 'tcx>, pat: &'tcx Pat) { return; } if_chain! { - if let PatKind::Binding(BindingAnnotation::Ref, .., name, _) = pat.node; - if let ty::Ref(_, tam, mutbl) = cx.tables.pat_ty(pat).sty; - if mutbl == MutImmutable; - if let ty::Ref(_, _, mutbl) = tam.sty; + if let PatKind::Binding(BindingAnnotation::Ref, .., name, _) = pat.kind; + if let ty::Ref(_, tam, mutbl) = cx.tables.pat_ty(pat).kind; + if mutbl == Mutability::Not; + if let ty::Ref(_, _, mutbl) = tam.kind; // only lint immutable refs, because borrowed `&mut T` cannot be moved out - if mutbl == MutImmutable; + if mutbl == Mutability::Not; then { span_lint_and_then( cx, @@ -107,14 +108,14 @@ fn check_pat(&mut self, cx: &LateContext<'a, 'tcx>, pat: &'tcx Pat) { } } - fn check_item(&mut self, _: &LateContext<'a, 'tcx>, item: &'tcx Item) { + fn check_item(&mut self, _: &LateContext<'a, 'tcx>, item: &'tcx Item<'_>) { if item.attrs.iter().any(|a| a.check_name(sym!(automatically_derived))) { debug_assert!(self.derived_item.is_none()); self.derived_item = Some(item.hir_id); } } - fn check_item_post(&mut self, _: &LateContext<'a, 'tcx>, item: &'tcx Item) { + fn check_item_post(&mut self, _: &LateContext<'a, 'tcx>, item: &'tcx Item<'_>) { if let Some(id) = self.derived_item { if item.hir_id == id { self.derived_item = None;