X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Fneedless_bool.rs;h=7e8540ffd3592674225d52aacf05c9511b9779d4;hb=e5a5b0a0774625eebbe7b29c67b49dc6431544d1;hp=d19939be6c0d20d1641a0be604c595f018a74ca9;hpb=4d30b08027f191e26431e0e62b5f17de76d273c5;p=rust.git diff --git a/clippy_lints/src/needless_bool.rs b/clippy_lints/src/needless_bool.rs index d19939be6c0..7e8540ffd35 100644 --- a/clippy_lints/src/needless_bool.rs +++ b/clippy_lints/src/needless_bool.rs @@ -4,10 +4,11 @@ use crate::utils::sugg::Sugg; use crate::utils::{higher, parent_node_is_if_expr, span_lint, span_lint_and_sugg}; +use rustc::declare_lint_pass; use rustc::hir::*; use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; -use rustc::{declare_lint_pass, declare_tool_lint}; use rustc_errors::Applicability; +use rustc_session::declare_tool_lint; use syntax::ast::LitKind; use syntax::source_map::Spanned; @@ -87,7 +88,7 @@ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) { applicability, ); }; - if let ExprKind::Block(ref then_block, _) = then_block.node { + if let ExprKind::Block(ref then_block, _) = then_block.kind { match (fetch_bool_block(then_block), fetch_bool_expr(else_expr)) { (RetBool(true), RetBool(true)) | (Bool(true), Bool(true)) => { span_lint( @@ -126,7 +127,7 @@ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) { return; } - if let ExprKind::Binary(Spanned { node, .. }, ..) = e.node { + if let ExprKind::Binary(Spanned { node, .. }, ..) = e.kind { let ignore_case = None::<(fn(_) -> _, &str)>; let ignore_no_literal = None::<(fn(_, _) -> _, &str)>; match node { @@ -193,7 +194,7 @@ fn check_comparison<'a, 'tcx>( ) { use self::Expression::*; - if let ExprKind::Binary(_, ref left_side, ref right_side) = e.node { + if let ExprKind::Binary(_, ref left_side, ref right_side) = e.kind { let (l_ty, r_ty) = (cx.tables.expr_ty(left_side), cx.tables.expr_ty(right_side)); if l_ty.is_bool() && r_ty.is_bool() { let mut applicability = Applicability::MachineApplicable; @@ -259,8 +260,8 @@ fn fetch_bool_block(block: &Block) -> Expression { match (&*block.stmts, block.expr.as_ref()) { (&[], Some(e)) => fetch_bool_expr(&**e), (&[ref e], None) => { - if let StmtKind::Semi(ref e) = e.node { - if let ExprKind::Ret(_) = e.node { + if let StmtKind::Semi(ref e) = e.kind { + if let ExprKind::Ret(_) = e.kind { fetch_bool_expr(&**e) } else { Expression::Other @@ -274,7 +275,7 @@ fn fetch_bool_block(block: &Block) -> Expression { } fn fetch_bool_expr(expr: &Expr) -> Expression { - match expr.node { + match expr.kind { ExprKind::Block(ref block, _) => fetch_bool_block(block), ExprKind::Lit(ref lit_ptr) => { if let LitKind::Bool(value) = lit_ptr.node {