X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Fmutex_atomic.rs;h=89865bbaa99e29138d8604c3933853e22c9a2da6;hb=6d1225981177587fbb68d9c4902c770c3dbaafb0;hp=522c4ab52e2ec50b9796b26aa9764fa6445fb07b;hpb=ca6a9beb31f0e95e1f605a1fcf7439c58b93db83;p=rust.git diff --git a/clippy_lints/src/mutex_atomic.rs b/clippy_lints/src/mutex_atomic.rs index 522c4ab52e2..89865bbaa99 100644 --- a/clippy_lints/src/mutex_atomic.rs +++ b/clippy_lints/src/mutex_atomic.rs @@ -3,10 +3,11 @@ //! This lint is **warn** by default use crate::utils::{match_type, paths, span_lint}; +use rustc::declare_lint_pass; use rustc::hir::Expr; use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; use rustc::ty::{self, Ty}; -use rustc::{declare_lint_pass, declare_tool_lint}; +use rustc_session::declare_tool_lint; use syntax::ast; declare_clippy_lint! { @@ -57,7 +58,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Mutex { fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) { let ty = cx.tables.expr_ty(expr); - if let ty::Adt(_, subst) = ty.sty { + if let ty::Adt(_, subst) = ty.kind { if match_type(cx, ty, &paths::MUTEX) { let mutex_param = subst.type_at(0); if let Some(atomic_name) = get_atomic_name(mutex_param) { @@ -66,7 +67,7 @@ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) { behaviour and not the internal type, consider using Mutex<()>.", atomic_name ); - match mutex_param.sty { + match mutex_param.kind { ty::Uint(t) if t != ast::UintTy::Usize => span_lint(cx, MUTEX_INTEGER, expr.span, &msg), ty::Int(t) if t != ast::IntTy::Isize => span_lint(cx, MUTEX_INTEGER, expr.span, &msg), _ => span_lint(cx, MUTEX_ATOMIC, expr.span, &msg), @@ -77,8 +78,8 @@ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) { } } -fn get_atomic_name(ty: Ty<'_>) -> Option<(&'static str)> { - match ty.sty { +fn get_atomic_name(ty: Ty<'_>) -> Option<&'static str> { + match ty.kind { ty::Bool => Some("AtomicBool"), ty::Uint(_) => Some("AtomicUsize"), ty::Int(_) => Some("AtomicIsize"),