X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Fif_not_else.rs;h=7019cfa8cc8f120715eeb8060dbe223456ca5143;hb=e5a5b0a0774625eebbe7b29c67b49dc6431544d1;hp=385ba9f16c89ee63d841689270434c51b717fee4;hpb=95e537b03976a8ddf42c91e63f4537e11b25b862;p=rust.git diff --git a/clippy_lints/src/if_not_else.rs b/clippy_lints/src/if_not_else.rs index 385ba9f16c8..7019cfa8cc8 100644 --- a/clippy_lints/src/if_not_else.rs +++ b/clippy_lints/src/if_not_else.rs @@ -1,8 +1,9 @@ //! lint on if branches that could be swapped so no `!` operation is necessary //! on the condition +use rustc::declare_lint_pass; use rustc::lint::{in_external_macro, EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass}; -use rustc::{declare_lint_pass, declare_tool_lint}; +use rustc_session::declare_tool_lint; use syntax::ast::*; use crate::utils::span_help_and_lint; @@ -17,6 +18,9 @@ /// /// **Example:** /// ```rust + /// # let v: Vec = vec![]; + /// # fn a() {} + /// # fn b() {} /// if !v.is_empty() { /// a() /// } else { @@ -27,6 +31,9 @@ /// Could be written: /// /// ```rust + /// # let v: Vec = vec![]; + /// # fn a() {} + /// # fn b() {} /// if v.is_empty() { /// b() /// } else { @@ -45,9 +52,9 @@ fn check_expr(&mut self, cx: &EarlyContext<'_>, item: &Expr) { if in_external_macro(cx.sess(), item.span) { return; } - if let ExprKind::If(ref cond, _, Some(ref els)) = item.node { - if let ExprKind::Block(..) = els.node { - match cond.node { + if let ExprKind::If(ref cond, _, Some(ref els)) = item.kind { + if let ExprKind::Block(..) = els.kind { + match cond.kind { ExprKind::Unary(UnOp::Not, _) => { span_help_and_lint( cx,