X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Fenum_clike.rs;h=c4b368a6e2e8054ba32292d6ec373696142f2c8e;hb=e5a5b0a0774625eebbe7b29c67b49dc6431544d1;hp=d2931acc538bd92e2220fe4ad9677829c32a6f88;hpb=46e64911ad43c519c61d22afef7f82625dd9c4a8;p=rust.git diff --git a/clippy_lints/src/enum_clike.rs b/clippy_lints/src/enum_clike.rs index d2931acc538..c4b368a6e2e 100644 --- a/clippy_lints/src/enum_clike.rs +++ b/clippy_lints/src/enum_clike.rs @@ -3,13 +3,14 @@ use crate::consts::{miri_to_const, Constant}; use crate::utils::span_lint; +use rustc::declare_lint_pass; use rustc::hir::*; use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; use rustc::mir::interpret::GlobalId; use rustc::ty; use rustc::ty::subst::InternalSubsts; use rustc::ty::util::IntTypeExt; -use rustc::{declare_lint_pass, declare_tool_lint}; +use rustc_session::declare_tool_lint; use std::convert::TryFrom; use syntax::ast::{IntTy, UintTy}; @@ -24,6 +25,7 @@ /// /// **Example:** /// ```rust + /// # #[cfg(target_pointer_width = "64")] /// #[repr(usize)] /// enum NonPortable { /// X = 0x1_0000_0000, @@ -43,13 +45,12 @@ fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) { if cx.tcx.data_layout.pointer_size.bits() != 64 { return; } - if let ItemKind::Enum(ref def, _) = item.node { + if let ItemKind::Enum(def, _) = &item.kind { for var in &def.variants { - let variant = &var.node; - if let Some(ref anon_const) = variant.disr_expr { + if let Some(anon_const) = &var.disr_expr { let param_env = ty::ParamEnv::empty(); let def_id = cx.tcx.hir().body_owner_def_id(anon_const.body); - let substs = InternalSubsts::identity_for_item(cx.tcx.global_tcx(), def_id); + let substs = InternalSubsts::identity_for_item(cx.tcx, def_id); let instance = ty::Instance::new(def_id, substs); let c_id = GlobalId { instance, @@ -58,12 +59,12 @@ fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) { let constant = cx.tcx.const_eval(param_env.and(c_id)).ok(); if let Some(Constant::Int(val)) = constant.and_then(miri_to_const) { let mut ty = cx.tcx.type_of(def_id); - if let ty::Adt(adt, _) = ty.sty { + if let ty::Adt(adt, _) = ty.kind { if adt.is_enum() { ty = adt.repr.discr_type().to_ty(cx.tcx); } } - match ty.sty { + match ty.kind { ty::Int(IntTy::Isize) => { let val = ((val as i128) << 64) >> 64; if i32::try_from(val).is_ok() {