X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Fdouble_parens.rs;h=d08981e8badc7e482b8d3c97a608d16806deec53;hb=920cdb59e1edf2c4cb2f266fa521f12c1b97a499;hp=f39ea6a3cc5a36d8e48a0a3dcd7b17ff5533ca26;hpb=a7fe3b2ebb35e6bca78bc103a75966105981abc4;p=rust.git diff --git a/clippy_lints/src/double_parens.rs b/clippy_lints/src/double_parens.rs index f39ea6a3cc5..d08981e8bad 100644 --- a/clippy_lints/src/double_parens.rs +++ b/clippy_lints/src/double_parens.rs @@ -1,6 +1,6 @@ -use crate::utils::{in_macro_or_desugar, span_lint}; -use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass}; -use rustc::{declare_lint_pass, declare_tool_lint}; +use crate::utils::span_lint; +use rustc_lint::{EarlyContext, EarlyLintPass}; +use rustc_session::{declare_lint_pass, declare_tool_lint}; use syntax::ast::*; declare_clippy_lint! { @@ -13,9 +13,10 @@ /// /// **Example:** /// ```rust - /// ((0)) - /// foo((0)) - /// ((1, 2)) + /// # fn foo(bar: usize) {} + /// ((0)); + /// foo((0)); + /// ((1, 2)); /// ``` pub DOUBLE_PARENS, complexity, @@ -26,12 +27,12 @@ impl EarlyLintPass for DoubleParens { fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) { - if in_macro_or_desugar(expr.span) { + if expr.span.from_expansion() { return; } - match expr.node { - ExprKind::Paren(ref in_paren) => match in_paren.node { + match expr.kind { + ExprKind::Paren(ref in_paren) => match in_paren.kind { ExprKind::Paren(_) | ExprKind::Tup(_) => { span_lint( cx, @@ -45,7 +46,7 @@ fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) { ExprKind::Call(_, ref params) => { if params.len() == 1 { let param = ¶ms[0]; - if let ExprKind::Paren(_) = param.node { + if let ExprKind::Paren(_) = param.kind { span_lint( cx, DOUBLE_PARENS, @@ -58,7 +59,7 @@ fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &Expr) { ExprKind::MethodCall(_, ref params) => { if params.len() == 2 { let param = ¶ms[1]; - if let ExprKind::Paren(_) = param.node { + if let ExprKind::Paren(_) = param.kind { span_lint( cx, DOUBLE_PARENS,