X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=clippy_lints%2Fsrc%2Farithmetic.rs;h=7653ba43459f2db068f24be9a778f71b2d65745c;hb=6d1225981177587fbb68d9c4902c770c3dbaafb0;hp=1cca897e73900b9eaa11fde39574f522d2585387;hpb=e6f16c77c1e39c60fcf17ef9d4b656c388543f29;p=rust.git diff --git a/clippy_lints/src/arithmetic.rs b/clippy_lints/src/arithmetic.rs index 1cca897e739..7653ba43459 100644 --- a/clippy_lints/src/arithmetic.rs +++ b/clippy_lints/src/arithmetic.rs @@ -1,8 +1,9 @@ use crate::consts::constant_simple; use crate::utils::span_lint; use rustc::hir; +use rustc::impl_lint_pass; use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass}; -use rustc::{declare_tool_lint, impl_lint_pass}; +use rustc_session::declare_tool_lint; use syntax::source_map::Span; declare_clippy_lint! { @@ -92,14 +93,14 @@ fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr) { }, hir::ExprKind::Unary(hir::UnOp::UnNeg, arg) => { let ty = cx.tables.expr_ty(arg); - if ty.is_integral() { - if constant_simple(cx, cx.tables, expr).is_none() { + if constant_simple(cx, cx.tables, expr).is_none() { + if ty.is_integral() { span_lint(cx, INTEGER_ARITHMETIC, expr.span, "integer arithmetic detected"); self.expr_span = Some(expr.span); + } else if ty.is_floating_point() { + span_lint(cx, FLOAT_ARITHMETIC, expr.span, "floating-point arithmetic detected"); + self.expr_span = Some(expr.span); } - } else if ty.is_floating_point() { - span_lint(cx, FLOAT_ARITHMETIC, expr.span, "floating-point arithmetic detected"); - self.expr_span = Some(expr.span); } }, _ => (), @@ -112,7 +113,7 @@ fn check_expr_post(&mut self, _: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr) } } - fn check_body(&mut self, cx: &LateContext<'_, '_>, body: &hir::Body) { + fn check_body(&mut self, cx: &LateContext<'_, '_>, body: &hir::Body<'_>) { let body_owner = cx.tcx.hir().body_owner(body.id()); match cx.tcx.hir().body_owner_kind(body_owner) { @@ -130,7 +131,7 @@ fn check_body(&mut self, cx: &LateContext<'_, '_>, body: &hir::Body) { } } - fn check_body_post(&mut self, cx: &LateContext<'_, '_>, body: &hir::Body) { + fn check_body_post(&mut self, cx: &LateContext<'_, '_>, body: &hir::Body<'_>) { let body_owner = cx.tcx.hir().body_owner(body.id()); let body_span = cx.tcx.hir().span(body_owner);