X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=CONTRIBUTING.md;h=8734242c6c016eac7e806205edf449b71951bf59;hb=647b30884d8ec6dbdc4f07d80c5c39eacfb0c061;hp=53caba6615c2403840f9d5fd55949f3edba395ac;hpb=851470639d001c446103e82b00e4730b929ae358;p=rust.git diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 53caba6615c..8734242c6c0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -28,10 +28,10 @@ how this syntax structure is encoded in the AST, it is recommended to run `rustc example of the structure and compare with the [nodes in the AST docs](http://manishearth.github.io/rust-internals-docs/syntax/ast/). Usually the lint will end up to be a nested series of matches and ifs, -[like so](https://github.com/Manishearth/rust-clippy/blob/de5ccdfab68a5e37689f3c950ed1532ba9d652a0/src/misc.rs#L34) +[like so](https://github.com/Manishearth/rust-clippy/blob/de5ccdfab68a5e37689f3c950ed1532ba9d652a0/src/misc.rs#L34). T-middle issues can be more involved and require verifying types. The -[`middle::ty`](http://manishearth.github.io/rust-internals-docs/rustc/middle/ty) module contains a +[`ty`](http://manishearth.github.io/rust-internals-docs/rustc/ty) module contains a lot of methods that are useful, though one of the most useful would be `expr_ty` (gives the type of an AST expression). `match_def_path()` in Clippy's `utils` module can also be useful. @@ -41,14 +41,17 @@ contains some questionable code itself! Also before making a pull request, pleas travis build actually checks for this. Also please document your lint with a doc comment akin to the following: -``` -/// **What it does:** Describe what the lint matches. +```rust +/// **What it does:** Checks for ... (describe what the lint matches). /// -/// **Why is this bad?** Write the reason for linting the code. +/// **Why is this bad?** Supply the reason for linting the code. /// -/// **Known problems:** Hopefully none. +/// **Known problems:** None. (Or describe where it could go wrong.) /// -/// **Example:** Insert a short example if you have one +/// **Example:** +/// ```rust +/// Insert a short example if you have one. +/// ``` ``` Our `util/update_wiki.py` script can then add your lint docs to the wiki.