X-Git-Url: https://git.lizzy.rs/?a=blobdiff_plain;f=CONTRIBUTING.md;h=37a217d2a04523fb53a3cc1c1ed6031ca2ff787b;hb=c8eefdffe9480bbd84554eab3343f71f04af8f9a;hp=c3a9a68963eb78136179bb5478c732b7d869e91a;hpb=215b09194f2ca1c19b1b5b4f5de4044671d6ad9a;p=rust.git diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c3a9a68963e..37a217d2a04 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -128,6 +128,14 @@ the master branch to your feature branch. Also, please make sure that fixup commits are squashed into other related commits with meaningful commit messages. +GitHub allows [closing issues using keywords][closing-keywords]. This feature +should be used to keep the issue tracker tidy. However, it is generally preferred +to put the "closes #123" text in the PR description rather than the issue commit; +particularly during rebasing, citing the issue number in the commit can "spam" +the issue in question. + +[closing-keywords]: https://help.github.com/en/articles/closing-issues-using-keywords + Please make sure your pull request is in compliance with Rust's style guidelines by running