error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:9:5
+ --> $DIR/while_loop.rs:15:5
|
-9 | / loop {
-10 | | if let Some(_x) = y {
-11 | | let _v = 1;
-12 | | } else {
-13 | | break
-14 | | }
-15 | | }
+LL | / loop {
+LL | | if let Some(_x) = y {
+LL | | let _v = 1;
+LL | | } else {
+LL | | break;
+LL | | }
+LL | | }
| |_____^ help: try: `while let Some(_x) = y { .. }`
|
- = note: `-D while-let-loop` implied by `-D warnings`
+ = note: `-D clippy::while-let-loop` implied by `-D warnings`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:22:5
+ --> $DIR/while_loop.rs:29:5
|
-22 | / loop {
-23 | | match y {
-24 | | Some(_x) => true,
-25 | | None => break
-26 | | };
-27 | | }
+LL | / loop {
+LL | | match y {
+LL | | Some(_x) => true,
+LL | | None => break,
+LL | | };
+LL | | }
| |_____^ help: try: `while let Some(_x) = y { .. }`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:28:5
+ --> $DIR/while_loop.rs:35:5
|
-28 | / loop {
-29 | | let x = match y {
-30 | | Some(x) => x,
-31 | | None => break
+LL | / loop {
+LL | | let x = match y {
+LL | | Some(x) => x,
+LL | | None => break,
... |
-34 | | let _str = "foo";
-35 | | }
+LL | | let _str = "foo";
+LL | | }
| |_____^ help: try: `while let Some(x) = y { .. }`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:36:5
+ --> $DIR/while_loop.rs:43:5
|
-36 | / loop {
-37 | | let x = match y {
-38 | | Some(x) => x,
-39 | | None => break,
+LL | / loop {
+LL | | let x = match y {
+LL | | Some(x) => x,
+LL | | None => break,
... |
-42 | | { let _b = "foobar"; }
-43 | | }
+LL | | }
+LL | | }
| |_____^ help: try: `while let Some(x) = y { .. }`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:58:5
+ --> $DIR/while_loop.rs:71:5
|
-58 | / loop {
-59 | | let (e, l) = match "".split_whitespace().next() {
-60 | | Some(word) => (word.is_empty(), word.len()),
-61 | | None => break
+LL | / loop {
+LL | | let (e, l) = match "".split_whitespace().next() {
+LL | | Some(word) => (word.is_empty(), word.len()),
+LL | | None => break,
... |
-64 | | let _ = (e, l);
-65 | | }
+LL | | let _ = (e, l);
+LL | | }
| |_____^ help: try: `while let Some(word) = "".split_whitespace().next() { .. }`
error: this loop could be written as a `for` loop
- --> $DIR/while_loop.rs:68:5
+ --> $DIR/while_loop.rs:81:33
|
-68 | / while let Option::Some(x) = iter.next() {
-69 | | println!("{}", x);
-70 | | }
- | |_____^ help: try: `for x in iter { .. }`
+LL | while let Option::Some(x) = iter.next() {
+ | ^^^^^^^^^^^ help: try: `for x in iter { .. }`
|
- = note: `-D while-let-on-iterator` implied by `-D warnings`
+ = note: `-D clippy::while-let-on-iterator` implied by `-D warnings`
error: this loop could be written as a `for` loop
- --> $DIR/while_loop.rs:73:5
+ --> $DIR/while_loop.rs:86:25
|
-73 | / while let Some(x) = iter.next() {
-74 | | println!("{}", x);
-75 | | }
- | |_____^ help: try: `for x in iter { .. }`
+LL | while let Some(x) = iter.next() {
+ | ^^^^^^^^^^^ help: try: `for x in iter { .. }`
error: this loop could be written as a `for` loop
- --> $DIR/while_loop.rs:78:5
+ --> $DIR/while_loop.rs:91:25
|
-78 | while let Some(_) = iter.next() {}
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in iter { .. }`
+LL | while let Some(_) = iter.next() {}
+ | ^^^^^^^^^^^ help: try: `for _ in iter { .. }`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:118:5
- |
-118 | / loop {
-119 | | let _ = match iter.next() {
-120 | | Some(ele) => ele,
-121 | | None => break
-122 | | };
-123 | | loop {}
-124 | | }
- | |_____^ help: try: `while let Some(ele) = iter.next() { .. }`
+ --> $DIR/while_loop.rs:134:5
+ |
+LL | / loop {
+LL | | let _ = match iter.next() {
+LL | | Some(ele) => ele,
+LL | | None => break,
+LL | | };
+LL | | loop {}
+LL | | }
+ | |_____^ help: try: `while let Some(ele) = iter.next() { .. }`
error: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body.
- --> $DIR/while_loop.rs:123:9
- |
-123 | loop {}
- | ^^^^^^^
- |
- = note: `-D empty-loop` implied by `-D warnings`
+ --> $DIR/while_loop.rs:139:9
+ |
+LL | loop {}
+ | ^^^^^^^
+ |
+ = note: `-D clippy::empty-loop` implied by `-D warnings`
error: this loop could be written as a `for` loop
- --> $DIR/while_loop.rs:183:9
- |
-183 | / while let Some(v) = y.next() { // use a for loop here
-184 | | }
- | |_________^ help: try: `for v in y { .. }`
+ --> $DIR/while_loop.rs:197:29
+ |
+LL | while let Some(v) = y.next() {
+ | ^^^^^^^^ help: try: `for v in y { .. }`
+
+error: this loop could be written as a `for` loop
+ --> $DIR/while_loop.rs:225:26
+ |
+LL | while let Some(..) = values.iter().next() {
+ | ^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in values.iter() { .. }`
-error: aborting due to 11 previous errors
+error: aborting due to 12 previous errors
projects / rust.git / blobdiff