error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:9:5
- |
-9 | / loop {
-10 | |
-11 | |
-12 | |
-... |
-17 | | }
-18 | | }
- | |_____^
- |
-note: lint level defined here
- --> $DIR/while_loop.rs:4:9
- |
-4 | #![deny(while_let_loop, empty_loop, while_let_on_iterator)]
- | ^^^^^^^^^^^^^^
-help: try
- | while let Some(_x) = y { .. }
+ --> $DIR/while_loop.rs:15:5
+ |
+LL | / loop {
+LL | | if let Some(_x) = y {
+LL | | let _v = 1;
+LL | | } else {
+LL | | break;
+LL | | }
+LL | | }
+ | |_____^ help: try: `while let Some(_x) = y { .. }`
+ |
+ = note: `-D clippy::while-let-loop` implied by `-D warnings`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:25:5
- |
-25 | / loop {
-26 | |
-27 | |
-28 | |
-... |
-32 | | };
-33 | | }
- | |_____^
- |
-help: try
- | while let Some(_x) = y { .. }
+ --> $DIR/while_loop.rs:29:5
+ |
+LL | / loop {
+LL | | match y {
+LL | | Some(_x) => true,
+LL | | None => break,
+LL | | };
+LL | | }
+ | |_____^ help: try: `while let Some(_x) = y { .. }`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:34:5
+ --> $DIR/while_loop.rs:35:5
|
-34 | / loop {
-35 | |
-36 | |
-37 | |
+LL | / loop {
+LL | | let x = match y {
+LL | | Some(x) => x,
+LL | | None => break,
... |
-43 | | let _str = "foo";
-44 | | }
- | |_____^
- |
-help: try
- | while let Some(x) = y { .. }
+LL | | let _str = "foo";
+LL | | }
+ | |_____^ help: try: `while let Some(x) = y { .. }`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:45:5
+ --> $DIR/while_loop.rs:43:5
|
-45 | / loop {
-46 | |
-47 | |
-48 | |
+LL | / loop {
+LL | | let x = match y {
+LL | | Some(x) => x,
+LL | | None => break,
... |
-54 | | { let _b = "foobar"; }
-55 | | }
- | |_____^
- |
-help: try
- | while let Some(x) = y { .. }
+LL | | }
+LL | | }
+ | |_____^ help: try: `while let Some(x) = y { .. }`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:70:5
+ --> $DIR/while_loop.rs:71:5
|
-70 | / loop {
-71 | |
-72 | |
-73 | |
+LL | / loop {
+LL | | let (e, l) = match "".split_whitespace().next() {
+LL | | Some(word) => (word.is_empty(), word.len()),
+LL | | None => break,
... |
-79 | | let _ = (e, l);
-80 | | }
- | |_____^
- |
-help: try
- | while let Some(word) = "".split_whitespace().next() { .. }
+LL | | let _ = (e, l);
+LL | | }
+ | |_____^ help: try: `while let Some(word) = "".split_whitespace().next() { .. }`
error: this loop could be written as a `for` loop
- --> $DIR/while_loop.rs:83:5
- |
-83 | / while let Option::Some(x) = iter.next() {
-84 | |
-85 | |
-86 | |
-87 | | println!("{}", x);
-88 | | }
- | |_____^
+ --> $DIR/while_loop.rs:81:33
|
-note: lint level defined here
- --> $DIR/while_loop.rs:4:37
+LL | while let Option::Some(x) = iter.next() {
+ | ^^^^^^^^^^^ help: try: `for x in iter { .. }`
|
-4 | #![deny(while_let_loop, empty_loop, while_let_on_iterator)]
- | ^^^^^^^^^^^^^^^^^^^^^
-help: try
- | for x in iter { .. }
+ = note: `-D clippy::while-let-on-iterator` implied by `-D warnings`
error: this loop could be written as a `for` loop
- --> $DIR/while_loop.rs:91:5
+ --> $DIR/while_loop.rs:86:25
|
-91 | / while let Some(x) = iter.next() {
-92 | |
-93 | |
-94 | |
-95 | | println!("{}", x);
-96 | | }
- | |_____^
- |
-help: try
- | for x in iter { .. }
+LL | while let Some(x) = iter.next() {
+ | ^^^^^^^^^^^ help: try: `for x in iter { .. }`
error: this loop could be written as a `for` loop
- --> $DIR/while_loop.rs:99:5
- |
-99 | while let Some(_) = iter.next() {}
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+ --> $DIR/while_loop.rs:91:25
|
-help: try
- | for _ in iter { .. }
+LL | while let Some(_) = iter.next() {}
+ | ^^^^^^^^^^^ help: try: `for _ in iter { .. }`
error: this loop could be written as a `while let` loop
- --> $DIR/while_loop.rs:142:5
- |
-142 | / loop {
-143 | |
-144 | |
-145 | |
-... |
-150 | | loop {}
-151 | | }
- | |_____^
- |
-help: try
- | while let Some(ele) = iter.next() { .. }
+ --> $DIR/while_loop.rs:134:5
+ |
+LL | / loop {
+LL | | let _ = match iter.next() {
+LL | | Some(ele) => ele,
+LL | | None => break,
+LL | | };
+LL | | loop {}
+LL | | }
+ | |_____^ help: try: `while let Some(ele) = iter.next() { .. }`
error: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body.
- --> $DIR/while_loop.rs:150:9
- |
-150 | loop {}
- | ^^^^^^^
- |
-note: lint level defined here
- --> $DIR/while_loop.rs:4:25
- |
-4 | #![deny(while_let_loop, empty_loop, while_let_on_iterator)]
- | ^^^^^^^^^^
+ --> $DIR/while_loop.rs:139:9
+ |
+LL | loop {}
+ | ^^^^^^^
+ |
+ = note: `-D clippy::empty-loop` implied by `-D warnings`
+
+error: this loop could be written as a `for` loop
+ --> $DIR/while_loop.rs:197:29
+ |
+LL | while let Some(v) = y.next() {
+ | ^^^^^^^^ help: try: `for v in y { .. }`
+
+error: this loop could be written as a `for` loop
+ --> $DIR/while_loop.rs:225:26
+ |
+LL | while let Some(..) = values.iter().next() {
+ | ^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in values.iter() { .. }`
-error: aborting due to 10 previous errors
+error: aborting due to 12 previous errors
projects / rust.git / blobdiff