#![warn(clippy::all)]
#![warn(clippy::redundant_pattern_matching)]
-#![allow(clippy::unit_arg, clippy::let_unit_value, unused_must_use)]
+#![allow(clippy::unit_arg, unused_must_use, clippy::needless_bool, deprecated)]
fn main() {
if let Ok(_) = Ok::<i32, i32>(42) {}
if let Some(_) = Some(42) {}
+ if let Some(_) = Some(42) {
+ foo();
+ } else {
+ bar();
+ }
+
+ while let Some(_) = Some(42) {}
+
+ while let None = Some(42) {}
+
+ while let None = None::<()> {}
+
+ while let Ok(_) = Ok::<i32, i32>(10) {}
+
+ while let Err(_) = Ok::<i32, i32>(10) {}
+
+ let mut v = vec![1, 2, 3];
+ while let Some(_) = v.pop() {
+ foo();
+ }
+
if Ok::<i32, i32>(42).is_ok() {}
if Err::<i32, i32>(42).is_err() {}
let _ = if let Ok(_) = Ok::<usize, ()>(4) { true } else { false };
- let _ = does_something();
- let _ = returns_unit();
-
let opt = Some(false);
let x = if let Some(_) = opt { true } else { false };
takes_bool(x);
-}
-fn takes_bool(_: bool) {}
+ issue5504();
-fn does_something() -> bool {
- if let Ok(_) = Ok::<i32, i32>(4) {
- true
+ let _ = if let Some(_) = gen_opt() {
+ 1
+ } else if let None = gen_opt() {
+ 2
+ } else if let Ok(_) = gen_res() {
+ 3
+ } else if let Err(_) = gen_res() {
+ 4
} else {
- false
- }
+ 5
+ };
}
-fn returns_unit() {
- if let Ok(_) = Ok::<i32, i32>(4) {
- true
- } else {
- false
+fn gen_opt() -> Option<()> {
+ None
+}
+
+fn gen_res() -> Result<(), ()> {
+ Ok(())
+}
+
+fn takes_bool(_: bool) {}
+
+fn foo() {}
+
+fn bar() {}
+
+macro_rules! m {
+ () => {
+ Some(42u32)
};
}
+
+fn issue5504() {
+ fn result_opt() -> Result<Option<i32>, i32> {
+ Err(42)
+ }
+
+ fn try_result_opt() -> Result<i32, i32> {
+ while let Some(_) = r#try!(result_opt()) {}
+ if let Some(_) = r#try!(result_opt()) {}
+ Ok(42)
+ }
+
+ try_result_opt();
+
+ if let Some(_) = m!() {}
+ while let Some(_) = m!() {}
+}