Fix `unnecessary_cast` suggestion when taking a reference

[rust.git] / tests / ui / needless_range_loop.rs

diff --git a/tests/ui/needless_range_loop.rs b/tests/ui/needless_range_loop.rs
index b960e3990c11c05647ef1e46c260f807a034c64e..921801138a9b6f1179f1901f58258c517af12e59 100644 (file)
--- a/tests/ui/needless_range_loop.rs
+++ b/tests/ui/needless_range_loop.rs
@@ -1,27 +1,96 @@
-fn calc_idx(i: usize) -> usize {
-    (i + i + 20) % 4
-}
+#![warn(clippy::needless_range_loop)]
+#![allow(clippy::uninlined_format_args)]
+
+static STATIC: [usize; 4] = [0, 1, 8, 16];
+const CONST: [usize; 4] = [0, 1, 8, 16];
+const MAX_LEN: usize = 42;
 
 fn main() {
-    let ns = [2, 3, 5, 7];
+    let mut vec = vec![1, 2, 3, 4];
+    let vec2 = vec![1, 2, 3, 4];
+    for i in 0..vec.len() {
+        println!("{}", vec[i]);
+    }
+
+    for i in 0..vec.len() {
+        let i = 42; // make a different `i`
+        println!("{}", vec[i]); // ok, not the `i` of the for-loop
+    }
+
+    for i in 0..vec.len() {
+        let _ = vec[i];
+    }
 
-    for i in 3..10 {
-        println!("{}", ns[i]);
+    // ICE #746
+    for j in 0..4 {
+        println!("{:?}", STATIC[j]);
     }
 
-    for i in 3..10 {
-        println!("{}", ns[i % 4]);
+    for j in 0..4 {
+        println!("{:?}", CONST[j]);
     }
 
-    for i in 3..10 {
-        println!("{}", ns[i % ns.len()]);
+    for i in 0..vec.len() {
+        println!("{} {}", vec[i], i);
+    }
+    for i in 0..vec.len() {
+        // not an error, indexing more than one variable
+        println!("{} {}", vec[i], vec2[i]);
     }
 
-    for i in 3..10 {
-        println!("{}", ns[calc_idx(i)]);
+    for i in 0..vec.len() {
+        println!("{}", vec2[i]);
     }
 
-    for i in 3..10 {
-        println!("{}", ns[calc_idx(i) % 4]);
+    for i in 5..vec.len() {
+        println!("{}", vec[i]);
+    }
+
+    for i in 0..MAX_LEN {
+        println!("{}", vec[i]);
+    }
+
+    for i in 0..=MAX_LEN {
+        println!("{}", vec[i]);
+    }
+
+    for i in 5..10 {
+        println!("{}", vec[i]);
+    }
+
+    for i in 5..=10 {
+        println!("{}", vec[i]);
+    }
+
+    for i in 5..vec.len() {
+        println!("{} {}", vec[i], i);
+    }
+
+    for i in 5..10 {
+        println!("{} {}", vec[i], i);
+    }
+
+    // #2542
+    for i in 0..vec.len() {
+        vec[i] = Some(1).unwrap_or_else(|| panic!("error on {}", i));
+    }
+
+    // #3788
+    let test = Test {
+        inner: vec![1, 2, 3, 4],
+    };
+    for i in 0..2 {
+        println!("{}", test[i]);
+    }
+}
+
+struct Test {
+    inner: Vec<usize>,
+}
+
+impl std::ops::Index<usize> for Test {
+    type Output = usize;
+    fn index(&self, index: usize) -> &Self::Output {
+        &self.inner[index]
     }
 }