-// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
-// file at the top-level directory of this distribution.
-//
-// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
-// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
-// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
-// option. This file may not be copied, modified, or distributed
-// except according to those terms.
-
-
-fn calc_idx(i: usize) -> usize {
- (i + i + 20) % 4
-}
+#![warn(clippy::needless_range_loop)]
-fn main() {
- let ns = vec![2, 3, 5, 7];
+static STATIC: [usize; 4] = [0, 1, 8, 16];
+const CONST: [usize; 4] = [0, 1, 8, 16];
+const MAX_LEN: usize = 42;
- for i in 3..10 {
- println!("{}", ns[i]);
+fn main() {
+ let mut vec = vec![1, 2, 3, 4];
+ let vec2 = vec![1, 2, 3, 4];
+ for i in 0..vec.len() {
+ println!("{}", vec[i]);
}
- for i in 3..10 {
- println!("{}", ns[i % 4]);
+ for i in 0..vec.len() {
+ let i = 42; // make a different `i`
+ println!("{}", vec[i]); // ok, not the `i` of the for-loop
}
- for i in 3..10 {
- println!("{}", ns[i % ns.len()]);
+ for i in 0..vec.len() {
+ let _ = vec[i];
}
- for i in 3..10 {
- println!("{}", ns[calc_idx(i)]);
+ // ICE #746
+ for j in 0..4 {
+ println!("{:?}", STATIC[j]);
}
- for i in 3..10 {
- println!("{}", ns[calc_idx(i) % 4]);
+ for j in 0..4 {
+ println!("{:?}", CONST[j]);
}
- let mut ms = vec![1, 2, 3, 4, 5, 6];
- for i in 0..ms.len() {
- ms[i] *= 2;
+ for i in 0..vec.len() {
+ println!("{} {}", vec[i], i);
+ }
+ for i in 0..vec.len() {
+ // not an error, indexing more than one variable
+ println!("{} {}", vec[i], vec2[i]);
}
- assert_eq!(ms, vec![2, 4, 6, 8, 10, 12]);
- let mut ms = vec![1, 2, 3, 4, 5, 6];
- for i in 0..ms.len() {
- let x = &mut ms[i];
- *x *= 2;
+ for i in 0..vec.len() {
+ println!("{}", vec2[i]);
}
- assert_eq!(ms, vec![2, 4, 6, 8, 10, 12]);
- let g = vec![1, 2, 3, 4, 5, 6];
- let glen = g.len();
- for i in 0..glen {
- let x: u32 = g[i+1..].iter().sum();
- println!("{}", g[i] + x);
+ for i in 5..vec.len() {
+ println!("{}", vec[i]);
}
- assert_eq!(g, vec![20, 18, 15, 11, 6, 0]);
- let mut g = vec![1, 2, 3, 4, 5, 6];
- let glen = g.len();
- for i in 0..glen {
- g[i] = g[i+1..].iter().sum();
+ for i in 0..MAX_LEN {
+ println!("{}", vec[i]);
}
- assert_eq!(g, vec![20, 18, 15, 11, 6, 0]);
- let x = 5;
- let mut vec = vec![0; 9];
+ for i in 0..=MAX_LEN {
+ println!("{}", vec[i]);
+ }
- for i in x..x + 4 {
- vec[i] += 1;
+ for i in 5..10 {
+ println!("{}", vec[i]);
}
- let x = 5;
- let mut vec = vec![0; 10];
+ for i in 5..=10 {
+ println!("{}", vec[i]);
+ }
- for i in x..=x + 4 {
- vec[i] += 1;
+ for i in 5..vec.len() {
+ println!("{} {}", vec[i], i);
}
- let arr = [1,2,3];
+ for i in 5..10 {
+ println!("{} {}", vec[i], i);
+ }
- for i in 0..3 {
- println!("{}", arr[i]);
+ // #2542
+ for i in 0..vec.len() {
+ vec[i] = Some(1).unwrap_or_else(|| panic!("error on {}", i));
}
+ // #3788
+ let test = Test {
+ inner: vec![1, 2, 3, 4],
+ };
for i in 0..2 {
- println!("{}", arr[i]);
+ println!("{}", test[i]);
}
+}
+
+struct Test {
+ inner: Vec<usize>,
+}
- for i in 1..3 {
- println!("{}", arr[i]);
+impl std::ops::Index<usize> for Test {
+ type Output = usize;
+ fn index(&self, index: usize) -> &Self::Output {
+ &self.inner[index]
}
}