error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
- --> $DIR/methods.rs:37:5
+ --> $DIR/methods.rs:39:5
|
-LL | pub fn add(self, other: T) -> T { self }
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+LL | / pub fn add(self, other: T) -> T {
+LL | | self
+LL | | }
+ | |_____^
|
= note: `-D clippy::should-implement-trait` implied by `-D warnings`
-error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
- --> $DIR/methods.rs:48:17
- |
-LL | fn into_u16(&self) -> u16 { 0 }
- | ^^^^^
- |
- = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
-
-error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
- --> $DIR/methods.rs:50:21
- |
-LL | fn to_something(self) -> u32 { 0 }
- | ^^^^
-
-error: methods called `new` usually take no self; consider choosing a less ambiguous name
- --> $DIR/methods.rs:52:12
- |
-LL | fn new(self) -> Self { unimplemented!(); }
- | ^^^^
-
-error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
- --> $DIR/methods.rs:120:13
- |
-LL | let _ = opt.map(|x| x + 1)
- | _____________^
-LL | |
-LL | | .unwrap_or(0); // should lint even though this call is on a separate line
- | |____________________________^
+error: methods called `new` usually return `Self`
+ --> $DIR/methods.rs:169:5
|
- = note: `-D clippy::option-map-unwrap-or` implied by `-D warnings`
- = note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
-
-error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
- --> $DIR/methods.rs:124:13
- |
-LL | let _ = opt.map(|x| {
- | _____________^
-LL | | x + 1
-LL | | }
-LL | | ).unwrap_or(0);
- | |____________________________^
-
-error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
- --> $DIR/methods.rs:128:13
- |
-LL | let _ = opt.map(|x| x + 1)
- | _____________^
-LL | | .unwrap_or({
-LL | | 0
-LL | | });
- | |__________________^
-
-error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
- --> $DIR/methods.rs:133:13
- |
-LL | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- |
- = note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
-
-error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
- --> $DIR/methods.rs:135:13
- |
-LL | let _ = opt.map(|x| {
- | _____________^
-LL | | Some(x + 1)
+LL | / fn new() -> i32 {
+LL | | 0
LL | | }
-LL | | ).unwrap_or(None);
- | |_____________________^
-
-error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
- --> $DIR/methods.rs:139:13
- |
-LL | let _ = opt
- | _____________^
-LL | | .map(|x| Some(x + 1))
-LL | | .unwrap_or(None);
- | |________________________^
- |
- = note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
-
-error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
- --> $DIR/methods.rs:147:13
+ | |_____^
|
-LL | let _ = opt.map(|x| x + 1)
- | _____________^
-LL | |
-LL | | .unwrap_or_else(|| 0); // should lint even though this call is on a separate line
- | |____________________________________^
- |
- = note: `-D clippy::option-map-unwrap-or-else` implied by `-D warnings`
- = note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
-
-error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
- --> $DIR/methods.rs:151:13
- |
-LL | let _ = opt.map(|x| {
- | _____________^
-LL | | x + 1
-LL | | }
-LL | | ).unwrap_or_else(|| 0);
- | |____________________________________^
-
-error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
- --> $DIR/methods.rs:155:13
- |
-LL | let _ = opt.map(|x| x + 1)
- | _____________^
-LL | | .unwrap_or_else(||
-LL | | 0
-LL | | );
- | |_________________^
-
-error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
- --> $DIR/methods.rs:164:13
- |
-LL | let _ = opt.map_or(None, |x| Some(x + 1));
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `opt.and_then(|x| Some(x + 1))`
- |
- = note: `-D clippy::option-map-or-none` implied by `-D warnings`
-
-error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
- --> $DIR/methods.rs:166:13
- |
-LL | let _ = opt.map_or(None, |x| {
- | _____________^
-LL | | Some(x + 1)
-LL | | }
-LL | | );
- | |_________________^
-help: try using and_then instead
- |
-LL | let _ = opt.and_then(|x| {
-LL | Some(x + 1)
-LL | });
- |
-
-error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
- --> $DIR/methods.rs:179:13
- |
-LL | let _ = res.map(|x| x + 1)
- | _____________^
-LL | |
-LL | | .unwrap_or_else(|e| 0); // should lint even though this call is on a separate line
- | |_____________________________________^
- |
- = note: `-D clippy::result-map-unwrap-or-else` implied by `-D warnings`
- = note: replace `map(|x| x + 1).unwrap_or_else(|e| 0)` with `ok().map_or_else(|e| 0, |x| x + 1)`
-
-error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
- --> $DIR/methods.rs:183:13
- |
-LL | let _ = res.map(|x| {
- | _____________^
-LL | | x + 1
-LL | | }
-LL | | ).unwrap_or_else(|e| 0);
- | |_____________________________________^
-
-error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
- --> $DIR/methods.rs:187:13
- |
-LL | let _ = res.map(|x| x + 1)
- | _____________^
-LL | | .unwrap_or_else(|e|
-LL | | 0
-LL | | );
- | |_________________^
+ = note: `-D clippy::new-ret-no-self` implied by `-D warnings`
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
- --> $DIR/methods.rs:250:13
+ --> $DIR/methods.rs:188:13
|
LL | let _ = v.iter().filter(|&x| *x < 0).next();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
- --> $DIR/methods.rs:253:13
+ --> $DIR/methods.rs:191:13
|
LL | let _ = v.iter().filter(|&x| {
| _____________^
| |___________________________^
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:268:13
+ --> $DIR/methods.rs:208:22
|
LL | let _ = v.iter().find(|&x| *x < 0).is_some();
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|x| *x < 0)`
|
= note: `-D clippy::search-is-some` implied by `-D warnings`
- = note: replace `find(|&x| *x < 0).is_some()` with `any(|&x| *x < 0)`
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:271:13
+ --> $DIR/methods.rs:209:20
+ |
+LL | let _ = (0..1).find(|x| **y == *x).is_some(); // one dereference less
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|x| **y == x)`
+
+error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
+ --> $DIR/methods.rs:210:20
+ |
+LL | let _ = (0..1).find(|x| *x == 0).is_some();
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|x| x == 0)`
+
+error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
+ --> $DIR/methods.rs:211:22
+ |
+LL | let _ = v.iter().find(|x| **x == 0).is_some();
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|x| *x == 0)`
+
+error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
+ --> $DIR/methods.rs:214:13
|
LL | let _ = v.iter().find(|&x| {
| _____________^
| |______________________________^
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:277:13
+ --> $DIR/methods.rs:220:22
|
LL | let _ = v.iter().position(|&x| x < 0).is_some();
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- |
- = note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:280:13
+ --> $DIR/methods.rs:223:13
|
LL | let _ = v.iter().position(|&x| {
| _____________^
| |______________________________^
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:286:13
+ --> $DIR/methods.rs:229:22
|
LL | let _ = v.iter().rposition(|&x| x < 0).is_some();
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- |
- = note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
+ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
- --> $DIR/methods.rs:289:13
+ --> $DIR/methods.rs:232:13
|
LL | let _ = v.iter().rposition(|&x| {
| _____________^
LL | | ).is_some();
| |______________________________^
-error: use of `unwrap_or` followed by a function call
- --> $DIR/methods.rs:324:22
- |
-LL | with_constructor.unwrap_or(make());
- | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(make)`
- |
- = note: `-D clippy::or-fun-call` implied by `-D warnings`
-
-error: use of `unwrap_or` followed by a call to `new`
- --> $DIR/methods.rs:327:5
- |
-LL | with_new.unwrap_or(Vec::new());
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
-
-error: use of `unwrap_or` followed by a function call
- --> $DIR/methods.rs:330:21
- |
-LL | with_const_args.unwrap_or(Vec::with_capacity(12));
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::with_capacity(12))`
-
-error: use of `unwrap_or` followed by a function call
- --> $DIR/methods.rs:333:14
- |
-LL | with_err.unwrap_or(make());
- | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| make())`
-
-error: use of `unwrap_or` followed by a function call
- --> $DIR/methods.rs:336:19
- |
-LL | with_err_args.unwrap_or(Vec::with_capacity(12));
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Vec::with_capacity(12))`
-
-error: use of `unwrap_or` followed by a call to `default`
- --> $DIR/methods.rs:339:5
- |
-LL | with_default_trait.unwrap_or(Default::default());
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
-
-error: use of `unwrap_or` followed by a call to `default`
- --> $DIR/methods.rs:342:5
- |
-LL | with_default_type.unwrap_or(u64::default());
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_type.unwrap_or_default()`
-
-error: use of `unwrap_or` followed by a function call
- --> $DIR/methods.rs:345:14
- |
-LL | with_vec.unwrap_or(vec![]);
- | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
-
-error: use of `unwrap_or` followed by a function call
- --> $DIR/methods.rs:350:21
- |
-LL | without_default.unwrap_or(Foo::new());
- | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Foo::new)`
-
-error: use of `or_insert` followed by a function call
- --> $DIR/methods.rs:353:19
- |
-LL | map.entry(42).or_insert(String::new());
- | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(String::new)`
-
-error: use of `or_insert` followed by a function call
- --> $DIR/methods.rs:356:21
- |
-LL | btree.entry(42).or_insert(String::new());
- | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(String::new)`
-
-error: use of `unwrap_or` followed by a function call
- --> $DIR/methods.rs:359:21
- |
-LL | let _ = stringy.unwrap_or("".to_owned());
- | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
-
-error: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
- --> $DIR/methods.rs:370:23
- |
-LL | let bad_vec = some_vec.iter().nth(3);
- | ^^^^^^^^^^^^^^^^^^^^^^
- |
- = note: `-D clippy::iter-nth` implied by `-D warnings`
-
-error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
- --> $DIR/methods.rs:371:26
- |
-LL | let bad_slice = &some_vec[..].iter().nth(3);
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
- --> $DIR/methods.rs:372:31
- |
-LL | let bad_boxed_slice = boxed_slice.iter().nth(3);
- | ^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
- --> $DIR/methods.rs:373:29
- |
-LL | let bad_vec_deque = some_vec_deque.iter().nth(3);
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
- --> $DIR/methods.rs:378:23
- |
-LL | let bad_vec = some_vec.iter_mut().nth(3);
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
- --> $DIR/methods.rs:381:26
- |
-LL | let bad_slice = &some_vec[..].iter_mut().nth(3);
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
- --> $DIR/methods.rs:384:29
- |
-LL | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
- | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
- --> $DIR/methods.rs:396:13
- |
-LL | let _ = opt.unwrap();
- | ^^^^^^^^^^^^
- |
- = note: `-D clippy::option-unwrap-used` implied by `-D warnings`
-
-error: aborting due to 46 previous errors
+error: aborting due to 13 previous errors
projects / rust.git / blobdiff