-
-#![feature(const_fn)]
-
-#![warn(clippy, clippy_pedantic, option_unwrap_used)]
-#![allow(blacklisted_name, unused, print_stdout, non_ascii_literal, new_without_default,
- new_without_default_derive, missing_docs_in_private_items, needless_pass_by_value)]
+// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+#![warn(clippy::all, clippy::pedantic, clippy::option_unwrap_used)]
+#![allow(
+ clippy::blacklisted_name,
+ unused,
+ clippy::print_stdout,
+ clippy::non_ascii_literal,
+ clippy::new_without_default,
+ clippy::missing_docs_in_private_items,
+ clippy::needless_pass_by_value,
+ clippy::default_trait_access,
+ clippy::use_self,
+ clippy::new_ret_no_self,
+ clippy::useless_format
+)]
use std::collections::BTreeMap;
use std::collections::HashMap;
fn to_something(self) -> u32 { 0 }
- fn new(self) {}
+ fn new(self) -> Self { unimplemented!(); }
}
struct Lt<'a> {
impl<'a> Lt<'a> {
// The lifetime is different, but that’s irrelevant, see #734
- #[allow(needless_lifetimes)]
+ #[allow(clippy::needless_lifetimes)]
pub fn new<'b>(s: &'b str) -> Lt<'b> { unimplemented!() }
}
A(i32),
}
- const fn make_const(i: i32) -> i32 { i }
+
fn make<T>() -> T { unimplemented!(); }
let with_enum = Some(Enum::A(1));
with_enum.unwrap_or(Enum::A(5));
- let with_const_fn = Some(1);
- with_const_fn.unwrap_or(make_const(5));
+ let with_const_fn = Some(::std::time::Duration::from_secs(1));
+ with_const_fn.unwrap_or(::std::time::Duration::from_secs(5));
let with_constructor = Some(vec![1]);
with_constructor.unwrap_or(make());
let _ = stringy.unwrap_or("".to_owned());
}
-/// Checks implementation of the `EXPECT_FUN_CALL` lint
-fn expect_fun_call() {
- struct Foo;
-
- impl Foo {
- fn new() -> Self { Foo }
-
- fn expect(&self, msg: &str) {
- panic!("{}", msg)
- }
- }
-
- let with_some = Some("value");
- with_some.expect("error");
-
- let with_none: Option<i32> = None;
- with_none.expect("error");
-
- let error_code = 123_i32;
- let with_none_and_format: Option<i32> = None;
- with_none_and_format.expect(&format!("Error {}: fake error", error_code));
-
- let with_none_and_as_str: Option<i32> = None;
- with_none_and_as_str.expect(format!("Error {}: fake error", error_code).as_str());
-
- let with_ok: Result<(), ()> = Ok(());
- with_ok.expect("error");
-
- let with_err: Result<(), ()> = Err(());
- with_err.expect("error");
-
- let error_code = 123_i32;
- let with_err_and_format: Result<(), ()> = Err(());
- with_err_and_format.expect(&format!("Error {}: fake error", error_code));
-
- let with_err_and_as_str: Result<(), ()> = Err(());
- with_err_and_as_str.expect(format!("Error {}: fake error", error_code).as_str());
-
- let with_dummy_type = Foo::new();
- with_dummy_type.expect("another test string");
-
- let with_dummy_type_and_format = Foo::new();
- with_dummy_type_and_format.expect(&format!("Error {}: fake error", error_code));
-
- let with_dummy_type_and_as_str = Foo::new();
- with_dummy_type_and_as_str.expect(format!("Error {}: fake error", error_code).as_str());
-}
-
/// Checks implementation of `ITER_NTH` lint
fn iter_nth() {
let mut some_vec = vec![0, 1, 2, 3];
let ok_mut = false_positive.iter_mut().nth(3);
}
-/// Checks implementation of `ITER_SKIP_NEXT` lint
-fn iter_skip_next() {
- let mut some_vec = vec![0, 1, 2, 3];
- let _ = some_vec.iter().skip(42).next();
- let _ = some_vec.iter().cycle().skip(42).next();
- let _ = (1..10).skip(10).next();
- let _ = &some_vec[..].iter().skip(3).next();
- let foo = IteratorFalsePositives { foo : 0 };
- let _ = foo.skip(42).next();
- let _ = foo.filter().skip(42).next();
-}
-
-#[allow(similar_names)]
+#[allow(clippy::similar_names)]
fn main() {
let opt = Some(0);
let _ = opt.unwrap();