-error: you don't need to add `&` to all patterns
- --> $DIR/matches.rs:11:9
+error: `Err(_)` will match all errors, maybe not a good idea
+ --> $DIR/matches.rs:14:9
|
-LL | / match v {
-LL | | &Some(v) => println!("{:?}", v),
-LL | | &None => println!("none"),
-LL | | }
- | |_________^
- |
- = note: `-D clippy::match-ref-pats` implied by `-D warnings`
-help: instead of prefixing all patterns with `&`, you can dereference the expression
- |
-LL | match *v {
-LL | Some(v) => println!("{:?}", v),
-LL | None => println!("none"),
+LL | Err(_) => panic!("err"),
+ | ^^^^^^
|
+ = note: `-D clippy::match-wild-err-arm` implied by `-D warnings`
+ = note: to remove this warning, match each error separately or use `unreachable!` macro
-error: you don't need to add `&` to all patterns
- --> $DIR/matches.rs:22:5
+error: this `match` has identical arm bodies
+ --> $DIR/matches.rs:13:18
+ |
+LL | Ok(_) => println!("ok"),
+ | ^^^^^^^^^^^^^^
|
-LL | / match tup {
-LL | | &(v, 1) => println!("{}", v),
-LL | | _ => println!("none"),
-LL | | }
- | |_____^
-help: instead of prefixing all patterns with `&`, you can dereference the expression
+ = note: `-D clippy::match-same-arms` implied by `-D warnings`
+note: same as this
+ --> $DIR/matches.rs:12:18
|
-LL | match *tup {
-LL | (v, 1) => println!("{}", v),
+LL | Ok(3) => println!("ok"),
+ | ^^^^^^^^^^^^^^
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:12:9
|
+LL | Ok(3) => println!("ok"),
+ | ^^^^^
+ = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-error: you don't need to add `&` to both the expression and the patterns
- --> $DIR/matches.rs:28:5
- |
-LL | / match &w {
-LL | | &Some(v) => println!("{:?}", v),
-LL | | &None => println!("none"),
-LL | | }
- | |_____^
-help: try
+error: `Err(_)` will match all errors, maybe not a good idea
+ --> $DIR/matches.rs:20:9
|
-LL | match w {
-LL | Some(v) => println!("{:?}", v),
-LL | None => println!("none"),
+LL | Err(_) => panic!(),
+ | ^^^^^^
|
+ = note: to remove this warning, match each error separately or use `unreachable!` macro
-error: you don't need to add `&` to all patterns
- --> $DIR/matches.rs:39:5
+error: this `match` has identical arm bodies
+ --> $DIR/matches.rs:19:18
|
-LL | / if let &None = a {
-LL | | println!("none");
-LL | | }
- | |_____^
-help: instead of prefixing all patterns with `&`, you can dereference the expression
+LL | Ok(_) => println!("ok"),
+ | ^^^^^^^^^^^^^^
|
-LL | if let None = *a {
- | ^^^^ ^^
-
-error: you don't need to add `&` to both the expression and the patterns
- --> $DIR/matches.rs:44:5
+note: same as this
+ --> $DIR/matches.rs:18:18
|
-LL | / if let &None = &b {
-LL | | println!("none");
-LL | | }
- | |_____^
-help: try
+LL | Ok(3) => println!("ok"),
+ | ^^^^^^^^^^^^^^
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:18:9
|
-LL | if let None = b {
- | ^^^^ ^
+LL | Ok(3) => println!("ok"),
+ | ^^^^^
+ = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-error: Err(_) will match all errors, maybe not a good idea
- --> $DIR/matches.rs:55:9
+error: `Err(_)` will match all errors, maybe not a good idea
+ --> $DIR/matches.rs:26:9
|
-LL | Err(_) => panic!("err"),
+LL | Err(_) => {
| ^^^^^^
|
- = note: `-D clippy::match-wild-err-arm` implied by `-D warnings`
- = note: to remove this warning, match each error separately or use unreachable macro
+ = note: to remove this warning, match each error separately or use `unreachable!` macro
error: this `match` has identical arm bodies
- --> $DIR/matches.rs:54:18
+ --> $DIR/matches.rs:25:18
|
LL | Ok(_) => println!("ok"),
| ^^^^^^^^^^^^^^
|
- = note: `-D clippy::match-same-arms` implied by `-D warnings`
note: same as this
- --> $DIR/matches.rs:53:18
+ --> $DIR/matches.rs:24:18
|
LL | Ok(3) => println!("ok"),
| ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:53:18
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:24:9
|
LL | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
+ | ^^^^^
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-error: Err(_) will match all errors, maybe not a good idea
- --> $DIR/matches.rs:61:9
+error: `Err(_e)` will match all errors, maybe not a good idea
+ --> $DIR/matches.rs:34:9
|
-LL | Err(_) => panic!(),
- | ^^^^^^
+LL | Err(_e) => panic!(),
+ | ^^^^^^^
|
- = note: to remove this warning, match each error separately or use unreachable macro
+ = note: to remove this warning, match each error separately or use `unreachable!` macro
error: this `match` has identical arm bodies
- --> $DIR/matches.rs:60:18
+ --> $DIR/matches.rs:33:18
|
LL | Ok(_) => println!("ok"),
| ^^^^^^^^^^^^^^
|
note: same as this
- --> $DIR/matches.rs:59:18
+ --> $DIR/matches.rs:32:18
|
LL | Ok(3) => println!("ok"),
| ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:59:18
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:32:9
|
LL | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
+ | ^^^^^
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-error: Err(_) will match all errors, maybe not a good idea
- --> $DIR/matches.rs:67:9
- |
-LL | Err(_) => {
- | ^^^^^^
- |
- = note: to remove this warning, match each error separately or use unreachable macro
-
error: this `match` has identical arm bodies
- --> $DIR/matches.rs:66:18
+ --> $DIR/matches.rs:40:18
|
LL | Ok(_) => println!("ok"),
| ^^^^^^^^^^^^^^
|
note: same as this
- --> $DIR/matches.rs:65:18
+ --> $DIR/matches.rs:39:18
|
LL | Ok(3) => println!("ok"),
| ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:65:18
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:39:9
|
LL | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
+ | ^^^^^
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error: this `match` has identical arm bodies
- --> $DIR/matches.rs:75:18
+ --> $DIR/matches.rs:47:18
|
LL | Ok(_) => println!("ok"),
| ^^^^^^^^^^^^^^
|
note: same as this
- --> $DIR/matches.rs:74:18
+ --> $DIR/matches.rs:46:18
|
LL | Ok(3) => println!("ok"),
| ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:74:18
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:46:9
|
LL | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
+ | ^^^^^
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error: this `match` has identical arm bodies
- --> $DIR/matches.rs:82:18
+ --> $DIR/matches.rs:54:18
|
LL | Ok(_) => println!("ok"),
| ^^^^^^^^^^^^^^
|
note: same as this
- --> $DIR/matches.rs:81:18
+ --> $DIR/matches.rs:53:18
|
LL | Ok(3) => println!("ok"),
| ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:81:18
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:53:9
|
LL | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
+ | ^^^^^
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error: this `match` has identical arm bodies
- --> $DIR/matches.rs:88:18
+ --> $DIR/matches.rs:60:18
|
LL | Ok(_) => println!("ok"),
| ^^^^^^^^^^^^^^
|
note: same as this
- --> $DIR/matches.rs:87:18
+ --> $DIR/matches.rs:59:18
|
LL | Ok(3) => println!("ok"),
| ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:87:18
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:59:9
|
LL | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
+ | ^^^^^
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error: this `match` has identical arm bodies
- --> $DIR/matches.rs:94:18
+ --> $DIR/matches.rs:66:18
|
LL | Ok(_) => println!("ok"),
| ^^^^^^^^^^^^^^
|
note: same as this
- --> $DIR/matches.rs:93:18
+ --> $DIR/matches.rs:65:18
|
LL | Ok(3) => println!("ok"),
| ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:93:18
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:65:9
|
LL | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
+ | ^^^^^
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error: this `match` has identical arm bodies
- --> $DIR/matches.rs:117:29
+ --> $DIR/matches.rs:89:29
|
LL | (Ok(_), Some(x)) => println!("ok {}", x),
| ^^^^^^^^^^^^^^^^^^^^
|
note: same as this
- --> $DIR/matches.rs:116:29
+ --> $DIR/matches.rs:88:29
|
LL | (Ok(x), Some(_)) => println!("ok {}", x),
| ^^^^^^^^^^^^^^^^^^^^
-note: consider refactoring into `(Ok(x), Some(_)) | (Ok(_), Some(x))`
- --> $DIR/matches.rs:116:29
+help: consider refactoring into `(Ok(x), Some(_)) | (Ok(_), Some(x))`
+ --> $DIR/matches.rs:88:9
|
LL | (Ok(x), Some(_)) => println!("ok {}", x),
- | ^^^^^^^^^^^^^^^^^^^^
+ | ^^^^^^^^^^^^^^^^
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
error: this `match` has identical arm bodies
- --> $DIR/matches.rs:132:18
+ --> $DIR/matches.rs:104:18
|
LL | Ok(_) => println!("ok"),
| ^^^^^^^^^^^^^^
|
note: same as this
- --> $DIR/matches.rs:131:18
+ --> $DIR/matches.rs:103:18
|
LL | Ok(3) => println!("ok"),
| ^^^^^^^^^^^^^^
-note: consider refactoring into `Ok(3) | Ok(_)`
- --> $DIR/matches.rs:131:18
+help: consider refactoring into `Ok(3) | Ok(_)`
+ --> $DIR/matches.rs:103:9
|
LL | Ok(3) => println!("ok"),
- | ^^^^^^^^^^^^^^
+ | ^^^^^
= note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
-error: use as_ref() instead
- --> $DIR/matches.rs:141:33
- |
-LL | let borrowed: Option<&()> = match owned {
- | _________________________________^
-LL | | None => None,
-LL | | Some(ref v) => Some(v),
-LL | | };
- | |_____^ help: try this: `owned.as_ref()`
- |
- = note: `-D clippy::match-as-ref` implied by `-D warnings`
-
-error: use as_mut() instead
- --> $DIR/matches.rs:147:39
- |
-LL | let borrow_mut: Option<&mut ()> = match mut_owned {
- | _______________________________________^
-LL | | None => None,
-LL | | Some(ref mut v) => Some(v),
-LL | | };
- | |_____^ help: try this: `mut_owned.as_mut()`
-
-error: you don't need to add `&` to all patterns
- --> $DIR/matches.rs:174:5
- |
-LL | / match foo_variant!(0) {
-LL | | &Foo::A => println!("A"),
-LL | | _ => println!("Wild"),
-LL | | }
- | |_____^
-help: instead of prefixing all patterns with `&`, you can dereference the expression
- |
-LL | match *foo_variant!(0) {
-LL | Foo::A => println!("A"),
- |
-
-error: aborting due to 20 previous errors
+error: aborting due to 15 previous errors
projects / rust.git / blobdiff