Fix `implicit_return` false positives.

[rust.git] / tests / ui / implicit_return.rs

diff --git a/tests/ui/implicit_return.rs b/tests/ui/implicit_return.rs
index 73cf2908833cd71cbf2c7656b96a916239d527c6..d1c63ca1697c3f9e1a4a2b2b1a5a9d29df1ec91d 100644 (file)
--- a/tests/ui/implicit_return.rs
+++ b/tests/ui/implicit_return.rs
@@ -1,16 +1,3 @@
-// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
-// file at the top-level directory of this distribution.
-//
-// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
-// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
-// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
-// option. This file may not be copied, modified, or distributed
-// except according to those terms.
-
-
-
-
-
 #![warn(clippy::implicit_return)]
 
 fn test_end_of_fn() -> bool {
@@ -31,12 +18,19 @@ fn test_if_block() -> bool {
 }
 
 #[allow(clippy::match_bool)]
+#[rustfmt::skip]
 fn test_match(x: bool) -> bool {
     match x {
         true => false,
-        false => {
-            true
-        }
+        false => { true },
+    }
+}
+
+#[allow(clippy::match_bool, clippy::needless_return)]
+fn test_match_with_unreachable(x: bool) -> bool {
+    match x {
+        true => return false,
+        false => unreachable!(),
     }
 }
 
@@ -47,10 +41,38 @@ fn test_loop() -> bool {
     }
 }
 
+#[allow(clippy::never_loop)]
+fn test_loop_with_block() -> bool {
+    loop {
+        {
+            break true;
+        }
+    }
+}
+
+#[allow(clippy::never_loop)]
+fn test_loop_with_nests() -> bool {
+    loop {
+        if true {
+            break true;
+        } else {
+            let _ = true;
+        }
+    }
+}
+
+#[allow(clippy::redundant_pattern_matching)]
+fn test_loop_with_if_let() -> bool {
+    loop {
+        if let Some(x) = Some(true) {
+            return x;
+        }
+    }
+}
+
 fn test_closure() {
-    let _ = || {
-        true
-    };
+    #[rustfmt::skip]
+    let _ = || { true };
     let _ = || true;
 }
 
@@ -58,6 +80,10 @@ fn main() {
     let _ = test_end_of_fn();
     let _ = test_if_block();
     let _ = test_match(true);
+    let _ = test_match_with_unreachable(true);
     let _ = test_loop();
+    let _ = test_loop_with_block();
+    let _ = test_loop_with_nests();
+    let _ = test_loop_with_if_let();
     test_closure();
 }