Apply `not_unsafe_ptr_arg_deref` to type aliases

[rust.git] / tests / ui / functions.rs

diff --git a/tests/ui/functions.rs b/tests/ui/functions.rs
index bb09be575fdca5e680490b0ec00bd898a5556b22..5521870eaecf761af9b0f50bdbdd941d63aaa551 100644 (file)
--- a/tests/ui/functions.rs
+++ b/tests/ui/functions.rs
@@ -1,25 +1,49 @@
-#![feature(plugin)]
-#![plugin(clippy)]
-
-#![deny(clippy)]
+#![warn(clippy::all)]
 #![allow(dead_code)]
-#![allow(unused_unsafe)]
+#![allow(unused_unsafe, clippy::missing_safety_doc)]
 
 // TOO_MANY_ARGUMENTS
 fn good(_one: u32, _two: u32, _three: &str, _four: bool, _five: f32, _six: f32, _seven: bool) {}
 
-fn bad(_one: u32, _two: u32, _three: &str, _four: bool, _five: f32, _six: f32, _seven: bool, _eight: ()) {
-
+fn bad(_one: u32, _two: u32, _three: &str, _four: bool, _five: f32, _six: f32, _seven: bool, _eight: ()) {}
+
+#[rustfmt::skip]
+fn bad_multiline(
+    one: u32,
+    two: u32,
+    three: &str,
+    four: bool,
+    five: f32,
+    six: f32,
+    seven: bool,
+    eight: ()
+) {
+    let _one = one;
+    let _two = two;
+    let _three = three;
+    let _four = four;
+    let _five = five;
+    let _six = six;
+    let _seven = seven;
 }
 
 // don't lint extern fns
-extern fn extern_fn(_one: u32, _two: u32, _three: &str, _four: bool, _five: f32, _six: f32, _seven: bool, _eight: ()) {}
+extern "C" fn extern_fn(
+    _one: u32,
+    _two: u32,
+    _three: *const u8,
+    _four: bool,
+    _five: f32,
+    _six: f32,
+    _seven: bool,
+    _eight: *const std::ffi::c_void,
+) {
+}
 
 pub trait Foo {
     fn good(_one: u32, _two: u32, _three: &str, _four: bool, _five: f32, _six: f32, _seven: bool);
     fn bad(_one: u32, _two: u32, _three: &str, _four: bool, _five: f32, _six: f32, _seven: bool, _eight: ());
 
-
     fn ptr(p: *const u8);
 }
 
@@ -28,7 +52,6 @@ pub trait Foo {
 impl Bar {
     fn good_method(_one: u32, _two: u32, _three: &str, _four: bool, _five: f32, _six: f32, _seven: bool) {}
     fn bad_method(_one: u32, _two: u32, _three: &str, _four: bool, _five: f32, _six: f32, _seven: bool, _eight: ()) {}
-
 }
 
 // ok, we don’t want to warn implementations
@@ -38,11 +61,8 @@ fn bad(_one: u32, _two: u32, _three: &str, _four: bool, _five: f32, _six: f32, _
 
     fn ptr(p: *const u8) {
         println!("{}", unsafe { *p });
-
         println!("{:?}", unsafe { p.as_ref() });
-
         unsafe { std::ptr::read(p) };
-
     }
 }
 
@@ -54,11 +74,16 @@ fn private(p: *const u8) {
 
 pub fn public(p: *const u8) {
     println!("{}", unsafe { *p });
-
     println!("{:?}", unsafe { p.as_ref() });
-
     unsafe { std::ptr::read(p) };
+}
+
+type Alias = *const u8;
 
+pub fn type_alias(p: Alias) {
+    println!("{}", unsafe { *p });
+    println!("{:?}", unsafe { p.as_ref() });
+    unsafe { std::ptr::read(p) };
 }
 
 impl Bar {
@@ -68,11 +93,8 @@ fn private(self, p: *const u8) {
 
     pub fn public(self, p: *const u8) {
         println!("{}", unsafe { *p });
-
         println!("{:?}", unsafe { p.as_ref() });
-
         unsafe { std::ptr::read(p) };
-
     }
 
     pub fn public_ok(self, p: *const u8) {