Auto merge of #4478 - tsurai:master, r=flip1995

[rust.git] / tests / ui / assign_ops2.stderr

diff --git a/tests/ui/assign_ops2.stderr b/tests/ui/assign_ops2.stderr
index 6fbfac71c1503de4980e7395672c0a6dc1e53234..872d6e0d7347323960197ff301bb629c62d42a5e 100644 (file)
--- a/tests/ui/assign_ops2.stderr
+++ b/tests/ui/assign_ops2.stderr
@@ -1,56 +1,138 @@
 error: variable appears on both sides of an assignment operation
- --> $DIR/assign_ops2.rs:8:5
-  |
-8 |     a += a + 1;
-  |     ^^^^^^^^^^ help: replace it with `a += 1`
-  |
-note: lint level defined here
- --> $DIR/assign_ops2.rs:5:8
-  |
-5 | #[deny(misrefactored_assign_op)]
-  |        ^^^^^^^^^^^^^^^^^^^^^^^
+  --> $DIR/assign_ops2.rs:5:5
+   |
+LL |     a += a + 1;
+   |     ^^^^^^^^^^
+   |
+   = note: `-D clippy::misrefactored-assign-op` implied by `-D warnings`
+help: Did you mean a = a + 1 or a = a + a + 1? Consider replacing it with
+   |
+LL |     a += 1;
+   |     ^^^^^^
+help: or
+   |
+LL |     a = a + a + 1;
+   |     ^^^^^^^^^^^^^
+
+error: variable appears on both sides of an assignment operation
+  --> $DIR/assign_ops2.rs:6:5
+   |
+LL |     a += 1 + a;
+   |     ^^^^^^^^^^
+help: Did you mean a = a + 1 or a = a + 1 + a? Consider replacing it with
+   |
+LL |     a += 1;
+   |     ^^^^^^
+help: or
+   |
+LL |     a = a + 1 + a;
+   |     ^^^^^^^^^^^^^
 
 error: variable appears on both sides of an assignment operation
- --> $DIR/assign_ops2.rs:9:5
-  |
-9 |     a += 1 + a;
-  |     ^^^^^^^^^^ help: replace it with `a += 1`
+  --> $DIR/assign_ops2.rs:7:5
+   |
+LL |     a -= a - 1;
+   |     ^^^^^^^^^^
+help: Did you mean a = a - 1 or a = a - (a - 1)? Consider replacing it with
+   |
+LL |     a -= 1;
+   |     ^^^^^^
+help: or
+   |
+LL |     a = a - (a - 1);
+   |     ^^^^^^^^^^^^^^^
+
+error: variable appears on both sides of an assignment operation
+  --> $DIR/assign_ops2.rs:8:5
+   |
+LL |     a *= a * 99;
+   |     ^^^^^^^^^^^
+help: Did you mean a = a * 99 or a = a * a * 99? Consider replacing it with
+   |
+LL |     a *= 99;
+   |     ^^^^^^^
+help: or
+   |
+LL |     a = a * a * 99;
+   |     ^^^^^^^^^^^^^^
+
+error: variable appears on both sides of an assignment operation
+  --> $DIR/assign_ops2.rs:9:5
+   |
+LL |     a *= 42 * a;
+   |     ^^^^^^^^^^^
+help: Did you mean a = a * 42 or a = a * 42 * a? Consider replacing it with
+   |
+LL |     a *= 42;
+   |     ^^^^^^^
+help: or
+   |
+LL |     a = a * 42 * a;
+   |     ^^^^^^^^^^^^^^
 
 error: variable appears on both sides of an assignment operation
   --> $DIR/assign_ops2.rs:10:5
    |
-10 |     a -= a - 1;
-   |     ^^^^^^^^^^ help: replace it with `a -= 1`
+LL |     a /= a / 2;
+   |     ^^^^^^^^^^
+help: Did you mean a = a / 2 or a = a / (a / 2)? Consider replacing it with
+   |
+LL |     a /= 2;
+   |     ^^^^^^
+help: or
+   |
+LL |     a = a / (a / 2);
+   |     ^^^^^^^^^^^^^^^
 
 error: variable appears on both sides of an assignment operation
   --> $DIR/assign_ops2.rs:11:5
    |
-11 |     a *= a * 99;
-   |     ^^^^^^^^^^^ help: replace it with `a *= 99`
+LL |     a %= a % 5;
+   |     ^^^^^^^^^^
+help: Did you mean a = a % 5 or a = a % (a % 5)? Consider replacing it with
+   |
+LL |     a %= 5;
+   |     ^^^^^^
+help: or
+   |
+LL |     a = a % (a % 5);
+   |     ^^^^^^^^^^^^^^^
 
 error: variable appears on both sides of an assignment operation
   --> $DIR/assign_ops2.rs:12:5
    |
-12 |     a *= 42 * a;
-   |     ^^^^^^^^^^^ help: replace it with `a *= 42`
+LL |     a &= a & 1;
+   |     ^^^^^^^^^^
+help: Did you mean a = a & 1 or a = a & a & 1? Consider replacing it with
+   |
+LL |     a &= 1;
+   |     ^^^^^^
+help: or
+   |
+LL |     a = a & a & 1;
+   |     ^^^^^^^^^^^^^
 
 error: variable appears on both sides of an assignment operation
   --> $DIR/assign_ops2.rs:13:5
    |
-13 |     a /= a / 2;
-   |     ^^^^^^^^^^ help: replace it with `a /= 2`
-
-error: variable appears on both sides of an assignment operation
-  --> $DIR/assign_ops2.rs:14:5
+LL |     a *= a * a;
+   |     ^^^^^^^^^^
+help: Did you mean a = a * a or a = a * a * a? Consider replacing it with
+   |
+LL |     a *= a;
+   |     ^^^^^^
+help: or
    |
-14 |     a %= a % 5;
-   |     ^^^^^^^^^^ help: replace it with `a %= 5`
+LL |     a = a * a * a;
+   |     ^^^^^^^^^^^^^
 
-error: variable appears on both sides of an assignment operation
-  --> $DIR/assign_ops2.rs:15:5
+error: manual implementation of an assign operation
+  --> $DIR/assign_ops2.rs:50:5
+   |
+LL |     buf = buf + cows.clone();
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf += cows.clone()`
    |
-15 |     a &= a & 1;
-   |     ^^^^^^^^^^ help: replace it with `a &= 1`
+   = note: `-D clippy::assign-op-pattern` implied by `-D warnings`
 
-error: aborting due to 8 previous errors
+error: aborting due to 10 previous errors