+#![cfg_attr(feature = "deny-warnings", deny(warnings))]
+#![warn(rust_2018_idioms, unused_lifetimes)]
+
+use std::ffi::OsStr;
use std::path::PathBuf;
use regex::RegexSet;
fn new(path: PathBuf) -> Self {
let content: String = std::fs::read_to_string(&path).unwrap();
// we don't want the first letter after "error: ", "help: " ... to be capitalized
- // also no puncutation (except for "?" ?) at the end of a line
+ // also no punctuation (except for "?" ?) at the end of a line
let regex_set: RegexSet = RegexSet::new(&[
r"error: [A-Z]",
r"help: [A-Z]",
])
.unwrap();
- // sometimes the first character is capitalized and it is legal (like in "Iterator...") or
+ // sometimes the first character is capitalized and it is legal (like in "C-like enum variants") or
// we want to ask a question ending in "?"
let exceptions_set: RegexSet = RegexSet::new(&[
- r".*error: I see you're using a LinkedList! Perhaps you meant some other data structure?",
r".*C-like enum variant discriminant is not portable to 32-bit targets",
- r".*Iterator::step_by(0) will panic at runtime",
r".*did you mean `unix`?",
r".*the arguments may be inverted...",
r".*Intel x86 assembly syntax used",
r".*AT&T x86 assembly syntax used",
- r".*remove .* the return type...",
+ r".*remove .*the return type...",
r"note: Clippy version: .*",
+ r"the compiler unexpectedly panicked. this is a bug.",
])
.unwrap();
.filter(|line| regex_set.matches(line).matched_any())
// ignore exceptions
.filter(|line| !exceptions_set.matches(line).matched_any())
- .map(|s| s.to_owned())
+ .map(ToOwned::to_owned)
.collect::<Vec<String>>();
Message { path, bad_lines }
#[test]
fn lint_message_convention() {
+ // disable the test inside the rustc test suite
+ if option_env!("RUSTC_TEST_SUITE").is_some() {
+ return;
+ }
+
// make sure that lint messages:
// * are not capitalized
- // * don't have puncuation at the end of the last sentence
+ // * don't have punctuation at the end of the last sentence
// these directories have interesting tests
let test_dirs = ["ui", "ui-cargo", "ui-internal", "ui-toml"]
// gather all .stderr files
let tests = test_dirs
- .map(|dir| {
+ .flat_map(|dir| {
std::fs::read_dir(dir)
.expect("failed to read dir")
.map(|direntry| direntry.unwrap().path())
})
- .flatten()
- .filter(|file| matches!(file.extension().map(|s| s.to_str()), Some(Some("stderr"))));
+ .filter(|file| matches!(file.extension().map(OsStr::to_str), Some(Some("stderr"))));
// get all files that have any "bad lines" in them
let bad_tests: Vec<Message> = tests
- .map(|path| Message::new(path))
+ .map(Message::new)
.filter(|message| !message.bad_lines.is_empty())
.collect();
- bad_tests.iter().for_each(|message| {
+ for message in &bad_tests {
eprintln!(
"error: the test '{}' contained the following nonconforming lines :",
message.path.display()
);
message.bad_lines.iter().for_each(|line| eprintln!("{}", line));
eprintln!("\n\n");
- });
+ }
- eprintln!("\n\n\nLint message should not start with a capital letter and should not have punctuation at the end of the message unless multiple sentences are needed.");
+ eprintln!(
+ "\n\n\nLint message should not start with a capital letter and should not have punctuation at the end of the message unless multiple sentences are needed."
+ );
eprintln!("Check out the rustc-dev-guide for more information:");
- eprintln!("https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-structure");
+ eprintln!("https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-structure\n\n\n");
assert!(bad_tests.is_empty());
}