iterate List by value

[rust.git] / tests / dogfood.rs

diff --git a/tests/dogfood.rs b/tests/dogfood.rs
index 4870bd285b499b248f320538524fc5504c1e7175..81af3d3033b23c268a152258d74a30a8cd0d4ecc 100644 (file)
--- a/tests/dogfood.rs
+++ b/tests/dogfood.rs
@@ -1,49 +1,76 @@
-#![feature(test, plugin)]
-#![plugin(clippy)]
-#![deny(clippy, clippy_pedantic)]
+// Dogfood cannot run on Windows
+#![cfg(not(windows))]
 
-extern crate compiletest_rs as compiletest;
-extern crate test;
-
-use std::env::{set_var, var};
+use lazy_static::lazy_static;
 use std::path::PathBuf;
-use test::TestPaths;
+use std::process::Command;
 
-#[test]
-fn dogfood() {
-    // don't run dogfood on travis, cargo-clippy already runs clippy on itself
-    if let Ok(travis) = var("TRAVIS") {
-        if travis == "true" {
-            return;
-        }
-    }
+mod cargo;
 
-    let mut config = compiletest::Config::default();
+lazy_static! {
+    static ref CLIPPY_PATH: PathBuf = cargo::TARGET_LIB.join("cargo-clippy");
+}
 
-    let cfg_mode = "run-fail".parse().expect("Invalid mode");
-    let mut s = String::new();
-    s.push_str(" -L target/debug/");
-    s.push_str(" -L target/debug/deps");
-    s.push_str(" -Zextra-plugins=clippy -Ltarget_recur/debug -Dwarnings -Dclippy_pedantic -Dclippy -Dclippy_internal");
-    config.target_rustcflags = Some(s);
-    if let Ok(name) = var("TESTNAME") {
-        config.filter = Some(name.to_owned())
+#[test]
+fn dogfood_clippy() {
+    // run clippy on itself and fail the test if lint warnings are reported
+    if cargo::is_rustc_test_suite() {
+        return;
     }
+    let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
 
-    config.mode = cfg_mode;
-    config.verbose = true;
+    let output = Command::new(&*CLIPPY_PATH)
+        .current_dir(root_dir)
+        .env("CLIPPY_DOGFOOD", "1")
+        .env("CARGO_INCREMENTAL", "0")
+        .arg("clippy-preview")
+        .arg("--all-targets")
+        .arg("--all-features")
+        .arg("--")
+        .args(&["-D", "clippy::all"])
+        .args(&["-D", "clippy::internal"])
+        .args(&["-D", "clippy::pedantic"])
+        .arg("-Cdebuginfo=0") // disable debuginfo to generate less data in the target dir
+        .output()
+        .unwrap();
+    println!("status: {}", output.status);
+    println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
+    println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
 
-    let files = ["src/main.rs", "src/lib.rs", "clippy_lints/src/lib.rs"];
+    assert!(output.status.success());
+}
 
-    for file in &files {
-        let paths = TestPaths {
-            base: PathBuf::new(),
-            file: PathBuf::from(file),
-            relative_dir: PathBuf::new(),
-        };
+#[test]
+fn dogfood_subprojects() {
+    // run clippy on remaining subprojects and fail the test if lint warnings are reported
+    if cargo::is_rustc_test_suite() {
+        return;
+    }
+    let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
 
-        set_var("CLIPPY_DOGFOOD", "tastes like chicken");
+    for d in &[
+        "clippy_workspace_tests",
+        "clippy_workspace_tests/src",
+        "clippy_workspace_tests/subcrate",
+        "clippy_workspace_tests/subcrate/src",
+        "clippy_dev",
+        "rustc_tools_util",
+    ] {
+        let output = Command::new(&*CLIPPY_PATH)
+            .current_dir(root_dir.join(d))
+            .env("CLIPPY_DOGFOOD", "1")
+            .env("CARGO_INCREMENTAL", "0")
+            .arg("clippy")
+            .arg("--")
+            .args(&["-D", "clippy::all"])
+            .args(&["-D", "clippy::pedantic"])
+            .arg("-Cdebuginfo=0") // disable debuginfo to generate less data in the target dir
+            .output()
+            .unwrap();
+        println!("status: {}", output.status);
+        println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
+        println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
 
-        compiletest::runtest::run(config.clone(), &paths);
+        assert!(output.status.success());
     }
 }