Add TODO(#1022)

[nothing.git] / test / parser_suite.h

diff --git a/test/parser_suite.h b/test/parser_suite.h
index d375661e78d0f0d5574e44f1591c9036c6ff8875..4bbadc41609a013570b6bd4a00a2728871311c1d 100644 (file)
--- a/test/parser_suite.h
+++ b/test/parser_suite.h
@@ -10,9 +10,13 @@ TEST(read_expr_from_file_test)
 {
     Gc *gc = create_gc();
 
-    struct ParseResult result = read_expr_from_file(gc, "test-data/simple-sum.lisp");
+    struct ParseResult result = read_expr_from_file(gc, "test-data/simple-sum.ebi");
 
-    ASSERT_TRUE(!result.is_error, result.error_message);
+    ASSERT_TRUE(!result.is_error, {
+            fprintf(stderr,
+                    "Parsing failed: %s",
+                    result.error_message);
+    });
 
     struct Expr head = result.expr;
 
@@ -56,10 +60,16 @@ TEST(parse_negative_numbers_test)
     struct ParseResult result = read_expr_from_string(gc, "-12345");
 
     ASSERT_FALSE(result.is_error, {
-        fprintf(stderr, "Parsing failed: %s", result.error_message);
+            fprintf(stderr, "Parsing failed: %s", result.error_message);
+    });
+    ASSERT_EQ(enum ExprType, EXPR_ATOM, result.expr.type, {
+            fprintf(stderr, "Expected: %s\n", expr_type_as_string(_expected));
+            fprintf(stderr, "Actual: %s\n", expr_type_as_string(_actual));
+    });
+    ASSERT_EQ(enum AtomType, ATOM_NUMBER, result.expr.atom->type, {
+            fprintf(stderr, "Expected: %s\n", atom_type_as_string(_expected));
+            fprintf(stderr, "Actual: %s\n", atom_type_as_string(_actual));
     });
-    ASSERT_TRUE(result.expr.type == EXPR_ATOM, "Parsed expression is not an atom");
-    ASSERT_TRUE(result.expr.atom->type == ATOM_NUMBER, "Parsed expression is not a number");
     ASSERT_LONGINTEQ(-12345L, result.expr.atom->num);
 
     destroy_gc(gc);
@@ -72,9 +82,19 @@ TEST(read_all_exprs_from_string_empty_test)
     Gc *gc = create_gc();
     struct ParseResult result = read_all_exprs_from_string(gc, "");
 
-    ASSERT_TRUE(result.is_error,
-                "Parsing is expected to fail, "
-                "but it did not");
+    ASSERT_FALSE(result.is_error, {
+            fprintf(stderr,
+                    "Parsing was unsuccessful: %s\n",
+                    result.error_message);
+    });
+
+    ASSERT_EQ(long int, 0, length_of_list(result.expr), {
+            fprintf(stderr, "Expected: %ld\n", _expected);
+            fprintf(stderr, "Actual: %ld\n", _actual);
+            fprintf(stderr, "Expression: ");
+            print_expr_as_sexpr(stderr, result.expr);
+            fprintf(stderr, "\n");
+    });
 
     destroy_gc(gc);
 
@@ -95,6 +115,9 @@ TEST(read_all_exprs_from_string_one_test)
     ASSERT_EQ(long int, 1, length_of_list(result.expr), {
             fprintf(stderr, "Expected: %ld\n", _expected);
             fprintf(stderr, "Actual: %ld\n", _actual);
+            fprintf(stderr, "Expression: ");
+            print_expr_as_sexpr(stderr, result.expr);
+            fprintf(stderr, "\n");
     });
 
     destroy_gc(gc);
@@ -135,14 +158,29 @@ TEST(read_all_exprs_from_string_bad_test)
         gc,
         "(+ 1 2) + 3 4)");
 
-    ASSERT_TRUE(result.is_error,
-                "Parsing didn't fail as expected");
+    ASSERT_TRUE(result.is_error, {
+            fprintf(stderr, "Parsing didn't fail as expected\n");
+    });
 
     destroy_gc(gc);
 
     return 0;
 }
 
+TEST(read_all_exprs_from_string_trailing_spaces_test)
+{
+    Gc *gc = create_gc();
+    const char *source_code = "5  ";
+    struct ParseResult result = read_all_exprs_from_string(gc, source_code);
+
+    ASSERT_FALSE(result.is_error, {
+            fprintf(stderr, "Parsing failed: %s\n", result.error_message);
+            fprintf(stderr, "Position: %zd\n", result.end - source_code);
+    });
+
+    return 0;
+}
+
 TEST_SUITE(parser_suite)
 {
     TEST_RUN(read_expr_from_file_test);
@@ -150,8 +188,9 @@ TEST_SUITE(parser_suite)
     TEST_RUN(read_all_exprs_from_string_empty_test);
     TEST_RUN(read_all_exprs_from_string_one_test);
     TEST_RUN(read_all_exprs_from_string_two_test);
-    // TODO: read_all_exprs_from_string_bad_test is failing
+    // TODO(#467): read_all_exprs_from_string_bad_test is failing
     TEST_IGNORE(read_all_exprs_from_string_bad_test);
+    TEST_RUN(read_all_exprs_from_string_trailing_spaces_test);
 
     return 0;
 }