Req *r;
qlock(&s->rlock);
- if((n = read9pmsg(s->infd, s->rbuf, s->msize)) <= 0){
+ n = read9pmsg(s->infd, s->rbuf, s->msize);
+ if(n <= 0){
qunlock(&s->rlock);
return nil;
}
static void
sversion(Srv *srv, Req *r)
{
- if(srv->rref.ref != 2){
+ if(srv->rref.ref != 1){
respond(r, Ebotch);
return;
}
if(strncmp(r->ifcall.version, "9P", 2) != 0){
r->ofcall.version = "unknown";
+ r->ofcall.msize = 256;
respond(r, nil);
return;
}
static void
rauth(Req *r, char *error)
{
- if(error && r->afid)
+ if(r->afid == nil)
+ return;
+ if(error){
closefid(removefid(r->srv->fpool, r->afid->fid));
+ return;
+ }
+ if(r->afid->omode == -1)
+ r->afid->omode = ORDWR;
}
static void
}
}
+static int
+dirwritable(Fid *fid)
+{
+ File *f;
+
+ f = fid->file;
+ if(f){
+ rlock(f);
+ if(f->parent && !hasperm(f->parent, fid->uid, AWRITE)){
+ runlock(f);
+ return 0;
+ }
+ runlock(f);
+ }
+ return 1;
+}
+
static void
sopen(Srv *srv, Req *r)
{
r->ofcall.qid = r->fid->qid;
switch(r->ifcall.mode&3){
default:
- assert(0);
+ respond(r, Ebotch);
+ return;
case OREAD:
p = AREAD;
break;
respond(r, Eperm);
return;
}
- /* BUG RACE */
- if((r->ifcall.mode&ORCLOSE)
- && !hasperm(r->fid->file->parent, r->fid->uid, AWRITE)){
+ if((r->ifcall.mode&ORCLOSE) && !dirwritable(r->fid)){
respond(r, Eperm);
return;
}
else
respond(r, nil);
}
-static void
-ropen(Req *r, char *error)
-{
- char errbuf[ERRMAX];
- if(error)
- return;
- if(chatty9p){
- snprint(errbuf, sizeof errbuf, "fid mode is 0x%ux\n", r->ifcall.mode);
- write(2, errbuf, strlen(errbuf));
- }
- r->fid->omode = r->ifcall.mode;
- r->fid->qid = r->ofcall.qid;
- if(r->ofcall.qid.type&QTDIR)
- r->fid->diroffset = 0;
-}
static void
screate(Srv *srv, Req *r)
else
respond(r, Enocreate);
}
+
static void
-rcreate(Req *r, char *error)
+ropen(Req *r, char *error)
{
if(error)
return;
- r->fid->omode = r->ifcall.mode;
+ if(chatty9p)
+ fprint(2, "fid mode is %x\n", (int)r->ifcall.mode);
+ if(r->ofcall.qid.type&QTDIR)
+ r->fid->diroffset = 0;
r->fid->qid = r->ofcall.qid;
+ r->fid->omode = r->ifcall.mode;
}
static void
respond(r, Eunknownfid);
return;
}
+ o = r->fid->omode;
+ if(o == -1){
+ respond(r, Ebotch);
+ return;
+ }
+ switch(o & 3){
+ default:
+ respond(r, Ebotch);
+ return;
+ case OREAD:
+ case ORDWR:
+ case OEXEC:
+ break;
+ }
if((int)r->ifcall.count < 0){
respond(r, Ebotch);
return;
respond(r, Ebadoffset);
return;
}
-
if(r->ifcall.count > srv->msize - IOHDRSZ)
r->ifcall.count = srv->msize - IOHDRSZ;
r->rbuf = emalloc9p(r->ifcall.count);
r->ofcall.data = r->rbuf;
- o = r->fid->omode & 3;
- if(o != OREAD && o != ORDWR && o != OEXEC){
- respond(r, Ebotch);
- return;
- }
if((r->fid->qid.type&QTDIR) && r->fid->file){
- r->ofcall.count = readdirfile(r->fid->rdir, r->rbuf, r->ifcall.count);
+ r->ofcall.count = readdirfile(r->fid->rdir, r->rbuf, r->ifcall.count, r->ifcall.offset);
respond(r, nil);
return;
}
rread(Req *r, char *error)
{
if(error==nil && (r->fid->qid.type&QTDIR))
- r->fid->diroffset += r->ofcall.count;
+ r->fid->diroffset = r->ifcall.offset + r->ofcall.count;
}
static void
swrite(Srv *srv, Req *r)
{
int o;
- char e[ERRMAX];
if((r->fid = lookupfid(srv->fpool, r->ifcall.fid)) == nil){
respond(r, Eunknownfid);
return;
}
+ o = r->fid->omode;
+ if(o == -1){
+ respond(r, Ebotch);
+ return;
+ }
+ switch(o & 3){
+ default:
+ respond(r, Ebotch);
+ return;
+ case OWRITE:
+ case ORDWR:
+ break;
+ }
+ if(r->fid->qid.type&QTDIR){
+ respond(r, Ebotch);
+ return;
+ }
if((int)r->ifcall.count < 0){
respond(r, Ebotch);
return;
}
if(r->ifcall.count > srv->msize - IOHDRSZ)
r->ifcall.count = srv->msize - IOHDRSZ;
- o = r->fid->omode & 3;
- if(o != OWRITE && o != ORDWR){
- snprint(e, sizeof e, "write on fid with open mode 0x%ux", r->fid->omode);
- respond(r, e);
- return;
- }
if(srv->write)
srv->write(r);
else
- respond(r, "no srv->write");
+ respond(r, Enowrite);
}
static void
rwrite(Req *r, char *error)
respond(r, Eunknownfid);
return;
}
- /* BUG RACE */
- if(r->fid->file && !hasperm(r->fid->file->parent, r->fid->uid, AWRITE)){
+ if(!dirwritable(r->fid)){
respond(r, Eperm);
return;
}
respond(r, Ebaddir);
return;
}
- if((ushort)~r->d.type){
- respond(r, "wstat -- attempt to change type");
- return;
- }
- if((uint)~r->d.dev){
- respond(r, "wstat -- attempt to change dev");
+ if(r->d.qid.path != ~0 && r->d.qid.path != r->fid->qid.path){
+ respond(r, "wstat -- attempt to change qid.path");
return;
}
- if((uchar)~r->d.qid.type || (ulong)~r->d.qid.vers || (uvlong)~r->d.qid.path){
- respond(r, "wstat -- attempt to change qid");
+ if(r->d.qid.vers != ~0 && r->d.qid.vers != r->fid->qid.vers){
+ respond(r, "wstat -- attempt to change qid.vers");
return;
}
- if(r->d.muid && r->d.muid[0]){
- respond(r, "wstat -- attempt to change muid");
- return;
- }
- if((ulong)~r->d.mode && ((r->d.mode&DMDIR)>>24) != (r->fid->qid.type&QTDIR)){
- respond(r, "wstat -- attempt to change DMDIR bit");
- return;
+ if(r->d.mode != ~0){
+ if(r->d.mode & ~(DMDIR|DMAPPEND|DMEXCL|DMTMP|0777)){
+ respond(r, "wstat -- unknown bits in mode");
+ return;
+ }
+ if(r->d.qid.type != (uchar)~0 && r->d.qid.type != ((r->d.mode>>24)&0xFF)){
+ respond(r, "wstat -- qid.type/mode mismatch");
+ return;
+ }
+ if(((r->d.mode>>24) ^ r->fid->qid.type) & ~(QTAPPEND|QTEXCL|QTTMP)){
+ respond(r, "wstat -- attempt to change qid.type");
+ return;
+ }
+ } else {
+ if(r->d.qid.type != (uchar)~0 && r->d.qid.type != r->fid->qid.type){
+ respond(r, "wstat -- attempt to change qid.type");
+ return;
+ }
}
srv->wstat(r);
}
Srv *srv = v;
Req *r;
- incref(&srv->rref);
- incref(&srv->sref);
while(r = getreq(srv)){
incref(&srv->rref);
if(r->error){
case Tstat: sstat(srv, r); break;
case Twstat: swstat(srv, r); break;
}
+ if(srv->sref.ref > 8 && srv->spid != getpid()){
+ decref(&srv->sref);
+ qunlock(&srv->slock);
+ return;
+ }
qunlock(&srv->slock);
}
- decref(&srv->sref);
- srvclose(srv);
+
+ if(srv->end && srv->sref.ref == 1)
+ srv->end(srv);
+ if(decref(&srv->sref) == 0)
+ srvclose(srv);
}
static void
srvclose(Srv *srv)
{
- if(decref(&srv->rref))
+ if(srv->rref.ref || srv->sref.ref)
return;
if(chatty9p)
freereqpool(srv->rpool);
srv->rpool = nil;
- if(srv->end)
- srv->end(srv);
+ if(srv->free)
+ srv->free(srv);
}
void
void
srvrelease(Srv *srv)
{
- if(decref(&srv->sref) == 0)
+ if(decref(&srv->sref) == 0){
+ incref(&srv->sref);
_forker(srvwork, srv, 0);
+ }
qunlock(&srv->slock);
}
fmtinstall('D', dirfmt);
fmtinstall('F', fcallfmt);
- srv->sref.ref = 0;
- srv->rref.ref = 0;
+ srv->spid = getpid();
+ memset(&srv->sref, 0, sizeof(srv->sref));
+ memset(&srv->rref, 0, sizeof(srv->rref));
if(srv->fpool == nil)
srv->fpool = allocfidpool(srv->destroyfid);
if(srv->start)
srv->start(srv);
+ incref(&srv->sref);
srvwork(srv);
}
case Tattach: rattach(r, error); break;
case Twalk: rwalk(r, error); break;
case Topen: ropen(r, error); break;
- case Tcreate: rcreate(r, error); break;
+ case Tcreate: ropen(r, error); break;
case Tread: rread(r, error); break;
case Twrite: rwrite(r, error); break;
case Tclunk: rclunk(r, error); break;
else
free(r);
- srvclose(srv);
+ if(decref(&srv->rref) == 0)
+ srvclose(srv);
}
void
rerrstr(errbuf, sizeof errbuf);
respond(r, errbuf);
}
-
-int
-postfd(char *name, int pfd)
-{
- int fd;
- char buf[80];
-
- snprint(buf, sizeof buf, "/srv/%s", name);
- if(chatty9p)
- fprint(2, "postfd %s\n", buf);
- fd = create(buf, OWRITE|ORCLOSE|OCEXEC, 0600);
- if(fd < 0){
- if(chatty9p)
- fprint(2, "create fails: %r\n");
- return -1;
- }
- if(fprint(fd, "%d", pfd) < 0){
- if(chatty9p)
- fprint(2, "write fails: %r\n");
- close(fd);
- return -1;
- }
- if(chatty9p)
- fprint(2, "postfd successful\n");
- return 0;
-}
-
-int
-sharefd(char *name, char *desc, int pfd)
-{
- int fd;
- char buf[80];
-
- snprint(buf, sizeof buf, "#σc/%s", name);
- if((fd = create(buf, OREAD, 0700|DMDIR)) >= 0)
- close(fd);
- snprint(buf, sizeof buf, "#σc/%s/%s", name, desc);
- if(chatty9p)
- fprint(2, "sharefd %s\n", buf);
- fd = create(buf, OWRITE, 0600);
- if(fd < 0){
- if(chatty9p)
- fprint(2, "create fails: %r\n");
- return -1;
- }
- if(fprint(fd, "%d\n", pfd) < 0){
- if(chatty9p)
- fprint(2, "write fails: %r\n");
- close(fd);
- return -1;
- }
- close(fd);
- if(chatty9p)
- fprint(2, "sharefd successful\n");
- return 0;
-}
projects / plan9front.git / blobdiff