]> git.lizzy.rs Git - plan9front.git/blobdiff - sys/src/cmd/aan.c
cwfs: fix listen filedescriptor leaks
[plan9front.git] / sys / src / cmd / aan.c
index 6994312e86954b31296b610a8a9ea827bea95f0a..7508720f824df8c4eeadd57f225c1daa7894d2b5 100644 (file)
@@ -18,14 +18,7 @@ enum {
        Timer = 0,                              // Alt channels.
        Unsent = 1,
        Maxto = 24 * 3600,                      // A full day to reconnect.
-};
-
-typedef struct Endpoints Endpoints;
-struct Endpoints {
-       char    *lsys;
-       char    *lserv;
-       char    *rsys;
-       char    *rserv;
+       Hdrsz = 3*4,
 };
 
 typedef struct {
@@ -34,7 +27,7 @@ typedef struct {
        uchar   acked[4];       // Number of messages acked
 } Hdr;
 
-typedef struct t_Buf {
+typedef struct {
        Hdr     hdr;
        uchar   buf[Bufsize];
 } Buf;
@@ -43,7 +36,8 @@ static Channel        *unsent;
 static Channel *unacked;
 static Channel *empty;
 static int     netfd;
-static int     inmsg;
+static ulong   inmsg;
+static ulong   outmsg;
 static char    *devdir;
 static int     debug;
 static int     done;
@@ -51,6 +45,8 @@ static char   *dialstring;
 static int     maxto = Maxto;
 static char    *Logname = "aan";
 static int     client;
+static int     reader = -1;
+static int     lostsync;
 
 static Alt a[] = {
        /*      c       v        op   */
@@ -61,16 +57,10 @@ static Alt a[] = {
 
 static void            fromnet(void*);
 static void            fromclient(void*);
-static void            reconnect(int);
+static int             reconnect(int);
 static void            synchronize(void);
-static int             sendcommand(ulong, ulong);
-static void            showmsg(int, char *, Buf *);
 static int             writen(int, uchar *, int);
-static int             getport(char *);
-static void            dmessage(int, char *, ...);
 static void            timerproc(void *);
-static Endpoints*      getendpoints(char *);
-static void            freeendpoints(Endpoints *);
 
 static void
 usage(void)
@@ -79,6 +69,7 @@ usage(void)
        exits("usage");
 }
 
 static int
 catch(void *, char *s)
 {
@@ -92,35 +83,24 @@ catch(void *, char *s)
 static void*
 emalloc(int n)
 {
-       ulong pc;
+       uintptr pc;
        void *v;
 
        pc = getcallerpc(&n);
        v = malloc(n);
        if(v == nil)
-               sysfatal("Cannot allocate memory; pc=%lux", pc);
+               sysfatal("Cannot allocate memory; pc=%#p", pc);
        setmalloctag(v, pc);
        return v;
 }
 
-static char*
-estrdup(char *s)
-{
-       char *v;
-       int n;
-
-       n = strlen(s)+1;
-       v = emalloc(n);
-       memmove(v, s, n);
-       return v;
-}
-
 void
 threadmain(int argc, char **argv)
 {
        vlong synctime;
        int i, n, failed;
        Channel *timer;
+       Hdr hdr;
        Buf *b;
 
        ARGBEGIN {
@@ -155,8 +135,6 @@ threadmain(int argc, char **argv)
                dup(fd, 2);
        }
 
-       fmtinstall('F', fcallfmt);
-
        atnotify(catch, 1);
 
        /*
@@ -165,8 +143,7 @@ threadmain(int argc, char **argv)
         * long if there is some general connection problem
         * (like NAT).
         */
-       netfd = -1;
-       reconnect(60);
+       netfd = reconnect(60);
 
        unsent = chancreate(sizeof(Buf *), Nbuf);
        unacked = chancreate(sizeof(Buf *), Nbuf);
@@ -178,7 +155,8 @@ threadmain(int argc, char **argv)
        for (i = 0; i < Nbuf; i++)
                sendp(empty, emalloc(sizeof(Buf)));
 
-       if (proccreate(fromnet, nil, Stacksize) < 0)
+       reader = proccreate(fromnet, nil, Stacksize);
+       if (reader < 0)
                sysfatal("Cannot start fromnet; %r");
 
        if (proccreate(fromclient, nil, Stacksize) < 0)
@@ -191,59 +169,64 @@ threadmain(int argc, char **argv)
        a[Unsent].c = unsent;
        a[Unsent].v = &b;
 
+Restart:
        synctime = nsec() + Synctime;
        failed = 0;
+       lostsync = 0;
        while (!done) {
-               if (failed) {
+               if (netfd < 0 || failed) {
                        // Wait for the netreader to die.
                        while (netfd >= 0) {
-                               dmessage(1, "main; waiting for netreader to die\n");
+                               if(debug) fprint(2, "main; waiting for netreader to die\n");
+                               threadint(reader);
                                sleep(1000);
                        }
 
                        // the reader died; reestablish the world.
-                       reconnect(maxto);
+                       netfd = reconnect(maxto);
                        synchronize();
-                       failed = 0;
+                       goto Restart;
                }
 
-               if (nsec() >= synctime) {
-                       Hdr hdr;
+               switch (alt(a)) {
+               case Timer:
+                       if (netfd < 0 || nsec() < synctime)
+                               break;
 
                        PBIT32(hdr.nb, 0);
                        PBIT32(hdr.acked, inmsg);
                        PBIT32(hdr.msg, -1);
 
-                       if (writen(netfd, (uchar *)&hdr, sizeof(Hdr)) < 0) {
-                               dmessage(2, "main; writen failed; %r\n");
+                       if (writen(netfd, (uchar *)&hdr, Hdrsz) < 0) {
                                failed = 1;
                                continue;
                        }
-                       synctime = nsec() + Synctime;
-               }
 
-               switch (alt(a)) {
-               case Timer:
+                       if(++lostsync > 2){
+                               syslog(0, Logname, "connection seems hung up...");
+                               failed = 1;
+                               continue;
+                       }
+                       synctime = nsec() + Synctime;
                        break;
 
                case Unsent:
                        sendp(unacked, b);
 
-                       PBIT32(b->hdr.acked, inmsg);
+                       if (netfd < 0)
+                               break;
 
-                       if (writen(netfd, (uchar *)&b->hdr, sizeof(Hdr)) < 0) {
-                               dmessage(2, "main; writen failed; %r\n");
-                               failed = 1;
-                       }
+                       PBIT32(b->hdr.acked, inmsg);
 
-                       n = GBIT32(b->hdr.nb);
-                       if (writen(netfd, b->buf, n) < 0) {
-                               dmessage(2, "main; writen failed; %r\n");
+                       if (writen(netfd, (uchar *)&b->hdr, Hdrsz) < 0)
                                failed = 1;
+                       else {
+                               n = GBIT32(b->hdr.nb);
+                               if (writen(netfd, b->buf, n) < 0)
+                                       failed = 1;
+                               if (n == 0)
+                                       done = 1;
                        }
-
-                       if (n == 0)
-                               done = 1;
                        break;
                }
        }
@@ -255,23 +238,18 @@ threadmain(int argc, char **argv)
 static void
 fromclient(void*)
 {
-       static int outmsg;
        int n;
        Buf *b;
 
+       threadsetname("fromclient");
+
        do {
                b = recvp(empty);
                n = read(0, b->buf, Bufsize);
-               if (n <= 0) {
-                       if (n < 0)
-                               dmessage(2, "fromclient; Cannot read 9P message; %r\n");
-                       else
-                               dmessage(2, "fromclient; Client terminated\n");
+               if (n < 0)
                        n = 0;
-               }
                PBIT32(b->hdr.nb, n);
                PBIT32(b->hdr.msg, outmsg);
-               showmsg(1, "fromclient", b);
                sendp(unsent, b);
                outmsg++;
        } while(n > 0);
@@ -280,82 +258,83 @@ fromclient(void*)
 static void
 fromnet(void*)
 {
-       static int lastacked;
-       int n, m, len, acked;
+       extern void _threadnote(void *, char *);
+       ulong m, acked, lastacked = 0;
+       int n, len;
        Buf *b;
 
+       notify(_threadnote);
+
+       threadsetname("fromnet");
+
        b = emalloc(sizeof(Buf));
        while (!done) {
                while (netfd < 0) {
                        if(done)
                                return;
-                       dmessage(1, "fromnet; waiting for connection... (inmsg %d)\n", inmsg);
+                       if(debug) fprint(2, "fromnet; waiting for connection... (inmsg %lud)\n", inmsg);
                        sleep(1000);
                }
 
                // Read the header.
-               len = readn(netfd, (uchar *)&b->hdr, sizeof(Hdr));
+               len = readn(netfd, (uchar *)&b->hdr, Hdrsz);
                if (len <= 0) {
-                       if (len < 0)
-                               dmessage(1, "fromnet; (hdr) network failure; %r\n");
-                       else
-                               dmessage(1, "fromnet; (hdr) network closed\n");
+                       if (debug) {
+                               if (len < 0)
+                                       fprint(2, "fromnet; (hdr) network failure; %r\n");
+                               else
+                                       fprint(2, "fromnet; (hdr) network closed\n");
+                       }
                        close(netfd);
                        netfd = -1;
                        continue;
                }
+               lostsync = 0;   // reset timeout
                n = GBIT32(b->hdr.nb);
                m = GBIT32(b->hdr.msg);
                acked = GBIT32(b->hdr.acked);
-               dmessage(2, "fromnet: Got message, size %d, nb %d, msg %d, acked %d, lastacked %d\n",
-                       len, n, m, acked, lastacked);
-
                if (n == 0) {
-                       if (m >= 0) {
-                               dmessage(1, "fromnet; network closed\n");
-                               break;
-                       }
-                       continue;
-               }
-
-               if (n > Bufsize) {
-                       dmessage(1, "fromnet; message too big %d > %d\n", n, Bufsize);
+                       if (m == (ulong)-1)
+                               continue;
+                       if(debug) fprint(2, "fromnet; network closed\n");
+                       break;
+               } else if (n < 0 || n > Bufsize) {
+                       if(debug) fprint(2, "fromnet; message too big %d > %d\n", n, Bufsize);
                        break;
                }
 
                len = readn(netfd, b->buf, n);
                if (len <= 0 || len != n) {
                        if (len == 0)
-                               dmessage(1, "fromnet; network closed\n");
+                               if(debug) fprint(2, "fromnet; network closed\n");
                        else
-                               dmessage(1, "fromnet; network failure; %r\n");
+                               if(debug) fprint(2, "fromnet; network failure; %r\n");
                        close(netfd);
                        netfd = -1;
                        continue;
                }
 
-               if (m < inmsg) {
-                       dmessage(1, "fromnet; skipping message %d, currently at %d\n", m, inmsg);
+               if (m != inmsg) {
+                       if(debug) fprint(2, "fromnet; skipping message %lud, currently at %lud\n", m, inmsg);
                        continue;
                }                       
+               inmsg++;
 
                // Process the acked list.
-               while(lastacked != acked) {
+               while((long)(acked - lastacked) > 0) {
                        Buf *rb;
 
-                       rb = recvp(unacked);
+                       if((rb = recvp(unacked)) == nil)
+                               break;
                        m = GBIT32(rb->hdr.msg);
                        if (m != lastacked) {
-                               dmessage(1, "fromnet; rb %p, msg %d, lastacked %d\n", rb, m, lastacked);
+                               if(debug) fprint(2, "fromnet; rb %p, msg %lud, lastacked %lud\n", rb, m, lastacked);
                                sysfatal("fromnet; bug");
                        }
                        PBIT32(rb->hdr.msg, -1);
                        sendp(empty, rb);
                        lastacked++;
                } 
-               inmsg++;
-
-               showmsg(1, "fromnet", b);
 
                if (writen(1, b->buf, len) < 0) 
                        sysfatal("fromnet; cannot write to client; %r");
@@ -363,33 +342,32 @@ fromnet(void*)
        done = 1;
 }
 
-static void
+static int
 reconnect(int secs)
 {
+       NetConnInfo *nci;
        char ldir[40];
        int lcfd, fd;
 
        if (dialstring) {
                syslog(0, Logname, "dialing %s", dialstring);
                alarm(secs*1000);
-               while ((fd = dial(dialstring, nil, nil, nil)) < 0) {
+               while ((fd = dial(dialstring, nil, ldir, nil)) < 0) {
                        char err[32];
 
                        err[0] = '\0';
                        errstr(err, sizeof err);
                        if (strstr(err, "connection refused")) {
-                               dmessage(1, "reconnect; server died...\n");
+                               if(debug) fprint(2, "reconnect; server died...\n");
                                threadexitsall("server died...");
                        }
-                       dmessage(1, "reconnect: dialed %s; %s\n", dialstring, err);
+                       if(debug) fprint(2, "reconnect: dialed %s; %s\n", dialstring, err);
                        sleep(1000);
                }
                alarm(0);
                syslog(0, Logname, "reconnected to %s", dialstring);
        } 
        else {
-               Endpoints *ep;
-
                syslog(0, Logname, "waiting for connection on %s", devdir);
                alarm(secs*1000);
                if ((lcfd = listen(devdir, ldir)) < 0) 
@@ -398,15 +376,16 @@ reconnect(int secs)
                        sysfatal("reconnect; cannot accept; %r");
                alarm(0);
                close(lcfd);
-               
-               ep = getendpoints(ldir);
-               dmessage(1, "rsys '%s'\n", ep->rsys);
-               syslog(0, Logname, "connected from %s", ep->rsys);
-               freeendpoints(ep);
        }
-       
-       // Wakes up the netreader.
-       netfd = fd;
+
+       if(nci = getnetconninfo(ldir, fd)){
+               syslog(0, Logname, "connected from %s", nci->rsys);
+               threadsetname(client? "client %s %s" : "server %s %s", ldir, nci->rsys);
+               freenetconninfo(nci);
+       } else
+               syslog(0, Logname, "connected");
+
+       return fd;
 }
 
 static void
@@ -423,7 +402,7 @@ synchronize(void)
        tmp = chancreate(sizeof(Buf *), Nbuf);
        while ((b = nbrecvp(unacked)) != nil) {
                n = GBIT32(b->hdr.nb);
-               writen(netfd, (uchar *)&b->hdr, sizeof(Hdr));
+               writen(netfd, (uchar *)&b->hdr, Hdrsz);
                writen(netfd, b->buf, n);
                sendp(tmp, b);
        }
@@ -431,22 +410,6 @@ synchronize(void)
        unacked = tmp;
 }
 
-static void
-showmsg(int level, char *s, Buf *b)
-{
-       int n;
-
-       if (b == nil) {
-               dmessage(level, "%s; b == nil\n", s);
-               return;
-       }
-       n = GBIT32(b->hdr.nb);
-       dmessage(level, "%s;  (len %d) %X %X %X %X %X %X %X %X %X (%p)\n", s, n, 
-                       b->buf[0], b->buf[1], b->buf[2],
-                       b->buf[3], b->buf[4], b->buf[5],
-                       b->buf[6], b->buf[7], b->buf[8], b);
-}
-
 static int
 writen(int fd, uchar *buf, int nb)
 {
@@ -459,10 +422,9 @@ writen(int fd, uchar *buf, int nb)
                        return -1;
 
                if ((n = write(fd, buf, nb)) < 0) {
-                       dmessage(1, "writen; Write failed; %r\n");
+                       if(debug) fprint(2, "writen; Write failed; %r\n");
                        return -1;
                }
-               dmessage(2, "writen: wrote %d bytes\n", n);
 
                buf += n;
                nb -= n;
@@ -474,74 +436,11 @@ static void
 timerproc(void *x)
 {
        Channel *timer = x;
+
+       threadsetname("timer");
+
        while (!done) {
                sleep((Synctime / MS(1)) >> 1);
                sendp(timer, "timer");
        }
 }
-
-static void
-dmessage(int level, char *fmt, ...)
-{
-       va_list arg; 
-
-       if (level > debug) 
-               return;
-
-       va_start(arg, fmt);
-       vfprint(2, fmt, arg);
-       va_end(arg);
-}
-
-static void
-getendpoint(char *dir, char *file, char **sysp, char **servp)
-{
-       int fd, n;
-       char buf[128];
-       char *sys, *serv;
-
-       sys = serv = 0;
-
-       snprint(buf, sizeof buf, "%s/%s", dir, file);
-       fd = open(buf, OREAD);
-       if(fd >= 0){
-               n = read(fd, buf, sizeof(buf)-1);
-               if(n>0){
-                       buf[n-1] = 0;
-                       serv = strchr(buf, '!');
-                       if(serv){
-                               *serv++ = 0;
-                               serv = estrdup(serv);
-                       }
-                       sys = estrdup(buf);
-               }
-               close(fd);
-       }
-       if(serv == 0)
-               serv = estrdup("unknown");
-       if(sys == 0)
-               sys = estrdup("unknown");
-       *servp = serv;
-       *sysp = sys;
-}
-
-static Endpoints *
-getendpoints(char *dir)
-{
-       Endpoints *ep;
-
-       ep = emalloc(sizeof(*ep));
-       getendpoint(dir, "local", &ep->lsys, &ep->lserv);
-       getendpoint(dir, "remote", &ep->rsys, &ep->rserv);
-       return ep;
-}
-
-static void
-freeendpoints(Endpoints *ep)
-{
-       free(ep->lsys);
-       free(ep->rsys);
-       free(ep->lserv);
-       free(ep->rserv);
-       free(ep);
-}