use rustc_span::{symbol, BytePos, Pos, Span, DUMMY_SP};
use crate::attr::*;
-use crate::comment::{rewrite_comment, CodeCharKind, CommentCodeSlices};
+use crate::comment::{contains_comment, rewrite_comment, CodeCharKind, CommentCodeSlices};
use crate::config::Version;
use crate::config::{BraceStyle, Config};
use crate::coverage::transform_missing_snippet;
use crate::items::{
format_impl, format_trait, format_trait_alias, is_mod_decl, is_use_item,
- rewrite_associated_impl_type, rewrite_associated_type, rewrite_extern_crate,
- rewrite_opaque_impl_type, rewrite_opaque_type, rewrite_type_alias, FnBraceStyle, FnSig,
- StaticParts, StructParts,
+ rewrite_associated_impl_type, rewrite_extern_crate, rewrite_opaque_impl_type,
+ rewrite_opaque_type, rewrite_type_alias, FnBraceStyle, FnSig, StaticParts, StructParts,
};
use crate::macros::{macro_style, rewrite_macro, rewrite_macro_def, MacroPosition};
use crate::modules::Module;
use crate::syntux::session::ParseSess;
use crate::utils::{
self, contains_skip, count_newlines, depr_skip_annotation, format_unsafety, inner_attributes,
- last_line_width, mk_sp, ptr_vec_to_ref_vec, rewrite_ident, stmt_expr,
+ last_line_width, mk_sp, ptr_vec_to_ref_vec, rewrite_ident, starts_with_newline, stmt_expr,
};
use crate::{ErrorKind, FormatReport, FormattingError};
pub(crate) macro_rewrite_failure: bool,
pub(crate) report: FormatReport,
pub(crate) skip_context: SkipContext,
+ pub(crate) is_macro_def: bool,
}
impl<'a> Drop for FmtVisitor<'a> {
self.parse_sess.span_to_debug_info(stmt.span())
);
- // https://github.com/rust-lang/rust/issues/63679.
- let is_all_semicolons =
- |snippet: &str| snippet.chars().all(|c| c.is_whitespace() || c == ';');
- if is_all_semicolons(&self.snippet(stmt.span())) {
+ if stmt.is_empty() {
+ // If the statement is empty, just skip over it. Before that, make sure any comment
+ // snippet preceding the semicolon is picked up.
+ let snippet = self.snippet(mk_sp(self.last_pos, stmt.span().lo()));
+ let original_starts_with_newline = snippet
+ .find(|c| c != ' ')
+ .map_or(false, |i| starts_with_newline(&snippet[i..]));
+ let snippet = snippet.trim();
+ if !snippet.is_empty() {
+ if original_starts_with_newline {
+ self.push_str("\n");
+ }
+ self.push_str(&self.block_indent.to_string(self.config));
+ self.push_str(snippet);
+ }
+
self.last_pos = stmt.span().hi();
return;
}
trimmed.is_empty() || trimmed.chars().all(|c| c == ';')
};
- for (kind, offset, sub_slice) in CommentCodeSlices::new(self.snippet(span)) {
+ let comment_snippet = self.snippet(span);
+
+ let align_to_right = if unindent_comment && contains_comment(&comment_snippet) {
+ let first_lines = comment_snippet.splitn(2, '/').next().unwrap_or("");
+ last_line_width(first_lines) > last_line_width(&comment_snippet)
+ } else {
+ false
+ };
+
+ for (kind, offset, sub_slice) in CommentCodeSlices::new(comment_snippet) {
let sub_slice = transform_missing_snippet(config, sub_slice);
debug!("close_block: {:?} {:?} {:?}", kind, offset, sub_slice);
match kind {
CodeCharKind::Comment => {
- if !unindented && unindent_comment {
+ if !unindented && unindent_comment && !align_to_right {
unindented = true;
self.block_indent = self.block_indent.block_unindent(config);
}
// Note that this only gets called for function definitions. Required methods
// on traits do not get handled here.
- fn visit_fn(
+ pub(crate) fn visit_fn(
&mut self,
fk: visit::FnKind<'_>,
generics: &ast::Generics,
ast::ItemKind::TyAlias(_, ref generics, ref generic_bounds, ref ty) => match ty {
Some(ty) => {
let rewrite = rewrite_type_alias(
- &self.get_context(),
- self.block_indent,
item.ident,
- &*ty,
+ Some(&*ty),
generics,
+ Some(generic_bounds),
+ &self.get_context(),
+ self.block_indent,
&item.vis,
+ item.span,
);
self.push_rewrite(item.span, rewrite);
}
generic_bounds,
generics,
&item.vis,
+ item.span,
);
self.push_rewrite(item.span, rewrite);
}
);
}
ast::AssocItemKind::TyAlias(_, ref generics, ref generic_bounds, ref type_default) => {
- let rewrite = rewrite_associated_type(
+ let rewrite = rewrite_type_alias(
ti.ident,
type_default.as_ref(),
generics,
Some(generic_bounds),
&self.get_context(),
self.block_indent,
+ &ti.vis,
+ ti.span,
);
self.push_rewrite(ti.span, rewrite);
}
let rewrite_associated = || {
rewrite_associated_impl_type(
ii.ident,
+ &ii.vis,
defaultness,
ty.as_ref(),
&generics,
&self.get_context(),
self.block_indent,
+ ii.span,
)
};
let rewrite = match ty {
snippet_provider,
line_number: 0,
skipped_range: Rc::new(RefCell::new(vec![])),
+ is_macro_def: false,
macro_rewrite_failure: false,
report,
skip_context: Default::default(),
);
} else {
match &attr.kind {
- ast::AttrKind::Normal(ref attribute_item)
+ ast::AttrKind::Normal(ref attribute_item, _)
if self.is_unknown_rustfmt_attr(&attribute_item.path.segments) =>
{
let file_name = self.parse_sess.span_to_filename(attr.span);
force_one_line_chain: Cell::new(false),
snippet_provider: self.snippet_provider,
macro_rewrite_failure: Cell::new(false),
+ is_macro_def: self.is_macro_def,
report: self.report.clone(),
skip_context: self.skip_context.clone(),
skipped_range: self.skipped_range.clone(),