]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/util/container.h
Merge pull request #59 from PrairieAstronomer/readme_irrlicht_change
[dragonfireclient.git] / src / util / container.h
index 267d54c16632cce645aee9df2db856b831d3cc0e..00106656393424d5b8362f2110d3ee23a4de8285 100644 (file)
@@ -17,14 +17,12 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
-#ifndef UTIL_CONTAINER_HEADER
-#define UTIL_CONTAINER_HEADER
-
-#include "../irrlichttypes.h"
-#include "../exceptions.h"
-#include "../jthread/jmutex.h"
-#include "../jthread/jmutexautolock.h"
-#include "../jthread/jsemaphore.h"
+#pragma once
+
+#include "irrlichttypes.h"
+#include "exceptions.h"
+#include "threading/mutex_auto_lock.h"
+#include "threading/semaphore.h"
 #include <list>
 #include <vector>
 #include <map>
@@ -81,111 +79,44 @@ template<typename Key, typename Value>
 class MutexedMap
 {
 public:
-       MutexedMap()
-       {
-       }
+       MutexedMap() = default;
 
        void set(const Key &name, const Value &value)
        {
-               JMutexAutoLock lock(m_mutex);
-
+               MutexAutoLock lock(m_mutex);
                m_values[name] = value;
        }
 
-       bool get(const Key &name, Value *result)
+       bool get(const Key &name, Value *result) const
        {
-               JMutexAutoLock lock(m_mutex);
-
-               typename std::map<Key, Value>::iterator n;
-               n = m_values.find(name);
-
-               if(n == m_values.end())
+               MutexAutoLock lock(m_mutex);
+               auto n = m_values.find(name);
+               if (n == m_values.end())
                        return false;
-
-               if(result != NULL)
+               if (result)
                        *result = n->second;
-
                return true;
        }
 
-       std::vector<Value> getValues()
+       std::vector<Value> getValues() const
        {
+               MutexAutoLock lock(m_mutex);
                std::vector<Value> result;
-               for(typename std::map<Key, Value>::iterator
-                       i = m_values.begin();
-                       i != m_values.end(); ++i){
-                       result.push_back(i->second);
-               }
+               result.reserve(m_values.size());
+               for (auto it = m_values.begin(); it != m_values.end(); ++it)
+                       result.push_back(it->second);
                return result;
        }
 
-       void clear ()
-       {
-               m_values.clear();
-       }
+       void clear() { m_values.clear(); }
 
 private:
        std::map<Key, Value> m_values;
-       JMutex m_mutex;
+       mutable std::mutex m_mutex;
 };
 
-/*
-Generates ids for comparable values.
-Id=0 is reserved for "no value".
 
-Is fast at:
-- Returning value by id (very fast)
-- Returning id by value
-- Generating a new id for a value
-
-Is not able to:
-- Remove an id/value pair (is possible to implement but slow)
-*/
-template<typename T>
-class MutexedIdGenerator
-{
-public:
-       MutexedIdGenerator()
-       {
-       }
-
-       // Returns true if found
-       bool getValue(u32 id, T &value)
-       {
-               if(id == 0)
-                       return false;
-               JMutexAutoLock lock(m_mutex);
-               if(m_id_to_value.size() < id)
-                       return false;
-               value = m_id_to_value[id-1];
-               return true;
-       }
-
-       // If id exists for value, returns the id.
-       // Otherwise generates an id for the value.
-       u32 getId(const T &value)
-       {
-               JMutexAutoLock lock(m_mutex);
-               typename std::map<T, u32>::iterator n;
-               n = m_value_to_id.find(value);
-               if(n != m_value_to_id.end())
-                       return n->second;
-               m_id_to_value.push_back(value);
-               u32 new_id = m_id_to_value.size();
-               m_value_to_id.insert(value, new_id);
-               return new_id;
-       }
-
-private:
-       JMutex m_mutex;
-       // Values are stored here at id-1 position (id 1 = [0])
-       std::vector<T> m_id_to_value;
-       std::map<T, u32> m_value_to_id;
-};
-
-/*
-Thread-safe FIFO queue (well, actually a FILO also)
-*/
+// Thread-safe Double-ended queue
 
 template<typename T>
 class MutexedQueue
@@ -194,19 +125,26 @@ class MutexedQueue
        template<typename Key, typename U, typename Caller, typename CallerData>
        friend class RequestQueue;
 
-       MutexedQueue()
+       MutexedQueue() = default;
+
+       bool empty() const
        {
+               MutexAutoLock lock(m_mutex);
+               return m_queue.empty();
        }
-       bool empty()
+
+       void push_back(const T &t)
        {
-               JMutexAutoLock lock(m_mutex);
-               return (m_queue.size() == 0);
+               MutexAutoLock lock(m_mutex);
+               m_queue.push_back(t);
+               m_signal.post();
        }
-       void push_back(T t)
+
+       void push_back(T &&t)
        {
-               JMutexAutoLock lock(m_mutex);
-               m_queue.push_back(t);
-               m_size.Post();
+               MutexAutoLock lock(m_mutex);
+               m_queue.push_back(std::move(t));
+               m_signal.post();
        }
 
        /* this version of pop_front returns a empty element of T on timeout.
@@ -214,99 +152,89 @@ class MutexedQueue
        */
        T pop_frontNoEx(u32 wait_time_max_ms)
        {
-               if (m_size.Wait(wait_time_max_ms)) {
-                       JMutexAutoLock lock(m_mutex);
+               if (m_signal.wait(wait_time_max_ms)) {
+                       MutexAutoLock lock(m_mutex);
 
-                       T t = m_queue.front();
+                       T t = std::move(m_queue.front());
                        m_queue.pop_front();
                        return t;
                }
-               else {
-                       return T();
-               }
+
+               return T();
        }
 
        T pop_front(u32 wait_time_max_ms)
        {
-               if (m_size.Wait(wait_time_max_ms)) {
-                       JMutexAutoLock lock(m_mutex);
+               if (m_signal.wait(wait_time_max_ms)) {
+                       MutexAutoLock lock(m_mutex);
 
-                       T t = m_queue.front();
+                       T t = std::move(m_queue.front());
                        m_queue.pop_front();
                        return t;
                }
-               else {
-                       throw ItemNotFoundException("MutexedQueue: queue is empty");
-               }
+
+               throw ItemNotFoundException("MutexedQueue: queue is empty");
        }
 
        T pop_frontNoEx()
        {
-               m_size.Wait();
+               m_signal.wait();
 
-               JMutexAutoLock lock(m_mutex);
+               MutexAutoLock lock(m_mutex);
 
-               T t = m_queue.front();
+               T t = std::move(m_queue.front());
                m_queue.pop_front();
                return t;
        }
 
        T pop_back(u32 wait_time_max_ms=0)
        {
-               if (m_size.Wait(wait_time_max_ms)) {
-                       JMutexAutoLock lock(m_mutex);
+               if (m_signal.wait(wait_time_max_ms)) {
+                       MutexAutoLock lock(m_mutex);
 
-                       T t = m_queue.back();
+                       T t = std::move(m_queue.back());
                        m_queue.pop_back();
                        return t;
                }
-               else {
-                       throw ItemNotFoundException("MutexedQueue: queue is empty");
-               }
+
+               throw ItemNotFoundException("MutexedQueue: queue is empty");
        }
 
        /* this version of pop_back returns a empty element of T on timeout.
        * Make sure default constructor of T creates a recognizable "empty" element
        */
-       T pop_backNoEx(u32 wait_time_max_ms=0)
+       T pop_backNoEx(u32 wait_time_max_ms)
        {
-               if (m_size.Wait(wait_time_max_ms)) {
-                       JMutexAutoLock lock(m_mutex);
+               if (m_signal.wait(wait_time_max_ms)) {
+                       MutexAutoLock lock(m_mutex);
 
-                       T t = m_queue.back();
+                       T t = std::move(m_queue.back());
                        m_queue.pop_back();
                        return t;
                }
-               else {
-                       return T();
-               }
+
+               return T();
        }
 
        T pop_backNoEx()
        {
-               m_size.Wait();
+               m_signal.wait();
 
-               JMutexAutoLock lock(m_mutex);
+               MutexAutoLock lock(m_mutex);
 
-               T t = m_queue.back();
+               T t = std::move(m_queue.back());
                m_queue.pop_back();
                return t;
        }
 
 protected:
-       JMutex & getMutex()
-       {
-               return m_mutex;
-       }
+       std::mutex &getMutex() { return m_mutex; }
 
-       std::deque<T> & getQueue()
-       {
-               return m_queue;
-       }
+       std::deque<T> &getQueue() { return m_queue; }
 
        std::deque<T> m_queue;
-       JMutex m_mutex;
-       JSemaphore m_size;
+       mutable std::mutex m_mutex;
+       Semaphore m_signal;
 };
 
 template<typename K, typename V>
@@ -377,6 +305,3 @@ class LRUCache
        // we can't use std::deque here, because its iterators get invalidated
        std::list<K> m_queue;
 };
-
-#endif
-