#![allow(clippy::stable_sort_primitive)]
use std::cell::Ref;
-use std::cmp::Reverse;
fn unnecessary_sort_by() {
fn id(x: isize) -> isize {
vec.sort_unstable_by_key(|a| id(-a));
// Reverse examples
vec.sort_by(|a, b| b.cmp(a)); // not linted to avoid suggesting `Reverse(b)` which would borrow
- vec.sort_by_key(|b| Reverse((b + 5).abs()));
- vec.sort_unstable_by_key(|b| Reverse(id(-b)));
+ vec.sort_by_key(|b| std::cmp::Reverse((b + 5).abs()));
+ vec.sort_unstable_by_key(|b| std::cmp::Reverse(id(-b)));
// Negative examples (shouldn't be changed)
let c = &7;
vec.sort_by(|a, b| (b - a).cmp(&(a - b)));
// The closure parameter is not dereferenced anymore, so non-Copy types can be linted
mod issue_6001 {
- use super::*;
struct Test(String);
impl Test {
args.sort_by_key(|a| a.name());
args.sort_unstable_by_key(|a| a.name());
// Reverse
- args.sort_by_key(|b| Reverse(b.name()));
- args.sort_unstable_by_key(|b| Reverse(b.name()));
+ args.sort_by_key(|b| std::cmp::Reverse(b.name()));
+ args.sort_unstable_by_key(|b| std::cmp::Reverse(b.name()));
}
}