-use crate::utils::{match_def_path, paths, span_lint, span_lint_and_help};
+use clippy_utils::diagnostics::{span_lint, span_lint_and_help};
+use clippy_utils::{match_def_path, paths};
use if_chain::if_chain;
use rustc_hir::{BinOpKind, Expr, ExprKind};
use rustc_lint::{LateContext, LateLintPass};
use rustc_session::{declare_lint_pass, declare_tool_lint};
declare_clippy_lint! {
- /// **What it does:** Checks for comparisons with an address of a function item.
+ /// ### What it does
+ /// Checks for comparisons with an address of a function item.
///
- /// **Why is this bad?** Function item address is not guaranteed to be unique and could vary
+ /// ### Why is this bad?
+ /// Function item address is not guaranteed to be unique and could vary
/// between different code generation units. Furthermore different function items could have
/// the same address after being merged together.
///
- /// **Known problems:** None.
- ///
- /// **Example:**
- ///
+ /// ### Example
/// ```rust
/// type F = fn();
/// fn a() {}
}
declare_clippy_lint! {
- /// **What it does:** Checks for comparisons with an address of a trait vtable.
+ /// ### What it does
+ /// Checks for comparisons with an address of a trait vtable.
///
- /// **Why is this bad?** Comparing trait objects pointers compares an vtable addresses which
+ /// ### Why is this bad?
+ /// Comparing trait objects pointers compares an vtable addresses which
/// are not guaranteed to be unique and could vary between different code generation units.
/// Furthermore vtables for different types could have the same address after being merged
/// together.
///
- /// **Known problems:** None.
- ///
- /// **Example:**
- ///
+ /// ### Example
/// ```rust,ignore
/// let a: Rc<dyn Trait> = ...
/// let b: Rc<dyn Trait> = ...
}
if_chain! {
- if let ExprKind::Binary(binop, ref left, ref right) = expr.kind;
+ if let ExprKind::Binary(binop, left, right) = expr.kind;
if is_comparison(binop.node);
if is_trait_ptr(cx, left) && is_trait_ptr(cx, right);
then {
}
if_chain! {
- if let ExprKind::Call(ref func, [ref _left, ref _right]) = expr.kind;
+ if let ExprKind::Call(func, [ref _left, ref _right]) = expr.kind;
if let ExprKind::Path(ref func_qpath) = func.kind;
if let Some(def_id) = cx.qpath_res(func_qpath, func.hir_id).opt_def_id();
if match_def_path(cx, def_id, &paths::PTR_EQ) ||
}
if_chain! {
- if let ExprKind::Binary(binop, ref left, ref right) = expr.kind;
+ if let ExprKind::Binary(binop, left, right) = expr.kind;
if is_comparison(binop.node);
- if cx.typeck_results().expr_ty_adjusted(left).is_fn_ptr() &&
- cx.typeck_results().expr_ty_adjusted(right).is_fn_ptr();
+ if cx.typeck_results().expr_ty_adjusted(left).is_fn_ptr();
+ if cx.typeck_results().expr_ty_adjusted(right).is_fn_ptr();
if is_fn_def(cx, left) || is_fn_def(cx, right);
then {
span_lint(