use clippy_utils::source::{first_line_of_span, is_present_in_source, snippet_opt, without_block_comments};
use clippy_utils::{extract_msrv_attr, meets_msrv};
use if_chain::if_chain;
-use rustc_ast::{AttrKind, AttrStyle, Attribute, Lit, LitKind, MacArgs, MacArgsEq, MetaItemKind, NestedMetaItem};
+use rustc_ast::{AttrKind, AttrStyle, Attribute, Lit, LitKind, MetaItemKind, NestedMetaItem};
use rustc_errors::Applicability;
use rustc_hir::{
Block, Expr, ExprKind, ImplItem, ImplItemKind, Item, ItemKind, StmtKind, TraitFn, TraitItem, TraitItemKind,
///
/// ### Example
/// ```ignore
- /// // Bad
/// #[deny(dead_code)]
/// extern crate foo;
/// #[forbid(dead_code)]
/// use foo::bar;
+ /// ```
///
- /// // Ok
+ /// Use instead:
+ /// ```rust,ignore
/// #[allow(unused_imports)]
/// use foo::baz;
/// #[allow(unused_imports)]
///
/// ### Example
/// ```rust
+ /// #[allow(dead_code)]
+ ///
+ /// fn not_quite_good_code() { }
+ /// ```
+ ///
+ /// Use instead:
+ /// ```rust
/// // Good (as inner attribute)
/// #![allow(dead_code)]
///
/// fn this_is_fine() { }
///
- /// // Bad
- /// #[allow(dead_code)]
- ///
- /// fn not_quite_good_code() { }
+ /// // or
///
/// // Good (as outer attribute)
/// #[allow(dead_code)]
/// These lints should only be enabled on a lint-by-lint basis and with careful consideration.
///
/// ### Example
- /// Bad:
/// ```rust
/// #![deny(clippy::restriction)]
/// ```
///
- /// Good:
+ /// Use instead:
/// ```rust
/// #![deny(clippy::as_conversions)]
/// ```
/// [#3123](https://github.com/rust-lang/rust-clippy/pull/3123#issuecomment-422321765)
///
/// ### Example
- /// Bad:
/// ```rust
/// #[cfg_attr(rustfmt, rustfmt_skip)]
/// fn main() { }
/// ```
///
- /// Good:
+ /// Use instead:
/// ```rust
/// #[rustfmt::skip]
/// fn main() { }
/// by the conditional compilation engine.
///
/// ### Example
- /// Bad:
/// ```rust
/// #[cfg(linux)]
/// fn conditional() { }
/// ```
///
- /// Good:
+ /// Use instead:
/// ```rust
+ /// # mod hidden {
/// #[cfg(target_os = "linux")]
/// fn conditional() { }
- /// ```
+ /// # }
+ ///
+ /// // or
///
- /// Or:
- /// ```rust
/// #[cfg(unix)]
/// fn conditional() { }
/// ```
/// ensure that others understand the reasoning
///
/// ### Example
- /// Bad:
/// ```rust
/// #![feature(lint_reasons)]
///
/// #![allow(clippy::some_lint)]
/// ```
///
- /// Good:
+ /// Use instead:
/// ```rust
/// #![feature(lint_reasons)]
///
}
fn check_empty_line_after_outer_attr(cx: &EarlyContext<'_>, item: &rustc_ast::Item) {
- for attr in &item.attrs {
- let attr_item = if let AttrKind::Normal(ref attr, _) = attr.kind {
- attr
- } else {
- return;
- };
-
- if attr.style == AttrStyle::Outer {
- if let MacArgs::Eq(_, MacArgsEq::Ast(expr)) = &attr_item.args
- && !matches!(expr.kind, rustc_ast::ExprKind::Lit(..)) {
- return;
- }
- if attr_item.args.inner_tokens().is_empty() || !is_present_in_source(cx, attr.span) {
- return;
- }
-
+ let mut iter = item.attrs.iter().peekable();
+ while let Some(attr) = iter.next() {
+ if matches!(attr.kind, AttrKind::Normal(..))
+ && attr.style == AttrStyle::Outer
+ && is_present_in_source(cx, attr.span)
+ {
let begin_of_attr_to_item = Span::new(attr.span.lo(), item.span.lo(), item.span.ctxt(), item.span.parent());
- let end_of_attr_to_item = Span::new(attr.span.hi(), item.span.lo(), item.span.ctxt(), item.span.parent());
+ let end_of_attr_to_next_attr_or_item = Span::new(
+ attr.span.hi(),
+ iter.peek().map_or(item.span.lo(), |next_attr| next_attr.span.lo()),
+ item.span.ctxt(),
+ item.span.parent(),
+ );
- if let Some(snippet) = snippet_opt(cx, end_of_attr_to_item) {
+ if let Some(snippet) = snippet_opt(cx, end_of_attr_to_next_attr_or_item) {
let lines = snippet.split('\n').collect::<Vec<_>>();
let lines = without_block_comments(lines);
fn check_deprecated_cfg_attr(cx: &EarlyContext<'_>, attr: &Attribute, msrv: Option<RustcVersion>) {
if_chain! {
- if meets_msrv(msrv.as_ref(), &msrvs::TOOL_ATTRIBUTES);
+ if meets_msrv(msrv, msrvs::TOOL_ATTRIBUTES);
// check cfg_attr
if attr.has_name(sym::cfg_attr);
if let Some(items) = attr.meta_item_list();
if feature_item.has_name(sym::rustfmt);
// check for `rustfmt_skip` and `rustfmt::skip`
if let Some(skip_item) = &items[1].meta_item();
- if skip_item.has_name(sym!(rustfmt_skip)) ||
- skip_item.path.segments.last().expect("empty path in attribute").ident.name == sym::skip;
+ if skip_item.has_name(sym!(rustfmt_skip))
+ || skip_item
+ .path
+ .segments
+ .last()
+ .expect("empty path in attribute")
+ .ident
+ .name
+ == sym::skip;
// Only lint outer attributes, because custom inner attributes are unstable
// Tracking issue: https://github.com/rust-lang/rust/issues/54726
if attr.style == AttrStyle::Outer;