warning: denote infinite loops with `loop { ... }`
- --> $DIR/suggestions.rs:46:5
+ --> $DIR/suggestions.rs:42:5
|
LL | while true {
| ^^^^^^^^^^ help: use `loop`
= note: `#[warn(while_true)]` on by default
warning: unnecessary parentheses around assigned value
- --> $DIR/suggestions.rs:49:31
+ --> $DIR/suggestions.rs:45:31
|
LL | let mut registry_no = (format!("NX-{}", 74205));
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
LL | #![warn(unused_mut, unused_parens)] // UI tests pass `-A unused`—see Issue #43896
| ^^^^^^^^^^^^^
-warning: use of deprecated attribute `no_debug`: the `#[no_debug]` attribute was an experimental feature that has been deprecated due to lack of demand. See https://github.com/rust-lang/rust/issues/29721
- --> $DIR/suggestions.rs:42:1
- |
-LL | #[no_debug] // should suggest removal of deprecated attribute
- | ^^^^^^^^^^^ help: remove this attribute
- |
- = note: `#[warn(deprecated)]` on by default
-
warning: variable does not need to be mutable
- --> $DIR/suggestions.rs:49:13
+ --> $DIR/suggestions.rs:45:13
|
LL | let mut registry_no = (format!("NX-{}", 74205));
| ----^^^^^^^^^^^
| ^^^^^^^^^^
warning: variable does not need to be mutable
- --> $DIR/suggestions.rs:55:13
+ --> $DIR/suggestions.rs:51:13
|
LL | let mut
| _____________^
| help: remove this `mut`
error: const items should never be `#[no_mangle]`
- --> $DIR/suggestions.rs:6:14
+ --> $DIR/suggestions.rs:5:14
|
LL | #[no_mangle] const DISCOVERY: usize = 1;
| -----^^^^^^^^^^^^^^^^^^^^^^
= note: `#[deny(no_mangle_const_items)]` on by default
warning: functions generic over types or consts must be mangled
- --> $DIR/suggestions.rs:12:1
+ --> $DIR/suggestions.rs:11:1
|
LL | #[no_mangle]
| ------------ help: remove this attribute
= note: `#[warn(no_mangle_generic_items)]` on by default
warning: the `warp_factor:` in this pattern is redundant
- --> $DIR/suggestions.rs:61:23
+ --> $DIR/suggestions.rs:57:23
|
LL | Equinox { warp_factor: warp_factor } => {}
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use shorthand field pattern: `warp_factor`
= note: `#[warn(non_shorthand_field_patterns)]` on by default
error: const items should never be `#[no_mangle]`
- --> $DIR/suggestions.rs:22:18
+ --> $DIR/suggestions.rs:21:18
|
LL | #[no_mangle] pub const DAUNTLESS: bool = true;
| ---------^^^^^^^^^^^^^^^^^^^^^^^^
| help: try a static value: `pub static`
warning: functions generic over types or consts must be mangled
- --> $DIR/suggestions.rs:25:18
+ --> $DIR/suggestions.rs:24:18
|
LL | #[no_mangle] pub fn val_jean<T>() {}
| ------------ ^^^^^^^^^^^^^^^^^^^^^^^
| help: remove this attribute
error: const items should never be `#[no_mangle]`
- --> $DIR/suggestions.rs:30:18
+ --> $DIR/suggestions.rs:29:18
|
LL | #[no_mangle] pub(crate) const VETAR: bool = true;
| ----------------^^^^^^^^^^^^^^^^^^^^
| help: try a static value: `pub static`
warning: functions generic over types or consts must be mangled
- --> $DIR/suggestions.rs:33:18
+ --> $DIR/suggestions.rs:32:18
|
LL | #[no_mangle] pub(crate) fn crossfield<T>() {}
| ------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^