Use std::vector instead of std::list in StaticObjectList and MutexedMap::getValues()

[minetest.git] / src / staticobject.h

diff --git a/src/staticobject.h b/src/staticobject.h
index c8427fe47bd74dc2995c840f43b20202ec4f86e8..4918a14663eb127c5227bb824e911332755aad64 100644 (file)
--- a/src/staticobject.h
+++ b/src/staticobject.h
@@ -23,6 +23,8 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "irrlichttypes_bloated.h"
 #include <string>
 #include <sstream>
+#include <vector>
+#include <map>
 #include "debug.h"
 
 struct StaticObject
@@ -52,7 +54,7 @@ class StaticObjectList
 public:
        /*
                Inserts an object to the container.
-               Id must be unique or 0.
+               Id must be unique (active) or 0 (stored).
        */
        void insert(u16 id, StaticObject obj)
        {
@@ -62,27 +64,27 @@ class StaticObjectList
                }
                else
                {
-                       if(m_active.find(id) != NULL)
+                       if(m_active.find(id) != m_active.end())
                        {
                                dstream<<"ERROR: StaticObjectList::insert(): "
                                                <<"id already exists"<<std::endl;
                                assert(0);
                                return;
                        }
-                       m_active.insert(id, obj);
+                       m_active[id] = obj;
                }
        }
 
        void remove(u16 id)
        {
                assert(id != 0);
-               if(m_active.find(id) == NULL)
+               if(m_active.find(id) == m_active.end())
                {
                        dstream<<"WARNING: StaticObjectList::remove(): id="<<id
                                        <<" not found"<<std::endl;
                        return;
                }
-               m_active.remove(id);
+               m_active.erase(id);
        }
 
        void serialize(std::ostream &os);
@@ -93,8 +95,8 @@ class StaticObjectList
                from m_stored and inserted to m_active.
                The caller directly manipulates these containers.
        */
-       core::list<StaticObject> m_stored;
-       core::map<u16, StaticObject> m_active;
+       std::vector<StaticObject> m_stored;
+       std::map<u16, StaticObject> m_active;
 
 private:
 };