Auto merge of #2183 - RalfJung:better-provenance-control, r=RalfJung

[rust.git] / src / shims / dlsym.rs

diff --git a/src/shims/dlsym.rs b/src/shims/dlsym.rs
index 1c2567b951ca0bc6c22a100d697a0e100c11183c..c5081582281bc3ef2dd89d723174b3c75560b4c5 100644 (file)
--- a/src/shims/dlsym.rs
+++ b/src/shims/dlsym.rs
@@ -1,49 +1,46 @@
-use rustc::mir;
+use rustc_middle::mir;
+use rustc_target::spec::abi::Abi;
 
 use crate::*;
+use shims::unix::dlsym as unix;
+use shims::windows::dlsym as windows;
 
 #[derive(Debug, Copy, Clone)]
+#[allow(non_camel_case_types)]
 pub enum Dlsym {
-    GetEntropy,
+    Posix(unix::Dlsym),
+    Windows(windows::Dlsym),
 }
 
 impl Dlsym {
-    pub fn from_str(name: &str) -> Option<Dlsym> {
-        use self::Dlsym::*;
-        Some(match name {
-            "getentropy" => GetEntropy,
-            _ => return None,
+    // Returns an error for unsupported symbols, and None if this symbol
+    // should become a NULL pointer (pretend it does not exist).
+    pub fn from_str<'tcx>(name: &[u8], target_os: &str) -> InterpResult<'tcx, Option<Dlsym>> {
+        let name = &*String::from_utf8_lossy(name);
+        Ok(match target_os {
+            "linux" | "macos" => unix::Dlsym::from_str(name, target_os)?.map(Dlsym::Posix),
+            "windows" => windows::Dlsym::from_str(name)?.map(Dlsym::Windows),
+            os => bug!("dlsym not implemented for target_os {}", os),
         })
     }
 }
 
-impl<'mir, 'tcx> EvalContextExt<'mir, 'tcx> for crate::MiriEvalContext<'mir, 'tcx> {}
+impl<'mir, 'tcx: 'mir> EvalContextExt<'mir, 'tcx> for crate::MiriEvalContext<'mir, 'tcx> {}
 pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx> {
     fn call_dlsym(
         &mut self,
         dlsym: Dlsym,
+        abi: Abi,
         args: &[OpTy<'tcx, Tag>],
-        dest: Option<PlaceTy<'tcx, Tag>>,
+        dest: &PlaceTy<'tcx, Tag>,
         ret: Option<mir::BasicBlock>,
     ) -> InterpResult<'tcx> {
-        use self::Dlsym::*;
-
         let this = self.eval_context_mut();
-
-        let dest = dest.expect("we don't support any diverging dlsym");
-        let ret = ret.expect("dest is `Some` but ret is `None`");
-        
         match dlsym {
-            GetEntropy => {
-                let ptr = this.read_scalar(args[0])?.not_undef()?;
-                let len = this.read_scalar(args[1])?.to_usize(this)?;
-                this.gen_random(len as usize, ptr)?;
-                this.write_null(dest)?;
-            }
+            Dlsym::Posix(dlsym) =>
+                unix::EvalContextExt::call_dlsym(this, dlsym, abi, args, dest, ret),
+            Dlsym::Windows(dlsym) =>
+                windows::EvalContextExt::call_dlsym(this, dlsym, abi, args, dest, ret),
         }
-
-        this.goto_block(Some(ret))?;
-        this.dump_place(*dest);
-        Ok(())
     }
 }