]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/serverenvironment.cpp
Trigger on_rightclick regardless on the formspec meta field
[dragonfireclient.git] / src / serverenvironment.cpp
index ecc7c31501256b07af0c5ad3af767c8474f42dac..2fb12692b75406a1cd470f4e80a5c2a3d79fdcf8 100644 (file)
@@ -28,14 +28,20 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "profiler.h"
 #include "raycast.h"
 #include "remoteplayer.h"
-#include "serverscripting.h"
+#include "scripting_server.h"
 #include "server.h"
-#include "voxelalgorithms.h"
 #include "util/serialize.h"
 #include "util/basic_macros.h"
 #include "util/pointedthing.h"
 #include "threading/mutex_auto_lock.h"
 #include "filesys.h"
+#include "gameparams.h"
+#include "database-dummy.h"
+#include "database-files.h"
+#include "database-sqlite3.h"
+#if USE_POSTGRESQL
+#include "database-postgresql.h"
+#endif
 
 #define LBM_NAME_ALLOWED_CHARS "abcdefghijklmnopqrstuvwxyz0123456789_:"
 
@@ -47,8 +53,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 */
 
 ABMWithState::ABMWithState(ActiveBlockModifier *abm_):
-       abm(abm_),
-       timer(0)
+       abm(abm_)
 {
        // Initialize timer to random value to spread processing
        float itv = abm->getTriggerInterval();
@@ -64,9 +69,8 @@ ABMWithState::ABMWithState(ActiveBlockModifier *abm_):
 
 void LBMContentMapping::deleteContents()
 {
-       for (std::vector<LoadingBlockModifierDef *>::iterator it = lbm_list.begin();
-               it != lbm_list.end(); ++it) {
-               delete *it;
+       for (auto &it : lbm_list) {
+               delete it;
        }
 }
 
@@ -78,24 +82,21 @@ void LBMContentMapping::addLBM(LoadingBlockModifierDef *lbm_def, IGameDef *gamed
 
        lbm_list.push_back(lbm_def);
 
-       for (std::set<std::string>::const_iterator it = lbm_def->trigger_contents.begin();
-               it != lbm_def->trigger_contents.end(); ++it) {
+       for (const std::string &nodeTrigger: lbm_def->trigger_contents) {
                std::set<content_t> c_ids;
-               bool found = nodedef->getIds(*it, c_ids);
+               bool found = nodedef->getIds(nodeTrigger, c_ids);
                if (!found) {
-                       content_t c_id = gamedef->allocateUnknownNodeId(*it);
+                       content_t c_id = gamedef->allocateUnknownNodeId(nodeTrigger);
                        if (c_id == CONTENT_IGNORE) {
                                // Seems it can't be allocated.
-                               warningstream << "Could not internalize node name \"" << *it
+                               warningstream << "Could not internalize node name \"" << nodeTrigger
                                        << "\" while loading LBM \"" << lbm_def->name << "\"." << std::endl;
                                continue;
                        }
                        c_ids.insert(c_id);
                }
 
-               for (std::set<content_t>::const_iterator iit =
-                       c_ids.begin(); iit != c_ids.end(); ++iit) {
-                       content_t c_id = *iit;
+               for (content_t c_id : c_ids) {
                        map[c_id].push_back(lbm_def);
                }
        }
@@ -104,7 +105,7 @@ void LBMContentMapping::addLBM(LoadingBlockModifierDef *lbm_def, IGameDef *gamed
 const std::vector<LoadingBlockModifierDef *> *
 LBMContentMapping::lookup(content_t c) const
 {
-       container_map::const_iterator it = map.find(c);
+       lbm_map::const_iterator it = map.find(c);
        if (it == map.end())
                return NULL;
        // This first dereferences the iterator, returning
@@ -115,13 +116,12 @@ LBMContentMapping::lookup(content_t c) const
 
 LBMManager::~LBMManager()
 {
-       for (std::map<std::string, LoadingBlockModifierDef *>::iterator it =
-               m_lbm_defs.begin(); it != m_lbm_defs.end(); ++it) {
-               delete it->second;
+       for (auto &m_lbm_def : m_lbm_defs) {
+               delete m_lbm_def.second;
        }
-       for (lbm_lookup_map::iterator it = m_lbm_lookup.begin();
-               it != m_lbm_lookup.end(); ++it) {
-               (it->second).deleteContents();
+
+       for (auto &it : m_lbm_lookup) {
+               (it.second).deleteContents();
        }
 }
 
@@ -134,7 +134,7 @@ void LBMManager::addLBMDef(LoadingBlockModifierDef *lbm_def)
        if (!string_allowed(lbm_def->name, LBM_NAME_ALLOWED_CHARS)) {
                throw ModError("Error adding LBM \"" + lbm_def->name +
                        "\": Does not follow naming conventions: "
-                               "Only chararacters [a-z0-9_:] are allowed.");
+                               "Only characters [a-z0-9_:] are allowed.");
        }
 
        m_lbm_defs[lbm_def->name] = lbm_def;
@@ -207,12 +207,11 @@ void LBMManager::loadIntroductionTimes(const std::string &times,
        LBMContentMapping &lbms_we_introduce_now = m_lbm_lookup[now];
        LBMContentMapping &lbms_running_always = m_lbm_lookup[U32_MAX];
 
-       for (std::map<std::string, LoadingBlockModifierDef *>::iterator it =
-               m_lbm_defs.begin(); it != m_lbm_defs.end(); ++it) {
-               if (it->second->run_at_every_load) {
-                       lbms_running_always.addLBM(it->second, gamedef);
+       for (auto &m_lbm_def : m_lbm_defs) {
+               if (m_lbm_def.second->run_at_every_load) {
+                       lbms_running_always.addLBM(m_lbm_def.second, gamedef);
                } else {
-                       lbms_we_introduce_now.addLBM(it->second, gamedef);
+                       lbms_we_introduce_now.addLBM(m_lbm_def.second, gamedef);
                }
        }
 
@@ -228,18 +227,16 @@ std::string LBMManager::createIntroductionTimesString()
                "attempted to query on non fully set up LBMManager");
 
        std::ostringstream oss;
-       for (lbm_lookup_map::iterator it = m_lbm_lookup.begin();
-               it != m_lbm_lookup.end(); ++it) {
-               u32 time = it->first;
-               std::vector<LoadingBlockModifierDef *> &lbm_list = it->second.lbm_list;
-               for (std::vector<LoadingBlockModifierDef *>::iterator iit = lbm_list.begin();
-                       iit != lbm_list.end(); ++iit) {
+       for (const auto &it : m_lbm_lookup) {
+               u32 time = it.first;
+               const std::vector<LoadingBlockModifierDef *> &lbm_list = it.second.lbm_list;
+               for (const auto &lbm_def : lbm_list) {
                        // Don't add if the LBM runs at every load,
                        // then introducement time is hardcoded
                        // and doesn't need to be stored
-                       if ((*iit)->run_at_every_load)
+                       if (lbm_def->run_at_every_load)
                                continue;
-                       oss << (*iit)->name << "~" << time << ";";
+                       oss << lbm_def->name << "~" << time << ";";
                }
        }
        return oss.str();
@@ -267,9 +264,8 @@ void LBMManager::applyLBMs(ServerEnvironment *env, MapBlock *block, u32 stamp)
                                                iit->second.lookup(c);
                                        if (!lbm_list)
                                                continue;
-                                       for (std::vector<LoadingBlockModifierDef *>::const_iterator iit =
-                                               lbm_list->begin(); iit != lbm_list->end(); ++iit) {
-                                               (*iit)->trigger(env, pos + pos_of_block, n);
+                                       for (auto lbmdef : *lbm_list) {
+                                               lbmdef->trigger(env, pos + pos_of_block, n);
                                        }
                                }
                        }
@@ -353,19 +349,34 @@ void ActiveBlockList::update(std::vector<v3s16> &active_positions,
 
 ServerEnvironment::ServerEnvironment(ServerMap *map,
        ServerScripting *scriptIface, Server *server,
-       const std::string &path_world) :
+       const std::string &path_world):
+       Environment(server),
        m_map(map),
        m_script(scriptIface),
        m_server(server),
-       m_path_world(path_world),
-       m_send_recommended_timer(0),
-       m_active_block_interval_overload_skip(0),
-       m_game_time(0),
-       m_game_time_fraction_counter(0),
-       m_last_clear_objects_time(0),
-       m_recommended_send_interval(0.1),
-       m_max_lag_estimate(0.1)
+       m_path_world(path_world)
 {
+       // Determine which database backend to use
+       std::string conf_path = path_world + DIR_DELIM + "world.mt";
+       Settings conf;
+       bool succeeded = conf.readConfigFile(conf_path.c_str());
+       if (!succeeded || !conf.exists("player_backend")) {
+               // fall back to files
+               conf.set("player_backend", "files");
+               warningstream << "/!\\ You are using old player file backend. "
+                               << "This backend is deprecated and will be removed in next release /!\\"
+                               << std::endl << "Switching to SQLite3 or PostgreSQL is advised, "
+                               << "please read http://wiki.minetest.net/Database_backends." << std::endl;
+
+               if (!conf.updateConfigFile(conf_path.c_str())) {
+                       errorstream << "ServerEnvironment::ServerEnvironment(): "
+                               << "Failed to update world.mt!" << std::endl;
+               }
+       }
+
+       std::string name = "";
+       conf.getNoEx("player_backend", name);
+       m_player_database = openPlayerDatabase(name, path_world, conf);
 }
 
 ServerEnvironment::~ServerEnvironment()
@@ -391,6 +402,8 @@ ServerEnvironment::~ServerEnvironment()
                i != m_players.end(); ++i) {
                delete (*i);
        }
+
+       delete m_player_database;
 }
 
 Map & ServerEnvironment::getMap()
@@ -454,6 +467,11 @@ void ServerEnvironment::removePlayer(RemotePlayer *player)
        }
 }
 
+bool ServerEnvironment::removePlayerFromDatabase(const std::string &name)
+{
+       return m_player_database->removePlayer(name);
+}
+
 bool ServerEnvironment::line_of_sight(v3f pos1, v3f pos2, float stepsize, v3s16 *p)
 {
        float distance = pos1.getDistanceFrom(pos2);
@@ -494,7 +512,7 @@ void ServerEnvironment::kickAllPlayers(AccessDeniedCode reason,
 
 void ServerEnvironment::saveLoadedPlayers()
 {
-       std::string players_path = m_path_world + DIR_DELIM "players";
+       std::string players_path = m_path_world + DIR_DELIM "players";
        fs::CreateDir(players_path);
 
        for (std::vector<RemotePlayer *>::iterator it = m_players.begin();
@@ -502,63 +520,64 @@ void ServerEnvironment::saveLoadedPlayers()
                ++it) {
                if ((*it)->checkModified() ||
                        ((*it)->getPlayerSAO() && (*it)->getPlayerSAO()->extendedAttributesModified())) {
-                       (*it)->save(players_path, m_server);
+                       try {
+                               m_player_database->savePlayer(*it);
+                       } catch (DatabaseException &e) {
+                               errorstream << "Failed to save player " << (*it)->getName() << " exception: "
+                                       << e.what() << std::endl;
+                               throw;
+                       }
                }
        }
 }
 
 void ServerEnvironment::savePlayer(RemotePlayer *player)
 {
-       std::string players_path = m_path_world + DIR_DELIM "players";
-       fs::CreateDir(players_path);
-
-       player->save(players_path, m_server);
+       try {
+               m_player_database->savePlayer(player);
+       } catch (DatabaseException &e) {
+               errorstream << "Failed to save player " << player->getName() << " exception: "
+                       << e.what() << std::endl;
+               throw;
+       }
 }
 
-RemotePlayer *ServerEnvironment::loadPlayer(const std::string &playername, PlayerSAO *sao)
+PlayerSAO *ServerEnvironment::loadPlayer(RemotePlayer *player, bool *new_player,
+       u16 peer_id, bool is_singleplayer)
 {
-       bool newplayer = false;
-       bool found = false;
-       std::string players_path = m_path_world + DIR_DELIM "players" DIR_DELIM;
-       std::string path = players_path + playername;
-
-       RemotePlayer *player = getPlayer(playername.c_str());
-       if (!player) {
-               player = new RemotePlayer("", m_server->idef());
-               newplayer = true;
-       }
-
-       for (u32 i = 0; i < PLAYER_FILE_ALTERNATE_TRIES; i++) {
-               //// Open file and deserialize
-               std::ifstream is(path.c_str(), std::ios_base::binary);
-               if (!is.good())
-                       continue;
-
-               player->deSerialize(is, path, sao);
-               is.close();
-
-               if (player->getName() == playername) {
-                       found = true;
-                       break;
+       PlayerSAO *playersao = new PlayerSAO(this, player, peer_id, is_singleplayer);
+       // Create player if it doesn't exist
+       if (!m_player_database->loadPlayer(player, playersao)) {
+               *new_player = true;
+               // Set player position
+               infostream << "Server: Finding spawn place for player \""
+                       << player->getName() << "\"" << std::endl;
+               playersao->setBasePosition(m_server->findSpawnPos());
+
+               // Make sure the player is saved
+               player->setModified(true);
+       } else {
+               // If the player exists, ensure that they respawn inside legal bounds
+               // This fixes an assert crash when the player can't be added
+               // to the environment
+               ServerMap &map = getServerMap();
+               if (map.getMapgenParams()->saoPosOverLimit(playersao->getBasePosition())) {
+                       actionstream << "Respawn position for player \""
+                               << player->getName() << "\" outside limits, resetting" << std::endl;
+                       playersao->setBasePosition(m_server->findSpawnPos());
                }
-
-               path = players_path + playername + itos(i);
        }
 
-       if (!found) {
-               infostream << "Player file for player " << playername
-                       << " not found" << std::endl;
-               if (newplayer)
-                       delete player;
+       // Add player to environment
+       addPlayer(player);
 
-               return NULL;
-       }
+       /* Clean up old HUD elements from previous sessions */
+       player->clearHud();
 
-       if (newplayer) {
-               addPlayer(player);
-       }
-       player->setModified(false);
-       return player;
+       /* Add object to environment */
+       addActiveObject(playersao);
+
+       return playersao;
 }
 
 void ServerEnvironment::saveMeta()
@@ -614,8 +633,8 @@ void ServerEnvironment::loadMeta()
        }
 
        setTimeOfDay(args.exists("time_of_day") ?
-               // set day to morning by default
-               args.getU64("time_of_day") : 9000);
+               // set day to early morning by default
+               args.getU64("time_of_day") : 5250);
 
        m_last_clear_objects_time = args.exists("last_clear_objects_time") ?
                // If missing, do as if clearObjects was never called
@@ -684,7 +703,7 @@ class ABMHandler
                                chance = 1;
                        ActiveABM aabm;
                        aabm.abm = abm;
-                       if(abm->getSimpleCatchUp()) {
+                       if (abm->getSimpleCatchUp()) {
                                float intervals = actual_interval / trigger_interval;
                                if(intervals == 0)
                                        continue;
@@ -694,25 +713,23 @@ class ABMHandler
                        } else {
                                aabm.chance = chance;
                        }
+
                        // Trigger neighbors
-                       std::set<std::string> required_neighbors_s
-                               = abm->getRequiredNeighbors();
-                       for(std::set<std::string>::iterator
-                               i = required_neighbors_s.begin();
-                               i != required_neighbors_s.end(); ++i)
-                       {
-                               ndef->getIds(*i, aabm.required_neighbors);
+                       const std::set<std::string> &required_neighbors_s =
+                               abm->getRequiredNeighbors();
+                       for (std::set<std::string>::iterator rn = required_neighbors_s.begin();
+                                       rn != required_neighbors_s.end(); ++rn) {
+                               ndef->getIds(*rn, aabm.required_neighbors);
                        }
+
                        // Trigger contents
-                       std::set<std::string> contents_s = abm->getTriggerContents();
-                       for(std::set<std::string>::iterator
-                               i = contents_s.begin(); i != contents_s.end(); ++i)
-                       {
+                       const std::set<std::string> &contents_s = abm->getTriggerContents();
+                       for (std::set<std::string>::iterator cs = contents_s.begin();
+                                       cs != contents_s.end(); ++cs) {
                                std::set<content_t> ids;
-                               ndef->getIds(*i, ids);
-                               for(std::set<content_t>::const_iterator k = ids.begin();
-                                       k != ids.end(); ++k)
-                               {
+                               ndef->getIds(*cs, ids);
+                               for (std::set<content_t>::const_iterator k = ids.begin();
+                                               k != ids.end(); ++k) {
                                        content_t c = *k;
                                        if (c >= m_aabms.size())
                                                m_aabms.resize(c + 256, NULL);
@@ -964,9 +981,10 @@ bool ServerEnvironment::swapNode(v3s16 p, const MapNode &n)
        return true;
 }
 
-void ServerEnvironment::getObjectsInsideRadius(std::vector<u16> &objects, v3f pos, float radius)
+void ServerEnvironment::getObjectsInsideRadius(std::vector<u16> &objects, v3f pos,
+       float radius)
 {
-       for (ActiveObjectMap::iterator i = m_active_objects.begin();
+       for (ServerActiveObjectMap::iterator i = m_active_objects.begin();
                i != m_active_objects.end(); ++i) {
                ServerActiveObject* obj = i->second;
                u16 id = i->first;
@@ -982,7 +1000,7 @@ void ServerEnvironment::clearObjects(ClearObjectsMode mode)
        infostream << "ServerEnvironment::clearObjects(): "
                << "Removing all active objects" << std::endl;
        std::vector<u16> objects_to_remove;
-       for (ActiveObjectMap::iterator i = m_active_objects.begin();
+       for (ServerActiveObjectMap::iterator i = m_active_objects.begin();
                i != m_active_objects.end(); ++i) {
                ServerActiveObject* obj = i->second;
                if (obj->getType() == ACTIVEOBJECT_TYPE_PLAYER)
@@ -1132,7 +1150,8 @@ void ServerEnvironment::step(float dtime)
        // Update this one
        // NOTE: This is kind of funny on a singleplayer game, but doesn't
        // really matter that much.
-       static const float server_step = g_settings->getFloat("dedicated_server_step");
+       static thread_local const float server_step =
+                       g_settings->getFloat("dedicated_server_step");
        m_recommended_send_interval = server_step;
 
        /*
@@ -1150,17 +1169,13 @@ void ServerEnvironment::step(float dtime)
        */
        {
                ScopeProfiler sp(g_profiler, "SEnv: handle players avg", SPT_AVG);
-               for (std::vector<RemotePlayer *>::iterator i = m_players.begin();
-                       i != m_players.end(); ++i) {
-                       RemotePlayer *player = dynamic_cast<RemotePlayer *>(*i);
-                       assert(player);
-
+               for (RemotePlayer *player : m_players) {
                        // Ignore disconnected players
-                       if(player->peer_id == 0)
+                       if (player->peer_id == 0)
                                continue;
 
                        // Move
-                       player->move(dtime, this, 100*BS);
+                       player->move(dtime, this, 100 * BS);
                }
        }
 
@@ -1173,11 +1188,7 @@ void ServerEnvironment::step(float dtime)
                        Get player block positions
                */
                std::vector<v3s16> players_blockpos;
-               for (std::vector<RemotePlayer *>::iterator i = m_players.begin();
-                       i != m_players.end(); ++i) {
-                       RemotePlayer *player = dynamic_cast<RemotePlayer *>(*i);
-                       assert(player);
-
+               for (RemotePlayer *player: m_players) {
                        // Ignore disconnected players
                        if (player->peer_id == 0)
                                continue;
@@ -1185,15 +1196,15 @@ void ServerEnvironment::step(float dtime)
                        PlayerSAO *playersao = player->getPlayerSAO();
                        assert(playersao);
 
-                       v3s16 blockpos = getNodeBlockPos(
-                               floatToInt(playersao->getBasePosition(), BS));
-                       players_blockpos.push_back(blockpos);
+                       players_blockpos.push_back(
+                               getNodeBlockPos(floatToInt(playersao->getBasePosition(), BS)));
                }
 
                /*
                        Update list of active blocks, collecting changes
                */
-               static const s16 active_block_range = g_settings->getS16("active_block_range");
+               static thread_local const s16 active_block_range =
+                               g_settings->getS16("active_block_range");
                std::set<v3s16> blocks_removed;
                std::set<v3s16> blocks_added;
                m_active_blocks.update(players_blockpos, active_block_range,
@@ -1206,16 +1217,9 @@ void ServerEnvironment::step(float dtime)
                // Convert active objects that are no more in active blocks to static
                deactivateFarObjects(false);
 
-               for(std::set<v3s16>::iterator
-                       i = blocks_removed.begin();
-                       i != blocks_removed.end(); ++i) {
-                       v3s16 p = *i;
-
-                       /* infostream<<"Server: Block " << PP(p)
-                               << " became inactive"<<std::endl; */
-
+               for (const v3s16 &p: blocks_removed) {
                        MapBlock *block = m_map->getBlockNoCreateNoEx(p);
-                       if(block==NULL)
+                       if (!block)
                                continue;
 
                        // Set current time as timestamp (and let it set ChangedFlag)
@@ -1226,21 +1230,14 @@ void ServerEnvironment::step(float dtime)
                        Handle added blocks
                */
 
-               for(std::set<v3s16>::iterator
-                       i = blocks_added.begin();
-                       i != blocks_added.end(); ++i)
-               {
-                       v3s16 p = *i;
-
+               for (const v3s16 &p: blocks_added) {
                        MapBlock *block = m_map->getBlockOrEmerge(p);
-                       if(block==NULL){
+                       if (!block) {
                                m_active_blocks.m_list.erase(p);
                                continue;
                        }
 
                        activateBlock(block);
-                       /* infostream<<"Server: Block " << PP(p)
-                               << " became active"<<std::endl; */
                }
        }
 
@@ -1252,17 +1249,9 @@ void ServerEnvironment::step(float dtime)
 
                float dtime = m_cache_nodetimer_interval;
 
-               for(std::set<v3s16>::iterator
-                       i = m_active_blocks.m_list.begin();
-                       i != m_active_blocks.m_list.end(); ++i)
-               {
-                       v3s16 p = *i;
-
-                       /*infostream<<"Server: Block ("<<p.X<<","<<p.Y<<","<<p.Z
-                                       <<") being handled"<<std::endl;*/
-
+               for (const v3s16 &p: m_active_blocks.m_list) {
                        MapBlock *block = m_map->getBlockNoCreateNoEx(p);
-                       if(block==NULL)
+                       if (!block)
                                continue;
 
                        // Reset block usage timer
@@ -1277,17 +1266,16 @@ void ServerEnvironment::step(float dtime)
                                        MOD_REASON_BLOCK_EXPIRED);
 
                        // Run node timers
-                       std::vector<NodeTimer> elapsed_timers =
-                               block->m_node_timers.step((float)dtime);
+                       std::vector<NodeTimer> elapsed_timers = block->m_node_timers.step(dtime);
                        if (!elapsed_timers.empty()) {
                                MapNode n;
-                               for (std::vector<NodeTimer>::iterator i = elapsed_timers.begin();
-                                       i != elapsed_timers.end(); ++i) {
-                                       n = block->getNodeNoEx(i->position);
-                                       p = i->position + block->getPosRelative();
-                                       if (m_script->node_on_timer(p, n, i->elapsed)) {
+                               v3s16 p2;
+                               for (const NodeTimer &elapsed_timer: elapsed_timers) {
+                                       n = block->getNodeNoEx(elapsed_timer.position);
+                                       p2 = elapsed_timer.position + block->getPosRelative();
+                                       if (m_script->node_on_timer(p2, n, elapsed_timer.elapsed)) {
                                                block->setNodeTimer(NodeTimer(
-                                                       i->timeout, 0, i->position));
+                                                       elapsed_timer.timeout, 0, elapsed_timer.position));
                                        }
                                }
                        }
@@ -1295,8 +1283,8 @@ void ServerEnvironment::step(float dtime)
        }
 
        if (m_active_block_modifier_interval.step(dtime, m_cache_abm_interval))
-               do{ // breakable
-                       if(m_active_block_interval_overload_skip > 0){
+               do { // breakable
+                       if (m_active_block_interval_overload_skip > 0) {
                                ScopeProfiler sp(g_profiler, "SEnv: ABM overload skips");
                                m_active_block_interval_overload_skip--;
                                break;
@@ -1307,17 +1295,9 @@ void ServerEnvironment::step(float dtime)
                        // Initialize handling of ActiveBlockModifiers
                        ABMHandler abmhandler(m_abms, m_cache_abm_interval, this, true);
 
-                       for(std::set<v3s16>::iterator
-                               i = m_active_blocks.m_list.begin();
-                               i != m_active_blocks.m_list.end(); ++i)
-                       {
-                               v3s16 p = *i;
-
-                               /*infostream<<"Server: Block ("<<p.X<<","<<p.Y<<","<<p.Z
-                                               <<") being handled"<<std::endl;*/
-
+                       for (const v3s16 &p : m_active_blocks.m_list) {
                                MapBlock *block = m_map->getBlockNoCreateNoEx(p);
-                               if(block == NULL)
+                               if (!block)
                                        continue;
 
                                // Set current time as timestamp
@@ -1329,7 +1309,7 @@ void ServerEnvironment::step(float dtime)
 
                        u32 time_ms = timer.stop(true);
                        u32 max_time_ms = 200;
-                       if(time_ms > max_time_ms){
+                       if (time_ms > max_time_ms) {
                                warningstream<<"active block modifiers took "
                                        <<time_ms<<"ms (longer than "
                                        <<max_time_ms<<"ms)"<<std::endl;
@@ -1360,7 +1340,7 @@ void ServerEnvironment::step(float dtime)
                        send_recommended = true;
                }
 
-               for(ActiveObjectMap::iterator i = m_active_objects.begin();
+               for (ServerActiveObjectMap::iterator i = m_active_objects.begin();
                        i != m_active_objects.end(); ++i) {
                        ServerActiveObject* obj = i->second;
                        // Don't step if is to be removed or stored statically
@@ -1381,8 +1361,7 @@ void ServerEnvironment::step(float dtime)
        /*
                Manage active objects
        */
-       if(m_object_management_interval.step(dtime, 0.5))
-       {
+       if (m_object_management_interval.step(dtime, 0.5)) {
                ScopeProfiler sp(g_profiler, "SEnv: remove removed objs avg /.5s", SPT_AVG);
                /*
                        Remove objects that satisfy (m_removed && m_known_by_count==0)
@@ -1394,7 +1373,7 @@ void ServerEnvironment::step(float dtime)
                Manage particle spawner expiration
        */
        if (m_particle_management_interval.step(dtime, 1.0)) {
-               for (UNORDERED_MAP<u32, float>::iterator i = m_particle_spawners.begin();
+               for (std::unordered_map<u32, float>::iterator i = m_particle_spawners.begin();
                        i != m_particle_spawners.end(); ) {
                        //non expiring spawners
                        if (i->second == PARTICLE_SPAWNER_NO_EXPIRY) {
@@ -1419,7 +1398,7 @@ u32 ServerEnvironment::addParticleSpawner(float exptime)
        u32 id = 0;
        for (;;) { // look for unused particlespawner id
                id++;
-               UNORDERED_MAP<u32, float>::iterator f = m_particle_spawners.find(id);
+               std::unordered_map<u32, float>::iterator f = m_particle_spawners.find(id);
                if (f == m_particle_spawners.end()) {
                        m_particle_spawners[id] = time;
                        break;
@@ -1441,9 +1420,9 @@ u32 ServerEnvironment::addParticleSpawner(float exptime, u16 attached_id)
 void ServerEnvironment::deleteParticleSpawner(u32 id, bool remove_from_object)
 {
        m_particle_spawners.erase(id);
-       UNORDERED_MAP<u32, u16>::iterator it = m_particle_spawner_attachments.find(id);
+       const auto &it = m_particle_spawner_attachments.find(id);
        if (it != m_particle_spawner_attachments.end()) {
-               u16 obj_id = (*it).second;
+               u16 obj_id = it->second;
                ServerActiveObject *sao = getActiveObject(obj_id);
                if (sao != NULL && remove_from_object) {
                        sao->detachParticleSpawner(id);
@@ -1454,11 +1433,11 @@ void ServerEnvironment::deleteParticleSpawner(u32 id, bool remove_from_object)
 
 ServerActiveObject* ServerEnvironment::getActiveObject(u16 id)
 {
-       ActiveObjectMap::iterator n = m_active_objects.find(id);
+       ServerActiveObjectMap::const_iterator n = m_active_objects.find(id);
        return (n != m_active_objects.end() ? n->second : NULL);
 }
 
-bool isFreeServerActiveObjectId(u16 id, ActiveObjectMap &objects)
+bool isFreeServerActiveObjectId(u16 id, ServerActiveObjectMap &objects)
 {
        if (id == 0)
                return false;
@@ -1466,7 +1445,7 @@ bool isFreeServerActiveObjectId(u16 id, ActiveObjectMap &objects)
        return objects.find(id) == objects.end();
 }
 
-u16 getFreeServerActiveObjectId(ActiveObjectMap &objects)
+u16 getFreeServerActiveObjectId(ServerActiveObjectMap &objects)
 {
        //try to reuse id's as late as possible
        static u16 last_used_id = 0;
@@ -1511,7 +1490,7 @@ void ServerEnvironment::getAddedActiveObjects(PlayerSAO *playersao, s16 radius,
                - discard objects that are found in current_objects.
                - add remaining objects to added_objects
        */
-       for (ActiveObjectMap::iterator i = m_active_objects.begin();
+       for (ServerActiveObjectMap::iterator i = m_active_objects.begin();
                i != m_active_objects.end(); ++i) {
                u16 id = i->first;
 
@@ -1607,7 +1586,7 @@ void ServerEnvironment::setStaticForActiveObjectsInBlock(
                so_it = block->m_static_objects.m_active.begin();
                so_it != block->m_static_objects.m_active.end(); ++so_it) {
                // Get the ServerActiveObject counterpart to this StaticObject
-               ActiveObjectMap::iterator ao_it = m_active_objects.find(so_it->first);
+               ServerActiveObjectMap::const_iterator ao_it = m_active_objects.find(so_it->first);
                if (ao_it == m_active_objects.end()) {
                        // If this ever happens, there must be some kind of nasty bug.
                        errorstream << "ServerEnvironment::setStaticForObjectsInBlock(): "
@@ -1632,6 +1611,38 @@ ActiveObjectMessage ServerEnvironment::getActiveObjectMessage()
        return message;
 }
 
+void ServerEnvironment::getSelectedActiveObjects(
+       const core::line3d<f32> &shootline_on_map,
+       std::vector<PointedThing> &objects)
+{
+       std::vector<u16> objectIds;
+       getObjectsInsideRadius(objectIds, shootline_on_map.start,
+               shootline_on_map.getLength() + 10.0f);
+       const v3f line_vector = shootline_on_map.getVector();
+
+       for (u32 i = 0; i < objectIds.size(); i++) {
+               ServerActiveObject* obj = getActiveObject(objectIds[i]);
+
+               aabb3f selection_box;
+               if (!obj->getSelectionBox(&selection_box))
+                       continue;
+
+               v3f pos = obj->getBasePosition();
+
+               aabb3f offsetted_box(selection_box.MinEdge + pos,
+                       selection_box.MaxEdge + pos);
+
+               v3f current_intersection;
+               v3s16 current_normal;
+               if (boxLineCollision(offsetted_box, shootline_on_map.start, line_vector,
+                               &current_intersection, &current_normal)) {
+                       objects.push_back(PointedThing(
+                               (s16) objectIds[i], current_intersection, current_normal,
+                               (current_intersection - shootline_on_map.start).getLengthSQ()));
+               }
+       }
+}
+
 /*
        ************ Private methods *************
 */
@@ -1726,7 +1737,7 @@ u16 ServerEnvironment::addActiveObjectRaw(ServerActiveObject *object,
 void ServerEnvironment::removeRemovedObjects()
 {
        std::vector<u16> objects_to_remove;
-       for(ActiveObjectMap::iterator i = m_active_objects.begin();
+       for(ServerActiveObjectMap::iterator i = m_active_objects.begin();
                i != m_active_objects.end(); ++i) {
                u16 id = i->first;
                ServerActiveObject* obj = i->second;
@@ -1944,7 +1955,7 @@ void ServerEnvironment::activateObjects(MapBlock *block, u32 dtime_s)
 void ServerEnvironment::deactivateFarObjects(bool _force_delete)
 {
        std::vector<u16> objects_to_remove;
-       for(ActiveObjectMap::iterator i = m_active_objects.begin();
+       for (ServerActiveObjectMap::iterator i = m_active_objects.begin();
                i != m_active_objects.end(); ++i) {
                // force_delete might be overriden per object
                bool force_delete = _force_delete;
@@ -2172,3 +2183,111 @@ void ServerEnvironment::deactivateFarObjects(bool _force_delete)
                m_active_objects.erase(*i);
        }
 }
+
+PlayerDatabase *ServerEnvironment::openPlayerDatabase(const std::string &name,
+               const std::string &savedir, const Settings &conf)
+{
+
+       if (name == "sqlite3")
+               return new PlayerDatabaseSQLite3(savedir);
+       else if (name == "dummy")
+               return new Database_Dummy();
+#if USE_POSTGRESQL
+       else if (name == "postgresql") {
+               std::string connect_string = "";
+               conf.getNoEx("pgsql_player_connection", connect_string);
+               return new PlayerDatabasePostgreSQL(connect_string);
+       }
+#endif
+       else if (name == "files")
+               return new PlayerDatabaseFiles(savedir + DIR_DELIM + "players");
+       else
+               throw BaseException(std::string("Database backend ") + name + " not supported.");
+}
+
+bool ServerEnvironment::migratePlayersDatabase(const GameParams &game_params,
+               const Settings &cmd_args)
+{
+       std::string migrate_to = cmd_args.get("migrate-players");
+       Settings world_mt;
+       std::string world_mt_path = game_params.world_path + DIR_DELIM + "world.mt";
+       if (!world_mt.readConfigFile(world_mt_path.c_str())) {
+               errorstream << "Cannot read world.mt!" << std::endl;
+               return false;
+       }
+
+       if (!world_mt.exists("player_backend")) {
+               errorstream << "Please specify your current backend in world.mt:"
+                       << std::endl
+                       << "    player_backend = {files|sqlite3|postgresql}"
+                       << std::endl;
+               return false;
+       }
+
+       std::string backend = world_mt.get("player_backend");
+       if (backend == migrate_to) {
+               errorstream << "Cannot migrate: new backend is same"
+                       << " as the old one" << std::endl;
+               return false;
+       }
+
+       const std::string players_backup_path = game_params.world_path + DIR_DELIM
+               + "players.bak";
+
+       if (backend == "files") {
+               // Create backup directory
+               fs::CreateDir(players_backup_path);
+       }
+
+       try {
+               PlayerDatabase *srcdb = ServerEnvironment::openPlayerDatabase(backend,
+                       game_params.world_path, world_mt);
+               PlayerDatabase *dstdb = ServerEnvironment::openPlayerDatabase(migrate_to,
+                       game_params.world_path, world_mt);
+
+               std::vector<std::string> player_list;
+               srcdb->listPlayers(player_list);
+               for (std::vector<std::string>::const_iterator it = player_list.begin();
+                       it != player_list.end(); ++it) {
+                       actionstream << "Migrating player " << it->c_str() << std::endl;
+                       RemotePlayer player(it->c_str(), NULL);
+                       PlayerSAO playerSAO(NULL, &player, 15000, false);
+
+                       srcdb->loadPlayer(&player, &playerSAO);
+
+                       playerSAO.finalize(&player, std::set<std::string>());
+                       player.setPlayerSAO(&playerSAO);
+
+                       dstdb->savePlayer(&player);
+
+                       // For files source, move player files to backup dir
+                       if (backend == "files") {
+                               fs::Rename(
+                                       game_params.world_path + DIR_DELIM + "players" + DIR_DELIM + (*it),
+                                       players_backup_path + DIR_DELIM + (*it));
+                       }
+               }
+
+               actionstream << "Successfully migrated " << player_list.size() << " players"
+                       << std::endl;
+               world_mt.set("player_backend", migrate_to);
+               if (!world_mt.updateConfigFile(world_mt_path.c_str()))
+                       errorstream << "Failed to update world.mt!" << std::endl;
+               else
+                       actionstream << "world.mt updated" << std::endl;
+
+               // When migration is finished from file backend, remove players directory if empty
+               if (backend == "files") {
+                       fs::DeleteSingleFileOrEmptyDirectory(game_params.world_path + DIR_DELIM
+                               + "players");
+               }
+
+               delete srcdb;
+               delete dstdb;
+
+       } catch (BaseException &e) {
+               errorstream << "An error occured during migration: " << e.what() << std::endl;
+               return false;
+       }
+       return true;
+}