]> git.lizzy.rs Git - minetest.git/blobdiff - src/server.cpp
Add support for statbar “off state” icons (#9462)
[minetest.git] / src / server.cpp
index b74bba258c0dd79368985ca10aa80f61707c382a..b28c30e1e2840b69e9aa08130b0a06d83aa55954 100644 (file)
@@ -34,8 +34,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "version.h"
 #include "filesys.h"
 #include "mapblock.h"
-#include "serverobject.h"
-#include "genericobject.h"
+#include "server/serveractiveobject.h"
 #include "settings.h"
 #include "profiler.h"
 #include "log.h"
@@ -48,7 +47,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "mapgen/mg_biome.h"
 #include "content_mapnode.h"
 #include "content_nodemeta.h"
-#include "content_sao.h"
 #include "content/mods.h"
 #include "modchannels.h"
 #include "serverlist.h"
@@ -65,6 +63,9 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "chatmessage.h"
 #include "chat_interface.h"
 #include "remoteplayer.h"
+#include "server/player_sao.h"
+#include "server/serverinventorymgr.h"
+#include "translation.h"
 
 class ClientNotFoundException : public BaseException
 {
@@ -229,18 +230,46 @@ Server::Server(
        m_nodedef(createNodeDefManager()),
        m_craftdef(createCraftDefManager()),
        m_thread(new ServerThread(this)),
-       m_uptime(0),
        m_clients(m_con),
        m_admin_chat(iface),
        m_modchannel_mgr(new ModChannelMgr())
 {
-       m_lag = g_settings->getFloat("dedicated_server_step");
-
        if (m_path_world.empty())
                throw ServerError("Supplied empty world path");
 
        if (!gamespec.isValid())
                throw ServerError("Supplied invalid gamespec");
+
+#if USE_PROMETHEUS
+       m_metrics_backend = std::unique_ptr<MetricsBackend>(createPrometheusMetricsBackend());
+#else
+       m_metrics_backend = std::unique_ptr<MetricsBackend>(new MetricsBackend());
+#endif
+
+       m_uptime_counter = m_metrics_backend->addCounter("minetest_core_server_uptime", "Server uptime (in seconds)");
+       m_player_gauge = m_metrics_backend->addGauge("minetest_core_player_number", "Number of connected players");
+
+       m_timeofday_gauge = m_metrics_backend->addGauge(
+                       "minetest_core_timeofday",
+                       "Time of day value");
+
+       m_lag_gauge = m_metrics_backend->addGauge(
+                       "minetest_core_latency",
+                       "Latency value (in seconds)");
+
+       m_aom_buffer_counter = m_metrics_backend->addCounter(
+                       "minetest_core_aom_generated_count",
+                       "Number of active object messages generated");
+
+       m_packet_recv_counter = m_metrics_backend->addCounter(
+                       "minetest_core_server_packet_recv",
+                       "Processable packets received");
+
+       m_packet_recv_processed_counter = m_metrics_backend->addCounter(
+                       "minetest_core_server_packet_recv_processed",
+                       "Valid received packets processed");
+
+       m_lag_gauge->set(g_settings->getFloat("dedicated_server_step"));
 }
 
 Server::~Server()
@@ -310,11 +339,6 @@ Server::~Server()
        infostream << "Server: Deinitializing scripting" << std::endl;
        delete m_script;
 
-       // Delete detached inventories
-       for (auto &detached_inventory : m_detached_inventories) {
-               delete detached_inventory.second;
-       }
-
        while (!m_unsent_map_edit_queue.empty()) {
                delete m_unsent_map_edit_queue.front();
                m_unsent_map_edit_queue.pop();
@@ -353,13 +377,16 @@ void Server::init()
        MutexAutoLock envlock(m_env_mutex);
 
        // Create the Map (loads map_meta.txt, overriding configured mapgen params)
-       ServerMap *servermap = new ServerMap(m_path_world, this, m_emerge);
+       ServerMap *servermap = new ServerMap(m_path_world, this, m_emerge, m_metrics_backend.get());
 
        // Initialize scripting
        infostream << "Server: Initializing Lua" << std::endl;
 
        m_script = new ServerScripting(this);
 
+       // Must be created before mod loading because we have some inventory creation
+       m_inventory_mgr = std::unique_ptr<ServerInventoryManager>(new ServerInventoryManager());
+
        m_script->loadMod(getBuiltinLuaPath() + DIR_DELIM "init.lua", BUILTIN_MOD_NAME);
 
        m_modmgr->loadMods(m_script);
@@ -374,8 +401,11 @@ void Server::init()
        std::vector<std::string> paths;
        fs::GetRecursiveDirs(paths, g_settings->get("texture_path"));
        fs::GetRecursiveDirs(paths, m_gamespec.path + DIR_DELIM + "textures");
-       for (const std::string &path : paths)
-               m_nodedef->applyTextureOverrides(path + DIR_DELIM + "override.txt");
+       for (const std::string &path : paths) {
+               TextureOverrideSource override_source(path + DIR_DELIM + "override.txt");
+               m_nodedef->applyTextureOverrides(override_source.getNodeTileOverrides());
+               m_itemdef->applyTextureOverrides(override_source.getItemTextureOverrides());
+       }
 
        m_nodedef->setNodeRegistrationStatus(true);
 
@@ -391,6 +421,7 @@ void Server::init()
        // Initialize Environment
        m_env = new ServerEnvironment(servermap, m_script, this, m_path_world);
 
+       m_inventory_mgr->setEnv(m_env);
        m_clients.setEnv(m_env);
 
        if (!servermap->settings_mgr.makeMapgenParams())
@@ -412,6 +443,8 @@ void Server::init()
 
        m_env->loadMeta();
 
+       // Those settings can be overwritten in world.mt, they are
+       // intended to be cached after environment loading.
        m_liquid_transform_every = g_settings->getFloat("liquid_update");
        m_max_chatmessage_length = g_settings->getU16("chat_message_max_size");
        m_csm_restriction_flags = g_settings->getU64("csm_restriction_flags");
@@ -420,6 +453,8 @@ void Server::init()
 
 void Server::start()
 {
+       init();
+
        infostream << "Starting server on " << m_bind_addr.serializeString()
                        << "..." << std::endl;
 
@@ -508,9 +543,7 @@ void Server::AsyncRunStep(bool initial_step)
        /*
                Update uptime
        */
-       {
-               m_uptime.set(m_uptime.get() + dtime);
-       }
+       m_uptime_counter->increment(dtime);
 
        handlePeerChanges();
 
@@ -524,11 +557,13 @@ void Server::AsyncRunStep(bool initial_step)
        */
 
        m_time_of_day_send_timer -= dtime;
-       if(m_time_of_day_send_timer < 0.0) {
+       if (m_time_of_day_send_timer < 0.0) {
                m_time_of_day_send_timer = g_settings->getFloat("time_send_interval");
                u16 time = m_env->getTimeOfDay();
                float time_speed = g_settings->getFloat("time_speed");
                SendTimeOfDay(PEER_ID_INEXISTENT, time, time_speed);
+
+               m_timeofday_gauge->set(time);
        }
 
        {
@@ -600,7 +635,7 @@ void Server::AsyncRunStep(bool initial_step)
        }
        m_clients.step(dtime);
 
-       m_lag += (m_lag > dtime ? -1 : 1) * dtime/100;
+       m_lag_gauge->increment((m_lag_gauge->get() > dtime ? -1 : 1) * dtime/100);
 #if USE_CURL
        // send masterserver announce
        {
@@ -611,9 +646,9 @@ void Server::AsyncRunStep(bool initial_step)
                                                ServerList::AA_START,
                                        m_bind_addr.getPort(),
                                        m_clients.getPlayerNames(),
-                                       m_uptime.get(),
+                                       m_uptime_counter->get(),
                                        m_env->getGameTime(),
-                                       m_lag,
+                                       m_lag_gauge->get(),
                                        m_gamespec.id,
                                        Mapgen::getMapgenName(m_emerge->mgparams->mgtype),
                                        m_modmgr->getMods(),
@@ -635,6 +670,7 @@ void Server::AsyncRunStep(bool initial_step)
                const RemoteClientMap &clients = m_clients.getClientList();
                ScopeProfiler sp(g_profiler, "Server: update objects within range");
 
+               m_player_gauge->set(clients.size());
                for (const auto &client_it : clients) {
                        RemoteClient *client = client_it.second;
 
@@ -656,14 +692,17 @@ void Server::AsyncRunStep(bool initial_step)
                // Save mod storages if modified
                m_mod_storage_save_timer -= dtime;
                if (m_mod_storage_save_timer <= 0.0f) {
-                       infostream << "Saving registered mod storages." << std::endl;
                        m_mod_storage_save_timer = g_settings->getFloat("server_map_save_interval");
+                       int n = 0;
                        for (std::unordered_map<std::string, ModMetadata *>::const_iterator
                                it = m_mod_storages.begin(); it != m_mod_storages.end(); ++it) {
                                if (it->second->isModified()) {
                                        it->second->save(getModStoragePath());
+                                       n++;
                                }
                        }
+                       if (n > 0)
+                               infostream << "Saved " << n << " modified mod storages." << std::endl;
                }
        }
 
@@ -697,6 +736,8 @@ void Server::AsyncRunStep(bool initial_step)
                        message_list->push_back(aom);
                }
 
+               m_aom_buffer_counter->increment(buffered_messages.size());
+
                m_clients.lock();
                const RemoteClientMap &clients = m_clients.getClientList();
                // Route data to every client
@@ -718,7 +759,7 @@ void Server::AsyncRunStep(bool initial_step)
                                // Go through every message
                                for (const ActiveObjectMessage &aom : *list) {
                                        // Send position updates to players who do not see the attachment
-                                       if (aom.datastring[0] == GENERIC_CMD_UPDATE_POSITION) {
+                                       if (aom.datastring[0] == AO_CMD_UPDATE_POSITION) {
                                                if (sao->getId() == player->getId())
                                                        continue;
 
@@ -809,7 +850,6 @@ void Server::AsyncRunStep(bool initial_step)
                                                disable_single_change_sending ? 5 : 30);
                                break;
                        case MEET_BLOCK_NODE_METADATA_CHANGED: {
-                               verbosestream << "Server: MEET_BLOCK_NODE_METADATA_CHANGED" << std::endl;
                                prof.add("MEET_BLOCK_NODE_METADATA_CHANGED", 1);
                                if (!event->is_private_change) {
                                        // Don't send the change yet. Collect them to eliminate dupes.
@@ -825,7 +865,6 @@ void Server::AsyncRunStep(bool initial_step)
                                break;
                        }
                        case MEET_OTHER:
-                               infostream << "Server: MEET_OTHER" << std::endl;
                                prof.add("MEET_OTHER", 1);
                                for (const v3s16 &modified_block : event->modified_blocks) {
                                        m_clients.markBlockposAsNotSent(modified_block);
@@ -939,7 +978,9 @@ void Server::Receive()
                        }
 
                        peer_id = pkt.getPeerId();
+                       m_packet_recv_counter->increment();
                        ProcessData(&pkt);
+                       m_packet_recv_processed_counter->increment();
                } catch (const con::InvalidIncomingDataException &e) {
                        infostream << "Server::Receive(): InvalidIncomingDataException: what()="
                                        << e.what() << std::endl;
@@ -1018,16 +1059,15 @@ PlayerSAO* Server::StageTwoClientInit(session_t peer_id)
        // Send Breath
        SendPlayerBreath(playersao);
 
-       Address addr = getPeerAddress(player->getPeerId());
-       std::string ip_str = addr.serializeString();
-       actionstream<<player->getName() <<" [" << ip_str << "] joins game. " << std::endl;
        /*
                Print out action
        */
        {
+               Address addr = getPeerAddress(player->getPeerId());
+               std::string ip_str = addr.serializeString();
                const std::vector<std::string> &names = m_clients.getPlayerNames();
 
-               actionstream << player->getName() << " joins game. List of players: ";
+               actionstream << player->getName() << " [" << ip_str << "] joins game. List of players: ";
 
                for (const std::string &name : names) {
                        actionstream << name << " ";
@@ -1144,82 +1184,6 @@ void Server::onMapEditEvent(const MapEditEvent &event)
        m_unsent_map_edit_queue.push(new MapEditEvent(event));
 }
 
-Inventory* Server::getInventory(const InventoryLocation &loc)
-{
-       switch (loc.type) {
-       case InventoryLocation::UNDEFINED:
-       case InventoryLocation::CURRENT_PLAYER:
-               break;
-       case InventoryLocation::PLAYER:
-       {
-               RemotePlayer *player = m_env->getPlayer(loc.name.c_str());
-               if(!player)
-                       return NULL;
-               PlayerSAO *playersao = player->getPlayerSAO();
-               if(!playersao)
-                       return NULL;
-               return playersao->getInventory();
-       }
-               break;
-       case InventoryLocation::NODEMETA:
-       {
-               NodeMetadata *meta = m_env->getMap().getNodeMetadata(loc.p);
-               if(!meta)
-                       return NULL;
-               return meta->getInventory();
-       }
-               break;
-       case InventoryLocation::DETACHED:
-       {
-               if(m_detached_inventories.count(loc.name) == 0)
-                       return NULL;
-               return m_detached_inventories[loc.name];
-       }
-               break;
-       default:
-               sanity_check(false); // abort
-               break;
-       }
-       return NULL;
-}
-
-void Server::setInventoryModified(const InventoryLocation &loc)
-{
-       switch(loc.type){
-       case InventoryLocation::UNDEFINED:
-               break;
-       case InventoryLocation::PLAYER:
-       {
-
-               RemotePlayer *player = m_env->getPlayer(loc.name.c_str());
-
-               if (!player)
-                       return;
-
-               player->setModified(true);
-               player->inventory.setModified(true);
-               // Updates are sent in ServerEnvironment::step()
-       }
-               break;
-       case InventoryLocation::NODEMETA:
-       {
-               MapEditEvent event;
-               event.type = MEET_BLOCK_NODE_METADATA_CHANGED;
-               event.p = loc.p;
-               m_env->getMap().dispatchEvent(event);
-       }
-               break;
-       case InventoryLocation::DETACHED:
-       {
-               // Updates are sent in ServerEnvironment::step()
-       }
-               break;
-       default:
-               sanity_check(false); // abort
-               break;
-       }
-}
-
 void Server::SetBlocksNotSent(std::map<v3s16, MapBlock *>& block)
 {
        std::vector<session_t> clients = m_clients.getClientIDs();
@@ -1264,7 +1228,8 @@ bool Server::getClientInfo(
                u8*          major,
                u8*          minor,
                u8*          patch,
-               std::string* vers_string
+               std::string* vers_string,
+               std::string* lang_code
        )
 {
        *state = m_clients.getClientState(peer_id);
@@ -1284,6 +1249,7 @@ bool Server::getClientInfo(
        *minor = client->getMinor();
        *patch = client->getPatch();
        *vers_string = client->getFull();
+       *lang_code = client->getLangCode();
 
        m_clients.unlock();
 
@@ -1655,7 +1621,7 @@ void Server::SendHUDAdd(session_t peer_id, u32 id, HudElement *form)
        pkt << id << (u8) form->type << form->pos << form->name << form->scale
                        << form->text << form->number << form->item << form->dir
                        << form->align << form->offset << form->world_pos << form->size
-                       << form->z_index;
+                       << form->z_index << form->text2;
 
        Send(&pkt);
 }
@@ -1681,6 +1647,7 @@ void Server::SendHUDChange(session_t peer_id, u32 id, HudElementStat stat, void
                        break;
                case HUD_STAT_NAME:
                case HUD_STAT_TEXT:
+               case HUD_STAT_TEXT2:
                        pkt << *(std::string *) value;
                        break;
                case HUD_STAT_WORLD_POS:
@@ -1718,17 +1685,62 @@ void Server::SendHUDSetParam(session_t peer_id, u16 param, const std::string &va
        Send(&pkt);
 }
 
-void Server::SendSetSky(session_t peer_id, const video::SColor &bgcolor,
-               const std::string &type, const std::vector<std::string> &params,
-               bool &clouds)
+void Server::SendSetSky(session_t peer_id, const SkyboxParams &params)
 {
        NetworkPacket pkt(TOCLIENT_SET_SKY, 0, peer_id);
-       pkt << bgcolor << type << (u16) params.size();
 
-       for (const std::string &param : params)
-               pkt << param;
+       // Handle prior clients here
+       if (m_clients.getProtocolVersion(peer_id) < 39) {
+               pkt << params.bgcolor << params.type << (u16) params.textures.size();
+
+               for (const std::string& texture : params.textures)
+                       pkt << texture;
+
+               pkt << params.clouds;
+       } else { // Handle current clients and future clients
+               pkt << params.bgcolor << params.type
+               << params.clouds << params.fog_sun_tint
+               << params.fog_moon_tint << params.fog_tint_type;
+
+               if (params.type == "skybox") {
+                       pkt << (u16) params.textures.size();
+                       for (const std::string &texture : params.textures)
+                               pkt << texture;
+               } else if (params.type == "regular") {
+                       pkt << params.sky_color.day_sky << params.sky_color.day_horizon
+                               << params.sky_color.dawn_sky << params.sky_color.dawn_horizon
+                               << params.sky_color.night_sky << params.sky_color.night_horizon
+                               << params.sky_color.indoors;
+               }
+       }
+
+       Send(&pkt);
+}
+
+void Server::SendSetSun(session_t peer_id, const SunParams &params)
+{
+       NetworkPacket pkt(TOCLIENT_SET_SUN, 0, peer_id);
+       pkt << params.visible << params.texture
+               << params.tonemap << params.sunrise
+               << params.sunrise_visible << params.scale;
+
+       Send(&pkt);
+}
+void Server::SendSetMoon(session_t peer_id, const MoonParams &params)
+{
+       NetworkPacket pkt(TOCLIENT_SET_MOON, 0, peer_id);
+
+       pkt << params.visible << params.texture
+               << params.tonemap << params.scale;
 
-       pkt << clouds;
+       Send(&pkt);
+}
+void Server::SendSetStars(session_t peer_id, const StarParams &params)
+{
+       NetworkPacket pkt(TOCLIENT_SET_STARS, 0, peer_id);
+
+       pkt << params.visible << params.count
+               << params.starcolor << params.scale;
 
        Send(&pkt);
 }
@@ -1768,18 +1780,13 @@ void Server::SendTimeOfDay(session_t peer_id, u16 time, f32 time_speed)
 void Server::SendPlayerHP(session_t peer_id)
 {
        PlayerSAO *playersao = getPlayerSAO(peer_id);
-       // In some rare case if the player is disconnected
-       // while Lua call l_punch, for example, this can be NULL
-       if (!playersao)
-               return;
+       assert(playersao);
 
        SendHP(peer_id, playersao->getHP());
        m_script->player_event(playersao,"health_changed");
 
        // Send to other clients
-       std::string str = gob_cmd_punched(playersao->getHP());
-       ActiveObjectMessage aom(playersao->getId(), true, str);
-       playersao->m_messages_out.push(aom);
+       playersao->sendPunchCommand();
 }
 
 void Server::SendPlayerBreath(PlayerSAO *sao)
@@ -1814,10 +1821,10 @@ void Server::SendMovePlayer(session_t peer_id)
 
 void Server::SendPlayerFov(session_t peer_id)
 {
-       NetworkPacket pkt(TOCLIENT_FOV, 4 + 1, peer_id);
+       NetworkPacket pkt(TOCLIENT_FOV, 4 + 1 + 4, peer_id);
 
        PlayerFovSpec fov_spec = m_env->getPlayer(peer_id)->getFov();
-       pkt << fov_spec.fov << fov_spec.is_multiplier;
+       pkt << fov_spec.fov << fov_spec.is_multiplier << fov_spec.transition_time;
 
        Send(&pkt);
 }
@@ -2013,8 +2020,18 @@ void Server::SendPlayerSpeed(session_t peer_id, const v3f &added_vel)
        Send(&pkt);
 }
 
+inline s32 Server::nextSoundId()
+{
+       s32 ret = m_next_sound_id;
+       if (m_next_sound_id == INT32_MAX)
+               m_next_sound_id = 0; // signed overflow is undefined
+       else
+               m_next_sound_id++;
+       return ret;
+}
+
 s32 Server::playSound(const SimpleSoundSpec &spec,
-               const ServerSoundParams &params)
+               const ServerSoundParams &params, bool ephemeral)
 {
        // Find out initial position of sound
        bool pos_exists = false;
@@ -2025,7 +2042,7 @@ s32 Server::playSound(const SimpleSoundSpec &spec,
 
        // Filter destination clients
        std::vector<session_t> dst_clients;
-       if(!params.to_player.empty()) {
+       if (!params.to_player.empty()) {
                RemotePlayer *player = m_env->getPlayer(params.to_player.c_str());
                if(!player){
                        infostream<<"Server::playSound: Player \""<<params.to_player
@@ -2045,6 +2062,9 @@ s32 Server::playSound(const SimpleSoundSpec &spec,
                        RemotePlayer *player = m_env->getPlayer(client_id);
                        if (!player)
                                continue;
+                       if (!params.exclude_player.empty() &&
+                                       params.exclude_player == player->getName())
+                               continue;
 
                        PlayerSAO *sao = player->getPlayerSAO();
                        if (!sao)
@@ -2063,27 +2083,32 @@ s32 Server::playSound(const SimpleSoundSpec &spec,
                return -1;
 
        // Create the sound
-       s32 id = m_next_sound_id++;
-       // The sound will exist as a reference in m_playing_sounds
-       m_playing_sounds[id] = ServerPlayingSound();
-       ServerPlayingSound &psound = m_playing_sounds[id];
-       psound.params = params;
-       psound.spec = spec;
+       s32 id;
+       ServerPlayingSound *psound = nullptr;
+       if (ephemeral) {
+               id = -1; // old clients will still use this, so pick a reserved ID
+       } else {
+               id = nextSoundId();
+               // The sound will exist as a reference in m_playing_sounds
+               m_playing_sounds[id] = ServerPlayingSound();
+               psound = &m_playing_sounds[id];
+               psound->params = params;
+               psound->spec = spec;
+       }
 
        float gain = params.gain * spec.gain;
        NetworkPacket pkt(TOCLIENT_PLAY_SOUND, 0);
        pkt << id << spec.name << gain
                        << (u8) params.type << pos << params.object
-                       << params.loop << params.fade << params.pitch;
+                       << params.loop << params.fade << params.pitch
+                       << ephemeral;
 
-       // Backwards compability
-       bool play_sound = gain > 0;
+       bool as_reliable = !ephemeral;
 
        for (const u16 dst_client : dst_clients) {
-               if (play_sound || m_clients.getProtocolVersion(dst_client) >= 32) {
-                       psound.clients.insert(dst_client);
-                       m_clients.send(dst_client, 0, &pkt, true);
-               }
+               if (psound)
+                       psound->clients.insert(dst_client);
+               m_clients.send(dst_client, 0, &pkt, as_reliable);
        }
        return id;
 }
@@ -2476,9 +2501,6 @@ void Server::fillMediaCache()
 
 void Server::sendMediaAnnouncement(session_t peer_id, const std::string &lang_code)
 {
-       verbosestream << "Server: Announcing files to id(" << peer_id << ")"
-               << std::endl;
-
        // Make packet
        NetworkPacket pkt(TOCLIENT_ANNOUNCE_MEDIA, 0, peer_id);
 
@@ -2501,6 +2523,9 @@ void Server::sendMediaAnnouncement(session_t peer_id, const std::string &lang_co
 
        pkt << g_settings->get("remote_media");
        Send(&pkt);
+
+       verbosestream << "Server: Announcing files to id(" << peer_id
+               << "): count=" << media_sent << " size=" << pkt.getSize() << std::endl;
 }
 
 struct SendableMedia
@@ -2616,40 +2641,20 @@ void Server::sendRequestedMedia(session_t peer_id,
        }
 }
 
-void Server::sendDetachedInventory(const std::string &name, session_t peer_id)
+void Server::sendDetachedInventory(Inventory *inventory, const std::string &name, session_t peer_id)
 {
-       const auto &inv_it = m_detached_inventories.find(name);
-       const auto &player_it = m_detached_inventories_player.find(name);
-
-       if (player_it == m_detached_inventories_player.end() ||
-                       player_it->second.empty()) {
-               // OK. Send to everyone
-       } else {
-               if (!m_env)
-                       return; // Mods are not done loading
-
-               RemotePlayer *p = m_env->getPlayer(player_it->second.c_str());
-               if (!p)
-                       return; // Player is offline
-
-               if (peer_id != PEER_ID_INEXISTENT && peer_id != p->getPeerId())
-                       return; // Caller requested send to a different player, so don't send.
-
-               peer_id = p->getPeerId();
-       }
-
        NetworkPacket pkt(TOCLIENT_DETACHED_INVENTORY, 0, peer_id);
        pkt << name;
 
-       if (inv_it == m_detached_inventories.end()) {
+       if (!inventory) {
                pkt << false; // Remove inventory
        } else {
                pkt << true; // Update inventory
 
                // Serialization & NetworkPacket isn't a love story
                std::ostringstream os(std::ios_base::binary);
-               inv_it->second->serialize(os);
-               inv_it->second->setModified(false);
+               inventory->serialize(os);
+               inventory->setModified(false);
 
                const std::string &os_str = os.str();
                pkt << static_cast<u16>(os_str.size()); // HACK: to keep compatibility with 5.0.0 clients
@@ -2664,16 +2669,17 @@ void Server::sendDetachedInventory(const std::string &name, session_t peer_id)
 
 void Server::sendDetachedInventories(session_t peer_id, bool incremental)
 {
-       for (const auto &detached_inventory : m_detached_inventories) {
-               const std::string &name = detached_inventory.first;
-               if (incremental) {
-                       Inventory *inv = detached_inventory.second;
-                       if (!inv || !inv->checkModified())
-                               continue;
-               }
-
-               sendDetachedInventory(name, peer_id);
+       // Lookup player name, to filter detached inventories just after
+       std::string peer_name;
+       if (peer_id != PEER_ID_INEXISTENT) {
+               peer_name = getClient(peer_id, CS_Created)->getName();
        }
+
+       auto send_cb = [this, peer_id](const std::string &name, Inventory *inv) {
+               sendDetachedInventory(inv, name, peer_id);
+       };
+
+       m_inventory_mgr->sendDetachedInventories(peer_name, incremental, send_cb);
 }
 
 /*
@@ -2683,10 +2689,7 @@ void Server::sendDetachedInventories(session_t peer_id, bool incremental)
 void Server::DiePlayer(session_t peer_id, const PlayerHPChangeReason &reason)
 {
        PlayerSAO *playersao = getPlayerSAO(peer_id);
-       // In some rare cases this can be NULL -- if the player is disconnected
-       // when a Lua function modifies l_punch, for example
-       if (!playersao)
-               return;
+       assert(playersao);
 
        infostream << "Server::DiePlayer(): Player "
                        << playersao->getPlayer()->getName()
@@ -2882,10 +2885,8 @@ void Server::UpdateCrafting(RemotePlayer *player)
        if (!clist || clist->getSize() == 0)
                return;
 
-       if (!clist->checkModified()) {
-               verbosestream << "Skip Server::UpdateCrafting(): list unmodified" << std::endl;
+       if (!clist->checkModified())
                return;
-       }
 
        // Get a preview for crafting
        ItemStack preview;
@@ -2976,8 +2977,16 @@ std::wstring Server::handleChat(const std::string &name, const std::wstring &wna
                line += L"-!- You don't have permission to shout.";
                broadcast_line = false;
        } else {
+               /*
+                       Workaround for fixing chat on Android. Lua doesn't handle
+                       the Cyrillic alphabet and some characters on older Android devices
+               */
+#ifdef __ANDROID__
+               line += L"<" + wname + L"> " + wmessage;
+#else
                line += narrow_to_wide(m_script->formatChatMessage(name,
                                wide_to_narrow(wmessage)));
+#endif
        }
 
        /*
@@ -3061,7 +3070,7 @@ std::wstring Server::getStatusString()
        // Version
        os << L"version=" << narrow_to_wide(g_version_string);
        // Uptime
-       os << L", uptime=" << m_uptime.get();
+       os << L", uptime=" << m_uptime_counter->get();
        // Max lag estimate
        os << L", max_lag=" << (m_env ? m_env->getMaxLagEstimate() : 0);
 
@@ -3308,13 +3317,32 @@ void Server::setPlayerEyeOffset(RemotePlayer *player, const v3f &first, const v3
        SendEyeOffset(player->getPeerId(), first, third);
 }
 
-void Server::setSky(RemotePlayer *player, const video::SColor &bgcolor,
-       const std::string &type, const std::vector<std::string> &params,
-       bool &clouds)
+void Server::setSky(RemotePlayer *player, const SkyboxParams &params)
 {
        sanity_check(player);
-       player->setSky(bgcolor, type, params, clouds);
-       SendSetSky(player->getPeerId(), bgcolor, type, params, clouds);
+       player->setSky(params);
+       SendSetSky(player->getPeerId(), params);
+}
+
+void Server::setSun(RemotePlayer *player, const SunParams &params)
+{
+       sanity_check(player);
+       player->setSun(params);
+       SendSetSun(player->getPeerId(), params);
+}
+
+void Server::setMoon(RemotePlayer *player, const MoonParams &params)
+{
+       sanity_check(player);
+       player->setMoon(params);
+       SendSetMoon(player->getPeerId(), params);
+}
+
+void Server::setStars(RemotePlayer *player, const StarParams &params)
+{
+       sanity_check(player);
+       player->setStars(params);
+       SendSetStars(player->getPeerId(), params);
 }
 
 void Server::setClouds(RemotePlayer *player, const CloudParams &params)
@@ -3324,15 +3352,12 @@ void Server::setClouds(RemotePlayer *player, const CloudParams &params)
        SendCloudParams(player->getPeerId(), params);
 }
 
-bool Server::overrideDayNightRatio(RemotePlayer *player, bool do_override,
+void Server::overrideDayNightRatio(RemotePlayer *player, bool do_override,
        float ratio)
 {
-       if (!player)
-               return false;
-
+       sanity_check(player);
        player->overrideDayNightRatio(do_override, ratio);
        SendOverrideDayNightRatio(player->getPeerId(), do_override, ratio);
-       return true;
 }
 
 void Server::notifyPlayers(const std::wstring &msg)
@@ -3423,52 +3448,6 @@ void Server::deleteParticleSpawner(const std::string &playername, u32 id)
        SendDeleteParticleSpawner(peer_id, id);
 }
 
-Inventory* Server::createDetachedInventory(const std::string &name, const std::string &player)
-{
-       if(m_detached_inventories.count(name) > 0){
-               infostream<<"Server clearing detached inventory \""<<name<<"\""<<std::endl;
-               delete m_detached_inventories[name];
-       } else {
-               infostream<<"Server creating detached inventory \""<<name<<"\""<<std::endl;
-       }
-       Inventory *inv = new Inventory(m_itemdef);
-       sanity_check(inv);
-       m_detached_inventories[name] = inv;
-       if (!player.empty())
-               m_detached_inventories_player[name] = player;
-
-       //TODO find a better way to do this
-       sendDetachedInventory(name,PEER_ID_INEXISTENT);
-       return inv;
-}
-
-bool Server::removeDetachedInventory(const std::string &name)
-{
-       const auto &inv_it = m_detached_inventories.find(name);
-       if (inv_it == m_detached_inventories.end())
-               return false;
-
-       delete inv_it->second;
-       m_detached_inventories.erase(inv_it);
-
-       if (!m_env) // Mods are not done loading
-               return true;
-
-       const auto &player_it = m_detached_inventories_player.find(name);
-       if (player_it != m_detached_inventories_player.end()) {
-               RemotePlayer *player = m_env->getPlayer(player_it->second.c_str());
-
-               if (player && player->getPeerId() != PEER_ID_INEXISTENT)
-                       sendDetachedInventory(name, player->getPeerId());
-
-               m_detached_inventories_player.erase(player_it);
-       } else {
-               // Notify all players about the change
-               sendDetachedInventory(name, PEER_ID_INEXISTENT);
-       }
-       return true;
-}
-
 // actions: time-reversed list
 // Return value: success/failure
 bool Server::rollbackRevertActions(const std::list<RollbackAction> &actions,
@@ -3489,7 +3468,7 @@ bool Server::rollbackRevertActions(const std::list<RollbackAction> &actions,
 
        for (const RollbackAction &action : actions) {
                num_tried++;
-               bool success = action.applyRevert(map, this, this);
+               bool success = action.applyRevert(map, m_inventory_mgr.get(), this);
                if(!success){
                        num_failed++;
                        std::ostringstream os;
@@ -3855,3 +3834,20 @@ void Server::broadcastModChannelMessage(const std::string &channel,
                m_script->on_modchannel_message(channel, sender, message);
        }
 }
+
+void Server::loadTranslationLanguage(const std::string &lang_code)
+{
+       if (g_server_translations->count(lang_code))
+               return; // Already loaded
+
+       std::string suffix = "." + lang_code + ".tr";
+       for (const auto &i : m_media) {
+               if (str_ends_with(i.first, suffix)) {
+                       std::ifstream t(i.second.path);
+                       std::string data((std::istreambuf_iterator<char>(t)),
+                       std::istreambuf_iterator<char>());
+
+                       (*g_server_translations)[lang_code].loadTranslation(data);
+               }
+       }
+}