]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/server.cpp
Cleanup & bugfix
[dragonfireclient.git] / src / server.cpp
index b7627f6cd06232f3d8d9b0e5c63301b0cf15851e..9e1db6c61f16fbf8ee1edd8ffad24bf24a717e48 100644 (file)
@@ -44,8 +44,8 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "itemdef.h"
 #include "craftdef.h"
 #include "emerge.h"
-#include "mapgen.h"
-#include "mg_biome.h"
+#include "mapgen/mapgen.h"
+#include "mapgen/mg_biome.h"
 #include "content_mapnode.h"
 #include "content_nodemeta.h"
 #include "content_sao.h"
@@ -61,7 +61,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "util/base64.h"
 #include "util/sha1.h"
 #include "util/hex.h"
-#include "database.h"
+#include "database/database.h"
 #include "chatmessage.h"
 #include "chat_interface.h"
 #include "remoteplayer.h"
@@ -253,9 +253,11 @@ Server::Server(
        m_nodedef->updateAliases(m_itemdef);
 
        // Apply texture overrides from texturepack/override.txt
-       std::string texture_path = g_settings->get("texture_path");
-       if (!texture_path.empty() && fs::IsDir(texture_path))
-               m_nodedef->applyTextureOverrides(texture_path + DIR_DELIM + "override.txt");
+       std::vector<std::string> paths;
+       fs::GetRecursiveDirs(paths, g_settings->get("texture_path"));
+       fs::GetRecursiveDirs(paths, m_gamespec.path + DIR_DELIM + "textures");
+       for (const std::string &path : paths)
+               m_nodedef->applyTextureOverrides(path + DIR_DELIM + "override.txt");
 
        m_nodedef->setNodeRegistrationStatus(true);
 
@@ -307,7 +309,7 @@ Server::Server(
 
 Server::~Server()
 {
-       infostream<<"Server destructing"<<std::endl;
+       infostream << "Server destructing" << std::endl;
 
        // Send shutdown message
        SendChatMessage(PEER_ID_INEXISTENT, ChatMessage(CHATMESSAGE_TYPE_ANNOUNCE,
@@ -316,9 +318,6 @@ Server::~Server()
        {
                MutexAutoLock envlock(m_env_mutex);
 
-               // Execute script shutdown hooks
-               m_script->on_shutdown();
-
                infostream << "Server: Saving players" << std::endl;
                m_env->saveLoadedPlayers();
 
@@ -334,6 +333,20 @@ Server::~Server()
                }
                m_env->kickAllPlayers(SERVER_ACCESSDENIED_SHUTDOWN,
                        kick_msg, reconnect);
+       }
+
+       // Do this before stopping the server in case mapgen callbacks need to access
+       // server-controlled resources (like ModStorages). Also do them before
+       // shutdown callbacks since they may modify state that is finalized in a
+       // callback.
+       m_emerge->stopThreads();
+
+       {
+               MutexAutoLock envlock(m_env_mutex);
+
+               // Execute script shutdown hooks
+               infostream << "Executing shutdown hooks" << std::endl;
+               m_script->on_shutdown();
 
                infostream << "Server: Saving environment metadata" << std::endl;
                m_env->saveMeta();
@@ -343,10 +356,6 @@ Server::~Server()
        stop();
        delete m_thread;
 
-       // stop all emerge threads before deleting players that may have
-       // requested blocks to be emerged
-       m_emerge->stopThreads();
-
        // Delete things in the reverse order of creation
        delete m_emerge;
        delete m_env;
@@ -358,7 +367,7 @@ Server::~Server()
        delete m_craftdef;
 
        // Deinitialize scripting
-       infostream<<"Server: Deinitializing scripting"<<std::endl;
+       infostream << "Server: Deinitializing scripting" << std::endl;
        delete m_script;
 
        // Delete detached inventories
@@ -1492,7 +1501,7 @@ void Server::SendItemDef(session_t peer_id,
 }
 
 void Server::SendNodeDef(session_t peer_id,
-               INodeDefManager *nodedef, u16 protocol_version)
+       const NodeDefManager *nodedef, u16 protocol_version)
 {
        NetworkPacket pkt(TOCLIENT_NODEDEF, 0, peer_id);
 
@@ -1562,8 +1571,10 @@ void Server::SendShowFormspecMessage(session_t peer_id, const std::string &forms
        NetworkPacket pkt(TOCLIENT_SHOW_FORMSPEC, 0 , peer_id);
        if (formspec.empty()){
                //the client should close the formspec
+               m_formspec_state_data.erase(peer_id);
                pkt.putLongString("");
        } else {
+               m_formspec_state_data[peer_id] = formname;
                pkt.putLongString(FORMSPEC_VERSION_STRING + formspec);
        }
        pkt << formname;
@@ -1764,17 +1775,11 @@ void Server::SendSetSky(session_t peer_id, const video::SColor &bgcolor,
        Send(&pkt);
 }
 
-void Server::SendCloudParams(session_t peer_id, float density,
-               const video::SColor &color_bright,
-               const video::SColor &color_ambient,
-               float height,
-               float thickness,
-               const v2f &speed)
+void Server::SendCloudParams(session_t peer_id, const CloudParams &params)
 {
        NetworkPacket pkt(TOCLIENT_CLOUD_PARAMS, 0, peer_id);
-       pkt << density << color_bright << color_ambient
-                       << height << thickness << speed;
-
+       pkt << params.density << params.color_bright << params.color_ambient
+                       << params.height << params.thickness << params.speed;
        Send(&pkt);
 }
 
@@ -2253,7 +2258,8 @@ void Server::fillMediaCache()
                paths.push_back(mod.path + DIR_DELIM + "models");
                paths.push_back(mod.path + DIR_DELIM + "locale");
        }
-       paths.push_back(porting::path_user + DIR_DELIM + "textures" + DIR_DELIM + "server");
+       fs::GetRecursiveDirs(paths, m_gamespec.path + DIR_DELIM + "textures");
+       fs::GetRecursiveDirs(paths, porting::path_user + DIR_DELIM + "textures" + DIR_DELIM + "server");
 
        // Collect media file information from paths into cache
        for (const std::string &mediapath : paths) {
@@ -2650,6 +2656,9 @@ void Server::DeleteClient(session_t peer_id, ClientDeletionReason reason)
                                ++i;
                }
 
+               // clear formspec info so the next client can't abuse the current state
+               m_formspec_state_data.erase(peer_id);
+
                RemotePlayer *player = m_env->getPlayer(peer_id);
 
                /* Run scripts and remove from environment */
@@ -3075,11 +3084,6 @@ bool Server::hudSetHotbarItemcount(RemotePlayer *player, s32 hotbar_itemcount)
        return true;
 }
 
-s32 Server::hudGetHotbarItemcount(RemotePlayer *player) const
-{
-       return player->getHotbarItemcount();
-}
-
 void Server::hudSetHotbarImage(RemotePlayer *player, std::string name)
 {
        if (!player)
@@ -3089,13 +3093,6 @@ void Server::hudSetHotbarImage(RemotePlayer *player, std::string name)
        SendHUDSetParam(player->getPeerId(), HUD_PARAM_HOTBAR_IMAGE, name);
 }
 
-std::string Server::hudGetHotbarImage(RemotePlayer *player)
-{
-       if (!player)
-               return "";
-       return player->getHotbarImage();
-}
-
 void Server::hudSetHotbarSelectedImage(RemotePlayer *player, std::string name)
 {
        if (!player)
@@ -3105,64 +3102,41 @@ void Server::hudSetHotbarSelectedImage(RemotePlayer *player, std::string name)
        SendHUDSetParam(player->getPeerId(), HUD_PARAM_HOTBAR_SELECTED_IMAGE, name);
 }
 
-const std::string& Server::hudGetHotbarSelectedImage(RemotePlayer *player) const
-{
-       return player->getHotbarSelectedImage();
-}
-
 Address Server::getPeerAddress(session_t peer_id)
 {
        return m_con->GetPeerAddress(peer_id);
 }
 
-bool Server::setLocalPlayerAnimations(RemotePlayer *player,
+void Server::setLocalPlayerAnimations(RemotePlayer *player,
                v2s32 animation_frames[4], f32 frame_speed)
 {
-       if (!player)
-               return false;
-
+       sanity_check(player);
        player->setLocalAnimations(animation_frames, frame_speed);
        SendLocalPlayerAnimations(player->getPeerId(), animation_frames, frame_speed);
-       return true;
 }
 
-bool Server::setPlayerEyeOffset(RemotePlayer *player, v3f first, v3f third)
+void Server::setPlayerEyeOffset(RemotePlayer *player, const v3f &first, const v3f &third)
 {
-       if (!player)
-               return false;
-
+       sanity_check(player);
        player->eye_offset_first = first;
        player->eye_offset_third = third;
        SendEyeOffset(player->getPeerId(), first, third);
-       return true;
 }
 
-bool Server::setSky(RemotePlayer *player, const video::SColor &bgcolor,
+void Server::setSky(RemotePlayer *player, const video::SColor &bgcolor,
        const std::string &type, const std::vector<std::string> &params,
        bool &clouds)
 {
-       if (!player)
-               return false;
-
+       sanity_check(player);
        player->setSky(bgcolor, type, params, clouds);
        SendSetSky(player->getPeerId(), bgcolor, type, params, clouds);
-       return true;
 }
 
-bool Server::setClouds(RemotePlayer *player, float density,
-       const video::SColor &color_bright,
-       const video::SColor &color_ambient,
-       float height,
-       float thickness,
-       const v2f &speed)
+void Server::setClouds(RemotePlayer *player, const CloudParams &params)
 {
-       if (!player)
-               return false;
-
-       SendCloudParams(player->getPeerId(), density,
-                       color_bright, color_ambient, height,
-                       thickness, speed);
-       return true;
+       sanity_check(player);
+       player->setCloudParams(params);
+       SendCloudParams(player->getPeerId(), params);
 }
 
 bool Server::overrideDayNightRatio(RemotePlayer *player, bool do_override,
@@ -3331,7 +3305,7 @@ IItemDefManager *Server::getItemDefManager()
        return m_itemdef;
 }
 
-INodeDefManager *Server::getNodeDefManager()
+const NodeDefManager *Server::getNodeDefManager()
 {
        return m_nodedef;
 }
@@ -3356,7 +3330,7 @@ IWritableItemDefManager *Server::getWritableItemDefManager()
        return m_itemdef;
 }
 
-IWritableNodeDefManager *Server::getWritableNodeDefManager()
+NodeDefManager *Server::getWritableNodeDefManager()
 {
        return m_nodedef;
 }