]> git.lizzy.rs Git - minetest.git/blobdiff - src/server.cpp
Properly handle mod-errors in on_shutdown
[minetest.git] / src / server.cpp
index 6ecbd70973d58b5163b0336f895584bd356343de..7b3978462673cc57c08070b001b1154a3817717f 100644 (file)
@@ -213,7 +213,8 @@ Server::Server(
                bool simple_singleplayer_mode,
                Address bind_addr,
                bool dedicated,
-               ChatInterface *iface
+               ChatInterface *iface,
+               std::string *on_shutdown_errmsg
        ):
        m_bind_addr(bind_addr),
        m_path_world(path_world),
@@ -232,6 +233,7 @@ Server::Server(
        m_thread(new ServerThread(this)),
        m_clients(m_con),
        m_admin_chat(iface),
+       m_on_shutdown_errmsg(on_shutdown_errmsg),
        m_modchannel_mgr(new ModChannelMgr())
 {
        if (m_path_world.empty())
@@ -314,7 +316,18 @@ Server::~Server()
 
                // Execute script shutdown hooks
                infostream << "Executing shutdown hooks" << std::endl;
-               m_script->on_shutdown();
+               try {
+                       m_script->on_shutdown();
+               } catch (ModError &e) {
+                       errorstream << "ModError: " << e.what() << std::endl;
+                       if (m_on_shutdown_errmsg) {
+                               if (m_on_shutdown_errmsg->empty()) {
+                                       *m_on_shutdown_errmsg = std::string("ModError: ") + e.what();
+                               } else {
+                                       *m_on_shutdown_errmsg += std::string("\nModError: ") + e.what();
+                               }
+                       }
+               }
 
                infostream << "Server: Saving environment metadata" << std::endl;
                m_env->saveMeta();
@@ -356,8 +369,13 @@ void Server::init()
        infostream << "- game:   " << m_gamespec.path << std::endl;
 
        // Create world if it doesn't exist
-       if (!loadGameConfAndInitWorld(m_path_world, m_gamespec))
-               throw ServerError("Failed to initialize world");
+       try {
+               loadGameConfAndInitWorld(m_path_world,
+                               fs::GetFilenameFromPath(m_path_world.c_str()),
+                               m_gamespec, false);
+       } catch (const BaseException &e) {
+               throw ServerError(std::string("Failed to initialize world: ") + e.what());
+       }
 
        // Create emerge manager
        m_emerge = new EmergeManager(this);
@@ -2405,94 +2423,113 @@ bool Server::SendBlock(session_t peer_id, const v3s16 &blockpos)
        return true;
 }
 
+bool Server::addMediaFile(const std::string &filename,
+       const std::string &filepath, std::string *filedata_to,
+       std::string *digest_to)
+{
+       // If name contains illegal characters, ignore the file
+       if (!string_allowed(filename, TEXTURENAME_ALLOWED_CHARS)) {
+               infostream << "Server: ignoring illegal file name: \""
+                               << filename << "\"" << std::endl;
+               return false;
+       }
+       // If name is not in a supported format, ignore it
+       const char *supported_ext[] = {
+               ".png", ".jpg", ".bmp", ".tga",
+               ".pcx", ".ppm", ".psd", ".wal", ".rgb",
+               ".ogg",
+               ".x", ".b3d", ".md2", ".obj",
+               // Custom translation file format
+               ".tr",
+               NULL
+       };
+       if (removeStringEnd(filename, supported_ext).empty()) {
+               infostream << "Server: ignoring unsupported file extension: \""
+                               << filename << "\"" << std::endl;
+               return false;
+       }
+       // Ok, attempt to load the file and add to cache
+
+       // Read data
+       std::ifstream fis(filepath.c_str(), std::ios_base::binary);
+       if (!fis.good()) {
+               errorstream << "Server::addMediaFile(): Could not open \""
+                               << filename << "\" for reading" << std::endl;
+               return false;
+       }
+       std::string filedata;
+       bool bad = false;
+       for (;;) {
+               char buf[1024];
+               fis.read(buf, sizeof(buf));
+               std::streamsize len = fis.gcount();
+               filedata.append(buf, len);
+               if (fis.eof())
+                       break;
+               if (!fis.good()) {
+                       bad = true;
+                       break;
+               }
+       }
+       if (bad) {
+               errorstream << "Server::addMediaFile(): Failed to read \""
+                               << filename << "\"" << std::endl;
+               return false;
+       } else if (filedata.empty()) {
+               errorstream << "Server::addMediaFile(): Empty file \""
+                               << filepath << "\"" << std::endl;
+               return false;
+       }
+
+       SHA1 sha1;
+       sha1.addBytes(filedata.c_str(), filedata.length());
+
+       unsigned char *digest = sha1.getDigest();
+       std::string sha1_base64 = base64_encode(digest, 20);
+       std::string sha1_hex = hex_encode((char*) digest, 20);
+       if (digest_to)
+               *digest_to = std::string((char*) digest, 20);
+       free(digest);
+
+       // Put in list
+       m_media[filename] = MediaInfo(filepath, sha1_base64);
+       verbosestream << "Server: " << sha1_hex << " is " << filename
+                       << std::endl;
+
+       if (filedata_to)
+               *filedata_to = std::move(filedata);
+       return true;
+}
+
 void Server::fillMediaCache()
 {
-       infostream<<"Server: Calculating media file checksums"<<std::endl;
+       infostream << "Server: Calculating media file checksums" << std::endl;
 
        // Collect all media file paths
        std::vector<std::string> paths;
-       m_modmgr->getModsMediaPaths(paths);
-       fs::GetRecursiveDirs(paths, m_gamespec.path + DIR_DELIM + "textures");
+       // The paths are ordered in descending priority
        fs::GetRecursiveDirs(paths, porting::path_user + DIR_DELIM + "textures" + DIR_DELIM + "server");
+       fs::GetRecursiveDirs(paths, m_gamespec.path + DIR_DELIM + "textures");
+       m_modmgr->getModsMediaPaths(paths);
 
        // Collect media file information from paths into cache
        for (const std::string &mediapath : paths) {
                std::vector<fs::DirListNode> dirlist = fs::GetDirListing(mediapath);
                for (const fs::DirListNode &dln : dirlist) {
-                       if (dln.dir) // Ignode dirs
+                       if (dln.dir) // Ignore dirs (already in paths)
                                continue;
-                       std::string filename = dln.name;
-                       // If name contains illegal characters, ignore the file
-                       if (!string_allowed(filename, TEXTURENAME_ALLOWED_CHARS)) {
-                               infostream<<"Server: ignoring illegal file name: \""
-                                               << filename << "\"" << std::endl;
-                               continue;
-                       }
-                       // If name is not in a supported format, ignore it
-                       const char *supported_ext[] = {
-                               ".png", ".jpg", ".bmp", ".tga",
-                               ".pcx", ".ppm", ".psd", ".wal", ".rgb",
-                               ".ogg",
-                               ".x", ".b3d", ".md2", ".obj",
-                               // Custom translation file format
-                               ".tr",
-                               NULL
-                       };
-                       if (removeStringEnd(filename, supported_ext).empty()){
-                               infostream << "Server: ignoring unsupported file extension: \""
-                                               << filename << "\"" << std::endl;
-                               continue;
-                       }
-                       // Ok, attempt to load the file and add to cache
-                       std::string filepath;
-                       filepath.append(mediapath).append(DIR_DELIM).append(filename);
-
-                       // Read data
-                       std::ifstream fis(filepath.c_str(), std::ios_base::binary);
-                       if (!fis.good()) {
-                               errorstream << "Server::fillMediaCache(): Could not open \""
-                                               << filename << "\" for reading" << std::endl;
-                               continue;
-                       }
-                       std::ostringstream tmp_os(std::ios_base::binary);
-                       bool bad = false;
-                       for(;;) {
-                               char buf[1024];
-                               fis.read(buf, 1024);
-                               std::streamsize len = fis.gcount();
-                               tmp_os.write(buf, len);
-                               if (fis.eof())
-                                       break;
-                               if (!fis.good()) {
-                                       bad = true;
-                                       break;
-                               }
-                       }
-                       if(bad) {
-                               errorstream<<"Server::fillMediaCache(): Failed to read \""
-                                               << filename << "\"" << std::endl;
-                               continue;
-                       }
-                       if(tmp_os.str().length() == 0) {
-                               errorstream << "Server::fillMediaCache(): Empty file \""
-                                               << filepath << "\"" << std::endl;
-                               continue;
-                       }
-
-                       SHA1 sha1;
-                       sha1.addBytes(tmp_os.str().c_str(), tmp_os.str().length());
 
-                       unsigned char *digest = sha1.getDigest();
-                       std::string sha1_base64 = base64_encode(digest, 20);
-                       std::string sha1_hex = hex_encode((char*)digest, 20);
-                       free(digest);
+                       const std::string &filename = dln.name;
+                       if (m_media.find(filename) != m_media.end()) // Do not override
+                               continue;
 
-                       // Put in list
-                       m_media[filename] = MediaInfo(filepath, sha1_base64);
-                       verbosestream << "Server: " << sha1_hex << " is " << filename
-                                       << std::endl;
+                       std::string filepath = mediapath;
+                       filepath.append(DIR_DELIM).append(filename);
+                       addMediaFile(filename, filepath);
                }
        }
+
+       infostream << "Server: " << m_media.size() << " media files collected" << std::endl;
 }
 
 void Server::sendMediaAnnouncement(session_t peer_id, const std::string &lang_code)
@@ -3428,6 +3465,44 @@ void Server::deleteParticleSpawner(const std::string &playername, u32 id)
        SendDeleteParticleSpawner(peer_id, id);
 }
 
+bool Server::dynamicAddMedia(const std::string &filepath)
+{
+       std::string filename = fs::GetFilenameFromPath(filepath.c_str());
+       if (m_media.find(filename) != m_media.end()) {
+               errorstream << "Server::dynamicAddMedia(): file \"" << filename
+                       << "\" already exists in media cache" << std::endl;
+               return false;
+       }
+
+       // Load the file and add it to our media cache
+       std::string filedata, raw_hash;
+       bool ok = addMediaFile(filename, filepath, &filedata, &raw_hash);
+       if (!ok)
+               return false;
+
+       // Push file to existing clients
+       NetworkPacket pkt(TOCLIENT_MEDIA_PUSH, 0);
+       pkt << raw_hash << filename << (bool) true;
+       pkt.putLongString(filedata);
+
+       auto client_ids = m_clients.getClientIDs(CS_DefinitionsSent);
+       for (session_t client_id : client_ids) {
+               /*
+                       The network layer only guarantees ordered delivery inside a channel.
+                       Since the very next packet could be one that uses the media, we have
+                       to push the media over ALL channels to ensure it is processed before
+                       it is used.
+                       In practice this means we have to send it twice:
+                       - channel 1 (HUD)
+                       - channel 0 (everything else: e.g. play_sound, object messages)
+               */
+               m_clients.send(client_id, 1, &pkt, true);
+               m_clients.send(client_id, 0, &pkt, true);
+       }
+
+       return true;
+}
+
 // actions: time-reversed list
 // Return value: success/failure
 bool Server::rollbackRevertActions(const std::list<RollbackAction> &actions,