]> git.lizzy.rs Git - dragonfireclient.git/blobdiff - src/server.cpp
Handle particle spawners in env and delete expired ids
[dragonfireclient.git] / src / server.cpp
index 09884f1bc0aa6ea7cb5c370545e5558606e53f2c..0aba2796c27c21d8a83a7425a6ed3870028261ba 100644 (file)
@@ -26,8 +26,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "ban.h"
 #include "environment.h"
 #include "map.h"
-#include "jthread/jmutexautolock.h"
-#include "main.h"
+#include "threading/mutex_auto_lock.h"
 #include "constants.h"
 #include "voxel.h"
 #include "config.h"
@@ -72,65 +71,48 @@ class ClientNotFoundException : public BaseException
        {}
 };
 
-class ServerThread : public JThread
+class ServerThread : public Thread
 {
-       Server *m_server;
-
 public:
 
        ServerThread(Server *server):
-               JThread(),
+               Thread("Server"),
                m_server(server)
-       {
-       }
+       {}
 
-       void * Thread();
+       void *run();
+
+private:
+       Server *m_server;
 };
 
-void * ServerThread::Thread()
+void *ServerThread::run()
 {
-       log_register_thread("ServerThread");
-
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        BEGIN_DEBUG_EXCEPTION_HANDLER
 
        m_server->AsyncRunStep(true);
 
-       ThreadStarted();
-
-       porting::setThreadName("ServerThread");
-
-       while(!StopRequested())
-       {
-               try{
+       while (!stopRequested()) {
+               try {
                        //TimeTaker timer("AsyncRunStep() + Receive()");
 
                        m_server->AsyncRunStep();
 
                        m_server->Receive();
 
-               }
-               catch(con::NoIncomingDataException &e)
-               {
-               }
-               catch(con::PeerNotFoundException &e)
-               {
+               } catch (con::NoIncomingDataException &e) {
+               } catch (con::PeerNotFoundException &e) {
                        infostream<<"Server: PeerNotFoundException"<<std::endl;
-               }
-               catch(ClientNotFoundException &e)
-               {
-               }
-               catch(con::ConnectionBindFailed &e)
-               {
-                       m_server->setAsyncFatalError(e.what());
-               }
-               catch(LuaError &e)
-               {
+               } catch (ClientNotFoundException &e) {
+               } catch (con::ConnectionBindFailed &e) {
                        m_server->setAsyncFatalError(e.what());
+               } catch (LuaError &e) {
+                       m_server->setAsyncFatalError("Lua: " + std::string(e.what()));
                }
        }
 
-       END_DEBUG_EXCEPTION_HANDLER(errorstream)
+       END_DEBUG_EXCEPTION_HANDLER
 
        return NULL;
 }
@@ -166,7 +148,8 @@ Server::Server(
                const std::string &path_world,
                const SubgameSpec &gamespec,
                bool simple_singleplayer_mode,
-               bool ipv6
+               bool ipv6,
+               ChatInterface *iface
        ):
        m_path_world(path_world),
        m_gamespec(gamespec),
@@ -192,6 +175,8 @@ Server::Server(
        m_uptime(0),
        m_clients(&m_con),
        m_shutdown_requested(false),
+       m_shutdown_ask_reconnect(false),
+       m_admin_chat(iface),
        m_ignore_map_edit_events(false),
        m_ignore_map_edit_events_peer_id(0),
        m_next_sound_id(0)
@@ -222,12 +207,9 @@ Server::Server(
        infostream<<"- world:  "<<m_path_world<<std::endl;
        infostream<<"- game:   "<<m_gamespec.path<<std::endl;
 
-       // Initialize default settings and override defaults with those provided
-       // by the game
-       set_default_settings(g_settings);
-       Settings gamedefaults;
-       getGameMinetestConfig(gamespec.path, gamedefaults);
-       override_default_settings(g_settings, &gamedefaults);
+       // Create world if it doesn't exist
+       if(!loadGameConfAndInitWorld(m_path_world, m_gamespec))
+               throw ServerError("Failed to initialize world");
 
        // Create server thread
        m_thread = new ServerThread(this);
@@ -235,10 +217,6 @@ Server::Server(
        // Create emerge manager
        m_emerge = new EmergeManager(this);
 
-       // Create world if it doesn't exist
-       if(!initializeWorld(m_path_world, m_gamespec.id))
-               throw ServerError("Failed to initialize world");
-
        // Create ban manager
        std::string ban_path = m_path_world + DIR_DELIM "ipban.txt";
        m_banmanager = new BanManager(ban_path);
@@ -247,11 +225,9 @@ Server::Server(
        m_mods = modconf.getMods();
        std::vector<ModSpec> unsatisfied_mods = modconf.getUnsatisfiedMods();
        // complain about mods with unsatisfied dependencies
-       if(!modconf.isConsistent())
-       {
+       if(!modconf.isConsistent()) {
                for(std::vector<ModSpec>::iterator it = unsatisfied_mods.begin();
-                       it != unsatisfied_mods.end(); ++it)
-               {
+                       it != unsatisfied_mods.end(); ++it) {
                        ModSpec mod = *it;
                        errorstream << "mod \"" << mod.name << "\" has unsatisfied dependencies: ";
                        for(std::set<std::string>::iterator dep_it = mod.unsatisfied_depends.begin();
@@ -267,8 +243,7 @@ Server::Server(
        std::vector<std::string> names = worldmt_settings.getNames();
        std::set<std::string> load_mod_names;
        for(std::vector<std::string>::iterator it = names.begin();
-               it != names.end(); ++it)
-       {
+               it != names.end(); ++it) {
                std::string name = *it;
                if(name.compare(0,9,"load_mod_")==0 && worldmt_settings.getBool(name))
                        load_mod_names.insert(name.substr(9));
@@ -280,8 +255,7 @@ Server::Server(
        for(std::vector<ModSpec>::iterator it = unsatisfied_mods.begin();
                        it != unsatisfied_mods.end(); ++it)
                load_mod_names.erase((*it).name);
-       if(!load_mod_names.empty())
-       {
+       if(!load_mod_names.empty()) {
                errorstream << "The following mods could not be found:";
                for(std::set<std::string>::iterator it = load_mod_names.begin();
                        it != load_mod_names.end(); ++it)
@@ -289,8 +263,8 @@ Server::Server(
                errorstream << std::endl;
        }
 
-       // Lock environment
-       JMutexAutoLock envlock(m_env_mutex);
+       //lock environment
+       MutexAutoLock envlock(m_env_mutex);
 
        // Load mapgen params from Settings
        m_emerge->loadMapgenParams();
@@ -303,32 +277,31 @@ Server::Server(
 
        m_script = new GameScripting(this);
 
-       std::string scriptpath = getBuiltinLuaPath() + DIR_DELIM "init.lua";
+       std::string script_path = getBuiltinLuaPath() + DIR_DELIM "init.lua";
 
-       if (!m_script->loadScript(scriptpath))
-               throw ModError("Failed to load and run " + scriptpath);
+       m_script->loadMod(script_path, BUILTIN_MOD_NAME);
 
-       // Print 'em
-       infostream<<"Server: Loading mods: ";
+       // Print mods
+       infostream << "Server: Loading mods: ";
        for(std::vector<ModSpec>::iterator i = m_mods.begin();
-                       i != m_mods.end(); i++){
+                       i != m_mods.end(); ++i) {
                const ModSpec &mod = *i;
-               infostream<<mod.name<<" ";
+               infostream << mod.name << " ";
        }
-       infostream<<std::endl;
+       infostream << std::endl;
        // Load and run "mod" scripts
-       for(std::vector<ModSpec>::iterator i = m_mods.begin();
-                       i != m_mods.end(); i++){
-               const ModSpec &mod = *i;
-               std::string scriptpath = mod.path + DIR_DELIM + "init.lua";
-               infostream<<"  ["<<padStringRight(mod.name, 12)<<"] [\""
-                               <<scriptpath<<"\"]"<<std::endl;
-               bool success = m_script->loadMod(scriptpath, mod.name);
-               if(!success){
-                       errorstream<<"Server: Failed to load and run "
-                                       <<scriptpath<<std::endl;
-                       throw ModError("Failed to load and run "+scriptpath);
+       for (std::vector<ModSpec>::iterator it = m_mods.begin();
+                       it != m_mods.end(); ++it) {
+               const ModSpec &mod = *it;
+               if (!string_allowed(mod.name, MODNAME_ALLOWED_CHARS)) {
+                       throw ModError("Error loading mod \"" + mod.name +
+                               "\": Mod name does not follow naming conventions: "
+                               "Only chararacters [a-z0-9_] are allowed.");
                }
+               std::string script_path = mod.path + DIR_DELIM + "init.lua";
+               infostream << "  [" << padStringRight(mod.name, 12) << "] [\""
+                               << script_path << "\"]" << std::endl;
+               m_script->loadMod(script_path, mod.name);
        }
 
        // Read Textures and calculate sha1 sums
@@ -337,10 +310,21 @@ Server::Server(
        // Apply item aliases in the node definition manager
        m_nodedef->updateAliases(m_itemdef);
 
+       // Apply texture overrides from texturepack/override.txt
+       std::string texture_path = g_settings->get("texture_path");
+       if (texture_path != "" && fs::IsDir(texture_path))
+               m_nodedef->applyTextureOverrides(texture_path + DIR_DELIM + "override.txt");
+
        m_nodedef->setNodeRegistrationStatus(true);
 
        // Perform pending node name resolutions
-       m_nodedef->runNodeResolverCallbacks();
+       m_nodedef->runNodeResolveCallbacks();
+
+       // unmap node names for connected nodeboxes
+       m_nodedef->mapNodeboxConnections();
+
+       // init the recipe hashes to speed up crafting
+       m_craftdef->initHashes(this);
 
        // Initialize Environment
        m_env = new ServerEnvironment(servermap, m_script, this, m_path_world);
@@ -363,10 +347,11 @@ Server::Server(
        servermap->addEventReceiver(this);
 
        // If file exists, load environment metadata
-       if(fs::PathExists(m_path_world + DIR_DELIM "env_meta.txt"))
-       {
-               infostream<<"Server: Loading environment metadata"<<std::endl;
+       if (fs::PathExists(m_path_world + DIR_DELIM "env_meta.txt")) {
+               infostream << "Server: Loading environment metadata" << std::endl;
                m_env->loadMeta();
+       } else {
+               m_env->loadDefaultMeta();
        }
 
        // Add some test ActiveBlockModifiers to environment
@@ -383,15 +368,28 @@ Server::~Server()
        SendChatMessage(PEER_ID_INEXISTENT, L"*** Server shutting down");
 
        {
-               JMutexAutoLock envlock(m_env_mutex);
+               MutexAutoLock envlock(m_env_mutex);
 
                // Execute script shutdown hooks
                m_script->on_shutdown();
 
-               infostream<<"Server: Saving players"<<std::endl;
+               infostream << "Server: Saving players" << std::endl;
                m_env->saveLoadedPlayers();
 
-               infostream<<"Server: Saving environment metadata"<<std::endl;
+               infostream << "Server: Kicking players" << std::endl;
+               std::string kick_msg;
+               bool reconnect = false;
+               if (getShutdownRequested()) {
+                       reconnect = m_shutdown_ask_reconnect;
+                       kick_msg = m_shutdown_msg;
+               }
+               if (kick_msg == "") {
+                       kick_msg = g_settings->get("kick_msg_shutdown");
+               }
+               m_env->kickAllPlayers(SERVER_ACCESSDENIED_SHUTDOWN,
+                       kick_msg, reconnect);
+
+               infostream << "Server: Saving environment metadata" << std::endl;
                m_env->saveMeta();
        }
 
@@ -423,14 +421,14 @@ Server::~Server()
        // Delete detached inventories
        for (std::map<std::string, Inventory*>::iterator
                        i = m_detached_inventories.begin();
-                       i != m_detached_inventories.end(); i++) {
+                       i != m_detached_inventories.end(); ++i) {
                delete i->second;
        }
 }
 
 void Server::start(Address bind_addr)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        m_bind_addr = bind_addr;
 
@@ -438,14 +436,14 @@ void Server::start(Address bind_addr)
                        << bind_addr.serializeString() <<"..."<<std::endl;
 
        // Stop thread if already running
-       m_thread->Stop();
+       m_thread->stop();
 
        // Initialize connection
        m_con.SetTimeoutMs(30);
        m_con.Serve(bind_addr);
 
        // Start thread
-       m_thread->Start();
+       m_thread->start();
 
        // ASCII art for the win!
        actionstream
@@ -463,14 +461,14 @@ void Server::start(Address bind_addr)
 
 void Server::stop()
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        infostream<<"Server: Stopping and waiting threads"<<std::endl;
 
        // Stop threads (set run=false first so both start stopping)
-       m_thread->Stop();
+       m_thread->stop();
        //m_emergethread.setRun(false);
-       m_thread->Wait();
+       m_thread->wait();
        //m_emergethread.stop();
 
        infostream<<"Server: Threads stopped"<<std::endl;
@@ -478,30 +476,35 @@ void Server::stop()
 
 void Server::step(float dtime)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        // Limit a bit
-       if(dtime > 2.0)
+       if (dtime > 2.0)
                dtime = 2.0;
        {
-               JMutexAutoLock lock(m_step_dtime_mutex);
+               MutexAutoLock lock(m_step_dtime_mutex);
                m_step_dtime += dtime;
        }
        // Throw if fatal error occurred in thread
        std::string async_err = m_async_fatal_error.get();
-       if(async_err != ""){
+       if (!async_err.empty()) {
+               if (!m_simple_singleplayer_mode) {
+                       m_env->kickAllPlayers(SERVER_ACCESSDENIED_CRASH,
+                               g_settings->get("kick_msg_crash"),
+                               g_settings->getBool("ask_reconnect_on_crash"));
+               }
                throw ServerError(async_err);
        }
 }
 
 void Server::AsyncRunStep(bool initial_step)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        g_profiler->add("Server::AsyncRunStep (num)", 1);
 
        float dtime;
        {
-               JMutexAutoLock lock1(m_step_dtime_mutex);
+               MutexAutoLock lock1(m_step_dtime_mutex);
                dtime = m_step_dtime;
        }
 
@@ -519,7 +522,7 @@ void Server::AsyncRunStep(bool initial_step)
        //infostream<<"Server::AsyncRunStep(): dtime="<<dtime<<std::endl;
 
        {
-               JMutexAutoLock lock1(m_step_dtime_mutex);
+               MutexAutoLock lock1(m_step_dtime_mutex);
                m_step_dtime -= dtime;
        }
 
@@ -550,7 +553,7 @@ void Server::AsyncRunStep(bool initial_step)
        }
 
        {
-               JMutexAutoLock lock(m_env_mutex);
+               MutexAutoLock lock(m_env_mutex);
                // Figure out and report maximum lag to environment
                float max_lag = m_env->getMaxLagEstimate();
                max_lag *= 0.9998; // Decrease slowly (about half per 5 minutes)
@@ -570,11 +573,28 @@ void Server::AsyncRunStep(bool initial_step)
        static const float map_timer_and_unload_dtime = 2.92;
        if(m_map_timer_and_unload_interval.step(dtime, map_timer_and_unload_dtime))
        {
-               JMutexAutoLock lock(m_env_mutex);
+               MutexAutoLock lock(m_env_mutex);
                // Run Map's timers and unload unused data
                ScopeProfiler sp(g_profiler, "Server: map timer and unload");
                m_env->getMap().timerUpdate(map_timer_and_unload_dtime,
-                               g_settings->getFloat("server_unload_unused_data_timeout"));
+                       g_settings->getFloat("server_unload_unused_data_timeout"),
+                       U32_MAX);
+       }
+
+       /*
+               Listen to the admin chat, if available
+       */
+       if (m_admin_chat) {
+               if (!m_admin_chat->command_queue.empty()) {
+                       MutexAutoLock lock(m_env_mutex);
+                       while (!m_admin_chat->command_queue.empty()) {
+                               ChatEvent *evt = m_admin_chat->command_queue.pop_frontNoEx();
+                               handleChatInterfaceEvent(evt);
+                               delete evt;
+                       }
+               }
+               m_admin_chat->outgoing_queue.push_back(
+                       new ChatEventTimeInfo(m_env->getGameTime(), m_env->getTimeOfDay()));
        }
 
        /*
@@ -587,7 +607,7 @@ void Server::AsyncRunStep(bool initial_step)
        {
                m_liquid_transform_timer -= m_liquid_transform_every;
 
-               JMutexAutoLock lock(m_env_mutex);
+               MutexAutoLock lock(m_env_mutex);
 
                ScopeProfiler sp(g_profiler, "Server: liquid transform");
 
@@ -648,27 +668,28 @@ void Server::AsyncRunStep(bool initial_step)
        */
        {
                //infostream<<"Server: Checking added and deleted active objects"<<std::endl;
-               JMutexAutoLock envlock(m_env_mutex);
+               MutexAutoLock envlock(m_env_mutex);
 
-               m_clients.Lock();
+               m_clients.lock();
                std::map<u16, RemoteClient*> clients = m_clients.getClientList();
                ScopeProfiler sp(g_profiler, "Server: checking added and deleted objs");
 
                // Radius inside which objects are active
-               s16 radius = g_settings->getS16("active_object_send_range_blocks");
-               s16 player_radius = g_settings->getS16("player_transfer_distance");
-
-               if (player_radius == 0 && g_settings->exists("unlimited_player_transfer_distance") &&
-                               !g_settings->getBool("unlimited_player_transfer_distance"))
+               static const s16 radius =
+                       g_settings->getS16("active_object_send_range_blocks") * MAP_BLOCKSIZE;
+
+               // Radius inside which players are active
+               static const bool is_transfer_limited =
+                       g_settings->exists("unlimited_player_transfer_distance") &&
+                       !g_settings->getBool("unlimited_player_transfer_distance");
+               static const s16 player_transfer_dist = g_settings->getS16("player_transfer_distance") * MAP_BLOCKSIZE;
+               s16 player_radius = player_transfer_dist;
+               if (player_radius == 0 && is_transfer_limited)
                        player_radius = radius;
 
-               radius *= MAP_BLOCKSIZE;
-               player_radius *= MAP_BLOCKSIZE;
-
-               for(std::map<u16, RemoteClient*>::iterator
+               for (std::map<u16, RemoteClient*>::iterator
                        i = clients.begin();
-                       i != clients.end(); ++i)
-               {
+                       i != clients.end(); ++i) {
                        RemoteClient *client = i->second;
 
                        // If definitions and textures have not been sent, don't
@@ -677,27 +698,23 @@ void Server::AsyncRunStep(bool initial_step)
                                continue;
 
                        Player *player = m_env->getPlayer(client->peer_id);
-                       if(player==NULL)
-                       {
+                       if(player == NULL) {
                                // This can happen if the client timeouts somehow
-                               /*infostream<<"WARNING: "<<__FUNCTION_NAME<<": Client "
+                               /*warningstream<<FUNCTION_NAME<<": Client "
                                                <<client->peer_id
                                                <<" has no associated player"<<std::endl;*/
                                continue;
                        }
-                       v3s16 pos = floatToInt(player->getPosition(), BS);
 
-                       std::set<u16> removed_objects;
-                       std::set<u16> added_objects;
-                       m_env->getRemovedActiveObjects(pos, radius, player_radius,
+                       std::queue<u16> removed_objects;
+                       std::queue<u16> added_objects;
+                       m_env->getRemovedActiveObjects(player, radius, player_radius,
                                        client->m_known_objects, removed_objects);
-                       m_env->getAddedActiveObjects(pos, radius, player_radius,
+                       m_env->getAddedActiveObjects(player, radius, player_radius,
                                        client->m_known_objects, added_objects);
 
                        // Ignore if nothing happened
-                       if(removed_objects.empty() && added_objects.empty())
-                       {
-                               //infostream<<"active objects: none changed"<<std::endl;
+                       if (removed_objects.empty() && added_objects.empty()) {
                                continue;
                        }
 
@@ -708,12 +725,9 @@ void Server::AsyncRunStep(bool initial_step)
                        // Handle removed objects
                        writeU16((u8*)buf, removed_objects.size());
                        data_buffer.append(buf, 2);
-                       for(std::set<u16>::iterator
-                                       i = removed_objects.begin();
-                                       i != removed_objects.end(); ++i)
-                       {
+                       while (!removed_objects.empty()) {
                                // Get object
-                               u16 id = *i;
+                               u16 id = removed_objects.front();
                                ServerActiveObject* obj = m_env->getActiveObject(id);
 
                                // Add to data buffer for sending
@@ -725,23 +739,21 @@ void Server::AsyncRunStep(bool initial_step)
 
                                if(obj && obj->m_known_by_count > 0)
                                        obj->m_known_by_count--;
+                               removed_objects.pop();
                        }
 
                        // Handle added objects
                        writeU16((u8*)buf, added_objects.size());
                        data_buffer.append(buf, 2);
-                       for(std::set<u16>::iterator
-                                       i = added_objects.begin();
-                                       i != added_objects.end(); ++i)
-                       {
+                       while (!added_objects.empty()) {
                                // Get object
-                               u16 id = *i;
+                               u16 id = added_objects.front();
                                ServerActiveObject* obj = m_env->getActiveObject(id);
 
                                // Get object type
                                u8 type = ACTIVEOBJECT_TYPE_INVALID;
                                if(obj == NULL)
-                                       infostream<<"WARNING: "<<__FUNCTION_NAME
+                                       warningstream<<FUNCTION_NAME
                                                        <<": NULL object"<<std::endl;
                                else
                                        type = obj->getSendType();
@@ -763,27 +775,24 @@ void Server::AsyncRunStep(bool initial_step)
 
                                if(obj)
                                        obj->m_known_by_count++;
-                       }
-
-                       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ACTIVE_OBJECT_REMOVE_ADD, 0, client->peer_id);
-                       pkt->putRawString(data_buffer.c_str(), data_buffer.size());
 
+                               added_objects.pop();
+                       }
 
+                       u32 pktSize = SendActiveObjectRemoveAdd(client->peer_id, data_buffer);
                        verbosestream << "Server: Sent object remove/add: "
                                        << removed_objects.size() << " removed, "
                                        << added_objects.size() << " added, "
-                                       << "packet size is " << pkt->getSize() << std::endl;
-
-                       Send(pkt);
+                                       << "packet size is " << pktSize << std::endl;
                }
-               m_clients.Unlock();
+               m_clients.unlock();
        }
 
        /*
                Send object messages
        */
        {
-               JMutexAutoLock envlock(m_env_mutex);
+               MutexAutoLock envlock(m_env_mutex);
                ScopeProfiler sp(g_profiler, "Server: sending object messages");
 
                // Key = object id
@@ -809,7 +818,7 @@ void Server::AsyncRunStep(bool initial_step)
                        message_list->push_back(aom);
                }
 
-               m_clients.Lock();
+               m_clients.lock();
                std::map<u16, RemoteClient*> clients = m_clients.getClientList();
                // Route data to every client
                for (std::map<u16, RemoteClient*>::iterator
@@ -853,22 +862,14 @@ void Server::AsyncRunStep(bool initial_step)
                                Send them.
                        */
                        if(reliable_data.size() > 0) {
-                               NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ACTIVE_OBJECT_MESSAGES,
-                                               0, client->peer_id);
-
-                               pkt->putRawString(reliable_data.c_str(), reliable_data.size());
-                               Send(pkt);
+                               SendActiveObjectMessages(client->peer_id, reliable_data);
                        }
 
                        if(unreliable_data.size() > 0) {
-                               NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ACTIVE_OBJECT_MESSAGES,
-                                               0, client->peer_id);
-
-                               pkt->putRawString(unreliable_data.c_str(), unreliable_data.size());
-                               Send(pkt);
+                               SendActiveObjectMessages(client->peer_id, unreliable_data, false);
                        }
                }
-               m_clients.Unlock();
+               m_clients.unlock();
 
                // Clear buffered_messages
                for(std::map<u16, std::vector<ActiveObjectMessage>* >::iterator
@@ -883,7 +884,7 @@ void Server::AsyncRunStep(bool initial_step)
        */
        {
                // We will be accessing the environment
-               JMutexAutoLock lock(m_env_mutex);
+               MutexAutoLock lock(m_env_mutex);
 
                // Don't send too many at a time
                //u32 count = 0;
@@ -937,7 +938,7 @@ void Server::AsyncRunStep(bool initial_step)
                                break;
                        default:
                                prof.add("unknown", 1);
-                               infostream << "WARNING: Server: Unknown MapEditEvent "
+                               warningstream << "Server: Unknown MapEditEvent "
                                                << ((u32)event->type) << std::endl;
                                break;
                        }
@@ -989,8 +990,7 @@ void Server::AsyncRunStep(bool initial_step)
        {
                float &counter = m_emergethread_trigger_timer;
                counter += dtime;
-               if(counter >= 2.0)
-               {
+               if (counter >= 2.0) {
                        counter = 0.0;
 
                        m_emerge->startThreads();
@@ -1001,10 +1001,11 @@ void Server::AsyncRunStep(bool initial_step)
        {
                float &counter = m_savemap_timer;
                counter += dtime;
-               if(counter >= g_settings->getFloat("server_map_save_interval"))
-               {
+               static const float save_interval =
+                       g_settings->getFloat("server_map_save_interval");
+               if (counter >= save_interval) {
                        counter = 0.0;
-                       JMutexAutoLock lock(m_env_mutex);
+                       MutexAutoLock lock(m_env_mutex);
 
                        ScopeProfiler sp(g_profiler, "Server: saving stuff");
 
@@ -1027,13 +1028,14 @@ void Server::AsyncRunStep(bool initial_step)
 
 void Server::Receive()
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        SharedBuffer<u8> data;
        u16 peer_id;
-       u32 datasize;
        try {
-               datasize = m_con.Receive(peer_id,data);
-               ProcessData(*data, datasize, peer_id);
+               NetworkPacket pkt;
+               m_con.Receive(&pkt);
+               peer_id = pkt.getPeerId();
+               ProcessData(&pkt);
        }
        catch(con::InvalidIncomingDataException &e) {
                infostream<<"Server::Receive(): "
@@ -1047,7 +1049,7 @@ void Server::Receive()
        }
        catch(ClientStateError &e) {
                errorstream << "ProcessData: peer=" << peer_id  << e.what() << std::endl;
-               DenyAccess(peer_id, L"Your client sent something server didn't expect."
+               DenyAccess_Legacy(peer_id, L"Your client sent something server didn't expect."
                                L"Try reconnecting or updating your client");
        }
        catch(con::PeerNotFoundException &e) {
@@ -1059,34 +1061,34 @@ PlayerSAO* Server::StageTwoClientInit(u16 peer_id)
 {
        std::string playername = "";
        PlayerSAO *playersao = NULL;
-       m_clients.Lock();
+       m_clients.lock();
        try {
                RemoteClient* client = m_clients.lockedGetClientNoEx(peer_id, CS_InitDone);
                if (client != NULL) {
                        playername = client->getName();
-                       playersao = emergePlayer(playername.c_str(), peer_id);
+                       playersao = emergePlayer(playername.c_str(), peer_id, client->net_proto_version);
                }
        } catch (std::exception &e) {
-               m_clients.Unlock();
+               m_clients.unlock();
                throw;
        }
-       m_clients.Unlock();
+       m_clients.unlock();
 
        RemotePlayer *player =
                static_cast<RemotePlayer*>(m_env->getPlayer(playername.c_str()));
 
        // If failed, cancel
-       if((playersao == NULL) || (player == NULL)) {
-               if(player && player->peer_id != 0) {
-                       errorstream<<"Server: "<<playername<<": Failed to emerge player"
-                                       <<" (player allocated to an another client)"<<std::endl;
-                       DenyAccess(peer_id, L"Another client is connected with this "
+       if ((playersao == NULL) || (player == NULL)) {
+               if (player && player->peer_id != 0) {
+                       actionstream << "Server: Failed to emerge player \"" << playername
+                                       << "\" (player allocated to an another client)" << std::endl;
+                       DenyAccess_Legacy(peer_id, L"Another client is connected with this "
                                        L"name. If your client closed unexpectedly, try again in "
                                        L"a minute.");
                } else {
-                       errorstream<<"Server: "<<playername<<": Failed to emerge player"
-                                       <<std::endl;
-                       DenyAccess(peer_id, L"Could not allocate player.");
+                       errorstream << "Server: " << playername << ": Failed to emerge player"
+                                       << std::endl;
+                       DenyAccess_Legacy(peer_id, L"Could not allocate player.");
                }
                return NULL;
        }
@@ -1106,14 +1108,13 @@ PlayerSAO* Server::StageTwoClientInit(u16 peer_id)
        SendInventory(playersao);
 
        // Send HP
-       if(g_settings->getBool("enable_damage"))
-               SendPlayerHP(peer_id);
+       SendPlayerHPOrDie(playersao);
 
        // Send Breath
        SendPlayerBreath(peer_id);
 
        // Show death screen if necessary
-       if(player->hp == 0)
+       if(player->isDead())
                SendDeathscreen(peer_id, false, v3f(0,0,0));
 
        // Note things in chat if not in simple singleplayer mode
@@ -1123,16 +1124,19 @@ PlayerSAO* Server::StageTwoClientInit(u16 peer_id)
 
                // Send information about joining in chat
                {
-                       std::wstring name = L"unknown";
+                       std::string name = "unknown";
                        Player *player = m_env->getPlayer(peer_id);
                        if(player != NULL)
-                               name = narrow_to_wide(player->getName());
+                               name = player->getName();
 
                        std::wstring message;
                        message += L"*** ";
-                       message += name;
+                       message += narrow_to_wide(name);
                        message += L" joined the game.";
                        SendChatMessage(PEER_ID_INEXISTENT,message);
+                       if (m_admin_chat)
+                               m_admin_chat->outgoing_queue.push_back(
+                                       new ChatEventNick(CET_NICK_ADD, name));
                }
        }
        Address addr = getPeerAddress(player->peer_id);
@@ -1147,7 +1151,7 @@ PlayerSAO* Server::StageTwoClientInit(u16 peer_id)
                actionstream<<player->getName() <<" joins game. List of players: ";
 
                for (std::vector<std::string>::iterator i = names.begin();
-                               i != names.end(); i++) {
+                               i != names.end(); ++i) {
                        actionstream << *i << " ";
                }
 
@@ -1162,13 +1166,14 @@ inline void Server::handleCommand(NetworkPacket* pkt)
        (this->*opHandle.handler)(pkt);
 }
 
-void Server::ProcessData(u8 *data, u32 datasize, u16 peer_id)
+void Server::ProcessData(NetworkPacket *pkt)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        // Environment is locked first.
-       JMutexAutoLock envlock(m_env_mutex);
+       MutexAutoLock envlock(m_env_mutex);
 
        ScopeProfiler sp(g_profiler, "Server::ProcessData");
+       u32 peer_id = pkt->getPeerId();
 
        try {
                Address address = getPeerAddress(peer_id);
@@ -1180,8 +1185,8 @@ void Server::ProcessData(u8 *data, u32 datasize, u16 peer_id)
                                        << addr_s << "; banned name was "
                                        << ban_name << std::endl;
                        // This actually doesn't seem to transfer to the client
-                       DenyAccess(peer_id, L"Your ip is banned. Banned name was "
-                                       + narrow_to_wide(ban_name));
+                       DenyAccess_Legacy(peer_id, L"Your ip is banned. Banned name was "
+                                       + utf8_to_wide(ban_name));
                        return;
                }
        }
@@ -1192,28 +1197,23 @@ void Server::ProcessData(u8 *data, u32 datasize, u16 peer_id)
                 * respond for some time, your server was overloaded or
                 * things like that.
                 */
-               infostream << "Server::ProcessData(): Cancelling: peer "
+               infostream << "Server::ProcessData(): Canceling: peer "
                                << peer_id << " not found" << std::endl;
                return;
        }
 
        try {
-               if(datasize < 2)
-                       return;
-
-               NetworkPacket* pkt = new NetworkPacket(data, datasize, peer_id);
-
                ToServerCommand command = (ToServerCommand) pkt->getCommand();
 
                // Command must be handled into ToServerCommandHandler
                if (command >= TOSERVER_NUM_MSG_TYPES) {
                        infostream << "Server: Ignoring unknown command "
                                         << command << std::endl;
+                       return;
                }
 
                if (toServerCommandTable[command].state == TOSERVER_STATE_NOT_CONNECTED) {
                        handleCommand(pkt);
-                       delete pkt;
                        return;
                }
 
@@ -1223,15 +1223,12 @@ void Server::ProcessData(u8 *data, u32 datasize, u16 peer_id)
                        errorstream << "Server::ProcessData(): Cancelling: Peer"
                                        " serialization format invalid or not initialized."
                                        " Skipping incoming command=" << command << std::endl;
-
-                       delete pkt;
                        return;
                }
 
                /* Handle commands related to client startup */
                if (toServerCommandTable[command].state == TOSERVER_STATE_STARTUP) {
                        handleCommand(pkt);
-                       delete pkt;
                        return;
                }
 
@@ -1241,19 +1238,18 @@ void Server::ProcessData(u8 *data, u32 datasize, u16 peer_id)
                        errorstream << "Got packet command: " << command << " for peer id "
                                        << peer_id << " but client isn't active yet. Dropping packet "
                                        << std::endl;
-
-                       delete pkt;
                        return;
                }
 
                handleCommand(pkt);
-               delete pkt;
-
-       }
-       catch(SendFailedException &e) {
+       } catch (SendFailedException &e) {
                errorstream << "Server::ProcessData(): SendFailedException: "
                                << "what=" << e.what()
                                << std::endl;
+       } catch (PacketError &e) {
+               actionstream << "Server::ProcessData(): PacketError: "
+                               << "what=" << e.what()
+                               << std::endl;
        }
 }
 
@@ -1306,18 +1302,21 @@ Inventory* Server::getInventory(const InventoryLocation &loc)
        }
                break;
        default:
-               assert(0);
+               sanity_check(false); // abort
                break;
        }
        return NULL;
 }
-void Server::setInventoryModified(const InventoryLocation &loc)
+void Server::setInventoryModified(const InventoryLocation &loc, bool playerSend)
 {
        switch(loc.type){
        case InventoryLocation::UNDEFINED:
                break;
        case InventoryLocation::PLAYER:
        {
+               if (!playerSend)
+                       return;
+
                Player *player = m_env->getPlayer(loc.name.c_str());
                if(!player)
                        return;
@@ -1345,7 +1344,7 @@ void Server::setInventoryModified(const InventoryLocation &loc)
        }
                break;
        default:
-               assert(0);
+               sanity_check(false); // abort
                break;
        }
 }
@@ -1353,19 +1352,19 @@ void Server::setInventoryModified(const InventoryLocation &loc)
 void Server::SetBlocksNotSent(std::map<v3s16, MapBlock *>& block)
 {
        std::vector<u16> clients = m_clients.getClientIDs();
-       m_clients.Lock();
+       m_clients.lock();
        // Set the modified blocks unsent for all the clients
        for (std::vector<u16>::iterator i = clients.begin();
                 i != clients.end(); ++i) {
                        if (RemoteClient *client = m_clients.lockedGetClientNoEx(*i))
                                client->SetBlocksNotSent(block);
        }
-       m_clients.Unlock();
+       m_clients.unlock();
 }
 
 void Server::peerAdded(con::Peer *peer)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        verbosestream<<"Server::peerAdded(): peer->id="
                        <<peer->id<<std::endl;
 
@@ -1378,7 +1377,7 @@ void Server::peerAdded(con::Peer *peer)
 
 void Server::deletingPeer(con::Peer *peer, bool timeout)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        verbosestream<<"Server::deletingPeer(): peer->id="
                        <<peer->id<<", timeout="<<timeout<<std::endl;
 
@@ -1410,11 +1409,11 @@ bool Server::getClientInfo(
        )
 {
        *state = m_clients.getClientState(peer_id);
-       m_clients.Lock();
+       m_clients.lock();
        RemoteClient* client = m_clients.lockedGetClientNoEx(peer_id, CS_Invalid);
 
        if (client == NULL) {
-               m_clients.Unlock();
+               m_clients.unlock();
                return false;
        }
 
@@ -1427,7 +1426,7 @@ bool Server::getClientInfo(
        *patch = client->getPatch();
        *vers_string = client->getPatch();
 
-       m_clients.Unlock();
+       m_clients.unlock();
 
        return true;
 }
@@ -1454,12 +1453,22 @@ void Server::handlePeerChanges()
                        break;
 
                default:
-                       assert("Invalid peer change event received!" == 0);
+                       FATAL_ERROR("Invalid peer change event received!");
                        break;
                }
        }
 }
 
+void Server::printToConsoleOnly(const std::string &text)
+{
+       if (m_admin_chat) {
+               m_admin_chat->outgoing_queue.push_back(
+                       new ChatEventChat("", utf8_to_wide(text)));
+       } else {
+               std::cout << text << std::endl;
+       }
+}
+
 void Server::Send(NetworkPacket* pkt)
 {
        m_clients.send(pkt->getPeerId(),
@@ -1470,70 +1479,99 @@ void Server::Send(NetworkPacket* pkt)
 
 void Server::SendMovement(u16 peer_id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        std::ostringstream os(std::ios_base::binary);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_MOVEMENT, 12 * sizeof(float), peer_id);
+       NetworkPacket pkt(TOCLIENT_MOVEMENT, 12 * sizeof(float), peer_id);
 
-       *pkt << g_settings->getFloat("movement_acceleration_default");
-       *pkt << g_settings->getFloat("movement_acceleration_air");
-       *pkt << g_settings->getFloat("movement_acceleration_fast");
-       *pkt << g_settings->getFloat("movement_speed_walk");
-       *pkt << g_settings->getFloat("movement_speed_crouch");
-       *pkt << g_settings->getFloat("movement_speed_fast");
-       *pkt << g_settings->getFloat("movement_speed_climb");
-       *pkt << g_settings->getFloat("movement_speed_jump");
-       *pkt << g_settings->getFloat("movement_liquid_fluidity");
-       *pkt << g_settings->getFloat("movement_liquid_fluidity_smooth");
-       *pkt << g_settings->getFloat("movement_liquid_sink");
-       *pkt << g_settings->getFloat("movement_gravity");
+       pkt << g_settings->getFloat("movement_acceleration_default");
+       pkt << g_settings->getFloat("movement_acceleration_air");
+       pkt << g_settings->getFloat("movement_acceleration_fast");
+       pkt << g_settings->getFloat("movement_speed_walk");
+       pkt << g_settings->getFloat("movement_speed_crouch");
+       pkt << g_settings->getFloat("movement_speed_fast");
+       pkt << g_settings->getFloat("movement_speed_climb");
+       pkt << g_settings->getFloat("movement_speed_jump");
+       pkt << g_settings->getFloat("movement_liquid_fluidity");
+       pkt << g_settings->getFloat("movement_liquid_fluidity_smooth");
+       pkt << g_settings->getFloat("movement_liquid_sink");
+       pkt << g_settings->getFloat("movement_gravity");
 
-       Send(pkt);
+       Send(&pkt);
+}
+
+void Server::SendPlayerHPOrDie(PlayerSAO *playersao)
+{
+       if (!g_settings->getBool("enable_damage"))
+               return;
+
+       u16 peer_id   = playersao->getPeerID();
+       bool is_alive = playersao->getHP() > 0;
+
+       if (is_alive)
+               SendPlayerHP(peer_id);
+       else
+               DiePlayer(peer_id);
 }
 
 void Server::SendHP(u16 peer_id, u8 hp)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_HP, 1, peer_id);
-       *pkt << hp;
-       Send(pkt);
+       NetworkPacket pkt(TOCLIENT_HP, 1, peer_id);
+       pkt << hp;
+       Send(&pkt);
 }
 
 void Server::SendBreath(u16 peer_id, u16 breath)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
+
+       NetworkPacket pkt(TOCLIENT_BREATH, 2, peer_id);
+       pkt << (u16) breath;
+       Send(&pkt);
+}
+
+void Server::SendAccessDenied(u16 peer_id, AccessDeniedCode reason,
+               const std::string &custom_reason, bool reconnect)
+{
+       assert(reason < SERVER_ACCESSDENIED_MAX);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_BREATH, 2, peer_id);
-       *pkt << (u16) breath;
-       Send(pkt);
+       NetworkPacket pkt(TOCLIENT_ACCESS_DENIED, 1, peer_id);
+       pkt << (u8)reason;
+       if (reason == SERVER_ACCESSDENIED_CUSTOM_STRING)
+               pkt << custom_reason;
+       else if (reason == SERVER_ACCESSDENIED_SHUTDOWN ||
+                       reason == SERVER_ACCESSDENIED_CRASH)
+               pkt << custom_reason << (u8)reconnect;
+       Send(&pkt);
 }
 
-void Server::SendAccessDenied(u16 peer_id,const std::wstring &reason)
+void Server::SendAccessDenied_Legacy(u16 peer_id,const std::wstring &reason)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ACCESS_DENIED, 0, peer_id);
-       *pkt << reason;
-       Send(pkt);
+       NetworkPacket pkt(TOCLIENT_ACCESS_DENIED_LEGACY, 0, peer_id);
+       pkt << reason;
+       Send(&pkt);
 }
 
 void Server::SendDeathscreen(u16 peer_id,bool set_camera_point_target,
                v3f camera_point_target)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_DEATHSCREEN, 1 + sizeof(v3f), peer_id);
-       *pkt << set_camera_point_target << camera_point_target;
-       Send(pkt);
+       NetworkPacket pkt(TOCLIENT_DEATHSCREEN, 1 + sizeof(v3f), peer_id);
+       pkt << set_camera_point_target << camera_point_target;
+       Send(&pkt);
 }
 
 void Server::SendItemDef(u16 peer_id,
                IItemDefManager *itemdef, u16 protocol_version)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ITEMDEF, 0, peer_id);
+       NetworkPacket pkt(TOCLIENT_ITEMDEF, 0, peer_id);
 
        /*
                u16 command
@@ -1544,21 +1582,21 @@ void Server::SendItemDef(u16 peer_id,
        itemdef->serialize(tmp_os, protocol_version);
        std::ostringstream tmp_os2(std::ios::binary);
        compressZlib(tmp_os.str(), tmp_os2);
-       pkt->putLongString(tmp_os2.str());
+       pkt.putLongString(tmp_os2.str());
 
        // Make data buffer
        verbosestream << "Server: Sending item definitions to id(" << peer_id
-                       << "): size=" << pkt->getSize() << std::endl;
+                       << "): size=" << pkt.getSize() << std::endl;
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 void Server::SendNodeDef(u16 peer_id,
                INodeDefManager *nodedef, u16 protocol_version)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_NODEDEF, 0, peer_id);
+       NetworkPacket pkt(TOCLIENT_NODEDEF, 0, peer_id);
 
        /*
                u16 command
@@ -1570,13 +1608,13 @@ void Server::SendNodeDef(u16 peer_id,
        std::ostringstream tmp_os2(std::ios::binary);
        compressZlib(tmp_os.str(), tmp_os2);
 
-       pkt->putLongString(tmp_os2.str());
+       pkt.putLongString(tmp_os2.str());
 
        // Make data buffer
        verbosestream << "Server: Sending node definitions to id(" << peer_id
-                       << "): size=" << pkt->getSize() << std::endl;
+                       << "): size=" << pkt.getSize() << std::endl;
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 /*
@@ -1585,7 +1623,7 @@ void Server::SendNodeDef(u16 peer_id,
 
 void Server::SendInventory(PlayerSAO* playerSAO)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        UpdateCrafting(playerSAO->getPlayer());
 
@@ -1593,44 +1631,43 @@ void Server::SendInventory(PlayerSAO* playerSAO)
                Serialize it
        */
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_INVENTORY, 0,
-                       playerSAO->getPeerID());
+       NetworkPacket pkt(TOCLIENT_INVENTORY, 0, playerSAO->getPeerID());
 
        std::ostringstream os;
        playerSAO->getInventory()->serialize(os);
 
        std::string s = os.str();
 
-       pkt->putRawString(s.c_str(), s.size());
-       Send(pkt);
+       pkt.putRawString(s.c_str(), s.size());
+       Send(&pkt);
 }
 
 void Server::SendChatMessage(u16 peer_id, const std::wstring &message)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_CHAT_MESSAGE, 0, peer_id);
-       *pkt << message;
+       NetworkPacket pkt(TOCLIENT_CHAT_MESSAGE, 0, peer_id);
+       pkt << message;
 
        if (peer_id != PEER_ID_INEXISTENT) {
-               Send(pkt);
+               Send(&pkt);
        }
        else {
-               m_clients.sendToAll(0,pkt,true);
+               m_clients.sendToAll(0, &pkt, true);
        }
 }
 
 void Server::SendShowFormspecMessage(u16 peer_id, const std::string &formspec,
                                      const std::string &formname)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_SHOW_FORMSPEC, 0 , peer_id);
+       NetworkPacket pkt(TOCLIENT_SHOW_FORMSPEC, 0 , peer_id);
 
-       pkt->putLongString(FORMSPEC_VERSION_STRING + formspec);
-       *pkt << formname;
+       pkt.putLongString(FORMSPEC_VERSION_STRING + formspec);
+       pkt << formname;
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 // Spawns a particle on peer with peer_id
@@ -1638,20 +1675,20 @@ void Server::SendSpawnParticle(u16 peer_id, v3f pos, v3f velocity, v3f accelerat
                                float expirationtime, float size, bool collisiondetection,
                                bool vertical, std::string texture)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_SPAWN_PARTICLE, 0, peer_id);
+       NetworkPacket pkt(TOCLIENT_SPAWN_PARTICLE, 0, peer_id);
 
-       *pkt << pos << velocity << acceleration << expirationtime
+       pkt << pos << velocity << acceleration << expirationtime
                        << size << collisiondetection;
-       pkt->putLongString(texture);
-       *pkt << vertical;
+       pkt.putLongString(texture);
+       pkt << vertical;
 
        if (peer_id != PEER_ID_INEXISTENT) {
-               Send(pkt);
+               Send(&pkt);
        }
        else {
-               m_clients.sendToAll(0,pkt,true);
+               m_clients.sendToAll(0, &pkt, true);
        }
 }
 
@@ -1660,156 +1697,160 @@ void Server::SendAddParticleSpawner(u16 peer_id, u16 amount, float spawntime, v3
        v3f minvel, v3f maxvel, v3f minacc, v3f maxacc, float minexptime, float maxexptime,
        float minsize, float maxsize, bool collisiondetection, bool vertical, std::string texture, u32 id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ADD_PARTICLESPAWNER, 0, peer_id);
+       NetworkPacket pkt(TOCLIENT_ADD_PARTICLESPAWNER, 0, peer_id);
 
-       *pkt << amount << spawntime << minpos << maxpos << minvel << maxvel
+       pkt << amount << spawntime << minpos << maxpos << minvel << maxvel
                        << minacc << maxacc << minexptime << maxexptime << minsize
                        << maxsize << collisiondetection;
 
-       pkt->putLongString(texture);
+       pkt.putLongString(texture);
 
-       *pkt << id << vertical;
+       pkt << id << vertical;
 
        if (peer_id != PEER_ID_INEXISTENT) {
-               Send(pkt);
+               Send(&pkt);
        }
        else {
-               m_clients.sendToAll(0, pkt, true);
+               m_clients.sendToAll(0, &pkt, true);
        }
 }
 
 void Server::SendDeleteParticleSpawner(u16 peer_id, u32 id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_DELETE_PARTICLESPAWNER, 2, peer_id);
+       NetworkPacket pkt(TOCLIENT_DELETE_PARTICLESPAWNER_LEGACY, 2, peer_id);
 
        // Ugly error in this packet
-       *pkt << (u16) id;
+       pkt << (u16) id;
 
        if (peer_id != PEER_ID_INEXISTENT) {
-               Send(pkt);
+               Send(&pkt);
        }
        else {
-               m_clients.sendToAll(0, pkt, true);
+               m_clients.sendToAll(0, &pkt, true);
        }
 
 }
 
 void Server::SendHUDAdd(u16 peer_id, u32 id, HudElement *form)
 {
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_HUDADD, 0 , peer_id);
+       NetworkPacket pkt(TOCLIENT_HUDADD, 0 , peer_id);
 
-       *pkt << id << (u8) form->type << form->pos << form->name << form->scale
+       pkt << id << (u8) form->type << form->pos << form->name << form->scale
                        << form->text << form->number << form->item << form->dir
                        << form->align << form->offset << form->world_pos << form->size;
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 void Server::SendHUDRemove(u16 peer_id, u32 id)
 {
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_HUDRM, 4, peer_id);
-       *pkt << id;
-       Send(pkt);
+       NetworkPacket pkt(TOCLIENT_HUDRM, 4, peer_id);
+       pkt << id;
+       Send(&pkt);
 }
 
 void Server::SendHUDChange(u16 peer_id, u32 id, HudElementStat stat, void *value)
 {
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_HUDCHANGE, 0, peer_id);
-       *pkt << id << (u8) stat;
+       NetworkPacket pkt(TOCLIENT_HUDCHANGE, 0, peer_id);
+       pkt << id << (u8) stat;
 
        switch (stat) {
                case HUD_STAT_POS:
                case HUD_STAT_SCALE:
                case HUD_STAT_ALIGN:
                case HUD_STAT_OFFSET:
-                       *pkt << *(v2f *) value;
+                       pkt << *(v2f *) value;
                        break;
                case HUD_STAT_NAME:
                case HUD_STAT_TEXT:
-                       *pkt << *(std::string *) value;
+                       pkt << *(std::string *) value;
                        break;
                case HUD_STAT_WORLD_POS:
-                       *pkt << *(v3f *) value;
+                       pkt << *(v3f *) value;
                        break;
                case HUD_STAT_SIZE:
-                       *pkt << *(v2s32 *) value;
+                       pkt << *(v2s32 *) value;
                        break;
                case HUD_STAT_NUMBER:
                case HUD_STAT_ITEM:
                case HUD_STAT_DIR:
                default:
-                       *pkt << *(u32 *) value;
+                       pkt << *(u32 *) value;
                        break;
        }
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 void Server::SendHUDSetFlags(u16 peer_id, u32 flags, u32 mask)
 {
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_HUD_SET_FLAGS, 4 + 4, peer_id);
+       NetworkPacket pkt(TOCLIENT_HUD_SET_FLAGS, 4 + 4, peer_id);
 
        flags &= ~(HUD_FLAG_HEALTHBAR_VISIBLE | HUD_FLAG_BREATHBAR_VISIBLE);
 
-       *pkt << flags << mask;
+       pkt << flags << mask;
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 void Server::SendHUDSetParam(u16 peer_id, u16 param, const std::string &value)
 {
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_HUD_SET_PARAM, 0, peer_id);
-       *pkt << param << value;
-       Send(pkt);
+       NetworkPacket pkt(TOCLIENT_HUD_SET_PARAM, 0, peer_id);
+       pkt << param << value;
+       Send(&pkt);
 }
 
 void Server::SendSetSky(u16 peer_id, const video::SColor &bgcolor,
                const std::string &type, const std::vector<std::string> &params)
 {
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_SET_SKY, 0, peer_id);
-       *pkt << bgcolor << type << (u16) params.size();
+       NetworkPacket pkt(TOCLIENT_SET_SKY, 0, peer_id);
+       pkt << bgcolor << type << (u16) params.size();
 
        for(size_t i=0; i<params.size(); i++)
-               *pkt << params[i];
+               pkt << params[i];
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 void Server::SendOverrideDayNightRatio(u16 peer_id, bool do_override,
                float ratio)
 {
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_OVERRIDE_DAY_NIGHT_RATIO,
+       NetworkPacket pkt(TOCLIENT_OVERRIDE_DAY_NIGHT_RATIO,
                        1 + 2, peer_id);
 
-       *pkt << do_override << (u16) (ratio * 65535);
+       pkt << do_override << (u16) (ratio * 65535);
 
-       Send (pkt);
+       Send(&pkt);
 }
 
 void Server::SendTimeOfDay(u16 peer_id, u16 time, f32 time_speed)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_TIME_OF_DAY, 0, peer_id);
-       *pkt << time << time_speed;
+       NetworkPacket pkt(TOCLIENT_TIME_OF_DAY, 0, peer_id);
+       pkt << time << time_speed;
 
        if (peer_id == PEER_ID_INEXISTENT) {
-               m_clients.sendToAll(0, pkt, true);
+               m_clients.sendToAll(0, &pkt, true);
        }
        else {
-               Send(pkt);
+               Send(&pkt);
        }
 }
 
 void Server::SendPlayerHP(u16 peer_id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        PlayerSAO *playersao = getPlayerSAO(peer_id);
-       assert(playersao);
+       // In some rare case, if the player is disconnected
+       // while Lua call l_punch, for example, this can be NULL
+       if (!playersao)
+               return;
+
        SendHP(peer_id, playersao->getHP());
        m_script->player_event(playersao,"health_changed");
 
@@ -1821,7 +1862,7 @@ void Server::SendPlayerHP(u16 peer_id)
 
 void Server::SendPlayerBreath(u16 peer_id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        PlayerSAO *playersao = getPlayerSAO(peer_id);
        assert(playersao);
 
@@ -1831,43 +1872,43 @@ void Server::SendPlayerBreath(u16 peer_id)
 
 void Server::SendMovePlayer(u16 peer_id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        Player *player = m_env->getPlayer(peer_id);
        assert(player);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_MOVE_PLAYER, 0, peer_id);
-       *pkt << player->getPosition() << player->getPitch() << player->getYaw();
+       NetworkPacket pkt(TOCLIENT_MOVE_PLAYER, sizeof(v3f) + sizeof(f32) * 2, peer_id);
+       pkt << player->getPosition() << player->getPitch() << player->getYaw();
 
        {
                v3f pos = player->getPosition();
                f32 pitch = player->getPitch();
                f32 yaw = player->getYaw();
-               verbosestream<<"Server: Sending TOCLIENT_MOVE_PLAYER"
-                               <<" pos=("<<pos.X<<","<<pos.Y<<","<<pos.Z<<")"
-                               <<" pitch="<<pitch
-                               <<" yaw="<<yaw
-                               <<std::endl;
+               verbosestream << "Server: Sending TOCLIENT_MOVE_PLAYER"
+                               << " pos=(" << pos.X << "," << pos.Y << "," << pos.Z << ")"
+                               << " pitch=" << pitch
+                               << " yaw=" << yaw
+                               << std::endl;
        }
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 void Server::SendLocalPlayerAnimations(u16 peer_id, v2s32 animation_frames[4], f32 animation_speed)
 {
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_LOCAL_PLAYER_ANIMATIONS, 0,
+       NetworkPacket pkt(TOCLIENT_LOCAL_PLAYER_ANIMATIONS, 0,
                peer_id);
 
-       *pkt << animation_frames[0] << animation_frames[1] << animation_frames[2]
+       pkt << animation_frames[0] << animation_frames[1] << animation_frames[2]
                        << animation_frames[3] << animation_speed;
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 void Server::SendEyeOffset(u16 peer_id, v3f first, v3f third)
 {
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_EYE_OFFSET, 0, peer_id);
-       *pkt << first << third;
-       Send(pkt);
+       NetworkPacket pkt(TOCLIENT_EYE_OFFSET, 0, peer_id);
+       pkt << first << third;
+       Send(&pkt);
 }
 void Server::SendPlayerPrivileges(u16 peer_id)
 {
@@ -1879,15 +1920,15 @@ void Server::SendPlayerPrivileges(u16 peer_id)
        std::set<std::string> privs;
        m_script->getAuth(player->getName(), NULL, &privs);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_PRIVILEGES, 0, peer_id);
-       *pkt << (u16) privs.size();
+       NetworkPacket pkt(TOCLIENT_PRIVILEGES, 0, peer_id);
+       pkt << (u16) privs.size();
 
        for(std::set<std::string>::const_iterator i = privs.begin();
-                       i != privs.end(); i++) {
-               *pkt << (*i);
+                       i != privs.end(); ++i) {
+               pkt << (*i);
        }
 
-       Send(pkt);
+       Send(&pkt);
 }
 
 void Server::SendPlayerInventoryFormspec(u16 peer_id)
@@ -1897,9 +1938,30 @@ void Server::SendPlayerInventoryFormspec(u16 peer_id)
        if(player->peer_id == PEER_ID_INEXISTENT)
                return;
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_INVENTORY_FORMSPEC, 0, peer_id);
-       pkt->putLongString(FORMSPEC_VERSION_STRING + player->inventory_formspec);
-       Send(pkt);
+       NetworkPacket pkt(TOCLIENT_INVENTORY_FORMSPEC, 0, peer_id);
+       pkt.putLongString(FORMSPEC_VERSION_STRING + player->inventory_formspec);
+       Send(&pkt);
+}
+
+u32 Server::SendActiveObjectRemoveAdd(u16 peer_id, const std::string &datas)
+{
+       NetworkPacket pkt(TOCLIENT_ACTIVE_OBJECT_REMOVE_ADD, datas.size(), peer_id);
+       pkt.putRawString(datas.c_str(), datas.size());
+       Send(&pkt);
+       return pkt.getSize();
+}
+
+void Server::SendActiveObjectMessages(u16 peer_id, const std::string &datas, bool reliable)
+{
+       NetworkPacket pkt(TOCLIENT_ACTIVE_OBJECT_MESSAGES,
+                       datas.size(), peer_id);
+
+       pkt.putRawString(datas.c_str(), datas.size());
+
+       m_clients.send(pkt.getPeerId(),
+                       reliable ? clientCommandFactoryTable[pkt.getCommand()].channel : 1,
+                       &pkt, reliable);
+
 }
 
 s32 Server::playSound(const SimpleSoundSpec &spec,
@@ -1957,16 +2019,15 @@ s32 Server::playSound(const SimpleSoundSpec &spec,
        ServerPlayingSound &psound = m_playing_sounds[id];
        psound.params = params;
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_PLAY_SOUND, 0);
-       *pkt << id << spec.name << (float) (spec.gain * params.gain)
+       NetworkPacket pkt(TOCLIENT_PLAY_SOUND, 0);
+       pkt << id << spec.name << (float) (spec.gain * params.gain)
                        << (u8) params.type << pos << params.object << params.loop;
 
        for(std::vector<u16>::iterator i = dst_clients.begin();
-                       i != dst_clients.end(); i++) {
+                       i != dst_clients.end(); ++i) {
                psound.clients.insert(*i);
-               m_clients.send(*i, 0, pkt, true, false);
+               m_clients.send(*i, 0, &pkt, true);
        }
-       delete pkt;
        return id;
 }
 void Server::stopSound(s32 handle)
@@ -1978,15 +2039,14 @@ void Server::stopSound(s32 handle)
                return;
        ServerPlayingSound &psound = i->second;
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_STOP_SOUND, 4);
-       *pkt << handle;
+       NetworkPacket pkt(TOCLIENT_STOP_SOUND, 4);
+       pkt << handle;
 
        for(std::set<u16>::iterator i = psound.clients.begin();
-                       i != psound.clients.end(); i++) {
+                       i != psound.clients.end(); ++i) {
                // Send as reliable
-               m_clients.send(*i, 0, pkt, true, false);
+               m_clients.send(*i, 0, &pkt, true);
        }
-       delete pkt;
        // Remove sound reference
        m_playing_sounds.erase(i);
 }
@@ -1997,8 +2057,8 @@ void Server::sendRemoveNode(v3s16 p, u16 ignore_id,
        float maxd = far_d_nodes*BS;
        v3f p_f = intToFloat(p, BS);
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_REMOVENODE, 6);
-       *pkt << p;
+       NetworkPacket pkt(TOCLIENT_REMOVENODE, 6);
+       pkt << p;
 
        std::vector<u16> clients = m_clients.getClientIDs();
        for(std::vector<u16>::iterator i = clients.begin();
@@ -2016,10 +2076,8 @@ void Server::sendRemoveNode(v3s16 p, u16 ignore_id,
                }
 
                // Send as reliable
-               m_clients.send(*i, 0, pkt, true, false);
+               m_clients.send(*i, 0, &pkt, true);
        }
-       // This loop needs the deletion of the packet here
-       delete pkt;
 }
 
 void Server::sendAddNode(v3s16 p, MapNode n, u16 ignore_id,
@@ -2045,44 +2103,44 @@ void Server::sendAddNode(v3s16 p, MapNode n, u16 ignore_id,
                        }
                }
 
-               NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ADDNODE, 6 + 2 + 1 + 1 + 1);
-               m_clients.Lock();
+               NetworkPacket pkt(TOCLIENT_ADDNODE, 6 + 2 + 1 + 1 + 1);
+               m_clients.lock();
                RemoteClient* client = m_clients.lockedGetClientNoEx(*i);
                if (client != 0) {
-                       *pkt << p << n.param0 << n.param1 << n.param2
+                       pkt << p << n.param0 << n.param1 << n.param2
                                        << (u8) (remove_metadata ? 0 : 1);
 
                        if (!remove_metadata) {
                                if (client->net_proto_version <= 21) {
                                        // Old clients always clear metadata; fix it
                                        // by sending the full block again.
-                                       client->SetBlockNotSent(p);
+                                       client->SetBlockNotSent(getNodeBlockPos(p));
                                }
                        }
                }
-               m_clients.Unlock();
+               m_clients.unlock();
 
                // Send as reliable
-               if (pkt->getSize() > 0)
-                       m_clients.send(*i, 0, pkt, true);
+               if (pkt.getSize() > 0)
+                       m_clients.send(*i, 0, &pkt, true);
        }
 }
 
 void Server::setBlockNotSent(v3s16 p)
 {
        std::vector<u16> clients = m_clients.getClientIDs();
-       m_clients.Lock();
+       m_clients.lock();
        for(std::vector<u16>::iterator i = clients.begin();
                i != clients.end(); ++i) {
                RemoteClient *client = m_clients.lockedGetClientNoEx(*i);
                client->SetBlockNotSent(p);
        }
-       m_clients.Unlock();
+       m_clients.unlock();
 }
 
 void Server::SendBlockNoLock(u16 peer_id, MapBlock *block, u8 ver, u16 net_proto_version)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        v3s16 p = block->getPos();
 
@@ -2095,19 +2153,18 @@ void Server::SendBlockNoLock(u16 peer_id, MapBlock *block, u8 ver, u16 net_proto
        block->serializeNetworkSpecific(os, net_proto_version);
        std::string s = os.str();
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_BLOCKDATA,
-               2 + 2 + 2 + 2 + s.size(), peer_id);
+       NetworkPacket pkt(TOCLIENT_BLOCKDATA, 2 + 2 + 2 + 2 + s.size(), peer_id);
 
-       *pkt << p;
-       pkt->putRawString(s.c_str(), s.size());
-       Send(pkt);
+       pkt << p;
+       pkt.putRawString(s.c_str(), s.size());
+       Send(&pkt);
 }
 
 void Server::SendBlocks(float dtime)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       JMutexAutoLock envlock(m_env_mutex);
+       MutexAutoLock envlock(m_env_mutex);
        //TODO check if one big lock could be faster then multiple small ones
 
        ScopeProfiler sp(g_profiler, "Server: sel and send blocks to clients");
@@ -2121,7 +2178,7 @@ void Server::SendBlocks(float dtime)
 
                std::vector<u16> clients = m_clients.getClientIDs();
 
-               m_clients.Lock();
+               m_clients.lock();
                for(std::vector<u16>::iterator i = clients.begin();
                        i != clients.end(); ++i) {
                        RemoteClient *client = m_clients.lockedGetClientNoEx(*i, CS_Active);
@@ -2132,7 +2189,7 @@ void Server::SendBlocks(float dtime)
                        total_sending += client->SendingCount();
                        client->GetNextBlocks(m_env,m_emerge, dtime, queue);
                }
-               m_clients.Unlock();
+               m_clients.unlock();
        }
 
        // Sort.
@@ -2140,7 +2197,7 @@ void Server::SendBlocks(float dtime)
        // Lowest is most important.
        std::sort(queue.begin(), queue.end());
 
-       m_clients.Lock();
+       m_clients.lock();
        for(u32 i=0; i<queue.size(); i++)
        {
                //TODO: Calculate limit dynamically
@@ -2170,19 +2227,19 @@ void Server::SendBlocks(float dtime)
                client->SentBlock(q.pos);
                total_sending++;
        }
-       m_clients.Unlock();
+       m_clients.unlock();
 }
 
 void Server::fillMediaCache()
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        infostream<<"Server: Calculating media file checksums"<<std::endl;
 
        // Collect all media file paths
        std::vector<std::string> paths;
        for(std::vector<ModSpec>::iterator i = m_mods.begin();
-                       i != m_mods.end(); i++) {
+                       i != m_mods.end(); ++i) {
                const ModSpec &mod = *i;
                paths.push_back(mod.path + DIR_DELIM + "textures");
                paths.push_back(mod.path + DIR_DELIM + "sounds");
@@ -2193,7 +2250,7 @@ void Server::fillMediaCache()
 
        // Collect media file information from paths into cache
        for(std::vector<std::string>::iterator i = paths.begin();
-                       i != paths.end(); i++) {
+                       i != paths.end(); ++i) {
                std::string mediapath = *i;
                std::vector<fs::DirListNode> dirlist = fs::GetDirListing(mediapath);
                for (u32 j = 0; j < dirlist.size(); j++) {
@@ -2269,58 +2326,26 @@ void Server::fillMediaCache()
        }
 }
 
-struct SendableMediaAnnouncement
-{
-       std::string name;
-       std::string sha1_digest;
-
-       SendableMediaAnnouncement(const std::string &name_="",
-                                 const std::string &sha1_digest_=""):
-               name(name_),
-               sha1_digest(sha1_digest_)
-       {}
-};
-
 void Server::sendMediaAnnouncement(u16 peer_id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       verbosestream<<"Server: Announcing files to id("<<peer_id<<")"
-                       <<std::endl;
-
-       std::vector<SendableMediaAnnouncement> file_announcements;
-
-       for (std::map<std::string, MediaInfo>::iterator i = m_media.begin();
-                       i != m_media.end(); i++){
-               // Put in list
-               file_announcements.push_back(
-                               SendableMediaAnnouncement(i->first, i->second.sha1_digest));
-       }
+       verbosestream << "Server: Announcing files to id(" << peer_id << ")"
+               << std::endl;
 
        // Make packet
        std::ostringstream os(std::ios_base::binary);
 
-       /*
-               u32 number of files
-               for each texture {
-                       u16 length of name
-                       string name
-                       u16 length of sha1_digest
-                       string sha1_digest
-               }
-       */
-
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_ANNOUNCE_MEDIA, 0, peer_id);
-       *pkt << (u16) file_announcements.size();
+       NetworkPacket pkt(TOCLIENT_ANNOUNCE_MEDIA, 0, peer_id);
+       pkt << (u16) m_media.size();
 
-       for (std::vector<SendableMediaAnnouncement>::iterator
-                       j = file_announcements.begin();
-                       j != file_announcements.end(); ++j) {
-               *pkt << j->name << j->sha1_digest;
+       for (std::map<std::string, MediaInfo>::iterator i = m_media.begin();
+                       i != m_media.end(); ++i) {
+               pkt << i->first << i->second.sha1_digest;
        }
 
-       *pkt << g_settings->get("remote_media");
-       Send(pkt);
+       pkt << g_settings->get("remote_media");
+       Send(&pkt);
 }
 
 struct SendableMedia
@@ -2340,7 +2365,7 @@ struct SendableMedia
 void Server::sendRequestedMedia(u16 peer_id,
                const std::vector<std::string> &tosend)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        verbosestream<<"Server::sendRequestedMedia(): "
                        <<"Sending files to client"<<std::endl;
@@ -2426,28 +2451,28 @@ void Server::sendRequestedMedia(u16 peer_id,
                        }
                */
 
-               NetworkPacket* pkt = new NetworkPacket(TOCLIENT_MEDIA, 0, peer_id);
-               *pkt << num_bunches << i << (u32) file_bunches[i].size();
+               NetworkPacket pkt(TOCLIENT_MEDIA, 4 + 0, peer_id);
+               pkt << num_bunches << i << (u32) file_bunches[i].size();
 
                for(std::vector<SendableMedia>::iterator
                                j = file_bunches[i].begin();
                                j != file_bunches[i].end(); ++j) {
-                       *pkt << j->name;
-                       pkt->putLongString(j->data);
+                       pkt << j->name;
+                       pkt.putLongString(j->data);
                }
 
                verbosestream << "Server::sendRequestedMedia(): bunch "
                                << i << "/" << num_bunches
                                << " files=" << file_bunches[i].size()
-                               << " size="  << pkt->getSize() << std::endl;
-               Send(pkt);
+                               << " size="  << pkt.getSize() << std::endl;
+               Send(&pkt);
        }
 }
 
 void Server::sendDetachedInventory(const std::string &name, u16 peer_id)
 {
        if(m_detached_inventories.count(name) == 0) {
-               errorstream<<__FUNCTION_NAME<<": \""<<name<<"\" not found"<<std::endl;
+               errorstream<<FUNCTION_NAME<<": \""<<name<<"\" not found"<<std::endl;
                return;
        }
        Inventory *inv = m_detached_inventories[name];
@@ -2459,24 +2484,24 @@ void Server::sendDetachedInventory(const std::string &name, u16 peer_id)
        // Make data buffer
        std::string s = os.str();
 
-       NetworkPacket* pkt = new NetworkPacket(TOCLIENT_DETACHED_INVENTORY, 0, peer_id);
-       pkt->putRawString(s.c_str(), s.size());
+       NetworkPacket pkt(TOCLIENT_DETACHED_INVENTORY, 0, peer_id);
+       pkt.putRawString(s.c_str(), s.size());
 
        if (peer_id != PEER_ID_INEXISTENT) {
-               Send(pkt);
+               Send(&pkt);
        }
        else {
-               m_clients.sendToAll(0, pkt, true);
+               m_clients.sendToAll(0, &pkt, true);
        }
 }
 
 void Server::sendDetachedInventories(u16 peer_id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        for(std::map<std::string, Inventory*>::iterator
                        i = m_detached_inventories.begin();
-                       i != m_detached_inventories.end(); i++) {
+                       i != m_detached_inventories.end(); ++i) {
                const std::string &name = i->first;
                //Inventory *inv = i->second;
                sendDetachedInventory(name, peer_id);
@@ -2489,7 +2514,7 @@ void Server::sendDetachedInventories(u16 peer_id)
 
 void Server::DiePlayer(u16 peer_id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        PlayerSAO *playersao = getPlayerSAO(peer_id);
        assert(playersao);
@@ -2509,7 +2534,7 @@ void Server::DiePlayer(u16 peer_id)
 
 void Server::RespawnPlayer(u16 peer_id)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        PlayerSAO *playersao = getPlayerSAO(peer_id);
        assert(playersao);
@@ -2526,24 +2551,93 @@ void Server::RespawnPlayer(u16 peer_id)
 
        bool repositioned = m_script->on_respawnplayer(playersao);
        if(!repositioned){
-               v3f pos = findSpawnPos(m_env->getServerMap());
+               v3f pos = findSpawnPos();
                // setPos will send the new position to client
                playersao->setPos(pos);
        }
 }
 
-void Server::DenyAccess(u16 peer_id, const std::wstring &reason)
+
+void Server::DenySudoAccess(u16 peer_id)
+{
+       DSTACK(FUNCTION_NAME);
+
+       NetworkPacket pkt(TOCLIENT_DENY_SUDO_MODE, 0, peer_id);
+       Send(&pkt);
+}
+
+
+void Server::DenyAccessVerCompliant(u16 peer_id, u16 proto_ver, AccessDeniedCode reason,
+               const std::string &str_reason, bool reconnect)
+{
+       if (proto_ver >= 25) {
+               SendAccessDenied(peer_id, reason, str_reason, reconnect);
+       } else {
+               std::wstring wreason = utf8_to_wide(
+                       reason == SERVER_ACCESSDENIED_CUSTOM_STRING ? str_reason :
+                       accessDeniedStrings[(u8)reason]);
+               SendAccessDenied_Legacy(peer_id, wreason);
+       }
+
+       m_clients.event(peer_id, CSE_SetDenied);
+       m_con.DisconnectPeer(peer_id);
+}
+
+
+void Server::DenyAccess(u16 peer_id, AccessDeniedCode reason, const std::string &custom_reason)
+{
+       DSTACK(FUNCTION_NAME);
+
+       SendAccessDenied(peer_id, reason, custom_reason);
+       m_clients.event(peer_id, CSE_SetDenied);
+       m_con.DisconnectPeer(peer_id);
+}
+
+// 13/03/15: remove this function when protocol version 25 will become
+// the minimum version for MT users, maybe in 1 year
+void Server::DenyAccess_Legacy(u16 peer_id, const std::wstring &reason)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
-       SendAccessDenied(peer_id, reason);
+       SendAccessDenied_Legacy(peer_id, reason);
        m_clients.event(peer_id, CSE_SetDenied);
        m_con.DisconnectPeer(peer_id);
 }
 
+void Server::acceptAuth(u16 peer_id, bool forSudoMode)
+{
+       DSTACK(FUNCTION_NAME);
+
+       if (!forSudoMode) {
+               RemoteClient* client = getClient(peer_id, CS_Invalid);
+
+               NetworkPacket resp_pkt(TOCLIENT_AUTH_ACCEPT, 1 + 6 + 8 + 4, peer_id);
+
+               // Right now, the auth mechs don't change between login and sudo mode.
+               u32 sudo_auth_mechs = client->allowed_auth_mechs;
+               client->allowed_sudo_mechs = sudo_auth_mechs;
+
+               resp_pkt << v3f(0,0,0) << (u64) m_env->getServerMap().getSeed()
+                               << g_settings->getFloat("dedicated_server_step")
+                               << sudo_auth_mechs;
+
+               Send(&resp_pkt);
+               m_clients.event(peer_id, CSE_AuthAccept);
+       } else {
+               NetworkPacket resp_pkt(TOCLIENT_ACCEPT_SUDO_MODE, 1 + 6 + 8 + 4, peer_id);
+
+               // We only support SRP right now
+               u32 sudo_auth_mechs = AUTH_MECHANISM_FIRST_SRP;
+
+               resp_pkt << sudo_auth_mechs;
+               Send(&resp_pkt);
+               m_clients.event(peer_id, CSE_SudoSuccess);
+       }
+}
+
 void Server::DeleteClient(u16 peer_id, ClientDeletionReason reason)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
        std::wstring message;
        {
                /*
@@ -2558,7 +2652,7 @@ void Server::DeleteClient(u16 peer_id, ClientDeletionReason reason)
                        if(psound.clients.empty())
                                m_playing_sounds.erase(i++);
                        else
-                               i++;
+                               ++i;
                }
 
                Player *player = m_env->getPlayer(peer_id);
@@ -2608,13 +2702,17 @@ void Server::DeleteClient(u16 peer_id, ClientDeletionReason reason)
                                        os << player->getName() << " ";
                                }
 
-                               actionstream << player->getName() << " "
+                               std::string name = player->getName();
+                               actionstream << name << " "
                                                << (reason == CDR_TIMEOUT ? "times out." : "leaves game.")
                                                << " List of players: " << os.str() << std::endl;
+                               if (m_admin_chat)
+                                       m_admin_chat->outgoing_queue.push_back(
+                                               new ChatEventNick(CET_NICK_REMOVE, name));
                        }
                }
                {
-                       JMutexAutoLock env_lock(m_env_mutex);
+                       MutexAutoLock env_lock(m_env_mutex);
                        m_clients.DeleteClient(peer_id);
                }
        }
@@ -2626,22 +2724,119 @@ void Server::DeleteClient(u16 peer_id, ClientDeletionReason reason)
 
 void Server::UpdateCrafting(Player* player)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        // Get a preview for crafting
        ItemStack preview;
        InventoryLocation loc;
        loc.setPlayer(player->getName());
-       getCraftingResult(&player->inventory, preview, false, this);
+       std::vector<ItemStack> output_replacements;
+       getCraftingResult(&player->inventory, preview, output_replacements, false, this);
        m_env->getScriptIface()->item_CraftPredict(preview, player->getPlayerSAO(), (&player->inventory)->getList("craft"), loc);
 
        // Put the new preview in
        InventoryList *plist = player->inventory.getList("craftpreview");
-       assert(plist);
-       assert(plist->getSize() >= 1);
+       sanity_check(plist);
+       sanity_check(plist->getSize() >= 1);
        plist->changeItem(0, preview);
 }
 
+void Server::handleChatInterfaceEvent(ChatEvent *evt)
+{
+       if (evt->type == CET_NICK_ADD) {
+               // The terminal informed us of its nick choice
+               m_admin_nick = ((ChatEventNick *)evt)->nick;
+               if (!m_script->getAuth(m_admin_nick, NULL, NULL)) {
+                       errorstream << "You haven't set up an account." << std::endl
+                               << "Please log in using the client as '"
+                               << m_admin_nick << "' with a secure password." << std::endl
+                               << "Until then, you can't execute admin tasks via the console," << std::endl
+                               << "and everybody can claim the user account instead of you," << std::endl
+                               << "giving them full control over this server." << std::endl;
+               }
+       } else {
+               assert(evt->type == CET_CHAT);
+               handleAdminChat((ChatEventChat *)evt);
+       }
+}
+
+std::wstring Server::handleChat(const std::string &name, const std::wstring &wname,
+       const std::wstring &wmessage, bool check_shout_priv,
+       u16 peer_id_to_avoid_sending)
+{
+       // If something goes wrong, this player is to blame
+       RollbackScopeActor rollback_scope(m_rollback,
+               std::string("player:") + name);
+
+       // Line to send
+       std::wstring line;
+       // Whether to send line to the player that sent the message, or to all players
+       bool broadcast_line = true;
+
+       // Run script hook
+       bool ate = m_script->on_chat_message(name,
+               wide_to_utf8(wmessage));
+       // If script ate the message, don't proceed
+       if (ate)
+               return L"";
+
+       // Commands are implemented in Lua, so only catch invalid
+       // commands that were not "eaten" and send an error back
+       if (wmessage[0] == L'/') {
+               std::wstring wcmd = wmessage.substr(1);
+               broadcast_line = false;
+               if (wcmd.length() == 0)
+                       line += L"-!- Empty command";
+               else
+                       line += L"-!- Invalid command: " + str_split(wcmd, L' ')[0];
+       } else {
+               if (check_shout_priv && !checkPriv(name, "shout")) {
+                       line += L"-!- You don't have permission to shout.";
+                       broadcast_line = false;
+               } else {
+                       line += L"<";
+                       line += wname;
+                       line += L"> ";
+                       line += wmessage;
+               }
+       }
+
+       /*
+               Tell calling method to send the message to sender
+       */
+       if (!broadcast_line) {
+               return line;
+       } else {
+               /*
+                       Send the message to others
+               */
+               actionstream << "CHAT: " << wide_to_narrow(line) << std::endl;
+
+               std::vector<u16> clients = m_clients.getClientIDs();
+
+               for (u16 i = 0; i < clients.size(); i++) {
+                       u16 cid = clients[i];
+                       if (cid != peer_id_to_avoid_sending)
+                               SendChatMessage(cid, line);
+               }
+       }
+       return L"";
+}
+
+void Server::handleAdminChat(const ChatEventChat *evt)
+{
+       std::string name = evt->nick;
+       std::wstring wname = utf8_to_wide(name);
+       std::wstring wmessage = evt->evt_msg;
+
+       std::wstring answer = handleChat(name, wname, wmessage);
+
+       // If asked to send answer to sender
+       if (!answer.empty()) {
+               m_admin_chat->outgoing_queue.push_back(new ChatEventChat("", answer));
+       }
+}
+
 RemoteClient* Server::getClient(u16 peer_id, ClientState state_min)
 {
        RemoteClient *client = getClientNoEx(peer_id,state_min);
@@ -2676,7 +2871,7 @@ std::wstring Server::getStatusString()
        std::wostringstream os(std::ios_base::binary);
        os<<L"# Server: ";
        // Version
-       os<<L"version="<<narrow_to_wide(minetest_version_simple);
+       os<<L"version="<<narrow_to_wide(g_version_string);
        // Uptime
        os<<L", uptime="<<m_uptime.get();
        // Max lag estimate
@@ -2769,9 +2964,18 @@ std::string Server::getBanDescription(const std::string &ip_or_name)
 
 void Server::notifyPlayer(const char *name, const std::wstring &msg)
 {
+       // m_env will be NULL if the server is initializing
+       if (!m_env)
+               return;
+
+       if (m_admin_nick == name && !m_admin_nick.empty()) {
+               m_admin_chat->outgoing_queue.push_back(new ChatEventChat("", msg));
+       }
+
        Player *player = m_env->getPlayer(name);
-       if(!player)
+       if (!player) {
                return;
+       }
 
        if (player->peer_id == PEER_ID_INEXISTENT)
                return;
@@ -2779,21 +2983,23 @@ void Server::notifyPlayer(const char *name, const std::wstring &msg)
        SendChatMessage(player->peer_id, msg);
 }
 
-bool Server::showFormspec(const char *playername, const std::string &formspec, const std::string &formname)
+bool Server::showFormspec(const char *playername, const std::string &formspec,
+       const std::string &formname)
 {
-       Player *player = m_env->getPlayer(playername);
+       // m_env will be NULL if the server is initializing
+       if (!m_env)
+               return false;
 
-       if(!player)
-       {
-               infostream<<"showFormspec: couldn't find player:"<<playername<<std::endl;
+       Player *player = m_env->getPlayer(playername);
+       if (!player)
                return false;
-       }
 
        SendShowFormspecMessage(player->peer_id, formspec, formname);
        return true;
 }
 
-u32 Server::hudAdd(Player *player, HudElement *form) {
+u32 Server::hudAdd(Player *player, HudElement *form)
+{
        if (!player)
                return -1;
 
@@ -2819,7 +3025,8 @@ bool Server::hudRemove(Player *player, u32 id) {
        return true;
 }
 
-bool Server::hudChange(Player *player, u32 id, HudElementStat stat, void *data) {
+bool Server::hudChange(Player *player, u32 id, HudElementStat stat, void *data)
+{
        if (!player)
                return false;
 
@@ -2827,12 +3034,14 @@ bool Server::hudChange(Player *player, u32 id, HudElementStat stat, void *data)
        return true;
 }
 
-bool Server::hudSetFlags(Player *player, u32 flags, u32 mask) {
+bool Server::hudSetFlags(Player *player, u32 flags, u32 mask)
+{
        if (!player)
                return false;
 
        SendHUDSetFlags(player->peer_id, flags, mask);
-       player->hud_flags = flags;
+       player->hud_flags &= ~mask;
+       player->hud_flags |= flags;
 
        PlayerSAO* playersao = player->getPlayerSAO();
 
@@ -2843,37 +3052,67 @@ bool Server::hudSetFlags(Player *player, u32 flags, u32 mask) {
        return true;
 }
 
-bool Server::hudSetHotbarItemcount(Player *player, s32 hotbar_itemcount) {
+bool Server::hudSetHotbarItemcount(Player *player, s32 hotbar_itemcount)
+{
        if (!player)
                return false;
        if (hotbar_itemcount <= 0 || hotbar_itemcount > HUD_HOTBAR_ITEMCOUNT_MAX)
                return false;
 
+       player->setHotbarItemcount(hotbar_itemcount);
        std::ostringstream os(std::ios::binary);
        writeS32(os, hotbar_itemcount);
        SendHUDSetParam(player->peer_id, HUD_PARAM_HOTBAR_ITEMCOUNT, os.str());
        return true;
 }
 
-void Server::hudSetHotbarImage(Player *player, std::string name) {
+s32 Server::hudGetHotbarItemcount(Player *player)
+{
+       if (!player)
+               return 0;
+       return player->getHotbarItemcount();
+}
+
+void Server::hudSetHotbarImage(Player *player, std::string name)
+{
        if (!player)
                return;
 
+       player->setHotbarImage(name);
        SendHUDSetParam(player->peer_id, HUD_PARAM_HOTBAR_IMAGE, name);
 }
 
-void Server::hudSetHotbarSelectedImage(Player *player, std::string name) {
+std::string Server::hudGetHotbarImage(Player *player)
+{
+       if (!player)
+               return "";
+       return player->getHotbarImage();
+}
+
+void Server::hudSetHotbarSelectedImage(Player *player, std::string name)
+{
        if (!player)
                return;
 
+       player->setHotbarSelectedImage(name);
        SendHUDSetParam(player->peer_id, HUD_PARAM_HOTBAR_SELECTED_IMAGE, name);
 }
 
-bool Server::setLocalPlayerAnimations(Player *player, v2s32 animation_frames[4], f32 frame_speed)
+std::string Server::hudGetHotbarSelectedImage(Player *player)
+{
+       if (!player)
+               return "";
+
+       return player->getHotbarSelectedImage();
+}
+
+bool Server::setLocalPlayerAnimations(Player *player,
+       v2s32 animation_frames[4], f32 frame_speed)
 {
        if (!player)
                return false;
 
+       player->setLocalAnimations(animation_frames, frame_speed);
        SendLocalPlayerAnimations(player->peer_id, animation_frames, frame_speed);
        return true;
 }
@@ -2883,26 +3122,30 @@ bool Server::setPlayerEyeOffset(Player *player, v3f first, v3f third)
        if (!player)
                return false;
 
+       player->eye_offset_first = first;
+       player->eye_offset_third = third;
        SendEyeOffset(player->peer_id, first, third);
        return true;
 }
 
 bool Server::setSky(Player *player, const video::SColor &bgcolor,
-               const std::string &type, const std::vector<std::string> &params)
+       const std::string &type, const std::vector<std::string> &params)
 {
        if (!player)
                return false;
 
+       player->setSky(bgcolor, type, params);
        SendSetSky(player->peer_id, bgcolor, type, params);
        return true;
 }
 
 bool Server::overrideDayNightRatio(Player *player, bool do_override,
-               float ratio)
+       float ratio)
 {
        if (!player)
                return false;
 
+       player->overrideDayNightRatio(do_override, ratio);
        SendOverrideDayNightRatio(player->peer_id, do_override, ratio);
        return true;
 }
@@ -2912,53 +3155,47 @@ void Server::notifyPlayers(const std::wstring &msg)
        SendChatMessage(PEER_ID_INEXISTENT,msg);
 }
 
-void Server::spawnParticle(const char *playername, v3f pos,
-               v3f velocity, v3f acceleration,
-               float expirationtime, float size, bool
-               collisiondetection, bool vertical, std::string texture)
+void Server::spawnParticle(const std::string &playername, v3f pos,
+       v3f velocity, v3f acceleration,
+       float expirationtime, float size, bool
+       collisiondetection, bool vertical, const std::string &texture)
 {
-       Player *player = m_env->getPlayer(playername);
-       if(!player)
+       // m_env will be NULL if the server is initializing
+       if (!m_env)
                return;
-       SendSpawnParticle(player->peer_id, pos, velocity, acceleration,
-                       expirationtime, size, collisiondetection, vertical, texture);
-}
 
-void Server::spawnParticleAll(v3f pos, v3f velocity, v3f acceleration,
-               float expirationtime, float size,
-               bool collisiondetection, bool vertical, std::string texture)
-{
-       SendSpawnParticle(PEER_ID_INEXISTENT,pos, velocity, acceleration,
+       u16 peer_id = PEER_ID_INEXISTENT;
+       if (playername != "") {
+               Player* player = m_env->getPlayer(playername.c_str());
+               if (!player)
+                       return;
+               peer_id = player->peer_id;
+       }
+
+       SendSpawnParticle(peer_id, pos, velocity, acceleration,
                        expirationtime, size, collisiondetection, vertical, texture);
 }
 
-u32 Server::addParticleSpawner(const char *playername,
-               u16 amount, float spawntime,
-               v3f minpos, v3f maxpos,
-               v3f minvel, v3f maxvel,
-               v3f minacc, v3f maxacc,
-               float minexptime, float maxexptime,
-               float minsize, float maxsize,
-               bool collisiondetection, bool vertical, std::string texture)
+u32 Server::addParticleSpawner(u16 amount, float spawntime,
+       v3f minpos, v3f maxpos, v3f minvel, v3f maxvel, v3f minacc, v3f maxacc,
+       float minexptime, float maxexptime, float minsize, float maxsize,
+       bool collisiondetection, bool vertical, const std::string &texture,
+       const std::string &playername)
 {
-       Player *player = m_env->getPlayer(playername);
-       if(!player)
+       // m_env will be NULL if the server is initializing
+       if (!m_env)
                return -1;
 
-       u32 id = 0;
-       for(;;) // look for unused particlespawner id
-       {
-               id++;
-               if (std::find(m_particlespawner_ids.begin(),
-                               m_particlespawner_ids.end(), id)
-                               == m_particlespawner_ids.end())
-               {
-                       m_particlespawner_ids.push_back(id);
-                       break;
-               }
+       u16 peer_id = PEER_ID_INEXISTENT;
+       if (playername != "") {
+               Player* player = m_env->getPlayer(playername.c_str());
+               if (!player)
+                       return -1;
+               peer_id = player->peer_id;
        }
 
-       SendAddParticleSpawner(player->peer_id, amount, spawntime,
+       u32 id = m_env->addParticleSpawner(spawntime);
+       SendAddParticleSpawner(peer_id, amount, spawntime,
                minpos, maxpos, minvel, maxvel, minacc, maxacc,
                minexptime, maxexptime, minsize, maxsize,
                collisiondetection, vertical, texture, id);
@@ -2966,54 +3203,27 @@ u32 Server::addParticleSpawner(const char *playername,
        return id;
 }
 
-u32 Server::addParticleSpawnerAll(u16 amount, float spawntime,
-               v3f minpos, v3f maxpos,
-               v3f minvel, v3f maxvel,
-               v3f minacc, v3f maxacc,
-               float minexptime, float maxexptime,
-               float minsize, float maxsize,
-               bool collisiondetection, bool vertical, std::string texture)
+void Server::deleteParticleSpawner(const std::string &playername, u32 id)
 {
-       u32 id = 0;
-       for(;;) // look for unused particlespawner id
-       {
-               id++;
-               if (std::find(m_particlespawner_ids.begin(),
-                               m_particlespawner_ids.end(), id)
-                               == m_particlespawner_ids.end())
-               {
-                       m_particlespawner_ids.push_back(id);
-                       break;
-               }
-       }
-
-       SendAddParticleSpawner(PEER_ID_INEXISTENT, amount, spawntime,
-               minpos, maxpos, minvel, maxvel, minacc, maxacc,
-               minexptime, maxexptime, minsize, maxsize,
-               collisiondetection, vertical, texture, id);
-
-       return id;
-}
+       // m_env will be NULL if the server is initializing
+       if (!m_env)
+               throw ServerError("Can't delete particle spawners during initialisation!");
 
-void Server::deleteParticleSpawner(const char *playername, u32 id)
-{
-       Player *player = m_env->getPlayer(playername);
-       if(!player)
-               return;
+       u16 peer_id = PEER_ID_INEXISTENT;
+       if (playername != "") {
+               Player* player = m_env->getPlayer(playername.c_str());
+               if (!player)
+                       return;
+               peer_id = player->peer_id;
+       }
 
-       m_particlespawner_ids.erase(
-                       std::remove(m_particlespawner_ids.begin(),
-                       m_particlespawner_ids.end(), id),
-                       m_particlespawner_ids.end());
-       SendDeleteParticleSpawner(player->peer_id, id);
+       m_env->deleteParticleSpawner(id);
+       SendDeleteParticleSpawner(peer_id, id);
 }
 
 void Server::deleteParticleSpawnerAll(u32 id)
 {
-       m_particlespawner_ids.erase(
-                       std::remove(m_particlespawner_ids.begin(),
-                       m_particlespawner_ids.end(), id),
-                       m_particlespawner_ids.end());
+       m_env->deleteParticleSpawner(id);
        SendDeleteParticleSpawner(PEER_ID_INEXISTENT, id);
 }
 
@@ -3026,31 +3236,13 @@ Inventory* Server::createDetachedInventory(const std::string &name)
                infostream<<"Server creating detached inventory \""<<name<<"\""<<std::endl;
        }
        Inventory *inv = new Inventory(m_itemdef);
-       assert(inv);
+       sanity_check(inv);
        m_detached_inventories[name] = inv;
        //TODO find a better way to do this
        sendDetachedInventory(name,PEER_ID_INEXISTENT);
        return inv;
 }
 
-class BoolScopeSet
-{
-public:
-       BoolScopeSet(bool *dst, bool val):
-               m_dst(dst)
-       {
-               m_orig_state = *m_dst;
-               *m_dst = val;
-       }
-       ~BoolScopeSet()
-       {
-               *m_dst = m_orig_state;
-       }
-private:
-       bool *m_dst;
-       bool m_orig_state;
-};
-
 // actions: time-reversed list
 // Return value: success/failure
 bool Server::rollbackRevertActions(const std::list<RollbackAction> &actions,
@@ -3070,7 +3262,7 @@ bool Server::rollbackRevertActions(const std::list<RollbackAction> &actions,
 
        for(std::list<RollbackAction>::const_iterator
                        i = actions.begin();
-                       i != actions.end(); i++)
+                       i != actions.end(); ++i)
        {
                const RollbackAction &action = *i;
                num_tried++;
@@ -3100,27 +3292,29 @@ bool Server::rollbackRevertActions(const std::list<RollbackAction> &actions,
 
 // IGameDef interface
 // Under envlock
-IItemDefManagerServer::getItemDefManager()
+IItemDefManager *Server::getItemDefManager()
 {
        return m_itemdef;
 }
-INodeDefManager* Server::getNodeDefManager()
+
+INodeDefManager *Server::getNodeDefManager()
 {
        return m_nodedef;
 }
-ICraftDefManager* Server::getCraftDefManager()
+
+ICraftDefManager *Server::getCraftDefManager()
 {
        return m_craftdef;
 }
-ITextureSourceServer::getTextureSource()
+ITextureSource *Server::getTextureSource()
 {
        return NULL;
 }
-IShaderSourceServer::getShaderSource()
+IShaderSource *Server::getShaderSource()
 {
        return NULL;
 }
-scene::ISceneManagerServer::getSceneManager()
+scene::ISceneManager *Server::getSceneManager()
 {
        return NULL;
 }
@@ -3129,81 +3323,82 @@ u16 Server::allocateUnknownNodeId(const std::string &name)
 {
        return m_nodedef->allocateDummy(name);
 }
-ISoundManager* Server::getSoundManager()
+
+ISoundManager *Server::getSoundManager()
 {
        return &dummySoundManager;
 }
-MtEventManager* Server::getEventManager()
+
+MtEventManager *Server::getEventManager()
 {
        return m_event;
 }
 
-IWritableItemDefManagerServer::getWritableItemDefManager()
+IWritableItemDefManager *Server::getWritableItemDefManager()
 {
        return m_itemdef;
 }
-IWritableNodeDefManager* Server::getWritableNodeDefManager()
+
+IWritableNodeDefManager *Server::getWritableNodeDefManager()
 {
        return m_nodedef;
 }
-IWritableCraftDefManager* Server::getWritableCraftDefManager()
+
+IWritableCraftDefManager *Server::getWritableCraftDefManager()
 {
        return m_craftdef;
 }
 
-const ModSpec* Server::getModSpec(const std::string &modname)
+const ModSpec *Server::getModSpec(const std::string &modname) const
 {
-       for(std::vector<ModSpec>::iterator i = m_mods.begin();
-                       i != m_mods.end(); i++){
-               const ModSpec &mod = *i;
-               if(mod.name == modname)
+       std::vector<ModSpec>::const_iterator it;
+       for (it = m_mods.begin(); it != m_mods.end(); ++it) {
+               const ModSpec &mod = *it;
+               if (mod.name == modname)
                        return &mod;
        }
        return NULL;
 }
+
 void Server::getModNames(std::vector<std::string> &modlist)
 {
-       for(std::vector<ModSpec>::iterator i = m_mods.begin(); i != m_mods.end(); i++) {
-               modlist.push_back(i->name);
-       }
+       std::vector<ModSpec>::iterator it;
+       for (it = m_mods.begin(); it != m_mods.end(); ++it)
+               modlist.push_back(it->name);
 }
+
 std::string Server::getBuiltinLuaPath()
 {
        return porting::path_share + DIR_DELIM + "builtin";
 }
 
-v3f findSpawnPos(ServerMap &map)
+v3f Server::findSpawnPos()
 {
-       //return v3f(50,50,50)*BS;
-
-       v3s16 nodepos;
-
-#if 0
-       nodepos = v2s16(0,0);
-       groundheight = 20;
-#endif
+       ServerMap &map = m_env->getServerMap();
+       v3f nodeposf;
+       if (g_settings->getV3FNoEx("static_spawnpoint", nodeposf)) {
+               return nodeposf * BS;
+       }
 
-#if 1
-       s16 water_level = map.getWaterLevel();
+       bool is_good = false;
 
        // Try to find a good place a few times
-       for(s32 i=0; i<1000; i++)
-       {
+       for(s32 i = 0; i < 4000 && !is_good; i++) {
                s32 range = 1 + i;
                // We're going to try to throw the player to this position
                v2s16 nodepos2d = v2s16(
                                -range + (myrand() % (range * 2)),
                                -range + (myrand() % (range * 2)));
 
-               // Get ground height at point
-               s16 groundheight = map.findGroundLevel(nodepos2d);
-               if (groundheight <= water_level) // Don't go underwater
-                       continue;
-               if (groundheight > water_level + 6) // Don't go to high places
+               // Get spawn level at point
+               s16 spawn_level = m_emerge->getSpawnLevelAtPoint(nodepos2d);
+               // Continue if MAX_MAP_GENERATION_LIMIT was returned by
+               // the mapgen to signify an unsuitable spawn position
+               if (spawn_level == MAX_MAP_GENERATION_LIMIT)
                        continue;
 
-               nodepos = v3s16(nodepos2d.X, groundheight, nodepos2d.Y);
-               bool is_good = false;
+               v3s16 nodepos(nodepos2d.X, spawn_level, nodepos2d.Y);
+
                s32 air_count = 0;
                for (s32 i = 0; i < 10; i++) {
                        v3s16 blockpos = getNodeBlockPos(nodepos);
@@ -3211,25 +3406,23 @@ v3f findSpawnPos(ServerMap &map)
                        content_t c = map.getNodeNoEx(nodepos).getContent();
                        if (c == CONTENT_AIR || c == CONTENT_IGNORE) {
                                air_count++;
-                               if (air_count >= 2){
+                               if (air_count >= 2) {
+                                       nodeposf = intToFloat(nodepos, BS);
+                                       // Don't spawn the player outside map boundaries
+                                       if (objectpos_over_limit(nodeposf))
+                                               continue;
                                        is_good = true;
                                        break;
                                }
                        }
                        nodepos.Y++;
                }
-               if(is_good){
-                       // Found a good place
-                       //infostream<<"Searched through "<<i<<" places."<<std::endl;
-                       break;
-               }
        }
-#endif
 
-       return intToFloat(nodepos, BS);
+       return nodeposf;
 }
 
-PlayerSAO* Server::emergePlayer(const char *name, u16 peer_id)
+PlayerSAO* Server::emergePlayer(const char *name, u16 peer_id, u16 proto_version)
 {
        bool newplayer = false;
 
@@ -3267,7 +3460,7 @@ PlayerSAO* Server::emergePlayer(const char *name, u16 peer_id)
                // Set player position
                infostream<<"Server: Finding spawn place for player \""
                                <<name<<"\""<<std::endl;
-               v3f pos = findSpawnPos(m_env->getServerMap());
+               v3f pos = findSpawnPos();
                player->setPosition(pos);
 
                // Make sure the player is saved
@@ -3275,6 +3468,16 @@ PlayerSAO* Server::emergePlayer(const char *name, u16 peer_id)
 
                // Add player to environment
                m_env->addPlayer(player);
+       } else {
+               // If the player exists, ensure that they respawn inside legal bounds
+               // This fixes an assert crash when the player can't be added
+               // to the environment
+               if (objectpos_over_limit(player->getPosition())) {
+                       actionstream << "Respawn position for player \""
+                               << name << "\" outside limits, resetting" << std::endl;
+                       v3f pos = findSpawnPos();
+                       player->setPosition(pos);
+               }
        }
 
        // Create a new player active object
@@ -3282,6 +3485,8 @@ PlayerSAO* Server::emergePlayer(const char *name, u16 peer_id)
                        getPlayerEffectivePrivs(player->getName()),
                        isSingleplayer());
 
+       player->protocol_version = proto_version;
+
        /* Clean up old HUD elements from previous sessions */
        player->clearHud();
 
@@ -3298,15 +3503,17 @@ PlayerSAO* Server::emergePlayer(const char *name, u16 peer_id)
 
 void dedicated_server_loop(Server &server, bool &kill)
 {
-       DSTACK(__FUNCTION_NAME);
+       DSTACK(FUNCTION_NAME);
 
        verbosestream<<"dedicated_server_loop()"<<std::endl;
 
        IntervalLimiter m_profiler_interval;
 
-       for(;;)
-       {
-               float steplen = g_settings->getFloat("dedicated_server_step");
+       static const float steplen = g_settings->getFloat("dedicated_server_step");
+       static const float profiler_print_interval =
+                       g_settings->getFloat("profiler_print_interval");
+
+       for(;;) {
                // This is kind of a hack but can be done like this
                // because server.step() is very light
                {
@@ -3328,10 +3535,7 @@ void dedicated_server_loop(Server &server, bool &kill)
                /*
                        Profiler
                */
-               float profiler_print_interval =
-                               g_settings->getFloat("profiler_print_interval");
-               if(profiler_print_interval != 0)
-               {
+               if (profiler_print_interval != 0) {
                        if(m_profiler_interval.step(steplen, profiler_print_interval))
                        {
                                infostream<<"Profiler:"<<std::endl;
@@ -3341,5 +3545,3 @@ void dedicated_server_loop(Server &server, bool &kill)
                }
        }
 }
-
-