]> git.lizzy.rs Git - minetest.git/blobdiff - src/remoteplayer.cpp
Optimize headers (part 2) (#6272)
[minetest.git] / src / remoteplayer.cpp
index f64d1d690897aeee4234923f755716ffc3920eae..c276062c2ad50552ff6eea70ffc94ca516fb7bf1 100644 (file)
@@ -19,13 +19,14 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 */
 
 #include "remoteplayer.h"
+#include <json/json.h>
 #include "content_sao.h"
 #include "filesys.h"
 #include "gamedef.h"
 #include "porting.h"  // strlcpy
+#include "server.h"
 #include "settings.h"
 
-
 /*
        RemotePlayer
 */
@@ -35,15 +36,7 @@ float RemotePlayer::m_setting_chat_message_limit_per_10sec = 0.0f;
 u16 RemotePlayer::m_setting_chat_message_limit_trigger_kick = 0;
 
 RemotePlayer::RemotePlayer(const char *name, IItemDefManager *idef):
-       Player(name, idef),
-       protocol_version(0),
-       m_sao(NULL),
-       m_dirty(false),
-       m_last_chat_message_sent(time(NULL)),
-       m_chat_message_allowance(5.0f),
-       m_message_rate_overhead(0),
-       hud_hotbar_image(""),
-       hud_hotbar_selected_image("")
+       Player(name, idef)
 {
        if (!RemotePlayer::m_setting_cache_loaded) {
                RemotePlayer::m_setting_chat_message_limit_per_10sec =
@@ -64,88 +57,85 @@ RemotePlayer::RemotePlayer(const char *name, IItemDefManager *idef):
        movement_liquid_fluidity_smooth = g_settings->getFloat("movement_liquid_fluidity_smooth") * BS;
        movement_liquid_sink            = g_settings->getFloat("movement_liquid_sink")            * BS;
        movement_gravity                = g_settings->getFloat("movement_gravity")                * BS;
+
+       // copy defaults
+       m_cloud_params.density = 0.4f;
+       m_cloud_params.color_bright = video::SColor(229, 240, 240, 255);
+       m_cloud_params.color_ambient = video::SColor(255, 0, 0, 0);
+       m_cloud_params.height = 120.0f;
+       m_cloud_params.thickness = 16.0f;
+       m_cloud_params.speed = v2f(0.0f, -2.0f);
 }
 
-void RemotePlayer::save(std::string savedir, IGameDef *gamedef)
+void RemotePlayer::serializeExtraAttributes(std::string &output)
 {
-       /*
-        * We have to open all possible player files in the players directory
-        * and check their player names because some file systems are not
-        * case-sensitive and player names are case-sensitive.
-        */
-
-       // A player to deserialize files into to check their names
-       RemotePlayer testplayer("", gamedef->idef());
-
-       savedir += DIR_DELIM;
-       std::string path = savedir + m_name;
-       for (u32 i = 0; i < PLAYER_FILE_ALTERNATE_TRIES; i++) {
-               if (!fs::PathExists(path)) {
-                       // Open file and serialize
-                       std::ostringstream ss(std::ios_base::binary);
-                       serialize(ss);
-                       if (!fs::safeWriteToFile(path, ss.str())) {
-                               infostream << "Failed to write " << path << std::endl;
-                       }
-                       setModified(false);
-                       return;
-               }
-               // Open file and deserialize
-               std::ifstream is(path.c_str(), std::ios_base::binary);
-               if (!is.good()) {
-                       infostream << "Failed to open " << path << std::endl;
-                       return;
-               }
-               testplayer.deSerialize(is, path);
-               is.close();
-               if (strcmp(testplayer.getName(), m_name) == 0) {
-                       // Open file and serialize
-                       std::ostringstream ss(std::ios_base::binary);
-                       serialize(ss);
-                       if (!fs::safeWriteToFile(path, ss.str())) {
-                               infostream << "Failed to write " << path << std::endl;
-                       }
-                       setModified(false);
-                       return;
-               }
-               path = savedir + m_name + itos(i);
+       assert(m_sao);
+       Json::Value json_root;
+       const PlayerAttributes &attrs = m_sao->getExtendedAttributes();
+       for (PlayerAttributes::const_iterator it = attrs.begin(); it != attrs.end(); ++it) {
+               json_root[(*it).first] = (*it).second;
        }
 
-       infostream << "Didn't find free file for player " << m_name << std::endl;
-       return;
+       Json::FastWriter writer;
+       output = writer.write(json_root);
+       m_sao->setExtendedAttributeModified(false);
 }
 
-void RemotePlayer::deSerialize(std::istream &is, const std::string &playername)
+
+void RemotePlayer::deSerialize(std::istream &is, const std::string &playername,
+               PlayerSAO *sao)
 {
        Settings args;
 
        if (!args.parseConfigLines(is, "PlayerArgsEnd")) {
-               throw SerializationError("PlayerArgsEnd of player " +
-                                                                playername + " not found!");
+               throw SerializationError("PlayerArgsEnd of player " + playername + " not found!");
        }
 
        m_dirty = true;
        //args.getS32("version"); // Version field value not used
-       std::string name = args.get("name");
+       const std::string &name = args.get("name");
        strlcpy(m_name, name.c_str(), PLAYERNAME_SIZE);
-       setPitch(args.getFloat("pitch"));
-       setYaw(args.getFloat("yaw"));
-       setPosition(args.getV3F("position"));
-       try {
-               hp = args.getS32("hp");
-       } catch(SettingNotFoundException &e) {
-               hp = PLAYER_MAX_HP;
-       }
 
-       try {
-               m_breath = args.getS32("breath");
-       } catch(SettingNotFoundException &e) {
-               m_breath = PLAYER_MAX_BREATH;
+       if (sao) {
+               try {
+                       sao->setHPRaw(args.getS32("hp"));
+               } catch(SettingNotFoundException &e) {
+                       sao->setHPRaw(PLAYER_MAX_HP);
+               }
+
+               try {
+                       sao->setBasePosition(args.getV3F("position"));
+               } catch (SettingNotFoundException &e) {}
+
+               try {
+                       sao->setPitch(args.getFloat("pitch"));
+               } catch (SettingNotFoundException &e) {}
+               try {
+                       sao->setYaw(args.getFloat("yaw"));
+               } catch (SettingNotFoundException &e) {}
+
+               try {
+                       sao->setBreath(args.getS32("breath"), false);
+               } catch (SettingNotFoundException &e) {}
+
+               try {
+                       const std::string &extended_attributes = args.get("extended_attributes");
+                       Json::Reader reader;
+                       Json::Value attr_root;
+                       reader.parse(extended_attributes, attr_root);
+
+                       const Json::Value::Members attr_list = attr_root.getMemberNames();
+                       for (Json::Value::Members::const_iterator it = attr_list.begin();
+                                       it != attr_list.end(); ++it) {
+                               Json::Value attr_value = attr_root[*it];
+                               sao->setExtendedAttribute(*it, attr_value.asString());
+                       }
+               } catch (SettingNotFoundException &e) {}
        }
 
        inventory.deSerialize(is);
 
-       if(inventory.getList("craftpreview") == NULL) {
+       if (inventory.getList("craftpreview") == NULL) {
                // Convert players without craftpreview
                inventory.addList("craftpreview", 1);
 
@@ -166,12 +156,18 @@ void RemotePlayer::serialize(std::ostream &os)
        Settings args;
        args.setS32("version", 1);
        args.set("name", m_name);
-       //args.set("password", m_password);
-       args.setFloat("pitch", m_pitch);
-       args.setFloat("yaw", m_yaw);
-       args.setV3F("position", m_position);
-       args.setS32("hp", hp);
-       args.setS32("breath", m_breath);
+
+       // This should not happen
+       assert(m_sao);
+       args.setS32("hp", m_sao->getHP());
+       args.setV3F("position", m_sao->getBasePosition());
+       args.setFloat("pitch", m_sao->getPitch());
+       args.setFloat("yaw", m_sao->getYaw());
+       args.setS32("breath", m_sao->getBreath());
+
+       std::string extended_attrs = "";
+       serializeExtraAttributes(extended_attrs);
+       args.set("extended_attributes", extended_attrs);
 
        args.writeLines(os);
 
@@ -180,16 +176,6 @@ void RemotePlayer::serialize(std::ostream &os)
        inventory.serialize(os);
 }
 
-void RemotePlayer::setPosition(const v3f &position)
-{
-       if (position != m_position)
-               m_dirty = true;
-
-       Player::setPosition(position);
-       if(m_sao)
-               m_sao->setBasePosition(position);
-}
-
 const RemotePlayerChatResult RemotePlayer::canSendChatMessage()
 {
        // Rate limit messages