src/environment.cpp: Fix NULL pointer dereference

[dragonfireclient.git] / src / player.cpp

diff --git a/src/player.cpp b/src/player.cpp
index 88c5634e35441aeb9da937a5431f6a32e35454d4..0e8fd86d2245c3445ccad7f669cb7aa59acc14ce 100644 (file)
--- a/src/player.cpp
+++ b/src/player.cpp
@@ -20,6 +20,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "player.h"
 
 #include <fstream>
+#include "jthread/jmutexautolock.h"
 #include "util/numeric.h"
 #include "hud.h"
 #include "constants.h"
@@ -43,6 +44,7 @@ Player::Player(IGameDef *gamedef, const char *name):
        hp(PLAYER_MAX_HP),
        hurt_tilt_timer(0),
        hurt_tilt_strength(0),
+       protocol_version(0),
        peer_id(PEER_ID_INEXISTENT),
        keyPressed(0),
 // protected
@@ -70,6 +72,7 @@ Player::Player(IGameDef *gamedef, const char *name):
                //"image[1,0.6;1,2;player.png]"
                "list[current_player;main;0,3.5;8,4;]"
                "list[current_player;craft;3,0;3,3;]"
+               "listring[]"
                "list[current_player;craftpreview;7,1;1,1;]";
 
        // Initialize movement settings at default values, so movement can work if the server fails to send them
@@ -85,6 +88,7 @@ Player::Player(IGameDef *gamedef, const char *name):
        movement_liquid_fluidity_smooth = 0.5  * BS;
        movement_liquid_sink            = 10   * BS;
        movement_gravity                = 9.81 * BS;
+       local_animation_speed           = 0.0;
 
        // Movement overrides are multipliers and must be 1 by default
        physics_override_speed        = 1;
@@ -116,31 +120,12 @@ void Player::accelerateHorizontal(v3f target_speed, f32 max_increase)
        f32 dl = d_wanted.getLength();
        if(dl > max_increase)
                dl = max_increase;
-       
+
        v3f d = d_wanted.normalize() * dl;
 
        m_speed.X += d.X;
        m_speed.Z += d.Z;
 
-#if 0 // old code
-       if(m_speed.X < target_speed.X - max_increase)
-               m_speed.X += max_increase;
-       else if(m_speed.X > target_speed.X + max_increase)
-               m_speed.X -= max_increase;
-       else if(m_speed.X < target_speed.X)
-               m_speed.X = target_speed.X;
-       else if(m_speed.X > target_speed.X)
-               m_speed.X = target_speed.X;
-
-       if(m_speed.Z < target_speed.Z - max_increase)
-               m_speed.Z += max_increase;
-       else if(m_speed.Z > target_speed.Z + max_increase)
-               m_speed.Z -= max_increase;
-       else if(m_speed.Z < target_speed.Z)
-               m_speed.Z = target_speed.Z;
-       else if(m_speed.Z > target_speed.Z)
-               m_speed.Z = target_speed.Z;
-#endif
 }
 
 // Vertical acceleration (Y), X and Z directions are ignored
@@ -157,16 +142,6 @@ void Player::accelerateVertical(v3f target_speed, f32 max_increase)
 
        m_speed.Y += d_wanted;
 
-#if 0 // old code
-       if(m_speed.Y < target_speed.Y - max_increase)
-               m_speed.Y += max_increase;
-       else if(m_speed.Y > target_speed.Y + max_increase)
-               m_speed.Y -= max_increase;
-       else if(m_speed.Y < target_speed.Y)
-               m_speed.Y = target_speed.Y;
-       else if(m_speed.Y > target_speed.Y)
-               m_speed.Y = target_speed.Y;
-#endif
 }
 
 v3s16 Player::getLightPosition() const
@@ -241,6 +216,7 @@ void Player::deSerialize(std::istream &is, std::string playername)
 u32 Player::addHud(HudElement *toadd)
 {
        JMutexAutoLock lock(m_mutex);
+
        u32 id = getFreeHudID();
 
        if (id < hud.size())