Fix a formspec crash triggered by ae9b5e00989756bb676429530dfe81039009001c

[minetest.git] / src / particles.h

diff --git a/src/particles.h b/src/particles.h
index 7ffb1c72826ae88dbece777bd110e853c7b7bb02..1956580452cf6f8f91c67608a57061d566dc6337 100644 (file)
--- a/src/particles.h
+++ b/src/particles.h
@@ -17,16 +17,12 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
-#ifndef PARTICLES_HEADER
-#define PARTICLES_HEADER
-
-#define DIGGING_PARTICLES_AMOUNT 10
+#pragma once
 
 #include <iostream>
 #include "irrlichttypes_extrabloated.h"
 #include "client/tile.h"
 #include "localplayer.h"
-#include "environment.h"
 #include "tileanimation.h"
 
 struct ClientEvent;
@@ -40,7 +36,6 @@ class Particle : public scene::ISceneNode
        public:
        Particle(
                IGameDef* gamedef,
-               scene::ISceneManager* mgr,
                LocalPlayer *player,
                ClientEnvironment *env,
                v3f pos,
@@ -58,7 +53,7 @@ class Particle : public scene::ISceneNode
                u8 glow,
                video::SColor color = video::SColor(0xFFFFFFFF)
        );
-       ~Particle();
+       ~Particle() = default;
 
        virtual const aabb3f &getBoundingBox() const
        {
@@ -88,7 +83,7 @@ class Particle : public scene::ISceneNode
        void updateVertices();
 
        video::S3DVertex m_vertices[4];
-       float m_time;
+       float m_time = 0.0f;
        float m_expiration;
 
        ClientEnvironment *m_env;
@@ -112,8 +107,8 @@ class Particle : public scene::ISceneNode
        bool m_vertical;
        v3s16 m_camera_offset;
        struct TileAnimationParams m_animation;
-       float m_animation_time;
-       int m_animation_frame;
+       float m_animation_time = 0.0f;
+       int m_animation_frame = 0;
        u8 m_glow;
 };
 
@@ -121,7 +116,6 @@ class ParticleSpawner
 {
        public:
        ParticleSpawner(IGameDef* gamedef,
-               scene::ISceneManager *smgr,
                LocalPlayer *player,
                u16 amount,
                float time,
@@ -139,7 +133,7 @@ class ParticleSpawner
                const struct TileAnimationParams &anim, u8 glow,
                ParticleManager* p_manager);
 
-       ~ParticleSpawner();
+       ~ParticleSpawner() = default;
 
        void step(float dtime, ClientEnvironment *env);
 
@@ -150,7 +144,6 @@ class ParticleSpawner
        ParticleManager* m_particlemanager;
        float m_time;
        IGameDef *m_gamedef;
-       scene::ISceneManager *m_smgr;
        LocalPlayer *m_player;
        u16 m_amount;
        float m_spawntime;
@@ -187,19 +180,16 @@ friend class ParticleSpawner;
        void step (float dtime);
 
        void handleParticleEvent(ClientEvent *event, Client *client,
-                       scene::ISceneManager* smgr, LocalPlayer *player);
+                       LocalPlayer *player);
 
-       void addDiggingParticles(IGameDef* gamedef, scene::ISceneManager* smgr,
-               LocalPlayer *player, v3s16 pos, const MapNode &n,
-               const ContentFeatures &f);
+       void addDiggingParticles(IGameDef *gamedef, LocalPlayer *player, v3s16 pos,
+               const MapNode &n, const ContentFeatures &f);
 
-       void addPunchingParticles(IGameDef* gamedef, scene::ISceneManager* smgr,
-               LocalPlayer *player, v3s16 pos, const MapNode &n,
-               const ContentFeatures &f);
+       void addPunchingParticles(IGameDef *gamedef, LocalPlayer *player, v3s16 pos,
+               const MapNode &n, const ContentFeatures &f);
 
-       void addNodeParticle(IGameDef* gamedef, scene::ISceneManager* smgr,
-               LocalPlayer *player, v3s16 pos, const MapNode &n,
-               const ContentFeatures &f);
+       void addNodeParticle(IGameDef *gamedef, LocalPlayer *player, v3s16 pos,
+               const MapNode &n, const ContentFeatures &f);
 
 protected:
        void addParticle(Particle* toadd);
@@ -215,8 +205,6 @@ friend class ParticleSpawner;
        std::map<u32, ParticleSpawner*> m_particle_spawners;
 
        ClientEnvironment* m_env;
-       Mutex m_particle_list_lock;
-       Mutex m_spawner_list_lock;
+       std::mutex m_particle_list_lock;
+       std::mutex m_spawner_list_lock;
 };
-
-#endif