]> git.lizzy.rs Git - minetest.git/blobdiff - src/nodedef.cpp
[CSM] Add flavour limits controlled by server (#5930)
[minetest.git] / src / nodedef.cpp
index 98f795c7a79c9129ba9abe4687f7fc3b75fb9dc2..6bb2bf9047792cac1c699f1fd86a4f6a89b5f55b 100644 (file)
@@ -21,9 +21,10 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 #include "itemdef.h"
 #ifndef SERVER
-#include "client/tile.h"
 #include "mesh.h"
 #include "client.h"
+#include "client/renderingengine.h"
+#include "client/tile.h"
 #include <IMeshManipulator.h>
 #endif
 #include "log.h"
@@ -61,11 +62,10 @@ void NodeBox::reset()
 
 void NodeBox::serialize(std::ostream &os, u16 protocol_version) const
 {
-       int version = 1;
+       // Protocol >= 21
+       int version = 2;
        if (protocol_version >= 27)
                version = 3;
-       else if (protocol_version >= 21)
-               version = 2;
        writeU8(os, version);
 
        switch (type) {
@@ -195,14 +195,12 @@ void TileDef::serialize(std::ostream &os, u16 protocol_version) const
                writeU8(os, 3);
        else if (protocol_version >= 26)
                writeU8(os, 2);
-       else if (protocol_version >= 17)
-               writeU8(os, 1);
        else
-               writeU8(os, 0);
-       os<<serializeString(name);
+               writeU8(os, 1);
+
+       os << serializeString(name);
        animation.serialize(os, protocol_version);
-       if (protocol_version >= 17)
-               writeU8(os, backface_culling);
+       writeU8(os, backface_culling);
        if (protocol_version >= 26) {
                writeU8(os, tileable_horizontal);
                writeU8(os, tileable_vertical);
@@ -251,15 +249,21 @@ void TileDef::deSerialize(std::istream &is, const u8 contenfeatures_version, con
 */
 
 static void serializeSimpleSoundSpec(const SimpleSoundSpec &ss,
-               std::ostream &os)
+               std::ostream &os, u8 version)
 {
        os<<serializeString(ss.name);
        writeF1000(os, ss.gain);
+
+       if (version >= 11)
+               writeF1000(os, ss.pitch);
 }
-static void deSerializeSimpleSoundSpec(SimpleSoundSpec &ss, std::istream &is)
+static void deSerializeSimpleSoundSpec(SimpleSoundSpec &ss, std::istream &is, u8 version)
 {
        ss.name = deSerializeString(is);
        ss.gain = readF1000(is);
+
+       if (version >= 11)
+               ss.pitch = readF1000(is);
 }
 
 void TextureSettings::readSettings()
@@ -269,10 +273,15 @@ void TextureSettings::readSettings()
        bool enable_shaders            = g_settings->getBool("enable_shaders");
        bool enable_bumpmapping        = g_settings->getBool("enable_bumpmapping");
        bool enable_parallax_occlusion = g_settings->getBool("enable_parallax_occlusion");
+       bool smooth_lighting           = g_settings->getBool("smooth_lighting");
        enable_mesh_cache              = g_settings->getBool("enable_mesh_cache");
        enable_minimap                 = g_settings->getBool("enable_minimap");
        std::string leaves_style_str   = g_settings->get("leaves_style");
 
+       // Mesh cache is not supported in combination with smooth lighting
+       if (smooth_lighting)
+               enable_mesh_cache = false;
+
        use_normal_texture = enable_shaders &&
                (enable_bumpmapping || enable_parallax_occlusion);
        if (leaves_style_str == "fancy") {
@@ -376,13 +385,14 @@ void ContentFeatures::reset()
 
 void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
 {
-       if (protocol_version < 30) {
+       if (protocol_version < 31) {
                serializeOld(os, protocol_version);
                return;
        }
 
        // version
-       writeU8(os, 9);
+       u8 version = (protocol_version >= 34) ? 11 : 10;
+       writeU8(os, version);
 
        // general
        os << serializeString(name);
@@ -402,6 +412,8 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
        writeU8(os, 6);
        for (u32 i = 0; i < 6; i++)
                tiledef[i].serialize(os, protocol_version);
+       for (u32 i = 0; i < 6; i++)
+               tiledef_overlay[i].serialize(os, protocol_version);
        writeU8(os, CF_SPECIAL_COUNT);
        for (u32 i = 0; i < CF_SPECIAL_COUNT; i++) {
                tiledef_special[i].serialize(os, protocol_version);
@@ -456,30 +468,27 @@ void ContentFeatures::serialize(std::ostream &os, u16 protocol_version) const
        collision_box.serialize(os, protocol_version);
 
        // sound
-       serializeSimpleSoundSpec(sound_footstep, os);
-       serializeSimpleSoundSpec(sound_dig, os);
-       serializeSimpleSoundSpec(sound_dug, os);
+       serializeSimpleSoundSpec(sound_footstep, os, version);
+       serializeSimpleSoundSpec(sound_dig, os, version);
+       serializeSimpleSoundSpec(sound_dug, os, version);
 
        // legacy
        writeU8(os, legacy_facedir_simple);
        writeU8(os, legacy_wallmounted);
 }
 
-void ContentFeatures::correctAlpha()
+void ContentFeatures::correctAlpha(TileDef *tiles, int length)
 {
+       // alpha == 0 means that the node is using texture alpha
        if (alpha == 0 || alpha == 255)
                return;
 
-       for (u32 i = 0; i < 6; i++) {
-               std::stringstream s;
-               s << tiledef[i].name << "^[noalpha^[opacity:" << ((int)alpha);
-               tiledef[i].name = s.str();
-       }
-
-       for (u32 i = 0; i < CF_SPECIAL_COUNT; i++) {
+       for (int i = 0; i < length; i++) {
+               if (tiles[i].name == "")
+                       continue;
                std::stringstream s;
-               s << tiledef_special[i].name << "^[noalpha^[opacity:" << ((int)alpha);
-               tiledef_special[i].name = s.str();
+               s << tiles[i].name << "^[noalpha^[opacity:" << ((int)alpha);
+               tiles[i].name = s.str();
        }
 }
 
@@ -490,7 +499,7 @@ void ContentFeatures::deSerialize(std::istream &is)
        if (version < 9) {
                deSerializeOld(is, version);
                return;
-       } else if (version > 9) {
+       } else if (version > 11) {
                throw SerializationError("unsupported ContentFeatures version");
        }
 
@@ -514,6 +523,9 @@ void ContentFeatures::deSerialize(std::istream &is)
                throw SerializationError("unsupported tile count");
        for (u32 i = 0; i < 6; i++)
                tiledef[i].deSerialize(is, version, drawtype);
+       if (version >= 10)
+               for (u32 i = 0; i < 6; i++)
+                       tiledef_overlay[i].deSerialize(is, version, drawtype);
        if (readU8(is) != CF_SPECIAL_COUNT)
                throw SerializationError("unsupported CF_SPECIAL_COUNT");
        for (u32 i = 0; i < CF_SPECIAL_COUNT; i++)
@@ -569,9 +581,9 @@ void ContentFeatures::deSerialize(std::istream &is)
        collision_box.deSerialize(is);
 
        // sounds
-       deSerializeSimpleSoundSpec(sound_footstep, is);
-       deSerializeSimpleSoundSpec(sound_dig, is);
-       deSerializeSimpleSoundSpec(sound_dug, is);
+       deSerializeSimpleSoundSpec(sound_footstep, is, version);
+       deSerializeSimpleSoundSpec(sound_dig, is, version);
+       deSerializeSimpleSoundSpec(sound_dug, is, version);
 
        // read legacy properties
        legacy_facedir_simple = readU8(is);
@@ -579,7 +591,7 @@ void ContentFeatures::deSerialize(std::istream &is)
 }
 
 #ifndef SERVER
-void ContentFeatures::fillTileAttribs(ITextureSource *tsrc, TileSpec *tile,
+void ContentFeatures::fillTileAttribs(ITextureSource *tsrc, TileLayer *tile,
                TileDef *tiledef, u32 shader_id, bool use_normal_texture,
                bool backface_culling, u8 material_type)
 {
@@ -661,9 +673,16 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
                if (tdef[j].name == "")
                        tdef[j].name = "unknown_node.png";
        }
+       // also the overlay tiles
+       TileDef tdef_overlay[6];
+       for (u32 j = 0; j < 6; j++)
+               tdef_overlay[j] = tiledef_overlay[j];
+       // also the special tiles
+       TileDef tdef_spec[6];
+       for (u32 j = 0; j < CF_SPECIAL_COUNT; j++)
+               tdef_spec[j] = tiledef_special[j];
 
        bool is_liquid = false;
-       bool is_water_surface = false;
 
        u8 material_type = (alpha == 255) ?
                TILE_MATERIAL_BASIC : TILE_MATERIAL_ALPHA;
@@ -671,6 +690,8 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
        switch (drawtype) {
        default:
        case NDT_NORMAL:
+               material_type = (alpha == 255) ?
+                       TILE_MATERIAL_OPAQUE : TILE_MATERIAL_ALPHA;
                solidness = 2;
                break;
        case NDT_AIRLIKE:
@@ -714,8 +735,8 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
                        visual_solidness = 1;
                } else if (tsettings.leaves_style == LEAVES_SIMPLE) {
                        for (u32 j = 0; j < 6; j++) {
-                               if (tiledef_special[j].name != "")
-                                       tdef[j].name = tiledef_special[j].name;
+                               if (tdef_spec[j].name != "")
+                                       tdef[j].name = tdef_spec[j].name;
                        }
                        drawtype = NDT_GLASSLIKE;
                        solidness = 0;
@@ -726,64 +747,87 @@ void ContentFeatures::updateTextures(ITextureSource *tsrc, IShaderSource *shdsrc
                        for (u32 i = 0; i < 6; i++)
                                tdef[i].name += std::string("^[noalpha");
                }
-               if (waving == 1)
+               if (waving >= 1)
                        material_type = TILE_MATERIAL_WAVING_LEAVES;
                break;
        case NDT_PLANTLIKE:
                solidness = 0;
-               if (waving == 1)
+               if (waving >= 1)
                        material_type = TILE_MATERIAL_WAVING_PLANTS;
                break;
        case NDT_FIRELIKE:
                solidness = 0;
                break;
        case NDT_MESH:
+       case NDT_NODEBOX:
                solidness = 0;
+               if (waving == 1)
+                       material_type = TILE_MATERIAL_WAVING_PLANTS;
+               else if (waving == 2)
+                       material_type = TILE_MATERIAL_WAVING_LEAVES;
                break;
        case NDT_TORCHLIKE:
        case NDT_SIGNLIKE:
        case NDT_FENCELIKE:
        case NDT_RAILLIKE:
-       case NDT_NODEBOX:
                solidness = 0;
                break;
+       case NDT_PLANTLIKE_ROOTED:
+               solidness = 2;
+               break;
        }
 
        if (is_liquid) {
+               // Vertex alpha is no longer supported, correct if necessary.
+               correctAlpha(tdef, 6);
+               correctAlpha(tdef_overlay, 6);
+               correctAlpha(tdef_spec, CF_SPECIAL_COUNT);
                material_type = (alpha == 255) ?
                        TILE_MATERIAL_LIQUID_OPAQUE : TILE_MATERIAL_LIQUID_TRANSPARENT;
-               if (name == "default:water_source")
-                       is_water_surface = true;
        }
 
-       // Vertex alpha is no longer supported, correct if necessary.
-       correctAlpha();
+       u32 tile_shader = shdsrc->getShader("nodes_shader", material_type, drawtype);
 
-       u32 tile_shader[6];
-       for (u16 j = 0; j < 6; j++) {
-               tile_shader[j] = shdsrc->getShader("nodes_shader",
-                       material_type, drawtype);
-       }
+       u8 overlay_material = material_type;
+       if (overlay_material == TILE_MATERIAL_OPAQUE)
+               overlay_material = TILE_MATERIAL_BASIC;
+       else if (overlay_material == TILE_MATERIAL_LIQUID_OPAQUE)
+               overlay_material = TILE_MATERIAL_LIQUID_TRANSPARENT;
 
-       if (is_water_surface) {
-               tile_shader[0] = shdsrc->getShader("water_surface_shader",
-                       material_type, drawtype);
-       }
+       u32 overlay_shader = shdsrc->getShader("nodes_shader", overlay_material, drawtype);
 
        // Tiles (fill in f->tiles[])
        for (u16 j = 0; j < 6; j++) {
-               fillTileAttribs(tsrc, &tiles[j], &tdef[j], tile_shader[j],
+               fillTileAttribs(tsrc, &tiles[j].layers[0], &tdef[j], tile_shader,
                        tsettings.use_normal_texture,
-                       tiledef[j].backface_culling, material_type);
+                       tdef[j].backface_culling, material_type);
+               if (tdef_overlay[j].name != "")
+                       fillTileAttribs(tsrc, &tiles[j].layers[1], &tdef_overlay[j],
+                               overlay_shader, tsettings.use_normal_texture,
+                               tdef[j].backface_culling, overlay_material);
+       }
+
+       u8 special_material = material_type;
+       if (drawtype == NDT_PLANTLIKE_ROOTED) {
+               if (waving == 1)
+                       special_material = TILE_MATERIAL_WAVING_PLANTS;
+               else if (waving == 2)
+                       special_material = TILE_MATERIAL_WAVING_LEAVES;
        }
+       u32 special_shader = shdsrc->getShader("nodes_shader", special_material, drawtype);
 
        // Special tiles (fill in f->special_tiles[])
        for (u16 j = 0; j < CF_SPECIAL_COUNT; j++) {
-               fillTileAttribs(tsrc, &special_tiles[j], &tiledef_special[j],
-                       tile_shader[j], tsettings.use_normal_texture,
-                       tiledef_special[j].backface_culling, material_type);
+               fillTileAttribs(tsrc, &special_tiles[j].layers[0], &tdef_spec[j],
+                       special_shader, tsettings.use_normal_texture,
+                       tdef_spec[j].backface_culling, special_material);
        }
 
+       if (param_type_2 == CPT2_COLOR ||
+                       param_type_2 == CPT2_COLORED_FACEDIR ||
+                       param_type_2 == CPT2_COLORED_WALLMOUNTED)
+               palette = tsrc->getPalette(palette_name);
+
        if ((drawtype == NDT_MESH) && (mesh != "")) {
                // Meshnode drawtype
                // Read the mesh and apply scale
@@ -857,16 +901,12 @@ class CNodeDefManager: public IWritableNodeDefManager {
        virtual void removeNode(const std::string &name);
        virtual void updateAliases(IItemDefManager *idef);
        virtual void applyTextureOverrides(const std::string &override_filepath);
-       //! Returns a palette or NULL if not found. Only on client.
-       std::vector<video::SColor> *getPalette(const ContentFeatures &f,
-               const IGameDef *gamedef);
        virtual void updateTextures(IGameDef *gamedef,
                void (*progress_cbk)(void *progress_args, u32 progress, u32 max_progress),
                void *progress_cbk_args);
        void serialize(std::ostream &os, u16 protocol_version) const;
        void deSerialize(std::istream &is);
 
-       inline virtual bool getNodeRegistrationStatus() const;
        inline virtual void setNodeRegistrationStatus(bool completed);
 
        virtual void pendNodeResolve(NodeResolver *nr);
@@ -898,19 +938,16 @@ class CNodeDefManager: public IWritableNodeDefManager {
        // item aliases too. Updated by updateAliases()
        // Note: Not serialized.
 
-       UNORDERED_MAP<std::string, content_t> m_name_id_mapping_with_aliases;
+       std::unordered_map<std::string, content_t> m_name_id_mapping_with_aliases;
 
        // A mapping from groups to a list of content_ts (and their levels)
        // that belong to it.  Necessary for a direct lookup in getIds().
        // Note: Not serialized.
-       UNORDERED_MAP<std::string, GroupItems> m_group_to_items;
+       std::unordered_map<std::string, GroupItems> m_group_to_items;
 
        // Next possibly free id
        content_t m_next_id;
 
-       // Maps image file names to loaded palettes.
-       UNORDERED_MAP<std::string, std::vector<video::SColor> > m_palettes;
-
        // NodeResolvers to callback once node registration has ended
        std::vector<NodeResolver *> m_pending_resolve_callbacks;
 
@@ -1039,7 +1076,7 @@ inline const ContentFeatures& CNodeDefManager::get(const MapNode &n) const
 
 bool CNodeDefManager::getId(const std::string &name, content_t &result) const
 {
-       UNORDERED_MAP<std::string, content_t>::const_iterator
+       std::unordered_map<std::string, content_t>::const_iterator
                i = m_name_id_mapping_with_aliases.find(name);
        if(i == m_name_id_mapping_with_aliases.end())
                return false;
@@ -1069,7 +1106,7 @@ bool CNodeDefManager::getIds(const std::string &name,
        }
        std::string group = name.substr(6);
 
-       UNORDERED_MAP<std::string, GroupItems>::const_iterator
+       std::unordered_map<std::string, GroupItems>::const_iterator
                i = m_group_to_items.find(group);
        if (i == m_group_to_items.end())
                return true;
@@ -1271,7 +1308,7 @@ content_t CNodeDefManager::set(const std::string &name, const ContentFeatures &d
                i != def.groups.end(); ++i) {
                std::string group_name = i->first;
 
-               UNORDERED_MAP<std::string, GroupItems>::iterator
+               std::unordered_map<std::string, GroupItems>::iterator
                        j = m_group_to_items.find(group_name);
                if (j == m_group_to_items.end()) {
                        m_group_to_items[group_name].push_back(
@@ -1307,35 +1344,35 @@ void CNodeDefManager::removeNode(const std::string &name)
        }
 
        // Erase node content from all groups it belongs to
-       for (UNORDERED_MAP<std::string, GroupItems>::iterator iter_groups =
-                       m_group_to_items.begin();
-                       iter_groups != m_group_to_items.end();) {
+       for (std::unordered_map<std::string, GroupItems>::iterator iter_groups =
+                       m_group_to_items.begin(); iter_groups != m_group_to_items.end();) {
                GroupItems &items = iter_groups->second;
                for (GroupItems::iterator iter_groupitems = items.begin();
                                iter_groupitems != items.end();) {
                        if (iter_groupitems->first == id)
                                items.erase(iter_groupitems++);
                        else
-                               iter_groupitems++;
+                               ++iter_groupitems;
                }
 
                // Check if group is empty
                if (items.size() == 0)
                        m_group_to_items.erase(iter_groups++);
                else
-                       iter_groups++;
+                       ++iter_groups;
        }
 }
 
 
 void CNodeDefManager::updateAliases(IItemDefManager *idef)
 {
-       std::set<std::string> all = idef->getAll();
+       std::set<std::string> all;
+       idef->getAll(all);
        m_name_id_mapping_with_aliases.clear();
-       for (std::set<std::string>::iterator
+       for (std::set<std::string>::const_iterator
                        i = all.begin(); i != all.end(); ++i) {
-               std::string name = *i;
-               std::string convert_to = idef->getAlias(name);
+               const std::string &name = *i;
+               const std::string &convert_to = idef->getAlias(name);
                content_t id;
                if (m_name_id_mapping.getId(convert_to, id)) {
                        m_name_id_mapping_with_aliases.insert(
@@ -1398,78 +1435,6 @@ void CNodeDefManager::applyTextureOverrides(const std::string &override_filepath
        }
 }
 
-std::vector<video::SColor> *CNodeDefManager::getPalette(
-       const ContentFeatures &f, const IGameDef *gamedef)
-{
-#ifndef SERVER
-       // This works because colors always use the most significant bits
-       // of param2. If you add a new colored type which uses param2
-       // in a more advanced way, you should change this code, too.
-       u32 palette_pixels = 0;
-       switch (f.param_type_2) {
-               case CPT2_COLOR:
-                       palette_pixels = 256;
-                       break;
-               case CPT2_COLORED_FACEDIR:
-                       palette_pixels = 8;
-                       break;
-               case CPT2_COLORED_WALLMOUNTED:
-                       palette_pixels = 32;
-                       break;
-               default:
-                       return NULL;
-       }
-       // This many param2 values will have the same color
-       u32 step = 256 / palette_pixels;
-       const std::string &name = f.palette_name;
-       if (name == "")
-               return NULL;
-       Client *client = (Client *) gamedef;
-       ITextureSource *tsrc = client->tsrc();
-
-       UNORDERED_MAP<std::string, std::vector<video::SColor> >::iterator it =
-       m_palettes.find(name);
-       if (it == m_palettes.end()) {
-               // Create palette
-               if (!tsrc->isKnownSourceImage(name)) {
-                       warningstream << "CNodeDefManager::getPalette(): palette \"" << name
-                               << "\" could not be loaded." << std::endl;
-                       return NULL;
-               }
-               video::IImage *img = tsrc->generateImage(name);
-               std::vector<video::SColor> new_palette;
-               u32 w = img->getDimension().Width;
-               u32 h = img->getDimension().Height;
-               // Real area of the image
-               u32 area = h * w;
-               if (area != palette_pixels)
-                       warningstream << "CNodeDefManager::getPalette(): the "
-                               << "specified palette image \"" << name << "\" does not "
-                               << "contain exactly " << palette_pixels
-                               << " pixels." << std::endl;
-               if (area > palette_pixels)
-                       area = palette_pixels;
-               // For each pixel in the image
-               for (u32 i = 0; i < area; i++) {
-                       video::SColor c = img->getPixel(i % w, i / w);
-                       // Fill in palette with 'step' colors
-                       for (u32 j = 0; j < step; j++)
-                               new_palette.push_back(c);
-               }
-               img->drop();
-               // Fill in remaining elements
-               while (new_palette.size() < 256)
-                       new_palette.push_back(video::SColor(0xFFFFFFFF));
-               m_palettes[name] = new_palette;
-               it = m_palettes.find(name);
-       }
-       if (it != m_palettes.end())
-               return &((*it).second);
-
-#endif
-       return NULL;
-}
-
 void CNodeDefManager::updateTextures(IGameDef *gamedef,
        void (*progress_callback)(void *progress_args, u32 progress, u32 max_progress),
        void *progress_callback_args)
@@ -1481,17 +1446,15 @@ void CNodeDefManager::updateTextures(IGameDef *gamedef,
        Client *client = (Client *)gamedef;
        ITextureSource *tsrc = client->tsrc();
        IShaderSource *shdsrc = client->getShaderSource();
-       scene::ISceneManager* smgr = client->getSceneManager();
-       scene::IMeshManipulator* meshmanip = smgr->getMeshManipulator();
+       scene::IMeshManipulator *meshmanip =
+               RenderingEngine::get_scene_manager()->getMeshManipulator();
        TextureSettings tsettings;
        tsettings.readSettings();
 
-       m_palettes.clear();
        u32 size = m_content_features.size();
 
        for (u32 i = 0; i < size; i++) {
                ContentFeatures *f = &(m_content_features[i]);
-               f->palette = getPalette(*f, gamedef);
                f->updateTextures(tsrc, shdsrc, meshmanip, client, tsettings);
                progress_callback(progress_callback_args, i, size);
        }
@@ -1606,109 +1569,23 @@ void ContentFeatures::serializeOld(std::ostream &os, u16 protocol_version) const
                        compatible_param_type_2 = CPT2_WALLMOUNTED;
        }
 
-       if (protocol_version == 13)
-       {
-               writeU8(os, 5); // version
-               os<<serializeString(name);
-               writeU16(os, groups.size());
-               for (ItemGroupList::const_iterator
-                               i = groups.begin(); i != groups.end(); ++i) {
-                       os<<serializeString(i->first);
-                       writeS16(os, i->second);
+       float compatible_visual_scale = visual_scale;
+       if (protocol_version < 30 && drawtype == NDT_PLANTLIKE)
+               compatible_visual_scale = sqrt(visual_scale);
+
+       TileDef compatible_tiles[6];
+       for (u8 i = 0; i < 6; i++) {
+               compatible_tiles[i] = tiledef[i];
+               if (tiledef_overlay[i].name != "") {
+                       std::stringstream s;
+                       s << "(" << tiledef[i].name << ")^(" << tiledef_overlay[i].name
+                               << ")";
+                       compatible_tiles[i].name = s.str();
                }
-               writeU8(os, drawtype);
-               writeF1000(os, visual_scale);
-               writeU8(os, 6);
-               for (u32 i = 0; i < 6; i++)
-                       tiledef[i].serialize(os, protocol_version);
-               //CF_SPECIAL_COUNT = 2 before cf ver. 7 and protocol ver. 24
-               writeU8(os, 2);
-               for (u32 i = 0; i < 2; i++)
-                       tiledef_special[i].serialize(os, protocol_version);
-               writeU8(os, alpha);
-               writeU8(os, post_effect_color.getAlpha());
-               writeU8(os, post_effect_color.getRed());
-               writeU8(os, post_effect_color.getGreen());
-               writeU8(os, post_effect_color.getBlue());
-               writeU8(os, param_type);
-               writeU8(os, compatible_param_type_2);
-               writeU8(os, is_ground_content);
-               writeU8(os, light_propagates);
-               writeU8(os, sunlight_propagates);
-               writeU8(os, walkable);
-               writeU8(os, pointable);
-               writeU8(os, diggable);
-               writeU8(os, climbable);
-               writeU8(os, buildable_to);
-               os<<serializeString(""); // legacy: used to be metadata_name
-               writeU8(os, liquid_type);
-               os<<serializeString(liquid_alternative_flowing);
-               os<<serializeString(liquid_alternative_source);
-               writeU8(os, liquid_viscosity);
-               writeU8(os, light_source);
-               writeU32(os, damage_per_second);
-               node_box.serialize(os, protocol_version);
-               selection_box.serialize(os, protocol_version);
-               writeU8(os, legacy_facedir_simple);
-               writeU8(os, legacy_wallmounted);
-               serializeSimpleSoundSpec(sound_footstep, os);
-               serializeSimpleSoundSpec(sound_dig, os);
-               serializeSimpleSoundSpec(sound_dug, os);
        }
-       else if (protocol_version > 13 && protocol_version < 24) {
-               writeU8(os, 6); // version
-               os<<serializeString(name);
-               writeU16(os, groups.size());
-               for (ItemGroupList::const_iterator
-                               i = groups.begin(); i != groups.end(); ++i) {
-                       os<<serializeString(i->first);
-                       writeS16(os, i->second);
-               }
-               writeU8(os, drawtype);
-               writeF1000(os, visual_scale);
-               writeU8(os, 6);
-               for (u32 i = 0; i < 6; i++)
-                       tiledef[i].serialize(os, protocol_version);
-               //CF_SPECIAL_COUNT = 2 before cf ver. 7 and protocol ver. 24
-               writeU8(os, 2);
-               for (u32 i = 0; i < 2; i++)
-                       tiledef_special[i].serialize(os, protocol_version);
-               writeU8(os, alpha);
-               writeU8(os, post_effect_color.getAlpha());
-               writeU8(os, post_effect_color.getRed());
-               writeU8(os, post_effect_color.getGreen());
-               writeU8(os, post_effect_color.getBlue());
-               writeU8(os, param_type);
-               writeU8(os, compatible_param_type_2);
-               writeU8(os, is_ground_content);
-               writeU8(os, light_propagates);
-               writeU8(os, sunlight_propagates);
-               writeU8(os, walkable);
-               writeU8(os, pointable);
-               writeU8(os, diggable);
-               writeU8(os, climbable);
-               writeU8(os, buildable_to);
-               os<<serializeString(""); // legacy: used to be metadata_name
-               writeU8(os, liquid_type);
-               os<<serializeString(liquid_alternative_flowing);
-               os<<serializeString(liquid_alternative_source);
-               writeU8(os, liquid_viscosity);
-               writeU8(os, liquid_renewable);
-               writeU8(os, light_source);
-               writeU32(os, damage_per_second);
-               node_box.serialize(os, protocol_version);
-               selection_box.serialize(os, protocol_version);
-               writeU8(os, legacy_facedir_simple);
-               writeU8(os, legacy_wallmounted);
-               serializeSimpleSoundSpec(sound_footstep, os);
-               serializeSimpleSoundSpec(sound_dig, os);
-               serializeSimpleSoundSpec(sound_dug, os);
-               writeU8(os, rightclickable);
-               writeU8(os, drowning);
-               writeU8(os, leveled);
-               writeU8(os, liquid_range);
-       }
-       else if(protocol_version >= 24 && protocol_version < 30) {
+
+       // Protocol >= 24
+       if (protocol_version < 31) {
                writeU8(os, protocol_version < 27 ? 7 : 8);
 
                os << serializeString(name);
@@ -1719,10 +1596,10 @@ void ContentFeatures::serializeOld(std::ostream &os, u16 protocol_version) const
                        writeS16(os, i->second);
                }
                writeU8(os, drawtype);
-               writeF1000(os, visual_scale);
+               writeF1000(os, compatible_visual_scale);
                writeU8(os, 6);
                for (u32 i = 0; i < 6; i++)
-                       tiledef[i].serialize(os, protocol_version);
+                       compatible_tiles[i].serialize(os, protocol_version);
                writeU8(os, CF_SPECIAL_COUNT);
                for (u32 i = 0; i < CF_SPECIAL_COUNT; i++)
                        tiledef_special[i].serialize(os, protocol_version);
@@ -1753,9 +1630,9 @@ void ContentFeatures::serializeOld(std::ostream &os, u16 protocol_version) const
                selection_box.serialize(os, protocol_version);
                writeU8(os, legacy_facedir_simple);
                writeU8(os, legacy_wallmounted);
-               serializeSimpleSoundSpec(sound_footstep, os);
-               serializeSimpleSoundSpec(sound_dig, os);
-               serializeSimpleSoundSpec(sound_dug, os);
+               serializeSimpleSoundSpec(sound_footstep, os, 10);
+               serializeSimpleSoundSpec(sound_dig, os, 10);
+               serializeSimpleSoundSpec(sound_dug, os, 10);
                writeU8(os, rightclickable);
                writeU8(os, drowning);
                writeU8(os, leveled);
@@ -1769,9 +1646,10 @@ void ContentFeatures::serializeOld(std::ostream &os, u16 protocol_version) const
                                i != connects_to_ids.end(); ++i)
                        writeU16(os, *i);
                writeU8(os, connect_sides);
-       } else
+       } else {
                throw SerializationError("ContentFeatures::serialize(): "
                        "Unsupported version requested");
+       }
 }
 
 void ContentFeatures::deSerializeOld(std::istream &is, int version)
@@ -1824,9 +1702,9 @@ void ContentFeatures::deSerializeOld(std::istream &is, int version)
                selection_box.deSerialize(is);
                legacy_facedir_simple = readU8(is);
                legacy_wallmounted = readU8(is);
-               deSerializeSimpleSoundSpec(sound_footstep, is);
-               deSerializeSimpleSoundSpec(sound_dig, is);
-               deSerializeSimpleSoundSpec(sound_dug, is);
+               deSerializeSimpleSoundSpec(sound_footstep, is, version);
+               deSerializeSimpleSoundSpec(sound_dig, is, version);
+               deSerializeSimpleSoundSpec(sound_dug, is, version);
        } else if (version == 6) {
                name = deSerializeString(is);
                groups.clear();
@@ -1874,9 +1752,9 @@ void ContentFeatures::deSerializeOld(std::istream &is, int version)
                selection_box.deSerialize(is);
                legacy_facedir_simple = readU8(is);
                legacy_wallmounted = readU8(is);
-               deSerializeSimpleSoundSpec(sound_footstep, is);
-               deSerializeSimpleSoundSpec(sound_dig, is);
-               deSerializeSimpleSoundSpec(sound_dug, is);
+               deSerializeSimpleSoundSpec(sound_footstep, is, version);
+               deSerializeSimpleSoundSpec(sound_dig, is, version);
+               deSerializeSimpleSoundSpec(sound_dug, is, version);
                rightclickable = readU8(is);
                drowning = readU8(is);
                leveled = readU8(is);
@@ -1929,9 +1807,9 @@ void ContentFeatures::deSerializeOld(std::istream &is, int version)
                selection_box.deSerialize(is);
                legacy_facedir_simple = readU8(is);
                legacy_wallmounted = readU8(is);
-               deSerializeSimpleSoundSpec(sound_footstep, is);
-               deSerializeSimpleSoundSpec(sound_dig, is);
-               deSerializeSimpleSoundSpec(sound_dug, is);
+               deSerializeSimpleSoundSpec(sound_footstep, is, version);
+               deSerializeSimpleSoundSpec(sound_dig, is, version);
+               deSerializeSimpleSoundSpec(sound_dug, is, version);
                rightclickable = readU8(is);
                drowning = readU8(is);
                leveled = readU8(is);
@@ -1952,13 +1830,6 @@ void ContentFeatures::deSerializeOld(std::istream &is, int version)
        }
 }
 
-
-inline bool CNodeDefManager::getNodeRegistrationStatus() const
-{
-       return m_node_registration_complete;
-}
-
-
 inline void CNodeDefManager::setNodeRegistrationStatus(bool completed)
 {
        m_node_registration_complete = completed;
@@ -2071,11 +1942,6 @@ bool CNodeDefManager::nodeboxConnects(MapNode from, MapNode to, u8 connect_face)
 
 NodeResolver::NodeResolver()
 {
-       m_ndef            = NULL;
-       m_nodenames_idx   = 0;
-       m_nnlistsizes_idx = 0;
-       m_resolve_done    = false;
-
        m_nodenames.reserve(16);
        m_nnlistsizes.reserve(4);
 }